Re: RFR: JDK-8239708 Split basics.m4 into basic.m4 and util.m4
Looks good, nice restructure! /Erik On 2020-02-21 02:39, Magnus Ihse Bursie wrote: The file basics.m4 in make/autoconf is mixing two different concerns: 1) Providing utility/helper functions to the rest of the autoconf files 2) Doing basic or initial setup that does not belong elsewhere. It should be split into two parts, so these different concerns are clearly separated. Furthermore, the naming has not followed our standards. The functions are prefixed "BASIC_" but the file is named "basics.m4". I propose to keep the prefix and drop the plural "s" from the file name. Bug: https://bugs.openjdk.java.net/browse/JDK-8239708 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8239708-split-out-util-m4/webrev.01 /Magnus
RFR: JDK-8239708 Split basics.m4 into basic.m4 and util.m4
The file basics.m4 in make/autoconf is mixing two different concerns: 1) Providing utility/helper functions to the rest of the autoconf files 2) Doing basic or initial setup that does not belong elsewhere. It should be split into two parts, so these different concerns are clearly separated. Furthermore, the naming has not followed our standards. The functions are prefixed "BASIC_" but the file is named "basics.m4". I propose to keep the prefix and drop the plural "s" from the file name. Bug: https://bugs.openjdk.java.net/browse/JDK-8239708 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8239708-split-out-util-m4/webrev.01 /Magnus