Re: RFR: Revert unintended changes to make/gensrc/Gensrc-jdk.hotspot.agent.gmk

2018-06-27 Thread mandy chung

+1

Mandy

On 6/27/18 12:48 PM, Daniel Fuchs wrote:

Hi,

My fix for  8205397 [1] includes a change to 
make/gensrc/Gensrc-jdk.hotspot.agent.gmk that was not intended:


diff --git a/make/gensrc/Gensrc-jdk.hotspot.agent.gmk 
b/make/gensrc/Gensrc-jdk.hotspot.agent.gmk

--- a/make/gensrc/Gensrc-jdk.hotspot.agent.gmk
+++ b/make/gensrc/Gensrc-jdk.hotspot.agent.gmk
@@ -49,6 +49,7 @@
    MACH_EXC_SERVER := $(MIG_OUTPUT_DIR)/mach_excServer.c

    $(MACH_EXC_SERVER): $(SDKROOT)/usr/include/mach/mach_exc.defs
+ $(call MakeTargetDir)
     $(MIG) -isysroot $(SDKROOT) -server $@ -user $(MACH_EXC_USER) \
     -header $(MACH_EXC_HEADER) 
$(SDKROOT)/usr/include/mach/mach_exc.defs


This patch is to revert the unintented change:

diff --git a/make/gensrc/Gensrc-jdk.hotspot.agent.gmk 
b/make/gensrc/Gensrc-jdk.hotspot.agent.gmk

--- a/make/gensrc/Gensrc-jdk.hotspot.agent.gmk
+++ b/make/gensrc/Gensrc-jdk.hotspot.agent.gmk
@@ -49,7 +49,6 @@
    MACH_EXC_SERVER := $(MIG_OUTPUT_DIR)/mach_excServer.c

    $(MACH_EXC_SERVER): $(SDKROOT)/usr/include/mach/mach_exc.defs
-    $(call MakeTargetDir)
  $(MIG) -isysroot $(SDKROOT) -server $@ -user $(MACH_EXC_USER) \
  -header $(MACH_EXC_HEADER) 
$(SDKROOT)/usr/include/mach/mach_exc.defs



My deepest apologies for the mistake :-(

-- daniel

[1] http://hg.openjdk.java.net/jdk/jdk/rev/d21a3d3aa4fb


RFR: Revert unintended changes to make/gensrc/Gensrc-jdk.hotspot.agent.gmk

2018-06-27 Thread Daniel Fuchs

Hi,

My fix for  8205397 [1] includes a change to 
make/gensrc/Gensrc-jdk.hotspot.agent.gmk that was not intended:


diff --git a/make/gensrc/Gensrc-jdk.hotspot.agent.gmk 
b/make/gensrc/Gensrc-jdk.hotspot.agent.gmk

--- a/make/gensrc/Gensrc-jdk.hotspot.agent.gmk
+++ b/make/gensrc/Gensrc-jdk.hotspot.agent.gmk
@@ -49,6 +49,7 @@
   MACH_EXC_SERVER := $(MIG_OUTPUT_DIR)/mach_excServer.c

   $(MACH_EXC_SERVER): $(SDKROOT)/usr/include/mach/mach_exc.defs
+ $(call MakeTargetDir)
$(MIG) -isysroot $(SDKROOT) -server $@ -user $(MACH_EXC_USER) \
-header $(MACH_EXC_HEADER) 
$(SDKROOT)/usr/include/mach/mach_exc.defs


This patch is to revert the unintented change:

diff --git a/make/gensrc/Gensrc-jdk.hotspot.agent.gmk 
b/make/gensrc/Gensrc-jdk.hotspot.agent.gmk

--- a/make/gensrc/Gensrc-jdk.hotspot.agent.gmk
+++ b/make/gensrc/Gensrc-jdk.hotspot.agent.gmk
@@ -49,7 +49,6 @@
   MACH_EXC_SERVER := $(MIG_OUTPUT_DIR)/mach_excServer.c

   $(MACH_EXC_SERVER): $(SDKROOT)/usr/include/mach/mach_exc.defs
-   $(call MakeTargetDir)
$(MIG) -isysroot $(SDKROOT) -server $@ -user $(MACH_EXC_USER) \
-header $(MACH_EXC_HEADER) $(SDKROOT)/usr/include/mach/mach_exc.defs


My deepest apologies for the mistake :-(

-- daniel

[1] http://hg.openjdk.java.net/jdk/jdk/rev/d21a3d3aa4fb