Re: RFR : [XS] 8218046: use bundled freetype in the AIX build by default
On 2019-01-30 14:59, Baesken, Matthias wrote: Thanks Magnus ! May I get a second review please ? For build changes a second reviewer is not needed; that's a hotspot rule. /Magnus Best regards, Matthias -Original Message- From: Magnus Ihse Bursie Sent: Mittwoch, 30. Januar 2019 14:42 To: Baesken, Matthias ; 'build- d...@openjdk.java.net' Subject: Re: RFR : [XS] 8218046: use bundled freetype in the AIX build by default On 2019-01-30 11:08, Baesken, Matthias wrote: Hello, please review this small change . It adjusts the freetype default on AIX to "bundled"(means : use the bundled freetype if not configured otherwise) . Currently only windows and macosx use the bundled freetype, the other platforms by default use the system freetype (see lib-freetype.m4). AIX would benefit from using the bundled as well, because even when freetype is installed on the system configure runs sometimes into detection issues. Bug/webrev : https://bugs.openjdk.java.net/browse/JDK-8218046 http://cr.openjdk.java.net/~mbaesken/webrevs/8218046.0/ Looks good to me. /Magnus Best regards, Matthias
RE: RFR : [XS] 8218046: use bundled freetype in the AIX build by default
Thanks Magnus ! May I get a second review please ? Best regards, Matthias > -Original Message- > From: Magnus Ihse Bursie > Sent: Mittwoch, 30. Januar 2019 14:42 > To: Baesken, Matthias ; 'build- > d...@openjdk.java.net' > Subject: Re: RFR : [XS] 8218046: use bundled freetype in the AIX build by > default > > On 2019-01-30 11:08, Baesken, Matthias wrote: > > Hello, please review this small change . > > > > It adjusts the freetype default on AIX to "bundled"(means : use the > bundled freetype if not configured otherwise) . > > > > > > Currently only windows and macosx use the bundled freetype, the other > platforms by default use the system freetype (see lib-freetype.m4). > > AIX would benefit from using the bundled as well, because even when > freetype is installed on the system configure runs sometimes into detection > issues. > > > > > > > > Bug/webrev : > > > > https://bugs.openjdk.java.net/browse/JDK-8218046 > > > > http://cr.openjdk.java.net/~mbaesken/webrevs/8218046.0/ > Looks good to me. > > /Magnus > > > > > > Best regards, > > Matthias
Re: RFR : [XS] 8218046: use bundled freetype in the AIX build by default
On 2019-01-30 11:08, Baesken, Matthias wrote: Hello, please review this small change . It adjusts the freetype default on AIX to "bundled"(means : use the bundled freetype if not configured otherwise) . Currently only windows and macosx use the bundled freetype, the other platforms by default use the system freetype (see lib-freetype.m4). AIX would benefit from using the bundled as well, because even when freetype is installed on the system configure runs sometimes into detection issues. Bug/webrev : https://bugs.openjdk.java.net/browse/JDK-8218046 http://cr.openjdk.java.net/~mbaesken/webrevs/8218046.0/ Looks good to me. /Magnus Best regards, Matthias
RFR : [XS] 8218046: use bundled freetype in the AIX build by default
Hello, please review this small change . It adjusts the freetype default on AIX to "bundled"(means : use the bundled freetype if not configured otherwise) . Currently only windows and macosx use the bundled freetype, the other platforms by default use the system freetype (see lib-freetype.m4). AIX would benefit from using the bundled as well, because even when freetype is installed on the system configure runs sometimes into detection issues. Bug/webrev : https://bugs.openjdk.java.net/browse/JDK-8218046 http://cr.openjdk.java.net/~mbaesken/webrevs/8218046.0/ Best regards, Matthias
