Re: Need reviewer: Correcting jar manifests

2011-04-26 Thread Mandy Chung 

 On 4/21/11 7:31 PM, Kelly O'Hair wrote:

Need reviewer for these jar manifest changes.

Multiple issues here:
   * Bean manifest information should only be in rt.jar, not resources.jar, 
jsse.jar,
   * Added missing basic jdk manifest information into demo jar manifests
   * JCE jars manifest missing company name change
   * Specification vendor changed from Oracle to Oracle Corporation for 
consistency sake

6595663: Manifest on jars contain JavaBeans entries
http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-manifest/webrev/


Looks good to me.

Mandy

Re: Need reviewer: Correcting jar manifests

2011-04-26 Thread Julien Ponge 
I'm certainly not qualified to have a voice on the review, but I looked anyway 
and it is ok.

Cheers

-- 
Julien Ponge
http://julien.ponge.info/

On Friday, April 22, 2011 at 4:31 AM, Kelly O'Hair wrote: 
 Need reviewer for these jar manifest changes.
 
 Multiple issues here:
  * Bean manifest information should only be in rt.jar, not resources.jar, 
 jsse.jar, 
  * Added missing basic jdk manifest information into demo jar manifests
  * JCE jars manifest missing company name change
  * Specification vendor changed from Oracle to Oracle Corporation for 
 consistency sake
 
 6595663: Manifest on jars contain JavaBeans entries
 http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-manifest/webrev/
 
 -kto

Re: Need reviewer: Correcting jar manifests

2011-04-22 Thread Alan Bateman 

Kelly O'Hair wrote:

Need reviewer for these jar manifest changes.

Multiple issues here:
  * Bean manifest information should only be in rt.jar, not resources.jar, jsse.jar, 
  * Added missing basic jdk manifest information into demo jar manifests

  * JCE jars manifest missing company name change
  * Specification vendor changed from Oracle to Oracle Corporation for 
consistency sake

6595663: Manifest on jars contain JavaBeans entries
http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-manifest/webrev/

-kto

  
This looks good to me, and good to have the attributes for the bean 
objects only going into rt.jar.


-Alan.

Re: Need reviewer: Correcting jar manifests

2011-04-22 Thread David Katleman 

 Hi Kelly, didn't see any issues with the makefile logic.

Dave


On 4/21/2011 7:31 PM, Kelly O'Hair wrote:

Need reviewer for these jar manifest changes.

Multiple issues here:
   * Bean manifest information should only be in rt.jar, not resources.jar, 
jsse.jar,
   * Added missing basic jdk manifest information into demo jar manifests
   * JCE jars manifest missing company name change
   * Specification vendor changed from Oracle to Oracle Corporation for 
consistency sake

6595663: Manifest on jars contain JavaBeans entries
http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-manifest/webrev/

-kto