Re: RFR: 8277012: Use blessed modifier order in src/utils

2021-11-12 Thread Thomas Stuefe 
On Thu, 11 Nov 2021 14:32:18 GMT, Magnus Ihse Bursie  wrote:

> I ran bin/blessed-modifier-order.sh on source code in src/utils. This scripts 
> verifies that modifiers are in the "blessed" order, and fixes it otherwise. I 
> have manually checked the changes made by the script to make sure they are 
> sound.
> 
> There are no clear ownership of this code, but I believe it's kind of 
> hotspot-related.

+1

-

Marked as reviewed by stuefe (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/6354

Re: RFR: 8277012: Use blessed modifier order in src/utils

2021-11-11 Thread David Holmes 
On Thu, 11 Nov 2021 14:32:18 GMT, Magnus Ihse Bursie  wrote:

> I ran bin/blessed-modifier-order.sh on source code in src/utils. This scripts 
> verifies that modifiers are in the "blessed" order, and fixes it otherwise. I 
> have manually checked the changes made by the script to make sure they are 
> sound.
> 
> There are no clear ownership of this code, but I believe it's kind of 
> hotspot-related.

Looks fine.

Thanks,
David

-

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/6354