Re: RFR: 8283017: GHA: Workflows break with update release versions
On Fri, 11 Mar 2022 09:27:55 GMT, Aleksey Shipilev wrote: > Current GHA workflow only takes `VERSION_FEATURE` to deduce the bundle names, > which means the test jobs in GHA workflows are unable to run when update > releases have versions beyond just 11, 17, 18. > > For example, in JDK 18u GHA runs, build step produce: > > > Creating jdk-18.0.1-internal+0_linux-x64_bin.tar.gz > Creating jdk-18.0.1-internal+0_linux-x64_bin-symbols.tar.gz > Creating jdk-18.0.1-internal+0_linux-x64_bin-tests-demos.tar.gz > > > Persist step fails to find it: > > > Warning: No files were found with the provided path: > jdk/build/linux-x64/bundles/jdk-18-internal+0_linux-x64_bin.tar.gz > > > ...because it looks for "18", not "18.0.1". > > 17u and 11u hacked the GHA workflow to get tests to work (see > [JDK-8276130](https://bugs.openjdk.java.net/browse/JDK-8276130)), but this > would keep breaking in update releases as 19.0.1, 20.0.1, etc. fork out of > the mainline. We should instead fix that in the mainline workflow config. > > Additional testing: > - [x] GHA passes with "fake" 19.0.1 > - [ ] GHA passes with "normal" 19 Thank you! - PR: https://git.openjdk.java.net/jdk/pull/7785
Re: RFR: 8283017: GHA: Workflows break with update release versions
On Fri, 11 Mar 2022 09:27:55 GMT, Aleksey Shipilev wrote: > Current GHA workflow only takes `VERSION_FEATURE` to deduce the bundle names, > which means the test jobs in GHA workflows are unable to run when update > releases have versions beyond just 11, 17, 18. > > For example, in JDK 18u GHA runs, build step produce: > > > Creating jdk-18.0.1-internal+0_linux-x64_bin.tar.gz > Creating jdk-18.0.1-internal+0_linux-x64_bin-symbols.tar.gz > Creating jdk-18.0.1-internal+0_linux-x64_bin-tests-demos.tar.gz > > > Persist step fails to find it: > > > Warning: No files were found with the provided path: > jdk/build/linux-x64/bundles/jdk-18-internal+0_linux-x64_bin.tar.gz > > > ...because it looks for "18", not "18.0.1". > > 17u and 11u hacked the GHA workflow to get tests to work (see > [JDK-8276130](https://bugs.openjdk.java.net/browse/JDK-8276130)), but this > would keep breaking in update releases as 19.0.1, 20.0.1, etc. fork out of > the mainline. We should instead fix that in the mainline workflow config. > > Additional testing: > - [x] GHA passes with "fake" 19.0.1 > - [ ] GHA passes with "normal" 19 Marked as reviewed by ihse (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7785
Re: RFR: 8283017: GHA: Workflows break with update release versions
On Fri, 11 Mar 2022 09:27:55 GMT, Aleksey Shipilev wrote: > Current GHA workflow only takes `VERSION_FEATURE` to deduce the bundle names, > which means the test jobs in GHA workflows are unable to run. > > See for example JDK 18u GHA run: > > Build step produce: > > > Creating jdk-18.0.1-internal+0_linux-x64_bin.tar.gz > Creating jdk-18.0.1-internal+0_linux-x64_bin-symbols.tar.gz > Creating jdk-18.0.1-internal+0_linux-x64_bin-tests-demos.tar.gz > > > Persist step fails to find it: > > > Warning: No files were found with the provided path: > jdk/build/linux-x64/bundles/jdk-18-internal+0_linux-x64_bin.tar.gz > > > ...because it looks for "18", not "18.0.1". > > 17u and 11u hacked the GHA workflow to get tests to work (see > [JDK-8276130](https://bugs.openjdk.java.net/browse/JDK-8276130)), but this > would keep breaking in update releases as 19.0.1, 20.0.1, etc. fork out of > the mainline. We should instead fix that in the mainline workflow config. > > Additional testing: > - [x] GHA passes with "fake" 19.0.1 > - [ ] GHA passes with "normal" 19 Marked as reviewed by erikj (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7785
