Re: RFR: JDK-8260669: Missing quotes in fixpath.sh
On Fri, 29 Jan 2021 19:54:12 GMT, Erik Joelsson wrote: > The build on Windows can fail if certain directory names are present in root > directory of the workspace. In particular I've observed that the single > letter 'p' is triggering this problem. This is caused by missing quotes > around [:upper:] in a 'tr' call in fixpath.sh. Looks good. I also verified that there are no other calls to tr in the build system with missing quotes. - Marked as reviewed by ihse (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/2318
Re: RFR: JDK-8260669: Missing quotes in fixpath.sh
On Fri, 29 Jan 2021 19:54:12 GMT, Erik Joelsson wrote: > The build on Windows can fail if certain directory names are present in root > directory of the workspace. In particular I've observed that the single > letter 'p' is triggering this problem. This is caused by missing quotes > around [:upper:] in a 'tr' call in fixpath.sh. Marked as reviewed by mikael (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2318
Re: RFR: JDK-8260669: Missing quotes in fixpath.sh
On Fri, 29 Jan 2021 19:54:12 GMT, Erik Joelsson wrote: > The build on Windows can fail if certain directory names are present in root > directory of the workspace. In particular I've observed that the single > letter 'p' is triggering this problem. This is caused by missing quotes > around [:upper:] in a 'tr' call in fixpath.sh. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2318
Re: RFR: JDK-8260669: Missing quotes in fixpath.sh
On Fri, 29 Jan 2021 19:54:12 GMT, Erik Joelsson wrote: > The build on Windows can fail if certain directory names are present in root > directory of the workspace. In particular I've observed that the single > letter 'p' is triggering this problem. This is caused by missing quotes > around [:upper:] in a 'tr' call in fixpath.sh. Looks good. - Marked as reviewed by tbell (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/2318