Re: RFR [14] 8225425: java.lang.UnsatisfiedLinkError: net.dll: Can't find dependent libraries

2019-08-16 Thread Erik Joelsson 

Build change looks good.

/Erik

On 2019-08-16 10:32, Chris Hegarty wrote:

Adding build-dev; minor change to remove a linker dependency.

-Chris.


On 16 Aug 2019, at 18:22, Daniel Fuchs  wrote:

Hi chris,

That looks good to me - although don't count me as reviewer
for the makefile changes.

best regards,

-- daniel

On 16/08/2019 18:05, Chris Hegarty wrote:

An unfortunate eager dependency on urlmon.dll has crept into net.dll,
the JIRA issue contains more details [1].
The dependency should be made lazy and optional, since if only pertains
to NTLM authentication over HTTP.
Webrev:
   https://cr.openjdk.java.net/~chegar/8225425/webrev.01/
-Chris.
[1] https://bugs.openjdk.java.net/browse/JDK-8225425

Re: RFR [14] 8225425: java.lang.UnsatisfiedLinkError: net.dll: Can't find dependent libraries

2019-08-16 Thread Chris Hegarty 
Adding build-dev; minor change to remove a linker dependency.

-Chris.

> On 16 Aug 2019, at 18:22, Daniel Fuchs  wrote:
> 
> Hi chris,
> 
> That looks good to me - although don't count me as reviewer
> for the makefile changes.
> 
> best regards,
> 
> -- daniel
> 
> On 16/08/2019 18:05, Chris Hegarty wrote:
>> An unfortunate eager dependency on urlmon.dll has crept into net.dll,
>> the JIRA issue contains more details [1].
>> The dependency should be made lazy and optional, since if only pertains
>> to NTLM authentication over HTTP.
>> Webrev:
>>   https://cr.openjdk.java.net/~chegar/8225425/webrev.01/
>> -Chris.
>> [1] https://bugs.openjdk.java.net/browse/JDK-8225425
>