Re: Review Request: JDK-8179035: Include tool modules in unified docs

2017-04-21 Thread Mandy Chung 

> On Apr 21, 2017, at 12:33 AM, Alan Bateman  wrote:
> 
> On 20/04/2017 19:37, Mandy Chung wrote:
> 
>> A few modules are missing in the unified docs such as jdk.jcmd,
>> jdk.jdwp.agent, jdk.jstatd, etc.  Some tool modules are providers
>> and they were in the initial set.  The modules that are neither
>> a provider nor exporting any API package are missed in the initial
>> patch.
>> 
>> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8179035/webrev.00/
> 
> For jdk.rmic then it might be better to take the wording from the man page so 
> that it reads:
> 
> "... to generate stub and skeleton class files (JRMP protocol) and stub and 
> tie class files (IIOP protocol) for remote objects."

I have pushed the fix.  We can rev it in the next pass.  Now that we have 
unified docs which will make it easier to do a review on the first sentence of 
module summary page.

Mandy

Re: Review Request: JDK-8179035: Include tool modules in unified docs

2017-04-21 Thread Alan Bateman 

On 20/04/2017 19:37, Mandy Chung wrote:


A few modules are missing in the unified docs such as jdk.jcmd,
jdk.jdwp.agent, jdk.jstatd, etc.  Some tool modules are providers
and they were in the initial set.  The modules that are neither
a provider nor exporting any API package are missed in the initial
patch.

http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8179035/webrev.00/


For jdk.rmic then it might be better to take the wording from the man 
page so that it reads:


"... to generate stub and skeleton class files (JRMP protocol) and stub 
and tie class files (IIOP protocol) for remote objects."


The proposed javadoc for jdk.pack looks okay to me.

-Alan

Re: Review Request: JDK-8179035: Include tool modules in unified docs

2017-04-20 Thread Lance Andersen 
The javadocs read fine.  Probably need to update the  copyright date for the 
module-info.java files

Best
Lance
> On Apr 20, 2017, at 2:37 PM, Mandy Chung  wrote:
> 
> A few modules are missing in the unified docs such as jdk.jcmd, 
> jdk.jdwp.agent, jdk.jstatd, etc.  Some tool modules are providers
> and they were in the initial set.  The modules that are neither
> a provider nor exporting any API package are missed in the initial
> patch.
> 
> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8179035/webrev.00/
> 
> Mandy

 
  

 Lance Andersen| 
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
lance.ander...@oracle.com