Re: fastdebug_build triggers -Werror with g++ 4.3.1-9 (Debian)

2008-08-27 Thread Kelly O'Hair

If you set the variable WARNINGS_ARE_ERRORS to be empty, it should
be sent through to all the makefiles. It's the variable
WARNINGS_ARE_ERRORS that contains the option -Werror.

So try:

   make WARNINGS_ARE_ERRORS=

Not using -Werror will likely let more warning errors creep into the
builds, and using it means a few people get annoyed.

And the changeset below probably has nothing to do with it, must be
an earlier changeset.

-kto

Florian Weimer wrote:

g++ -DLINUX -D_GNU_SOURCE -DAMD64 -DASSERT -DFASTDEBUG -I. 
-I../generated/adfiles -I../generated/jvmtifiles 
-I/home/fw/src/java/jdk7/hotspot/src/share/vm/asm 
-I/home/fw/src/java/jdk7/hotspot/src/share/vm/ci 
-I/home/fw/src/java/jdk7/hotspot/src/share/vm/classfile 
-I/home/fw/src/java/jdk7/hotspot/src/share/vm/code 
-I/home/fw/src/java/jdk7/hotspot/src/share/vm/compiler 
-I/home/fw/src/java/jdk7/hotspot/src/share/vm/gc_implementation 
-I/home/fw/src/java/jdk7/hotspot/src/share/vm/gc_implementation/parNew 
-I/home/fw/src/java/jdk7/hotspot/src/share/vm/gc_implementation/concurrentMarkSweep
 -I/home/fw/src/java/jdk7/hotspot/src/share/vm/gc_implementation/shared 
-I/home/fw/src/java/jdk7/hotspot/src/share/vm/gc_implementation/parallelScavenge
 -I/home/fw/src/java/jdk7/hotspot/src/share/vm/gc_interface 
-I/home/fw/src/java/jdk7/hotspot/src/share/vm/interpreter 
-I/home/fw/src/java/jdk7/hotspot/src/share/vm/libadt 
-I/home/fw/src/java/jdk7/hotspot/src/share/vm/memory -I/home/fw/src/java/jdk7/

hotspot/src/share/vm/oops -I/home/fw/src/java/jdk7/hotspot/src/share/vm/opto -I/home/fw/src/java/jdk7/hotspot/src/share/vm/prims -I/home/fw/src/java/jdk7/hotspot/src/share/vm/runtime 
-I/home/fw/src/java/jdk7/hotspot/src/share/vm/services -I/home/fw/src/java/jdk7/hotspot/src/share/vm/utilities -I/home/fw/src/java/jdk7/hotspot/src/cpu/x86/vm 
-I/home/fw/src/java/jdk7/hotspot/src/os/linux/vm -I/home/fw/src/java/jdk7/hotspot/src/os_cpu/linux_x86/vm -I../generated -DHOTSPOT_RELEASE_VERSION=\14.0-b01\ 
-DHOTSPOT_BUILD_TARGET=\fastdebug\ -DHOTSPOT_BUILD_USER=\fw\ -DHOTSPOT_LIB_ARCH=\amd64\ 
-DJRE_RELEASE_VERSION=\1.7.0-internal-fastdebug-fw_2008_08_27_11_45-b00\ -DHOTSPOT_VM_DISTRO=\OpenJDK\ -DCOMPILER2 -fPIC -fno-rtti 
-fno-exceptions -D_REENTRANT -fcheck-new -m64 -pipe -O3 -fno-strict-aliasing -DVM_LITTLE_ENDIAN -D_LP64=1 -fno-omit-frame-pointer -Werror -Wpointer-arith -Wsign-compare-c -o 
ciMethodBlocks.o /home/fw/src/java/jdk7/hotspot/src/share/vm/ci/ciMetho
dBlocks.cpp

cc1plus: warnings being treated as errors
/home/fw/src/java/jdk7/hotspot/src/share/vm/ci/ciMethodBlocks.cpp:362: error: 
deprecated conversion from string constant to ‘char*’

It's inside #ifndef PRODUCT, that's why it hasn't been caught before.

This happens with this tip:

changeset:   241:5b3b8a69f10f
tag: tip
user:xdono
date:Thu Aug 14 09:26:23 2008 -0700
summary: Added tag jdk7-b33 for changeset 585535ec8a14


To be honest, I think -Werror should be disabled except for test builds
(with well-defined compilers).  For downstream consumers, -Werror only
adds additional hassle.


Re: fastdebug_build triggers -Werror with g++ 4.3.1-9 (Debian)

2008-08-27 Thread Tom Rodriguez

This was fixed as part of 6712835.  
http://hg.openjdk.java.net/jdk7/hotspot-comp/hotspot/rev/6ca61c728c2d

tom

On Aug 27, 2008, at 5:24 AM, Florian Weimer wrote:

g++ -DLINUX -D_GNU_SOURCE -DAMD64 -DASSERT -DFASTDEBUG -I. -I../ 
generated/adfiles -I../generated/jvmtifiles -I/home/fw/src/java/jdk7/ 
hotspot/src/share/vm/asm -I/home/fw/src/java/jdk7/hotspot/src/share/ 
vm/ci -I/home/fw/src/java/jdk7/hotspot/src/share/vm/classfile -I/ 
home/fw/src/java/jdk7/hotspot/src/share/vm/code -I/home/fw/src/java/ 
jdk7/hotspot/src/share/vm/compiler -I/home/fw/src/java/jdk7/hotspot/ 
src/share/vm/gc_implementation -I/home/fw/src/java/jdk7/hotspot/src/ 
share/vm/gc_implementation/parNew -I/home/fw/src/java/jdk7/hotspot/ 
src/share/vm/gc_implementation/concurrentMarkSweep -I/home/fw/src/ 
java/jdk7/hotspot/src/share/vm/gc_implementation/shared -I/home/fw/ 
src/java/jdk7/hotspot/src/share/vm/gc_implementation/ 
parallelScavenge -I/home/fw/src/java/jdk7/hotspot/src/share/vm/ 
gc_interface -I/home/fw/src/java/jdk7/hotspot/src/share/vm/ 
interpreter -I/home/fw/src/java/jdk7/hotspot/src/share/vm/libadt -I/ 
home/fw/src/java/jdk7/hotspot/src/share/vm/memory -I/home/fw/src/ 
java/jdk7/hotspot/src/share/vm/oops -I/home/fw/src/java/jdk7/hotspot/ 
src/share/vm/opto -I/home/fw/src/java/jdk7/hotspot/src/share/vm/ 
prims -I/home/fw/src/java/jdk7/hotspot/src/share/vm/runtime -I/home/ 
fw/src/java/jdk7/hotspot/src/share/vm/services -I/home/fw/src/java/ 
jdk7/hotspot/src/share/vm/utilities -I/home/fw/src/java/jdk7/hotspot/ 
src/cpu/x86/vm -I/home/fw/src/java/jdk7/hotspot/src/os/linux/vm -I/ 
home/fw/src/java/jdk7/hotspot/src/os_cpu/linux_x86/vm -I../generated  
-DHOTSPOT_RELEASE_VERSION=\14.0-b01\ - 
DHOTSPOT_BUILD_TARGET=\fastdebug\ -DHOTSPOT_BUILD_USER=\fw\ - 
DHOTSPOT_LIB_ARCH=\amd64\ -DJRE_RELEASE_VERSION=\1.7.0-internal- 
fastdebug-fw_2008_08_27_11_45-b00\ -DHOTSPOT_VM_DISTRO=\OpenJDK 
\ -DCOMPILER2 -fPIC -fno-rtti -fno-exceptions -D_REENTRANT -fcheck- 
new -m64 -pipe -O3 -fno-strict-aliasing -DVM_LITTLE_ENDIAN -D_LP64=1  
-fno-omit-frame-pointer -Werror -Wpointer-arith -Wsign-compare-c  
-o ciMethodBlocks.o /home/fw/src/java/jdk7/hotspot/src/share/vm/ci/ 
ciMethodBlocks.cpp

cc1plus: warnings being treated as errors
/home/fw/src/java/jdk7/hotspot/src/share/vm/ci/ciMethodBlocks.cpp: 
362: error: deprecated conversion from string constant to ‘char*’


It's inside #ifndef PRODUCT, that's why it hasn't been caught before.

This happens with this tip:

changeset:   241:5b3b8a69f10f
tag: tip
user:xdono
date:Thu Aug 14 09:26:23 2008 -0700
summary: Added tag jdk7-b33 for changeset 585535ec8a14


To be honest, I think -Werror should be disabled except for test  
builds

(with well-defined compilers).  For downstream consumers, -Werror only
adds additional hassle.