Re: Need reviewer and comments

[Dalibor Topic]

On 12/20/10 10:17 PM, Erik Trimble wrote:
> Our main problem with forests is that the forest extension appears to no 
> longer be a part of the official Hg distribution 

Technically, it never was part of it. Hgforest was hosted on hg.akoha.org, then 
forked on bitbucket by
hgforest-crew (that's the still maintained version), and then while that one 
was in apparent limbo a few 
other forks appeared and added support for hg 1.6 & 1.7, then the hgforest-crew 
fork pulled those back in,
afaict.

So, in short - use https://bitbucket.org/pmezard/hgforest-crew/overview/ for a 
working hgforest.

Given that subrepos are in hg mainline now, I wouldn't expect to see hgforest 
make it in there, 
as well. 

cheers,
dalibor topic

-- 
Oracle 
Dalibor Topic | Java F/OSS Ambassador
Phone: +494023646738  | | | Mobile: +491772664192 

Oracle Java Platform Group

ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg

ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung: Riesstr. 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V.
Rijnzathe 6, 3454PV De Meern, Niederlande
Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697
Geschäftsführer: Jürgen Kunz, Marcel van de Molen, Alexander van der Ven

Green Oracle  Oracle is committed to 
developing practices and products that help protect the environment

Re: Need reviewer and comments

[Dalibor Topic]

On 12/20/10 9:53 PM, Kelly O'Hair wrote:
> 
> I'm proposing adding that script to the make/scripts directory and also 
> provide an easy 'get-source.sh'
> script for people to get the entire forest and avoid a hard dependence on the 
> Forest Extension.

Sounds good to me (for the parallel hg pull, which hgforest doesn't do ;).

Can one continue to use hgforest on a forest fetched with the script?

Please document https://bitbucket.org/pmezard/hgforest-crew/overview/ in the 
README as the 
location to get 'real' hgforest, too.

cheers,
dalibor topic
-- 
Oracle 
Dalibor Topic | Java F/OSS Ambassador
Phone: +494023646738  | | | Mobile: +491772664192 

Oracle Java Platform Group

ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg

ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung: Riesstr. 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V.
Rijnzathe 6, 3454PV De Meern, Niederlande
Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697
Geschäftsführer: Jürgen Kunz, Marcel van de Molen, Alexander van der Ven

Green Oracle  Oracle is committed to 
developing practices and products that help protect the environment

Re: Need reviewers and comments: 6989472: Provide simple jdk identification information in the install image

[Dr Andrew John Hughes]

On 16:29 Tue 21 Dec , Kelly O'Hair wrote:
> I'm back with another stab at a webrev and modified proposal.
> 
> 6989472: Provide simple jdk identification information in the install  
> image
> http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-eclipse/webrev/
> 
> The above change creates a small text file called "release" at the top  
> of the
> jdk or jre install image with some very basic values about that  
> install image.
> 
> For example, on Solaris 10 X86 the file would contain the 4 lines:
> 
> JAVA_VERSION="1.7.0"
> OS_NAME="SunOS"
> OS_VERSION="5.10"
> OS_ARCH="i586"
> 
> They are not properties and don't look like properties.

But they are available as system properties already; os.arch, os.name, 
os.version and java.version.
So why do you need this file?

> It doesn't contain trademark names or company names.
> It unfortunately does not identify the specific VM, but it does  
> provide some basic
> information about what the jdk image is and where it can be used.
> 
> To solve the original Eclipse issue really requires a similar file  
> delivered by the
> VMs shipped with the JDK. That will need to be pursued with a  
> different CR.
> 
> -kto

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8

Re: Need reviewer and comments

[Kelly O'Hair]

On Dec 22, 2010, at 4:41 AM, Dalibor Topic wrote:


On 12/20/10 9:53 PM, Kelly O'Hair wrote:


I'm proposing adding that script to the make/scripts directory and  
also provide an easy 'get-source.sh'
script for people to get the entire forest and avoid a hard  
dependence on the Forest Extension.


Sounds good to me (for the parallel hg pull, which hgforest doesn't  
do ;).


Thanks.



Can one continue to use hgforest on a forest fetched with the script?


Yes. It does all commands in parallel, e.g. 'sh make/scripts/ 
hgforest.sh pull -u'  is quite handy.
It does have some simple governors (http://en.wikipedia.org/wiki/Governor_%28device%29 
) on

the parallel actions, nothing fancy.



Please document https://bitbucket.org/pmezard/hgforest-crew/ 
overview/ in the README as the

location to get 'real' hgforest, too.


Don't confuse my little hgforest.sh shell script with the hgforest  
repository that has the forest.py

extension it it, two completely different things.

I'll update the Developer Guide with the information about the Forest  
Extension.


-kto



cheers,
dalibor topic
--
Oracle 
Dalibor Topic | Java F/OSS Ambassador
Phone: +494023646738  | | | Mobile: +491772664192  


Oracle Java Platform Group

ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg

ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung: Riesstr. 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V.
Rijnzathe 6, 3454PV De Meern, Niederlande
Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697
Geschäftsführer: Jürgen Kunz, Marcel van de Molen, Alexander van der  
Ven


Green Oracle  Oracle is committed  
to developing practices and products that help protect the environment

hg: jdk7/build: 2 new changesets

[kelly . ohair]

Changeset: dc9eb519c6ed
Author:ohair
Date:  2010-12-22 12:25 -0800
URL:   http://hg.openjdk.java.net/jdk7/build/rev/dc9eb519c6ed

7003845: README-builds document proper location of forest extension, provide 
alternatives
Reviewed-by: robilad

! README
! README-builds.html
+ get_source.sh
+ make/scripts/hgforest.sh

Changeset: 4d044e6e1080
Author:ohair
Date:  2010-12-22 12:27 -0800
URL:   http://hg.openjdk.java.net/jdk7/build/rev/4d044e6e1080

Merge

! README-builds.html

Re: Need reviewers and comments: 6989472: Provide simple jdk identification information in the install image

[Kelly O'Hair]

On Dec 22, 2010, at 9:09 AM, Dr Andrew John Hughes wrote:


On 16:29 Tue 21 Dec , Kelly O'Hair wrote:

I'm back with another stab at a webrev and modified proposal.

6989472: Provide simple jdk identification information in the install
image
http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-eclipse/webrev/

The above change creates a small text file called "release" at the  
top

of the
jdk or jre install image with some very basic values about that
install image.

For example, on Solaris 10 X86 the file would contain the 4 lines:

JAVA_VERSION="1.7.0"
OS_NAME="SunOS"
OS_VERSION="5.10"
OS_ARCH="i586"

They are not properties and don't look like properties.


But they are available as system properties already; os.arch,  
os.name, os.version and java.version.

So why do you need this file?


To do sanity checks on jdk images before you try and run them.

-kto




It doesn't contain trademark names or company names.
It unfortunately does not identify the specific VM, but it does
provide some basic
information about what the jdk image is and where it can be used.

To solve the original Eclipse issue really requires a similar file
delivered by the
VMs shipped with the JDK. That will need to be pursued with a
different CR.

-kto


--
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8

Re: Need reviewers and comments: 6989472: Provide simple jdk identification information in the install image

[Dr Andrew John Hughes]

On 14:19 Wed 22 Dec , Kelly O'Hair wrote:
> 
> On Dec 22, 2010, at 9:09 AM, Dr Andrew John Hughes wrote:
> 
> > On 16:29 Tue 21 Dec , Kelly O'Hair wrote:
> >> I'm back with another stab at a webrev and modified proposal.
> >>
> >> 6989472: Provide simple jdk identification information in the install
> >> image
> >> http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-eclipse/webrev/
> >>
> >> The above change creates a small text file called "release" at the  
> >> top
> >> of the
> >> jdk or jre install image with some very basic values about that
> >> install image.
> >>
> >> For example, on Solaris 10 X86 the file would contain the 4 lines:
> >>
> >> JAVA_VERSION="1.7.0"
> >> OS_NAME="SunOS"
> >> OS_VERSION="5.10"
> >> OS_ARCH="i586"
> >>
> >> They are not properties and don't look like properties.
> >
> > But they are available as system properties already; os.arch,  
> > os.name, os.version and java.version.
> > So why do you need this file?
> 
> To do sanity checks on jdk images before you try and run them.
> 

Ah so, for example, you'd parse this, say 'hey we're actually running
on GNU/Linux' and not use it?  Sounds like it could be useful in some
circumstances, but I think the HotSpot solution you mention below will
be more generally applicable.  Are you planning to look at this too?


> -kto
> 
> >
> >> It doesn't contain trademark names or company names.
> >> It unfortunately does not identify the specific VM, but it does
> >> provide some basic
> >> information about what the jdk image is and where it can be used.
> >>
> >> To solve the original Eclipse issue really requires a similar file
> >> delivered by the
> >> VMs shipped with the JDK. That will need to be pursued with a
> >> different CR.
> >>
> >> -kto
> >
> > -- 
> > Andrew :)
> >
> > Free Java Software Engineer
> > Red Hat, Inc. (http://www.redhat.com)
> >
> > Support Free Java!
> > Contribute to GNU Classpath and IcedTea
> > http://www.gnu.org/software/classpath
> > http://icedtea.classpath.org
> > PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
> > Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8
> 

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8

Need reviewer: OpenJDK7 binary plug logic removal

[Kelly O'Hair]

Need reviewer: OpenJDK7 binary plug logic removal

7008723: Remove binary plugs creation and use from openjdk
http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-plug-removal/webrev/

-kto

Re: Need reviewer: OpenJDK7 binary plug logic removal

[David Holmes]

Kelly O'Hair said the following on 12/23/10 11:51:

Need reviewer: OpenJDK7 binary plug logic removal

7008723: Remove binary plugs creation and use from openjdk
http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-build-plug-removal/webrev/


Looks nicely eradicated to me. Surprised how far it's tentacles spread ...

David