Re: [10] RFR(S) 8186462: [Graal] build Graal regardless AOT build

2017-08-29 Thread Erik Joelsson 

Looks good to me.

/Erik


On 2017-08-28 22:18, Vladimir Kozlov wrote:

http://cr.openjdk.java.net/~kvn/8186462/webrev/
https://bugs.openjdk.java.net/browse/JDK-8186462

We are planning to have Graal as experimental JIT compiler on 
linux-x64 in next release. For that we should enable its build 
independent from AOT build.


Thanks,
Vladimir

Re: [10] RFR(S) 8186462: [Graal] build Graal regardless AOT build

2017-08-29 Thread Lennart Börjeson 
Could we, please, get this on OSX/MacOS, too?

(For now, I enabling it in my own builds, but it would be nice to have it in 
the release builds.)

Best regards,

/Lennart

> 28 aug. 2017 kl. 22:18 skrev Vladimir Kozlov :
> 
> http://cr.openjdk.java.net/~kvn/8186462/webrev/
> https://bugs.openjdk.java.net/browse/JDK-8186462
> 
> We are planning to have Graal as experimental JIT compiler on linux-x64 in 
> next release. For that we should enable its build independent from AOT build.
> 
> Thanks,
> Vladimir

RFR: JDK-8185928: Generate OpenJDK builds for Mac platform JDK 9.0.3 and beyond in Mach 5

2017-08-29 Thread Erik Joelsson 
This change adds configuration necessary for our internal distributed 
build system to store builds of OpenJDK on Macosx. This is intended for 
JDK 10.


Bug: https://bugs.openjdk.java.net/browse/JDK-8185928

Webrev: http://cr.openjdk.java.net/~erikj/8185928/webrev.01/

/Erik

CompileJavaModule.gmk overrides values from a custom extension gmk

2017-08-29 Thread Jason Yong 
Hello,
 
I've had an issue where I've had a custom extension to CompileJavaModules.gmk 
with the variable java.base_COPY set to files that I wanted to be copied across 
but its value was overwritten by CompileJavaModules.gmk.
 
I would like to propose changes that would allow a custom extensions to update 
variables listed in CompileJavaModules.gmk. This issue is similar to bug 
JDK-8064372 (https://bugs.openjdk.java.net/browse/JDK-8064372) but affects all 
the other variables such as:
 
java.activation_SETUP
java.base_ADD_JAVAC_FLAGS
java.base_COPY
java.base_CLEAN
etc
 
The fix is also similar, changing := to += allowing the custom extension to 
append to the variable if already set and create it if its not.
I would appreciate any feedback and help on what the next steps would be.

Thanks

Jason


Jason Yong
CEng MEng MIET
Software Engineer, IBM Runtime Technologies
IBM Hybrid Cloud
Phone: 44-1962-815256
E-mail: yon...@uk.ibm.com
Find me on:  and within IBM on:  
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 
741598. 
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU

Re: RFR: JDK-8185928: Generate OpenJDK builds for Mac platform JDK 9.0.3 and beyond in Mach 5

2017-08-29 Thread Magnus Ihse Bursie 

On 2017-08-29 09:53, Erik Joelsson wrote:
This change adds configuration necessary for our internal distributed 
build system to store builds of OpenJDK on Macosx. This is intended 
for JDK 10.


Bug: https://bugs.openjdk.java.net/browse/JDK-8185928

Webrev: http://cr.openjdk.java.net/~erikj/8185928/webrev.01/


Looks good to me.

/Magnus


/Erik

Re: CompileJavaModule.gmk overrides values from a custom extension gmk

2017-08-29 Thread Erik Joelsson 

Hello Jason,

Your suggestion makes sense. The only reason these variables have := 
today is that we (at Oracle) haven't had a need for appending to those 
particular variables (yet).


/Erik


On 2017-08-29 11:31, Jason Yong wrote:

Hello,
  
I've had an issue where I've had a custom extension to CompileJavaModules.gmk with the variable java.base_COPY set to files that I wanted to be copied across but its value was overwritten by CompileJavaModules.gmk.
  
I would like to propose changes that would allow a custom extensions to update variables listed in CompileJavaModules.gmk. This issue is similar to bug JDK-8064372 (https://bugs.openjdk.java.net/browse/JDK-8064372) but affects all the other variables such as:
  
java.activation_SETUP

java.base_ADD_JAVAC_FLAGS
java.base_COPY
java.base_CLEAN
etc
  
The fix is also similar, changing := to += allowing the custom extension to append to the variable if already set and create it if its not.

I would appreciate any feedback and help on what the next steps would be.

Thanks

Jason


Jason Yong
CEng MEng MIET
Software Engineer, IBM Runtime Technologies
IBM Hybrid Cloud
Phone: 44-1962-815256
E-mail: yon...@uk.ibm.com
Find me on:  and within IBM on:
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU

Re: [10] RFR(S) 8186462: [Graal] build Graal regardless AOT build

2017-08-29 Thread Andrew Haley 
On 28/08/17 21:18, Vladimir Kozlov wrote:
> We are planning to have Graal as experimental JIT compiler on linux-x64 
> in next release. For that we should enable its build independent from 
> AOT build.

Excellent.  We'll want to pull the AArch64 parts of Graal next time there
is an import.

-- 
Andrew Haley
Java Platform Lead Engineer
Red Hat UK Ltd. 
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671

Re: RFR: JDK-8185928: Generate OpenJDK builds for Mac platform JDK 9.0.3 and beyond in Mach 5

2017-08-29 Thread Tim Bell 

Erik:

On 08/29/17 03:44, Magnus Ihse Bursie wrote:

On 2017-08-29 09:53, Erik Joelsson wrote:

This change adds configuration necessary for our internal distributed
build system to store builds of OpenJDK on Macosx. This is intended
for JDK 10.

Bug: https://bugs.openjdk.java.net/browse/JDK-8185928

Webrev: http://cr.openjdk.java.net/~erikj/8185928/webrev.01/


Looks good to me.

/Magnus


Looks good to me as well.

Tim

Re: [10] RFR(S) 8186462: [Graal] build Graal regardless AOT build

2017-08-29 Thread Vladimir Kozlov 

Thank you, Erik

Vladimir

On 8/29/17 12:14 AM, Erik Joelsson wrote:

Looks good to me.

/Erik


On 2017-08-28 22:18, Vladimir Kozlov wrote:

http://cr.openjdk.java.net/~kvn/8186462/webrev/
https://bugs.openjdk.java.net/browse/JDK-8186462

We are planning to have Graal as experimental JIT compiler on linux-x64 in next release. For that we should enable its 
build independent from AOT build.


Thanks,
Vladimir

Re: [10] RFR(S) 8186462: [Graal] build Graal regardless AOT build

2017-08-29 Thread Vladimir Kozlov 

On 8/29/17 12:30 AM, Lennart Börjeson wrote:

Could we, please, get this on OSX/MacOS, too?


Unfortunately we can not do that. We have very tight schedule for next release and we are doing only linux-x64 testing 
now due to most resources are used for JDK 9 final testing.


Regards,
Vladimir



(For now, I enabling it in my own builds, but it would be nice to have it in 
the release builds.)

Best regards,

/Lennart


28 aug. 2017 kl. 22:18 skrev Vladimir Kozlov :

http://cr.openjdk.java.net/~kvn/8186462/webrev/
https://bugs.openjdk.java.net/browse/JDK-8186462

We are planning to have Graal as experimental JIT compiler on linux-x64 in next 
release. For that we should enable its build independent from AOT build.

Thanks,
Vladimir