Re: Boot JDK used with jdk7 builds

[Joe Darcy]

Phil Race wrote:
Well .. we do not distribute binaries of 6-open so that's a bit of a 
stumbling block.
Plus 6-open is relatively new in the great scheme of things and is 
more of a 6/7 hybrid.


The OpenJDK 6 project has publicly existed for around three and a half 
years and IcedTea6 [1] and OpenJDK 6 binaries [2] have been able to pass 
the JCK 6 conformance suite for nearly three years.


For my own JDK 7 development, I use OpenJDK 6/IcedTea 6 as the boot JDK.

-Joe

[1] http://blog.softwhere.org/archives/196
[2] http://blogs.oracle.com/darcy/entry/openjdk_6_b13_and_jck



-phil.

On 6/3/2011 9:02 AM, Dr Andrew John Hughes wrote:

On 08:57 Fri 03 Jun , Kelly O'Hair wrote:
The documented Boot JDK to be used when building JDK7 repositories 
is JDK6 Update 18, as listed here
   
http://hg.openjdk.java.net/jdk7/build/raw-file/tip/README-builds.html#MBE 



However, as many people know, JDK releases newer than JDK6u18 should 
always work, and some older ones can work too.
Variations in build dependencies can sometimes create unwanted 
differences between builds by different developers
or build systems, so our tendency is to minimize these variations, 
but by doing so, we run a risk that we don't

see what does not work.

If you have any incidents where particular JDKs can or cannot be 
used as the Boot JDK for JDK7, please let us know.


-kto

And OpenJDK6 works.  Is there any reason this is not recommended 
rather than a proprietary product?

Code review request for 7052122: Update JDK_MINOR_VERSION for JDK 8

[Joe Darcy]

Hello.

Please review this change to bump the JDK 8 version number from 1.7 to 1.8:

   7052122: Update JDK_MINOR_VERSION for JDK 8
   http://cr.openjdk.java.net/~darcy/7052122.0/

Patch below followed by post-GPL text of new langtools test.

Thanks,

-Joe

--- old/make/common/shared/Defs.gmk2011-06-07 20:28:41.0 -0700
+++ new/make/common/shared/Defs.gmk2011-06-07 20:28:41.0 -0700
@@ -195,8 +195,8 @@
endif

ifndef JDK_MINOR_VERSION
-  JDK_MINOR_VERSION  = 7
-  PREVIOUS_MINOR_VERSION = 6
+  JDK_MINOR_VERSION  = 8
+  PREVIOUS_MINOR_VERSION = 7
endif

ifndef JDK_MICRO_VERSION
--- old/make/docs/Makefile2011-06-07 20:28:42.0 -0700
+++ new/make/docs/Makefile2011-06-07 20:28:41.0 -0700
@@ -223,6 +223,9 @@
ifeq ($(JDK_MINOR_VERSION),6)
  JDK_IS_FCS = true
endif
+ifeq ($(JDK_MINOR_VERSION),7)
+  JDK_IS_FCS = true
+endif
ifeq ($(JDK_IS_FCS),false)
  ifneq ($(MILESTONE), fcs)
DRAFT_HEADER = 
DRAFT $(MILESTONE)-$(BUILD_NUMBER)


/*
* @test
* @bug 7025809
* @summary Test latest and latestSupported
* @author  Joseph D. Darcy
*/

import javax.lang.model.SourceVersion;
import static javax.lang.model.SourceVersion.*;

/**
* Verify latest[Supported] behavior.
*/
public class TestSourceVersion {
   public static void main(String... args) {
   if (SourceVersion.latest() != RELEASE_8 ||
   SourceVersion.latestSupported() != RELEASE_8)
   throw new RuntimeException("Unexpected release value(s) 
found:\n" +
  "latest:\t" + 
SourceVersion.latest() + "\n" +
  "latestSupported:\t" + 
SourceVersion.latestSupported());

   }
}

Re: Different javac options for explicitly and automatically compiled files

[Joe Darcy]

Hi Sasha.

This isn't the question you asked, but you can use

javac -implicit:none

to disable the compilation of implicitly referenced types.

-Joe

On 8/1/2011 11:07 AM, Alexandre Boulgakov wrote:

Hello Kelly,

Do you know the answer to this one?

Thanks,
Sasha

On 7/29/2011 11:37 AM, Alexandre Boulgakov wrote:

Hello,

I am working on removing the javac -Xlint warnings from java.net.*. 
After removing these warnings, I would like to turn on javac's 
-Werror flag in make/java/net/Makefile. However, it seems that the 
javac task in make/java/net/Makefile has to automatically compile 
some dependencies (not listed in the makefile, presumably inferred by 
the compiler from the sourcepath) which have not had warnings fixed 
yet (sun.net.idn.*, com.sun.security.ntlm.*).


Is there some way to have the -Werror flag only apply to explicitly 
specified source files, but not to the ones that javac pulls in 
automatically?


Thanks,
Sasha

Re: please review 7122061: enable -Werror in various jdk build steps

[Joe Darcy]

On 12/22/2011 3:52 AM, Alan Bateman wrote:

On 22/12/2011 01:51, Stuart Marks wrote:


I dug up a bit of background on this. Apparently Sasha ran across 
this problem back in July and asked about this on net-dev [1]. 
Discussion continued on build-dev [2]. Kurchi later picked up this 
work and after some discussion got it integrated [3].


I didn't see Sasha's original webrev, but he might have fixed all the 
warnings in the java.net package, enabled -Werror in 
make/java/net/Makefile, and then was surprised to find that this 
build step was (implicitly) compiling files that weren't in the 
java.net package. Kurchi's fix [3] apparently fixed warnings in these 
other files as well before enabling -Werror.


In my proposal to add -Werror, I've ensured that specific runs of 
javac to which -Werror will be added actually have no warnings at 
all, whether in implicitly or explicitly listed files.


I'm also not entirely clear what's meant by "partial" and 
"incremental" builds. I've been doing clean builds, but only in the 
jdk repo. Is this a "partial" build, as opposed to a full forest or 
"control" build? I'm doing one of those now and I'll certainly 
correct any issues that arise because of -Werror.


Or, is a "partial" build what happens if one descends into a make 
subdirectory, e.g. jdk/make/java/net, and calls "make" from there? I 
haven't been doing that. Should I?


Still trying to figure out what I need to do to move this forward.
Just on terminology, when I use the term "partial" build then I meant 
building a subset of the repositories with an import JDK providing the 
per-built bits from the other repositories. I think this is what most 
folks working in the jdk repository do, at least in Oracle. 
Incremental builds are where folks go into specific directories and 
run the make file so that it re-builds just the changed sources for 
that area. It's far from perfect, requires local knowledge, at least 
one amulet, but critical to productivity when working in the jdk 
repository.


Anyway, I think you've been digging in the right place. Warnings were 
fixed and builds completed successfully but then later we found cases 
where areas hadn't been completely cleared of mines. This is not a 
criticism of Sasha's great work, it's just that they slipped through 
because classes were compiled implicitly by something earlier in the 
build. This is just one reason to look forward to the new build.


As to moving this forward. If you are happy that these areas are 
completely warning free then I think we are happy and you should push 
the changes.




As an aside, I've thought it was a bit of design error that implicit 
compilation was the default.


Since JDK 6 there has been a javac option that can be used to disable 
implicit compilation, -implicit:none.


Perhaps this option could be used in some portion of the JDK build.

-Joe

Re: 7140918: Remove dependency on apt and com.sun.mirror API

[Joe Darcy]

On 01/30/2012 07:08 AM, Alan Bateman wrote:


The following webrev is a patch from Miran Kos and Martin Grebac 
(cc'ed) to remove the JAX-WS dependency on apt and the com.sun.mirror 
API:


http://cr.openjdk.java.net/~alanb/7140918/webrev/

This is needed before Joe Darcy can wield his machete.

Please cc'ed Miran and Martin on my review comments.

-Alan.


Hi Alan,

In Release.gmk, there seems to be inconsistent indention on these two lines:

 368 com/sun/tools/internal/jxc/ap   \
 369 com/sun/tools/internal/ws/wscompile/plugin/at_generated \

Likewise at Defs-jaxws.gmk:

  58  
META-INF/services/com.sun.tools.internal.ws.wscompile.Plugin \

  59  META-INF/services/com.sun.tools.internal.xjc.Plugin \

Otherwise, the changes look okay.

Thanks,

-Joe

Re: 7140918: Remove dependency on apt and com.sun.mirror API

[Joe Darcy]

On 01/30/2012 04:50 PM, David Holmes wrote:

On 31/01/2012 1:08 AM, Alan Bateman wrote:


The following webrev is a patch from Miran Kos and Martin Grebac (cc'ed)
to remove the JAX-WS dependency on apt and the com.sun.mirror API:

http://cr.openjdk.java.net/~alanb/7140918/webrev/

This is needed before Joe Darcy can wield his machete.

Please cc'ed Miran and Martin on my review comments.


One question: how does this change:

jaxws_src.bundle.name=jdk8-jaxws-2_2-SNAPSHOT-2012_01_11.zip

impact day to day builds? Do we need to have some internal locations 
updated with this new zip file? JPRT?




Yes, there is an Oracle-internal directory location where the zip files 
are stored and where the build looks for the files by default.  
Otherwise, for a build outside of Oracle, you can run with 
ALLOW_DOWNLOADS=true or download the file into a directory named by the 
the DROPS_DIR variable (which is what I do for my builds).


-Joe

Re: jsr instructions in OpenJDK 6 classes

[Joe Darcy]

Hi Andrew,

Whether or not the jsr instruction is used is -target specific; version 
50.0 class files from -target 6 and later do not support jsr/ret since 
stackmaps are used.


I haven't delved into the OpenJDK 6 build before writing this email, but 
I suspect some of the classes in rt.jar are compiled with -target 5, but 
javac in OpenJDK 6 defaults to -target 6 so you wouldn't see jsr 
instructions from a stock compile.


Sufficiently recent versions of javap will emit the classfile version 
under the -verbose flag.


HTH,

-Joe

[1] "Source, target, class file version decoder ring,"
http://blogs.oracle.com/darcy/entry/source_target_class_file_version

On 02/02/2012 04:46 AM, Andrew Haley wrote:

I'm sorry for the cross-post, but I don't know exactly who to
address this to.

Just to save you time reading all this: the javac in OpenJDK 6
generates jsr instructions, but only if you compile a great many
source files in one go.  This affects rt.jar.  I'm trying to find
out why.

If you build OpenJDK6 and do this:

happy:jdk6 $ javap -c -bootclasspath build/linux-amd64/classes/ -classpath 
build/linux-amd64/classes/ java.util.concurrent/PriorityBlockingQueue | grep jsr
48:  jsr 62
56:  jsr 62
17:  jsr 28
23:  jsr 28
74:  jsr 87
  ...

you'll see lots of jsr instructions.  Why is this?  It seems that if
you compile the .java file this doesn't happen:

happy:jdk6 $ ./build/linux-amd64/j2sdk-image/jre/bin/java -Xmx896m -Xms128m 
-XX:PermSize=32m -XX:MaxPermSize=160m 
-Xbootclasspath/p:./build/linux-amd64/langtools/dist/bootstrap/lib/javac.jar 
-jar ./build/linux-amd64/langtools/dist/bootstrap/lib/javac.jar -g -source 1.5 
-target 5 -encoding ascii 
-Xbootclasspath:/local/openjdk/jdk6/build/linux-amd64/classes -sourcepath 
/local/openjdk/jdk6/build/linux-amd64/gensrc:/local/openjdk/jdk6/jdk/src/solaris/classes:/local/openjdk/jdk6/jdk/src/share/classes
 -d /tmp
/local/openjdk/jdk6/jdk/src/share/classes/java/util/concurrent/PriorityBlockingQueue.java

happy:jdk6 $  javap -c -bootclasspath /tmp -classpath /tmp 
java.util.concurrent/PriorityBlockingQueue | grep jsr

No jsr instructions this time.

So, I try the compile again, but with the full list of classes in .classes.list:

  $  $ /local/openjdk/jdk6/build/linux-amd64/j2sdk-image/jre/bin/java -Xmx896m 
-Xms128m -XX:PermSize=32m -XX:MaxPermSize=160m 
-Xbootclasspath/p:/local/openjdk/jdk6/build/linux-amd64/langtools/dist/bootstrap/lib/javac.jar
 -jar 
/local/openjdk/jdk6/build/linux-amd64/langtools/dist/bootstrap/lib/javac.jar -g 
-source 1.5 -target 5 -encoding ascii 
-Xbootclasspath:/local/openjdk/jdk6/build/linux-amd64/classes -sourcepath
/local/openjdk/jdk6/build/linux-amd64/gensrc:/local/openjdk/jdk6/jdk/src/solaris/classes:/local/openjdk/jdk6/jdk/src/share/classes
 -d /tmp 
@/local/openjdk/jdk6/build/linux-amd64/tmp/java/java.lang/java/.classes.list

  $  javap -c -bootclasspath /tmp -classpath /tmp 
java.util.concurrent/PriorityBlockingQueue | grep jsr | head -5
48:  jsr 62
56:  jsr 62
17:  jsr 28
23:  jsr 28
74:  jsr 87

Lots of jsrs.

Now the really weird bit: if I edit classes.list to contain only a
small subset of the files and run the command again,

  $ grep java.util.concurrent 
/local/openjdk/jdk6/build/linux-amd64/tmp/java/java.lang/java/.classes.list>  
classes.concurrent

  $ /local/openjdk/jdk6/build/linux-amd64/j2sdk-image/jre/bin/java -Xmx896m 
-Xms128m -XX:PermSize=32m -XX:MaxPermSize=160m 
-Xbootclasspath/p:/local/openjdk/jdk6/build/linux-amd64/langtools/dist/bootstrap/lib/javac.jar
 -jar 
/local/openjdk/jdk6/build/linux-amd64/langtools/dist/bootstrap/lib/javac.jar -g 
-source 1.5 -target 5 -encoding ascii 
-Xbootclasspath:/local/openjdk/jdk6/build/linux-amd64/classes -sourcepath
/local/openjdk/jdk6/build/linux-amd64/gensrc:/local/openjdk/jdk6/jdk/src/solaris/classes:/local/openjdk/jdk6/jdk/src/share/classes
 -d /tmp @classes.concurrent

  $  javap -c -bootclasspath /tmp -classpath /tmp 
java.util.concurrent/PriorityBlockingQueue | grep jsr | head -5

... no jsr instructions.

I realize that OpenJDK 6 is nearing EOL, but this behaviour is so bizarre
that I'd appreciate some input!

Thanks,
Andrew.

Re: jsr instructions in OpenJDK 6 classes

[Joe Darcy]

On 02/02/2012 08:59 AM, Andrew Haley wrote:

On 02/02/2012 04:52 PM, Joe Darcy wrote:

stackmaps are used.

I haven't delved into the OpenJDK 6 build before writing this email, but
I suspect some of the classes in rt.jar are compiled with -target 5, but
javac in OpenJDK 6 defaults to -target 6 so you wouldn't see jsr
instructions from a stock compile.

Well, I'm using the same compile command so that doesn't quite explain it,
but never mind.

Why are some of the classes in rt.jar are compiled with -target 5 ?
Would it hurt simply to remove that?

Andrew.


I haven't had to poke around this part of the system for a while, but 
some classes were compiled as part of bootstrapping under the previous 
platform version language level.


I don't recall offhand the earliest system OpenJDK 6 supports using as a 
bootstrap.  I don't think compiling the classes in rt.jar with -target 5 
or -target 6 should make much difference, but probably wouldn't offer 
much benefit either.  (The classes in rt.jar aren't verified anyway so 
the faster verifier doesn't help.)


-Joe

Re: Need reviewer on addition of whitespace normalizer script

[Joe Darcy]

Looks fine Kelly; great to have this sort of script included with the 
JDK itself.


-Joe

On 3/1/2012 1:32 PM, Kelly O'Hair wrote:

Need reviewer. Adding the whitespace normalizer script as a convenience to the 
jdk developers.

6625113: Add the normalize and rmkw perl script to the openjdk repository or 
openjdk site?
http://cr.openjdk.java.net/~ohair/openjdk8/normalizer-script/webrev/

Probably a little history is warranted here. This script was originally written 
to normalize the
whitespace in the jdk7 sources as they entered the Mercurial repositories in 
"changeset 0".
It's been modified since then very slightly. I can't recall who wrote it 
(please speak up if you know)
but it has been a valuable tool and I've had this CR to add it to the 
make/scripts directory for some time.

The SCCS keyword removed (rmkw) was less useful, and I decided that it did not 
deserve being added.

Why whitespace normalization? This was decided a long time ago when we had a 
raft of complaints from
people viewing the sources with different tools and getting different views 
based on the TABs and trailing
blanks or trailing newlines. So we decided to normalize on no TABs, no trailing 
blanks on lines, and
no more than one blank line at the end of the file. This script was used to do 
that normalization.

-kto

Re: Fwd: Need reviewer, 7150322: Stop using drop source bundles in jaxws

[Joe Darcy]

Looks fine,

-Joe

On 3/6/2012 9:24 AM, Kelly O'Hair wrote:

Still need a reviewer or 2 on this.

-kto


Begin forwarded message:

*From: *"Kelly O'Hair" >
*Subject: **Need reviewer, 7150322: Stop using drop source bundles in 
jaxws *

*Date: *March 2, 2012 15:49:28 PM PST
*To: *build-dev build-dev >


Similar to jaxp change, but the source normalization was not needed.

7150322: Stop using drop source bundles in jaxws
http://cr.openjdk.java.net/~ohair/openjdk8/infra-jaxws/webrev/ 



I'm working on helping to get the jdk8 build-infra changes 
integrated, this is for jaxws.


This is just the changes to the build files to remove the use of the 
drop bundles and add a new Makefile
that won't be used just yet. The ant scripts have been cleaned up and 
simplified too.


The webrevs do not contain the src/ directory addition, made it too 
big a webrev.


I created a make/scripts/update_src.sh script that will copy in the
latest source drop bundle that was used for this repository, position 
it in the src/ directory,
and run the whitespace normalizer script. This script could be 
re-used in the future but
it's mostly there to document how I pulled the sources into the 
repository.


Once these changes are reviewed, I would need to:
  sh ./make/scripts/update_src.sh&&  hg addremove src
on the repository before creating the changesets that bring in all 
these sources.


I have run builds and verified that the two deliveries from these 
repositories (dist/lib/classes.jar

and dist/lib/src.zip) match the ones created before this change.

These changes should not impact the final built jdk bits.

-kto

Re: location of -source / -target in new build infrastructure

[Joe Darcy]

Actually the long-standing recommended practice is to explicitly set 
source, target, and encoding when compiling:


https://blogs.oracle.com/darcy/entry/build_advice_set_source_target

This means you get the language semantics you're asking for :-)  This is 
appropriate when building the JDK too.


-Joe

On 4/20/2012 11:52 AM, Mike Duigou wrote:

The filed that needed modifying turned out to be

jdk/makefiles/common/shared/Defs-java.gmk

It explicitly sets source and target versions. As you suggest this shouldn't be 
necessary. I can see why specifying source/target is necessary for code 
compiled with the bootstrap javac but in other cases we should be avoiding 
explicit specification and let the compiler use it's default. I was also kind 
of dubious about the specification of -encoding ascii I was pretty sure we had 
joined the 21st century and all the java source files are using utf-8.

Mike


On Apr 20 2012, at 10:48 , Fredrik Öhrström wrote:


Yes, a leftover exist in Setup.gmk thanks for spotting that David!

the -source 7 -target 7 should be replaced with $(BOOT_JDK_SOURCETARGET)
which is setup by configure and stored in the spec.gmk file.

That flag is only be used for compiling code that has to be
run by the boot jdk. The particular setup that uses -source 7 -target 7
in Setup.gmk is called GENERATE_OLDBYTECODE, which seems correct.

However for all new bytecode, the remaining setups seems to lack both
-source and -target, which is the intent, since I assumed that it would 
automatically
build for jdk8 then?

//Fredrik

- david.hol...@oracle.com skrev:


Hi Mike,

Check out: jdk/makefiles/Setup.gmk

David

On 20/04/2012 10:13 AM, Mike Duigou wrote:

Hello All;

I am working on merging the new build infra into the lambda

workspace and have run into a minor problem. The javac compile for the
jdk sources is run with -source 7 -target 7 rather than -source 8
-target 8. In the classic build system for the lambda repo everything
except langtools is compiled with source/target 8. I looked and
couldn't find where the new build sets the source version. Any helpful
pointers?

Thanks,

Mike

Re: 2nd try: please, review the script for JDK license headers verification

[Joe Darcy]

Hello,

I've suggested to Misha in the past a design where a basic and simple 
lic_check.sh script would live in the root repository and then each 
child repo (jdk, langtools, hotspot, etc.) would have a repo-specific 
license checking script that would encode all the expected values and 
per-repo rules.


As a simple example, for langtools a first approximation of the expected 
license rules would be


# GPL with ClassPath exception expected on normal sources...
../make/scripts/lic_check.sh -gplcp `find src "*.java"`

# but GPL without ClassPath expected expected on tests
../make/scripts/lic_check.sh -gpl   `find tests "*.java"

(The full check of langtools would have to account for various 
exceptions, such as the tests that need to have /nodynamiccopyright/, etc.)


-Joe

On 6/4/2012 5:48 PM, Jonathan Gibbons wrote:

Misha,

"It would be nice" if you could infer the default license type from 
the type and/or location of file.


"It would be nice" if it could default the set of files to the set of 
recently modified files, such as determined by "hg status".


-- Jon

On 06/04/2012 04:53 PM, Misha Bykov wrote:


Please, review the webrev is located at:

http://cr.openjdk.java.net/~mbykov/lic_check/webrev.00/

INTRO

It's recommended for a developer, when he introduced or modified 
source code files, to check whether a license header is precisely 
correct for every modified file.


The new script allows a JDK developer to check if the specified 
license header for a given file (or a set of files) matches the right 
header template.


NAME

lic_check.sh - JDK source code legal headers conformance verification

SYNOPSIS

lic_check.sh [-gpl] or [-gplcp] or [-bsd] file(s)

DESCRIPTION

The script for OpenJDK distribution to verify legal notices in a 
particular source file or a set of files.


The script must be located in the directory:

$ROOT/make/scripts

It uses templates from:

$ROOT/make/templates

The successful output example:

###
### Checking copyright notice in the file: filename.java
###
No differences encountered
SUCCESS: The license header for filename.java has been verified.

The unsuccessful output example if Oracle copyright string is missing 
or copyright years are not correct :


###
### Checking copyright notice in the file: filename.java
###
ERROR: Copyright string is not correct or missing in filename.java.

If the copyright string is correct, but the license header is not 
correct, the script should produce the
"diff" output between a template in $ROOT/make/templates and the 
license header from the given file.


HOW TO TEST

1. Place the script into $ROOT/make/scripts in JDK8 source repository 
(otherwise it will not find $ROOT/make/templates and produce an error).

2. cd to the directory with the files to check license headers
3. $ROOT/make/scripts/lic_check.sh [-gpl] or [-gplcp] or [-bsd] 
filename(s)


SUCCESS EXAMPLE

% ./lic_check.sh -gpl update_copyright_year.sh
### Checking copyright notice in the file: update_copyright_year.sh
###
No differences encountered
SUCCESS: The license header for 
jdk8/make/scripts/update_copyright_year.sh has been verified.

###

FAILURE EXAMPLE

% ./lic_check.sh -gpl hgforest.sh
### Checking copyright notice in the file: hgforest.sh
###
*** /tmp/source_file.9122   Mon Jun  4 17:44:11 2012
--- jdk8/make/scripts/./../templates/gpl-header Wed Apr 11 08:53:09 2012
***
*** 1,7 
 Copyright (c) %YEARS% Oracle and/or its affiliates. All rights 
reserved.

 DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.

! This code is free software; you can redistribute it and/or modify itX
 under the terms of the GNU General Public License version 2 only, as
 published by the Free Software Foundation.

--- 1,7 
 Copyright (c) %YEARS% Oracle and/or its affiliates. All rights 
reserved.

 DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.

! This code is free software; you can redistribute it and/or modify it
 under the terms of the GNU General Public License version 2 only, as
 published by the Free Software Foundation.

ERROR: License header is not correct in 
/java/jle_build/headers/jdk8/make/scripts/hgforest.sh

See diffs above.
###


NEXT STEPS

In the future, this script will be used by special scripts to allow 
headers verification in the whole OpenJDK source code base.

Re: Enhance jcheck for Copyright location on 0th line ?

[Joe Darcy]

Kumar,

There is now a copyright-checking script in the repos which could/should 
be run before a push or during an integration.


I think this is preferable to having jcheck do more semantic analysis of 
sources given all the special cases that can come about.


-Joe

On 10/18/2012 12:06 PM, Kumar Srinivasan wrote:

Hi,

{ I don't know if this has been brought my apologies if it has }

When using NetBeans sometimes the import statements are inserted 
preceding
the Copyright header, this happens with a new java file containing a 
Copyright header,
and if import statements are absent, in which case NB does not know 
where to group

them.

Does anyone think it would be a worthwhile enhancement to jcheck, ie.
warn and thereby ensure the Copyright header is on the very first line 
of the file ?


Kumar

Re: RFR: 8013552: Add build support for different man pages for OpenJDK and OracleJDK

[Joe Darcy]

On 05/02/2013 09:38 AM, Jonathan Gibbons wrote:

On 05/02/2013 08:58 AM, Andrew Hughes wrote:

  The man pages in the
>jdk source tree are generated files that the docs team periodically 
updates.

>

Will the source files be added to the OpenJDK trees at some point?



Purely from a curiosity point of view, this also begs the side 
question of

what format are the source files in...



The original source of the man pages is a stylized subset of HTML.

-Joe

JDK 8 code review request of langtools build changes for JDK-8014365 Restore Objects.requireNonNull(T, Supplier)

[Joe Darcy]

Hello,

Please review the patch below for JDK-8014365 "Restore 
Objects.requireNonNull(T, Supplier)" which addresses the issue 
tripped over during JDK-8012344 "Backout 8011800 until langtools 
genstubs updated."


A full build with the below patch to langtools and the update JDK 
library succeeds.


Thanks,

-Joe

diff -r ce7e1674eb73 makefiles/BuildLangtools.gmk
--- a/makefiles/BuildLangtools.gmkFri May 10 16:10:20 2013 +0100
+++ b/makefiles/BuildLangtools.gmkFri May 10 14:04:29 2013 -0700
@@ -1,5 +1,5 @@
 #
-# Copyright (c) 2011, 2012, Oracle and/or its affiliates. All rights 
reserved.
+# Copyright (c) 2011, 2013, Oracle and/or its affiliates. All rights 
reserved.

 # DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
 #
 # This code is free software; you can redistribute it and/or modify it
@@ -123,10 +123,10 @@
  genstubs.GenStubs
 # We fetch source from the JDK...
 JDKS=$(JDK_TOPDIR)/src/share/classes
-# Build the list of classes to generate stubs from. 
java/util/Objects.java isn't
+# Build the list of classes to generate stubs from. 
java/util/function/Predicate.java isn't

 # currently needed, but is used as a demo for now.
  STUBSOURCES:=$(shell $(FIND) $(JDKS) -name "*.java" | $(GREP) \
--e "$(JDKS)/java/util/Objects.java")
+-e "$(JDKS)/java/util/function/Predicate.java")
 # Rewrite the file names into class names because the GenStubs 
tool require this.
 STUBCLASSES:=$(subst /,.,$(patsubst 
$(JDKS)/%.java,%,$(STUBSOURCES)))

Re: Disable overrides during jdk build

[Joe Darcy]

Failure to have proper equals / hashCode behaviors can create hard to 
discover bugs if such objects are ever put in collections.


By default, I would categorize these as real problems to be fixed and 
for a @SuppressWarning annotation to be wrong approach to resolve the 
warning.


Since its initial implementation, the javac warning generation has been 
tuned to be smarter; it only reports a problem if hashCode isn't 
overridden anywhere in the superclass chain. (It is often possible to 
have more sharing among hashCode implementation than among equals 
implementations.)


Regards,

-Joe

On 5/13/2013 8:36 AM, Chris Hegarty wrote:
I have no objection to someone fixing these warnings. They are across 
a number of different areas, and could take an amount of time to resolve.


If we are to have a concerted effort, I'm not sure that I would start 
with these warnings. I too feel the pain, and it does appear that we 
are moving backwards on this problem, I just don't see that this is 
the right place to start.


I'm just after a slightly easier life here, but I understand that this 
is a hot topic ;-)


-Chris.

On 13/05/2013 16:08, Alan Bateman wrote:


No objection although it feels like we are going backwards rather than
forwards.

I submitted a few bugs on this topic recently as it seems to me that
there aren't too many override warnings to kill off. Daniel Fuchs has a
patch out for review today that fixes these warnings in the jaxp
repository. The overrides warnings were also fixed in the jaxws
repository as part of the bulk update a few weeks ago. That leaves 12
for the corba repository and about 29 in the jdk repository (29 on Linux
at least, it varies by platform).

I completely agree with you that the noise is high. On several occasions
I've had to edit the build log to find the errors when they get lots in
the warnings. I just wonder whether we should just fix what seems like a
small number of warnings.

-Alan


On 13/05/2013 14:53, Chris Hegarty wrote:

Please hold your fire! This is not a suggestion to about general
handling of warnings during the build, just a specific gripe I have
when trying to find genuine build failures among the noise.

Would there be any objection to adding '-overrides' to the jdk build?

This lint warning was added after the new build was introduced. I
suspect it would have been suppressed originally if it was supported
at the time.

diff --git a/makefiles/Setup.gmk b/makefiles/Setup.gmk
--- a/makefiles/Setup.gmk
+++ b/makefiles/Setup.gmk
@@ -23,7 +23,7 @@
# questions.
#

-DISABLE_WARNINGS:=-Xlint:all,-deprecation,-unchecked,-rawtypes,-cast,-serial,-dep-ann,-static,-fallthrough,-try,-varargs,-empty,-finally 



+DISABLE_WARNINGS:=-Xlint:all,-deprecation,-unchecked,-rawtypes,-cast,-serial,-dep-ann,-static,-fallthrough,-try,-varargs,-empty,-finally,-overrides 




# The generate old bytecode javac setup uses the new compiler to
compile for the
# boot jdk to generate tools that need to be run with the boot jdk.

-Chris.

P.S. how to handle warnings generally will have to be addressed at
some point, but I am not making any proposal at this time.

Re: RFR: 8251549: Update docs on building for Git [v2]

[Joe Darcy]

> 8251549: Update docs on building for Git

Joe Darcy has updated the pull request incrementally with one additional commit 
since the last revision:

  Update doc/building.md
  
  Co-authored-by: Magnus Ihse Bursie 

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/21/files
  - new: https://git.openjdk.java.net/jdk/pull/21/files/185b04d4..91d91125

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=21&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=21&range=00-01

  Stats: 15 lines in 1 file changed: 14 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/21.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/21/head:pull/21

PR: https://git.openjdk.java.net/jdk/pull/21

Integrated: 8251549: Update docs on building for Git

[Joe Darcy]

On Sat, 5 Sep 2020 20:13:18 GMT, Joe Darcy  wrote:

> 8251549: Update docs on building for Git

This pull request has now been integrated.

Changeset: 042734cc
Author:    Joe Darcy 
URL:   https://git.openjdk.java.net/jdk/commit/042734cc
Stats: 68 lines in 1 file changed: 12 ins; 37 del; 19 mod

8251549: Update docs on building for Git

Reviewed-by: lancea

-

PR: https://git.openjdk.java.net/jdk/pull/21

RFR: 8253753 Enable default constructor warning in client modules

[Joe Darcy]

With the default constructors warnings in java.desktop and jdk.accessibility 
now fixed, the warning should be enabled in the build for those modules.

-

Commit messages:
 - Merge branch 'JDK-8253753' of https://github.com/jddarcy/jdk into JDK-8253753
 - Update build to enable default constructor warning in client modules.
 - Update build to enable default constructor warning in client modules.

Changes: https://git.openjdk.java.net/jdk/pull/1420/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1420&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8253753
  Stats: 5 lines in 1 file changed: 0 ins; 5 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1420.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1420/head:pull/1420

PR: https://git.openjdk.java.net/jdk/pull/1420

Integrated: 8253753 Enable default constructor warning in client modules

[Joe Darcy]

On Tue, 24 Nov 2020 19:10:04 GMT, Joe Darcy  wrote:

> With the default constructors warnings in java.desktop and jdk.accessibility 
> now fixed, the warning should be enabled in the build for those modules.

This pull request has now been integrated.

Changeset: 65137ff0
Author:    Joe Darcy 
URL:   https://git.openjdk.java.net/jdk/commit/65137ff0
Stats: 5 lines in 1 file changed: 0 ins; 5 del; 0 mod

8253753: Enable default constructor warning in client modules

Reviewed-by: prr, serb, ihse

-

PR: https://git.openjdk.java.net/jdk/pull/1420

Re: RFR: 8257450: Start of release updates for JDK 17

[Joe Darcy]

On Tue, 1 Dec 2020 07:33:25 GMT, David Holmes  wrote:

>> Start of JDK 17 updates.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/code/Source.java line 226:
> 
>> 224: REIFIABLE_TYPES_INSTANCEOF(JDK16, 
>> Fragments.FeatureReifiableTypesInstanceof, DiagKind.PLURAL),
>> 225: RECORDS(JDK16, Fragments.FeatureRecords, DiagKind.PLURAL),
>> 226: SEALED_CLASSES(JDK17, Fragments.FeatureSealedClasses, 
>> DiagKind.PLURAL),
> 
> Is this changed because it is still preview?

Right; JEP 397: "Sealed Classes (Second Preview)" is PTT for JDk 16.

-

PR: https://git.openjdk.java.net/jdk/pull/1531

RFR: 8257450: Start of release updates for JDK 17

[Joe Darcy]

Start of JDK 17 updates.

-

Commit messages:
 - Update tests.
 - Merge branch 'master' into JDK-8257450
 - Merge branch 'JDK-8257450' of https://github.com/jddarcy/jdk into JDK-8257450
 - Merge branch 'JDK-8257450' of https://github.com/jddarcy/jdk into JDK-8257450
 - JDK-8257450
 - JDK-8257450
 - JDK-8257450

Changes: https://git.openjdk.java.net/jdk/pull/1531/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1531&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8257450
  Stats: 7522 lines in 76 files changed: 7463 ins; 0 del; 59 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1531.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1531/head:pull/1531

PR: https://git.openjdk.java.net/jdk/pull/1531

Re: RFR: 8257450: Start of release updates for JDK 17

[Joe Darcy]

On Tue, 1 Dec 2020 07:38:13 GMT, David Holmes  wrote:

>> Start of JDK 17 updates.
>
> Looks good - 99% sym stuff :)
> 
> Doesn't look like the hotspot deprecated flag test will need updating this 
> time, as no newly deprecated flags marked for obsoletion in 17.

Usual start of release update:

* Expected version number updates in the make system
* New set of data files to support --release 16 in javac
* Update to various version-related langtools APIs and tests
* Minor N -> N+1 updates in vm and vm tests

One javadoc test that failed under the new version was fixed before this PR was 
sent out.

-

PR: https://git.openjdk.java.net/jdk/pull/1531

Re: RFR: 8257450: Start of release updates for JDK 17 [v2]

[Joe Darcy]

> Start of JDK 17 updates.

Joe Darcy has updated the pull request with a new target base due to a merge or 
a rebase. The incremental webrev excludes the unrelated changes brought in by 
the merge/rebase. The pull request contains eight additional commits since the 
last revision:

 - Merge branch 'master' into JDK-8257450
 - Update tests.
 - Merge branch 'master' into JDK-8257450
 - Merge branch 'JDK-8257450' of https://github.com/jddarcy/jdk into JDK-8257450
 - Merge branch 'JDK-8257450' of https://github.com/jddarcy/jdk into JDK-8257450
 - JDK-8257450
 - JDK-8257450
 - JDK-8257450

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/1531/files
  - new: https://git.openjdk.java.net/jdk/pull/1531/files/4187d66f..f6a64473

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1531&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1531&range=00-01

  Stats: 12681 lines in 254 files changed: 8255 ins; 3285 del; 1141 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1531.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1531/head:pull/1531

PR: https://git.openjdk.java.net/jdk/pull/1531

Re: RFR: 8257450: Start of release updates for JDK 17 [v2]

[Joe Darcy]

On Mon, 7 Dec 2020 16:10:42 GMT, Jan Lahoda  wrote:

> 
> 
> The langtools changes look fine to me. There were additions/changes to jcod 
> files under `test/hotspot/jtreg/runtime/sealedClasses/` made under 
> JDK-8246778, so these may need an update. Sorry about that.

After a merge, the tests in that directory still pass. Will keep merging in new 
changes and do at least more more test run before pushing. Thanks.

-

PR: https://git.openjdk.java.net/jdk/pull/1531

Re: RFR: 8257450: Start of release updates for JDK 17 [v2]

[Joe Darcy]

On Mon, 7 Dec 2020 20:08:59 GMT, Jonathan Gibbons  wrote:

>> Joe Darcy has updated the pull request with a new target base due to a merge 
>> or a rebase. The incremental webrev excludes the unrelated changes brought 
>> in by the merge/rebase. The pull request contains eight additional commits 
>> since the last revision:
>> 
>>  - Merge branch 'master' into JDK-8257450
>>  - Update tests.
>>  - Merge branch 'master' into JDK-8257450
>>  - Merge branch 'JDK-8257450' of https://github.com/jddarcy/jdk into 
>> JDK-8257450
>>  - Merge branch 'JDK-8257450' of https://github.com/jddarcy/jdk into 
>> JDK-8257450
>>  - JDK-8257450
>>  - JDK-8257450
>>  - JDK-8257450
>
> test/jdk/java/lang/module/ClassFileVersionsTest.java line 107:
> 
>> 105: { 61,   0,  Set.of(STATIC, TRANSITIVE) },
>> 106: 
>> 107: { 62,   0,  Set.of()},   // JDK 18
> 
> This seems unduly repetitive. Could this be dynamically generated, perhaps in 
> a future release?

I've had similar thoughts; that strikes me as a fine RFE for after this fork. I 
see what the code is doing, but haven't delved into the module system details 
to understand exactly the rationale for these tests. In any case, filed the RFE 
JDK-8257856: "Make ClassFileVersionsTest.java robust to JDK version updates."

-

PR: https://git.openjdk.java.net/jdk/pull/1531

Re: RFR: 8257450: Start of release updates for JDK 17 [v2]

[Joe Darcy]

On Mon, 7 Dec 2020 20:20:58 GMT, Jesper Wilhelmsson  
wrote:

>> Joe Darcy has updated the pull request with a new target base due to a merge 
>> or a rebase. The incremental webrev excludes the unrelated changes brought 
>> in by the merge/rebase. The pull request contains eight additional commits 
>> since the last revision:
>> 
>>  - Merge branch 'master' into JDK-8257450
>>  - Update tests.
>>  - Merge branch 'master' into JDK-8257450
>>  - Merge branch 'JDK-8257450' of https://github.com/jddarcy/jdk into 
>> JDK-8257450
>>  - Merge branch 'JDK-8257450' of https://github.com/jddarcy/jdk into 
>> JDK-8257450
>>  - JDK-8257450
>>  - JDK-8257450
>>  - JDK-8257450
>
> src/java.compiler/share/classes/javax/lang/model/SourceVersion.java line 234:
> 
>> 232:  * @since 17
>> 233:  */
>> 234: RELEASE_17;
> 
> Would it make sense to have a RELEASE_LATEST for the cases that are just 
> updated to the latest release every six months?

That kind of design was considered and rejected with the API was initially 
added. The use of enum constants in annotations must be an actual enum 
constant, not just a static final field pointing to a particular enum value. It 
would be possible to conceptually alias RELEASE_LATEST with whatever actual 
constant was the latest (16, then 17, then 18...), but that would cause issues 
with other uses of the API.

-

PR: https://git.openjdk.java.net/jdk/pull/1531

Re: RFR: 8257450: Start of release updates for JDK 17 [v3]

[Joe Darcy]

> Start of JDK 17 updates.

Joe Darcy has updated the pull request with a new target base due to a merge or 
a rebase. The incremental webrev excludes the unrelated changes brought in by 
the merge/rebase. The pull request contains ten additional commits since the 
last revision:

 - Merge branch 'master' into JDK-8257450
 - Merge branch 'master' into JDK-8257450
 - Update tests.
 - Merge branch 'master' into JDK-8257450
 - Merge branch 'JDK-8257450' of https://github.com/jddarcy/jdk into JDK-8257450
 - Merge branch 'JDK-8257450' of https://github.com/jddarcy/jdk into JDK-8257450
 - JDK-8257450
 - JDK-8257450
 - JDK-8257450

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/1531/files
  - new: https://git.openjdk.java.net/jdk/pull/1531/files/f6a64473..96e75b08

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1531&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1531&range=01-02

  Stats: 851 lines in 29 files changed: 560 ins; 163 del; 128 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1531.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1531/head:pull/1531

PR: https://git.openjdk.java.net/jdk/pull/1531

Re: RFR: 8257450: Start of release updates for JDK 17 [v4]

[Joe Darcy]

> Start of JDK 17 updates.

Joe Darcy has updated the pull request with a new target base due to a merge or 
a rebase. The incremental webrev excludes the unrelated changes brought in by 
the merge/rebase. The pull request contains 10 additional commits since the 
last revision:

 - Merge branch 'master' into JDK-8257450
 - Merge branch 'master' into JDK-8257450
 - Merge branch 'master' into JDK-8257450
 - Update tests.
 - Merge branch 'master' into JDK-8257450
 - Merge branch 'JDK-8257450' of https://github.com/jddarcy/jdk into JDK-8257450
 - Merge branch 'JDK-8257450' of https://github.com/jddarcy/jdk into JDK-8257450
 - JDK-8257450
 - JDK-8257450
 - JDK-8257450

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/1531/files
  - new: https://git.openjdk.java.net/jdk/pull/1531/files/96e75b08..342c8650

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1531&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1531&range=02-03

  Stats: 3 lines in 1 file changed: 0 ins; 3 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1531.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1531/head:pull/1531

PR: https://git.openjdk.java.net/jdk/pull/1531

Re: RFR: 8257450: Start of release updates for JDK 17 [v5]

[Joe Darcy]

> Start of JDK 17 updates.

Joe Darcy has updated the pull request with a new target base due to a merge or 
a rebase. The incremental webrev excludes the unrelated changes brought in by 
the merge/rebase. The pull request contains 12 additional commits since the 
last revision:

 - Merge branch 'master' into JDK-8257450
 - Update symbol files for JDK 16b27.
 - Merge branch 'master' into JDK-8257450
 - Merge branch 'master' into JDK-8257450
 - Merge branch 'master' into JDK-8257450
 - Update tests.
 - Merge branch 'master' into JDK-8257450
 - Merge branch 'JDK-8257450' of https://github.com/jddarcy/jdk into JDK-8257450
 - Merge branch 'JDK-8257450' of https://github.com/jddarcy/jdk into JDK-8257450
 - JDK-8257450
 - ... and 2 more: https://git.openjdk.java.net/jdk/compare/e5462611...ff9b78ec

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/1531/files
  - new: https://git.openjdk.java.net/jdk/pull/1531/files/342c8650..ff9b78ec

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1531&range=04
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1531&range=03-04

  Stats: 1427 lines in 38 files changed: 1106 ins; 191 del; 130 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1531.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1531/head:pull/1531

PR: https://git.openjdk.java.net/jdk/pull/1531

Re: RFR: 8257450: Start of release updates for JDK 17 [v6]

[Joe Darcy]

> Start of JDK 17 updates.

Joe Darcy has updated the pull request with a new target base due to a merge or 
a rebase. The incremental webrev excludes the unrelated changes brought in by 
the merge/rebase. The pull request contains 14 additional commits since the 
last revision:

 - Get in JEP 390 changes.
 - Merge branch 'master' into JDK-8257450
 - Merge branch 'master' into JDK-8257450
 - Update symbol files for JDK 16b27.
 - Merge branch 'master' into JDK-8257450
 - Merge branch 'master' into JDK-8257450
 - Merge branch 'master' into JDK-8257450
 - Update tests.
 - Merge branch 'master' into JDK-8257450
 - Merge branch 'JDK-8257450' of https://github.com/jddarcy/jdk into JDK-8257450
 - ... and 4 more: https://git.openjdk.java.net/jdk/compare/823053e1...57ba7b64

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/1531/files
  - new: https://git.openjdk.java.net/jdk/pull/1531/files/ff9b78ec..57ba7b64

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1531&range=05
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1531&range=04-05

  Stats: 1178 lines in 148 files changed: 571 ins; 195 del; 412 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1531.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1531/head:pull/1531

PR: https://git.openjdk.java.net/jdk/pull/1531

Re: RFR: 8257450: Start of release updates for JDK 17 [v7]

[Joe Darcy]

> Start of JDK 17 updates.

Joe Darcy has updated the pull request with a new target base due to a merge or 
a rebase. The incremental webrev excludes the unrelated changes brought in by 
the merge/rebase. The pull request contains 17 additional commits since the 
last revision:

 - Merge branch 'master' into JDK-8257450
 - Merge branch 'master' into JDK-8257450
 - Merge branch 'master' into JDK-8257450
 - Get in JEP 390 changes.
 - Merge branch 'master' into JDK-8257450
 - Merge branch 'master' into JDK-8257450
 - Update symbol files for JDK 16b27.
 - Merge branch 'master' into JDK-8257450
 - Merge branch 'master' into JDK-8257450
 - Merge branch 'master' into JDK-8257450
 - ... and 7 more: https://git.openjdk.java.net/jdk/compare/bbfda542...766c2c01

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/1531/files
  - new: https://git.openjdk.java.net/jdk/pull/1531/files/57ba7b64..766c2c01

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1531&range=06
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1531&range=05-06

  Stats: 4920 lines in 147 files changed: 3195 ins; 1060 del; 665 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1531.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1531/head:pull/1531

PR: https://git.openjdk.java.net/jdk/pull/1531

Re: RFR: 8257450: Start of release updates for JDK 17 [v8]

[Joe Darcy]

> Start of JDK 17 updates.

Joe Darcy has updated the pull request with a new target base due to a merge or 
a rebase. The incremental webrev excludes the unrelated changes brought in by 
the merge/rebase. The pull request contains 18 additional commits since the 
last revision:

 - Merge branch 'master' into JDK-8257450
 - Merge branch 'master' into JDK-8257450
 - Merge branch 'master' into JDK-8257450
 - Merge branch 'master' into JDK-8257450
 - Get in JEP 390 changes.
 - Merge branch 'master' into JDK-8257450
 - Merge branch 'master' into JDK-8257450
 - Update symbol files for JDK 16b27.
 - Merge branch 'master' into JDK-8257450
 - Merge branch 'master' into JDK-8257450
 - ... and 8 more: https://git.openjdk.java.net/jdk/compare/61f30b72...553d134f

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/1531/files
  - new: https://git.openjdk.java.net/jdk/pull/1531/files/766c2c01..553d134f

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1531&range=07
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1531&range=06-07

  Stats: 554 lines in 7 files changed: 324 ins; 220 del; 10 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1531.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1531/head:pull/1531

PR: https://git.openjdk.java.net/jdk/pull/1531

Integrated: 8257450: Start of release updates for JDK 17

[Joe Darcy]

On Tue, 1 Dec 2020 06:22:51 GMT, Joe Darcy  wrote:

> Start of JDK 17 updates.

This pull request has now been integrated.

Changeset: 6be1f567
Author:    Joe Darcy 
URL:   https://git.openjdk.java.net/jdk/commit/6be1f567
Stats: 7607 lines in 77 files changed: 7548 ins; 0 del; 59 mod

8257450: Start of release updates for JDK 17
8257451: Add SourceVersion.RELEASE_17
8257453: Add source 17 and target 17 to javac

Reviewed-by: dholmes, erikj, iris, mikael, jjg, jlahoda, jwilhelm, mchung, ihse

-

PR: https://git.openjdk.java.net/jdk/pull/1531

RFR: 8257457: Update --release 16 symbol information for JDK 16 build 28

[Joe Darcy]

Update symbol information for --release 16 to JDK 16 b28, includes updates for 
JEP 390.

-

Commit messages:
 - 8257457

Changes: https://git.openjdk.java.net/jdk/pull/1754/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1754&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8257457
  Stats: 235 lines in 4 files changed: 149 ins; 2 del; 84 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1754.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1754/head:pull/1754

PR: https://git.openjdk.java.net/jdk/pull/1754

RFR: 8258143: Update --release 16 symbol information for JDK 16 build 30 or later

[Joe Darcy]

Updating to the symbol files for JDK 16 b30; change generated with the script 

make/scripts/generate-symbol-data.sh

The change to the java.desktop module looks to be for JDK-8258373.

-

Commit messages:
 - 8258143: Update --release 16 symbol information for JDK 16 build 30 or later

Changes: https://git.openjdk.java.net/jdk/pull/1954/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1954&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8258143
  Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1954.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1954/head:pull/1954

PR: https://git.openjdk.java.net/jdk/pull/1954

Integrated: 8258143: Update --release 16 symbol information for JDK 16 build 30 or later

[Joe Darcy]

On Wed, 6 Jan 2021 02:19:51 GMT, Joe Darcy  wrote:

> Updating to the symbol files for JDK 16 b30; change generated with the script 
> 
> make/scripts/generate-symbol-data.sh
> 
> The change to the java.desktop module looks to be for JDK-8258373.

This pull request has now been integrated.

Changeset: d20d2fa9
Author:Joe Darcy 
URL:   https://git.openjdk.java.net/jdk/commit/d20d2fa9
Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod

8258143: Update --release 16 symbol information for JDK 16 build 30 or later

Reviewed-by: iris, erikj

-

PR: https://git.openjdk.java.net/jdk/pull/1954

RFR: 8259512: Update --release 16 symbol information for JDK 16 build 31

[Joe Darcy]

Using the symbol updating script, update the symbol files for API changes in 
JDK 16 build 31.

-

Commit messages:
 - 8259512: Update --release 16 symbol information for JDK 16 build 31

Changes: https://git.openjdk.java.net/jdk/pull/2010/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2010&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8259512
  Stats: 9 lines in 1 file changed: 8 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2010.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2010/head:pull/2010

PR: https://git.openjdk.java.net/jdk/pull/2010

Integrated: 8259512: Update --release 16 symbol information for JDK 16 build 31

[Joe Darcy]

On Fri, 8 Jan 2021 22:36:01 GMT, Joe Darcy  wrote:

> Using the symbol updating script, update the symbol files for API changes in 
> JDK 16 build 31.

This pull request has now been integrated.

Changeset: a6539282
Author:    Joe Darcy 
URL:   https://git.openjdk.java.net/jdk/commit/a6539282
Stats: 9 lines in 1 file changed: 8 ins; 0 del; 1 mod

8259512: Update --release 16 symbol information for JDK 16 build 31

Reviewed-by: jjg

-

PR: https://git.openjdk.java.net/jdk/pull/2010

RFR: 8262893: Enable more doclint checks in javadoc build

[Joe Darcy]

With recent cleanups, several doclint categories have been cleared across the 
JDK and should be enabled in the javadoc build to make sure they stay clean.

Local docs build completes with this stricter set of checks.

-

Commit messages:
 - 8262893: Enable more doclint checks in javadoc build

Changes: https://git.openjdk.java.net/jdk/pull/2799/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2799&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8262893
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2799.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2799/head:pull/2799

PR: https://git.openjdk.java.net/jdk/pull/2799

Integrated: 8262893: Enable more doclint checks in javadoc build

[Joe Darcy]

On Tue, 2 Mar 2021 22:41:38 GMT, Joe Darcy  wrote:

> With recent cleanups, several doclint categories have been cleared across the 
> JDK and should be enabled in the javadoc build to make sure they stay clean.
> 
> Local docs build completes with this stricter set of checks.

This pull request has now been integrated.

Changeset: c9097a60
Author:    Joe Darcy 
URL:   https://git.openjdk.java.net/jdk/commit/c9097a60
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod

8262893: Enable more doclint checks in javadoc build

Reviewed-by: jjg, erikj

-

PR: https://git.openjdk.java.net/jdk/pull/2799

Re: RFR: 8257459: Bump minimum boot jdk to JDK 16

[Joe Darcy]

On Sat, 17 Apr 2021 07:20:21 GMT, Mikael Vidstedt  wrote:

> With JDK 16 having gone GA about a month ago it's time to bump the minimum 
> boot JDK version for mainline/JDK 17.
> 
> Testing: tier1-5.

Marked as reviewed by darcy (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/3555

Re: RFR: 8266459: Implement JEP 411: Deprecate the Security Manager for Removal

[Joe Darcy]

On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang  wrote:

> Please review this implementation of [JEP 
> 411](https://openjdk.java.net/jeps/411).
> 
> The code change is divided into 3 commits. Please review them one by one.
> 
> 1. 
> https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28c9f9be7941a1
>  The essential change for this JEP, including the `@Deprecate` annotations 
> and spec change. It also update the default value of the 
> `java.security.manager` system property to "disallow", and necessary test 
> change following this update.
> 2. 
> https://github.com/openjdk/jdk/commit/26a54a835e9f84aa528740a7c5c35d07355a8a66
>  Manual changes to several files so that the next commit can be generated 
> programatically.
> 3. 
> https://github.com/openjdk/jdk/commit/eb6c566ff9207974a03a53335e0e697cffcf0950
>  Automatic changes to other source files to avoid javac warnings on 
> deprecation for removal
> 
> The 1st and 2nd commits should be reviewed carefully. The 3rd one is 
> generated programmatically, see the comment below for more details. If you 
> are only interested in a portion of the 3rd commit and would like to review 
> it as a separate file, please comment here and I'll generate an individual 
> webrev.
> 
> Due to the size of this PR, no attempt is made to update copyright years for 
> any file to minimize unnecessary merge conflict.
> 
> Furthermore, since the default value of `java.security.manager` system 
> property is now "disallow", most of the tests calling 
> `System.setSecurityManager()` need to launched with 
> `-Djava.security.manager=allow`. This is covered in a different PR at 
> https://github.com/openjdk/jdk/pull/4071.

Marked as reviewed by darcy (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/4073

Re: RFR: 8267630: Start of release updates for JDK 18

[Joe Darcy]

On Mon, 24 May 2021 22:35:04 GMT, Joe Darcy  wrote:

> 8267630: Start of release updates for JDK 18

JDK 18 is right around the corner, time for the usual start-of-release 
changeset for review.

Typical structure for these kinds of changes. I'll update the symbol file 
information of JDK 17 b25 after that build is promoted.

Usual updates to SourceVersion, javac, HotSpot, and version-oriented tests.

Please also review the related CSRs:

JDK-8268156: Add SourceVersion.RELEASE_18
https://bugs.openjdk.java.net/browse/JDK-8268156

JDK-8268157: Add source 18 and target 18 to javac
https://bugs.openjdk.java.net/browse/JDK-8268157

-

PR: https://git.openjdk.java.net/jdk/pull/4175

RFR: 8267630: Start of release updates for JDK 18

[Joe Darcy]

8267630: Start of release updates for JDK 18

-

Commit messages:
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Clean langtools test run.
 - ... and 1 more: https://git.openjdk.java.net/jdk/compare/ef01e478...9c7c88bf

Changes: https://git.openjdk.java.net/jdk/pull/4175/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4175&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8267630
  Stats: 4946 lines in 62 files changed: 4904 ins; 0 del; 42 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4175.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4175/head:pull/4175

PR: https://git.openjdk.java.net/jdk/pull/4175

Re: RFR: 8267630: Start of release updates for JDK 18 [v2]

[Joe Darcy]

> 8267630: Start of release updates for JDK 18

Joe Darcy has updated the pull request with a new target base due to a merge or 
a rebase. The incremental webrev excludes the unrelated changes brought in by 
the merge/rebase. The pull request contains 12 additional commits since the 
last revision:

 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - ... and 2 more: https://git.openjdk.java.net/jdk/compare/388f8dae...e584c467

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/4175/files
  - new: https://git.openjdk.java.net/jdk/pull/4175/files/9c7c88bf..e584c467

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4175&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4175&range=00-01

  Stats: 428395 lines in 342 files changed: 426299 ins; 917 del; 1179 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4175.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4175/head:pull/4175

PR: https://git.openjdk.java.net/jdk/pull/4175

Re: RFR: 8267630: Start of release updates for JDK 18 [v3]

[Joe Darcy]

> 8267630: Start of release updates for JDK 18

Joe Darcy has updated the pull request with a new target base due to a merge or 
a rebase. The incremental webrev excludes the unrelated changes brought in by 
the merge/rebase. The pull request contains 13 additional commits since the 
last revision:

 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - ... and 3 more: https://git.openjdk.java.net/jdk/compare/662de459...fc4d8725

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/4175/files
  - new: https://git.openjdk.java.net/jdk/pull/4175/files/e584c467..fc4d8725

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4175&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4175&range=01-02

  Stats: 112 lines in 5 files changed: 10 ins; 50 del; 52 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4175.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4175/head:pull/4175

PR: https://git.openjdk.java.net/jdk/pull/4175

Re: RFR: 8267630: Start of release updates for JDK 18 [v4]

[Joe Darcy]

> 8267630: Start of release updates for JDK 18

Joe Darcy has updated the pull request with a new target base due to a merge or 
a rebase. The incremental webrev excludes the unrelated changes brought in by 
the merge/rebase. The pull request contains 15 additional commits since the 
last revision:

 - Update symbols for JDK 17 b25.
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - ... and 5 more: https://git.openjdk.java.net/jdk/compare/5aafa154...f926c1bc

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/4175/files
  - new: https://git.openjdk.java.net/jdk/pull/4175/files/fc4d8725..f926c1bc

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4175&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4175&range=02-03

  Stats: 2678 lines in 127 files changed: 1537 ins; 898 del; 243 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4175.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4175/head:pull/4175

PR: https://git.openjdk.java.net/jdk/pull/4175

RFR: 8268299: jvms tag produces incorrect URL

[Joe Darcy]

The @jls and @jvms taglet share most of their functionality.  A  JLS URL looks 
like

https://docs.oracle.com/javase/specs/jls/se16/html/**jls**-8.html#jls-8.1

and a JVMS URL looks like


https://docs.oracle.com/javase/specs/jvms/se16/html/**jvms**-4.html#jvms-4.3.2

The current taglet incorrectly uses "jls" in from the chapter for both JLS and 
JVMS URLs. The patch corrects this to use "jvms" for JVMS URLs.

-

Commit messages:
 - 8268299: jvms tag produces incorrect URL

Changes: https://git.openjdk.java.net/jdk/pull/4381/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4381&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8268299
  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4381.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4381/head:pull/4381

PR: https://git.openjdk.java.net/jdk/pull/4381

Integrated: 8268299: jvms tag produces incorrect URL

[Joe Darcy]

On Sun, 6 Jun 2021 22:03:46 GMT, Joe Darcy  wrote:

> The @jls and @jvms taglet share most of their functionality.  A  JLS URL 
> looks like
> 
> https://docs.oracle.com/javase/specs/jls/se16/html/**jls**-8.html#jls-8.1
> 
> and a JVMS URL looks like
> 
> 
> https://docs.oracle.com/javase/specs/jvms/se16/html/**jvms**-4.html#jvms-4.3.2
> 
> The current taglet incorrectly uses "jls" in from the chapter for both JLS 
> and JVMS URLs. The patch corrects this to use "jvms" for JVMS URLs.

This pull request has now been integrated.

Changeset: e663ba96
Author:Joe Darcy 
URL:   
https://git.openjdk.java.net/jdk/commit/e663ba961f25c83758815bbfce97a58d9560c7a2
Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod

8268299: jvms tag produces incorrect URL

Reviewed-by: iris, erikj, jjg

-

PR: https://git.openjdk.java.net/jdk/pull/4381

Re: RFR: 8267630: Start of release updates for JDK 18 [v5]

[Joe Darcy]

> 8267630: Start of release updates for JDK 18

Joe Darcy has updated the pull request with a new target base due to a merge or 
a rebase. The incremental webrev excludes the unrelated changes brought in by 
the merge/rebase. The pull request contains 17 additional commits since the 
last revision:

 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Update symbols for JDK 17 b25.
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - ... and 7 more: https://git.openjdk.java.net/jdk/compare/947ea6f5...34480e50

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/4175/files
  - new: https://git.openjdk.java.net/jdk/pull/4175/files/f926c1bc..34480e50

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4175&range=04
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4175&range=03-04

  Stats: 24229 lines in 300 files changed: 22483 ins; 936 del; 810 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4175.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4175/head:pull/4175

PR: https://git.openjdk.java.net/jdk/pull/4175

Re: RFR: 8267630: Start of release updates for JDK 18 [v6]

[Joe Darcy]

> 8267630: Start of release updates for JDK 18

Joe Darcy has updated the pull request with a new target base due to a merge or 
a rebase. The incremental webrev excludes the unrelated changes brought in by 
the merge/rebase. The pull request contains 18 additional commits since the 
last revision:

 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Update symbols for JDK 17 b25.
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - ... and 8 more: https://git.openjdk.java.net/jdk/compare/f12e9650...15479c92

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/4175/files
  - new: https://git.openjdk.java.net/jdk/pull/4175/files/34480e50..15479c92

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4175&range=05
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4175&range=04-05

  Stats: 5201 lines in 96 files changed: 2786 ins; 1026 del; 1389 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4175.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4175/head:pull/4175

PR: https://git.openjdk.java.net/jdk/pull/4175

Re: RFR: 8267630: Start of release updates for JDK 18 [v7]

[Joe Darcy]

> 8267630: Start of release updates for JDK 18

Joe Darcy has updated the pull request with a new target base due to a merge or 
a rebase. The pull request now contains 19 commits:

 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Update symbols for JDK 17 b25.
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - ... and 9 more: https://git.openjdk.java.net/jdk/compare/51e8201e...ee6bd4de

-

Changes: https://git.openjdk.java.net/jdk/pull/4175/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4175&range=06
  Stats: 5334 lines in 63 files changed: 5292 ins; 0 del; 42 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4175.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4175/head:pull/4175

PR: https://git.openjdk.java.net/jdk/pull/4175

Re: RFR: 8267630: Start of release updates for JDK 18 [v8]

[Joe Darcy]

> 8267630: Start of release updates for JDK 18

Joe Darcy has updated the pull request with a new target base due to a merge or 
a rebase. The pull request now contains 21 commits:

 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Update symbols for JDK 17 b25.
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - ... and 11 more: https://git.openjdk.java.net/jdk/compare/b41f3f8e...ae4d6cce

-

Changes: https://git.openjdk.java.net/jdk/pull/4175/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4175&range=07
  Stats: 5334 lines in 63 files changed: 5292 ins; 0 del; 42 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4175.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4175/head:pull/4175

PR: https://git.openjdk.java.net/jdk/pull/4175

Re: RFR: 8267630: Start of release updates for JDK 18 [v9]

[Joe Darcy]

> 8267630: Start of release updates for JDK 18

Joe Darcy has updated the pull request with a new target base due to a merge or 
a rebase. The pull request now contains 22 commits:

 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Update symbols for JDK 17 b25.
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - ... and 12 more: https://git.openjdk.java.net/jdk/compare/2623b0bf...794f3173

-

Changes: https://git.openjdk.java.net/jdk/pull/4175/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4175&range=08
  Stats: 5334 lines in 63 files changed: 5292 ins; 0 del; 42 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4175.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4175/head:pull/4175

PR: https://git.openjdk.java.net/jdk/pull/4175

Re: RFR: 8267630: Start of release updates for JDK 18 [v10]

[Joe Darcy]

> 8267630: Start of release updates for JDK 18

Joe Darcy has updated the pull request with a new target base due to a merge or 
a rebase. The pull request now contains 24 commits:

 - Update copyright year.
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Update symbols for JDK 17 b25.
 - ... and 14 more: https://git.openjdk.java.net/jdk/compare/dd1cbadc...aaf47c1f

-

Changes: https://git.openjdk.java.net/jdk/pull/4175/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4175&range=09
  Stats: 5352 lines in 63 files changed: 5292 ins; 0 del; 60 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4175.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4175/head:pull/4175

PR: https://git.openjdk.java.net/jdk/pull/4175

Re: RFR: 8267630: Start of release updates for JDK 18 [v11]

[Joe Darcy]

> 8267630: Start of release updates for JDK 18

Joe Darcy has updated the pull request with a new target base due to a merge or 
a rebase. The pull request now contains 25 commits:

 - Merge branch 'master' into 8267630
 - Update copyright year.
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - Merge branch 'master' into 8267630
 - ... and 15 more: https://git.openjdk.java.net/jdk/compare/a95e64cc...51f51814

-

Changes: https://git.openjdk.java.net/jdk/pull/4175/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4175&range=10
  Stats: 5352 lines in 63 files changed: 5292 ins; 0 del; 60 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4175.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4175/head:pull/4175

PR: https://git.openjdk.java.net/jdk/pull/4175

Integrated: 8267630: Start of release updates for JDK 18

[Joe Darcy]

On Mon, 24 May 2021 22:35:04 GMT, Joe Darcy  wrote:

> 8267630: Start of release updates for JDK 18

This pull request has now been integrated.

Changeset: b018c450
Author:    Joe Darcy 
URL:   
https://git.openjdk.java.net/jdk/commit/b018c450e5e4737ccd08ed505fd06cee16c42648
Stats: 5352 lines in 63 files changed: 5292 ins; 0 del; 60 mod

8267630: Start of release updates for JDK 18
8267632: Add source 18 and target 18 to javac
8267631: Add SourceVersion.RELEASE_18

Reviewed-by: iris, erikj, dholmes

-

PR: https://git.openjdk.java.net/jdk/pull/4175

Re: RFR: 8266036: class file for sun.misc.Contended not found

[Joe Darcy]

On Wed, 9 Jun 2021 11:05:37 GMT, Jan Lahoda  wrote:

> The ct.sym may contain classfiles referring to annotations that are not 
> present in ct.sym (liek JDK's internal annotation `sun.misc.Contended`). If 
> javac will try to load them (while discovering annotations for the purpose of 
> detecting which annotation processors should be run), an error will be 
> produced (please see the issue). The proposal is to strip annotations that 
> are not present in ct.sym when generating ct.sym.

Does jdk.internal.ValueBased also need special handling? See JDK-8258421.

-

PR: https://git.openjdk.java.net/jdk/pull/4428

Re: [jdk17] RFR: 8266036: class file for sun.misc.Contended not found

[Joe Darcy]

On Fri, 11 Jun 2021 13:09:55 GMT, Jan Lahoda  wrote:

> [this is an improved version of openjdk/jdk PR:
> https://github.com/openjdk/jdk/pull/4428
> ]
> 
> The ct.sym may contain classfiles referring to annotations that are not 
> present in ct.sym (liek JDK's internal annotation sun.misc.Contended). If 
> javac will try to load them (while discovering annotations for the purpose of 
> detecting which annotation processors should be run), an error will be 
> produced (please see the issue). The proposal is to strip annotations that 
> are not present in ct.sym when generating ct.sym.
> 
> As noted by @jddarcy, we also need a special handling of ValueBased, which 
> this patch should do, so it also solves 
> https://bugs.openjdk.java.net/browse/JDK-8258421

I was wondering how better to document that the addition of new JDK-specific 
annotation types might require more updates to this list.

Perhaps adding notes in the existing annotation types would help, as people 
might cut-and-paste the old types when creating new ones. That may be more 
effective than adding package-level documentation on the internal packages.

-

Marked as reviewed by darcy (Reviewer).

PR: https://git.openjdk.java.net/jdk17/pull/27

RFR: 8267634: Update --release 17 symbol information for JDK 17 build 26

[Joe Darcy]

Update symbol files in JDK 18 for changes in JDK 17 b26.

-

Commit messages:
 - 8267634: Update --release 17 symbol information for JDK 17 build 26

Changes: https://git.openjdk.java.net/jdk/pull/4477/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4477&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8267634
  Stats: 222 lines in 8 files changed: 206 ins; 13 del; 3 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4477.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4477/head:pull/4477

PR: https://git.openjdk.java.net/jdk/pull/4477

Integrated: 8267634: Update --release 17 symbol information for JDK 17 build 26

[Joe Darcy]

On Fri, 11 Jun 2021 22:44:03 GMT, Joe Darcy  wrote:

> Update symbol files in JDK 18 for changes in JDK 17 b26.

This pull request has now been integrated.

Changeset: a466b49e
Author:    Joe Darcy 
URL:   
https://git.openjdk.java.net/jdk/commit/a466b49e71b0d235294e17faba47ed4fd3fb8f6e
Stats: 222 lines in 8 files changed: 206 ins; 13 del; 3 mod

8267634: Update --release 17 symbol information for JDK 17 build 26

Reviewed-by: jjg, iris

-

PR: https://git.openjdk.java.net/jdk/pull/4477

RFR: 8268637: Update --release 17 symbol information for JDK 17 build 28

[Joe Darcy]

JDK 17 b28 had two fixes which updated the symbol information. A 
CallerSensitive annotation was removed as part of JDK-8268349 and API changes 
in JDK-826.

These should be reflected in the JDK 18 symbol information for 17.

-

Commit messages:
 - 8268637: Update --release 17 symbol information for JDK 17 build 28

Changes: https://git.openjdk.java.net/jdk/pull/4641/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4641&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8268637
  Stats: 6 lines in 2 files changed: 2 ins; 4 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4641.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4641/head:pull/4641

PR: https://git.openjdk.java.net/jdk/pull/4641

Integrated: 8268637: Update --release 17 symbol information for JDK 17 build 28

[Joe Darcy]

On Wed, 30 Jun 2021 16:54:57 GMT, Joe Darcy  wrote:

> JDK 17 b28 had two fixes which updated the symbol information. A 
> CallerSensitive annotation was removed as part of JDK-8268349 and API changes 
> in JDK-826.
> 
> These should be reflected in the JDK 18 symbol information for 17.

This pull request has now been integrated.

Changeset: 85262c71
Author:Joe Darcy 
URL:   
https://git.openjdk.java.net/jdk/commit/85262c71834e9293ee1fe90baf84bf928405cf98
Stats: 6 lines in 2 files changed: 2 ins; 4 del; 0 mod

8268637: Update --release 17 symbol information for JDK 17 build 28

Reviewed-by: iris

-

PR: https://git.openjdk.java.net/jdk/pull/4641

RFR: 8269689: Update --release 17 symbol information for JDK 17 build 31

[Joe Darcy]

Usual kind of  updates for the symbol information in JDK 18 to reflect changes 
in the JDK 17 API. Bug fixes with API changes since JDK 17 b28 include 
JDK-8266313, JDK-8268972, and JDK-8266269.

-

Commit messages:
 - 8269689: Update --release 17 symbol information for JDK 17 build 31

Changes: https://git.openjdk.java.net/jdk/pull/4820/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4820&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8269689
  Stats: 6 lines in 2 files changed: 2 ins; 2 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4820.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4820/head:pull/4820

PR: https://git.openjdk.java.net/jdk/pull/4820

Re: RFR: 8272067: Initial nroff manpage generation for JDK 18

[Joe Darcy]

On Fri, 6 Aug 2021 01:53:51 GMT, David Holmes  wrote:

> Please review this trivial update to the generated manpages that updates 
> their version from "JDK 17" to "JDK 18-ea".
> 
> Thanks,
> David

Marked as reviewed by darcy (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/5028

Re: RFR: JDK-8272667: substandard error messages from the docs build

[Joe Darcy]

On Wed, 18 Aug 2021 22:06:13 GMT, Jonathan Gibbons  wrote:

> Please review a small (delete one character) change to improve the error 
> messages reported when bad HTML is detected when post-processing the output 
> from pandoc to generate the docs.
> 
> The change is just to pass the filename as an argument to the command, 
> instead of just piping the input to stdin. As a result, the name of any file 
> containing bad input is reported in the message, instead of the message 
> simply referring to ``

Marked as reviewed by darcy (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/5175

Re: RFR: 8267636: Bump minimum boot jdk to JDK 17

[Joe Darcy]

On Wed, 22 Sep 2021 20:03:55 GMT, Mikael Vidstedt  wrote:

> With the JDK 17 GA out it's time to bump the minimum boot JDK version for 
> mainline/JDK 18.
> 
> Testing: tier1-5, GHA builds

Marked as reviewed by darcy (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/5639

RFR: 8202056: Expand serial warning to check for bad overloads of serial-related methods and ineffectual fields

[Joe Darcy]

This is an initial PR for expanded lint warnings done under two bugs:

8202056: Expand serial warning to check for bad overloads of serial-related 
methods and ineffectual fields
8160675: Issue lint warning for non-serializable non-transient instance fields 
in serializable type

to get feedback on the general approach and test strategy before further 
polishing the implementation.

The implementation initially started as an annotation processor I wrote several 
years ago. The refined version being incorporated into Attr has been 
refactored, had its checks expanded, and been partially ported to idiomatic 
javac coding style rather than using the javax.lang.model API from annotation 
processing.

Subsequent versions of this PR are expected to move the implementation closer 
to idiomatic javac, in particular to use javac flags rather than 
javax.lang.model.Modifier's. Additional resources keys will be defined for the 
serialization-related fields and methods not having the expected modifiers, 
types, etc. The resource keys for the existing checks related to 
serialVersionUID and reused.

Please also review the corresponding CSRs:

https://bugs.openjdk.java.net/browse/JDK-8274335
https://bugs.openjdk.java.net/browse/JDK-8274336

Informative serialization-related warning messages must take into account 
whether a class, interface, annotation, record, and enum is being analyzed. 
Enum classes and record classes have special handling in serialization. This 
implementation under review has been augmented with checks for interface types 
recommended by Chris Hegarty in an attachment on 8202056.

The JDK build has the Xlint:serial check enabled. The build did not pass with 
the augmented checks. For most modules, this PR contains the library changes 
necessary for the build to pass. I will start separate PRs in those library 
areas to get the needed SuppressWarning("serial") or other changes in place. 
For one module, I temporarily disabled the Xlint:serial check.

In terms of performance, I have not done benchmarks of the JDK build with and 
without these changes, but informally the build seems to take about as long as 
before.

-

Commit messages:
 - Appease jcheck
 - Implement checks chegar recommended for interfaces.
 - Update comment.
 - Add tests for instance field checks.
 - Clean build with instance field checks in place.
 - Merge branch 'master' into JDK-8202056
 - Put Externalizable checks last.
 - Add checks for constructor access in Serializable classes.
 - Add no-arg ctor check for Externalizable classes.
 - Improve Externalization warnings.
 - ... and 19 more: https://git.openjdk.java.net/jdk/compare/5756385c...d498ff5f

Changes: https://git.openjdk.java.net/jdk/pull/5709/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5709&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8202056
  Stats: 1519 lines in 79 files changed: 1511 ins; 1 del; 7 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5709.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5709/head:pull/5709

PR: https://git.openjdk.java.net/jdk/pull/5709

Re: RFR: 8202056: Expand serial warning to check for bad overloads of serial-related methods and ineffectual fields [v2]

[Joe Darcy]

> This is an initial PR for expanded lint warnings done under two bugs:
> 
> 8202056: Expand serial warning to check for bad overloads of serial-related 
> methods and ineffectual fields
> 8160675: Issue lint warning for non-serializable non-transient instance 
> fields in serializable type
> 
> to get feedback on the general approach and test strategy before further 
> polishing the implementation.
> 
> The implementation initially started as an annotation processor I wrote 
> several years ago. The refined version being incorporated into Attr has been 
> refactored, had its checks expanded, and been partially ported to idiomatic 
> javac coding style rather than using the javax.lang.model API from annotation 
> processing.
> 
> Subsequent versions of this PR are expected to move the implementation closer 
> to idiomatic javac, in particular to use javac flags rather than 
> javax.lang.model.Modifier's. Additional resources keys will be defined for 
> the serialization-related fields and methods not having the expected 
> modifiers, types, etc. The resource keys for the existing checks related to 
> serialVersionUID and reused.
> 
> Please also review the corresponding CSRs:
> 
> https://bugs.openjdk.java.net/browse/JDK-8274335
> https://bugs.openjdk.java.net/browse/JDK-8274336
> 
> Informative serialization-related warning messages must take into account 
> whether a class, interface, annotation, record, and enum is being analyzed. 
> Enum classes and record classes have special handling in serialization. This 
> implementation under review has been augmented with checks for interface 
> types recommended by Chris Hegarty in an attachment on 8202056.
> 
> The JDK build has the Xlint:serial check enabled. The build did not pass with 
> the augmented checks. For most modules, this PR contains the library changes 
> necessary for the build to pass. I will start separate PRs in those library 
> areas to get the needed SuppressWarning("serial") or other changes in place. 
> For one module, I temporarily disabled the Xlint:serial check.
> 
> In terms of performance, I have not done benchmarks of the JDK build with and 
> without these changes, but informally the build seems to take about as long 
> as before.

Joe Darcy has updated the pull request with a new target base due to a merge or 
a rebase. The incremental webrev excludes the unrelated changes brought in by 
the merge/rebase. The pull request contains 30 additional commits since the 
last revision:

 - Merge branch 'master' into JDK-8202056
 - Appease jcheck
 - Implement checks chegar recommended for interfaces.
 - Update comment.
 - Add tests for instance field checks.
 - Clean build with instance field checks in place.
 - Merge branch 'master' into JDK-8202056
 - Put Externalizable checks last.
 - Add checks for constructor access in Serializable classes.
 - Add no-arg ctor check for Externalizable classes.
 - ... and 20 more: https://git.openjdk.java.net/jdk/compare/fa1a96de...053de6bb

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/5709/files
  - new: https://git.openjdk.java.net/jdk/pull/5709/files/d498ff5f..053de6bb

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=5709&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=5709&range=00-01

  Stats: 469 lines in 32 files changed: 252 ins; 70 del; 147 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5709.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5709/head:pull/5709

PR: https://git.openjdk.java.net/jdk/pull/5709

Re: RFR: 8202056: Expand serial warning to check for bad overloads of serial-related methods and ineffectual fields [v3]

[Joe Darcy]

> This is an initial PR for expanded lint warnings done under two bugs:
> 
> 8202056: Expand serial warning to check for bad overloads of serial-related 
> methods and ineffectual fields
> 8160675: Issue lint warning for non-serializable non-transient instance 
> fields in serializable type
> 
> to get feedback on the general approach and test strategy before further 
> polishing the implementation.
> 
> The implementation initially started as an annotation processor I wrote 
> several years ago. The refined version being incorporated into Attr has been 
> refactored, had its checks expanded, and been partially ported to idiomatic 
> javac coding style rather than using the javax.lang.model API from annotation 
> processing.
> 
> Subsequent versions of this PR are expected to move the implementation closer 
> to idiomatic javac, in particular to use javac flags rather than 
> javax.lang.model.Modifier's. Additional resources keys will be defined for 
> the serialization-related fields and methods not having the expected 
> modifiers, types, etc. The resource keys for the existing checks related to 
> serialVersionUID and reused.
> 
> Please also review the corresponding CSRs:
> 
> https://bugs.openjdk.java.net/browse/JDK-8274335
> https://bugs.openjdk.java.net/browse/JDK-8274336
> 
> Informative serialization-related warning messages must take into account 
> whether a class, interface, annotation, record, and enum is being analyzed. 
> Enum classes and record classes have special handling in serialization. This 
> implementation under review has been augmented with checks for interface 
> types recommended by Chris Hegarty in an attachment on 8202056.
> 
> The JDK build has the Xlint:serial check enabled. The build did not pass with 
> the augmented checks. For most modules, this PR contains the library changes 
> necessary for the build to pass. I will start separate PRs in those library 
> areas to get the needed SuppressWarning("serial") or other changes in place. 
> For one module, I temporarily disabled the Xlint:serial check.
> 
> In terms of performance, I have not done benchmarks of the JDK build with and 
> without these changes, but informally the build seems to take about as long 
> as before.

Joe Darcy has updated the pull request with a new target base due to a merge or 
a rebase. The incremental webrev excludes the unrelated changes brought in by 
the merge/rebase. The pull request contains 33 additional commits since the 
last revision:

 - Merge branch 'master' into JDK-8202056
 - Merge branch 'master' into JDK-8202056
 - Restore serial checks on java.xml module.
 - Merge branch 'master' into JDK-8202056
 - Appease jcheck
 - Implement checks chegar recommended for interfaces.
 - Update comment.
 - Add tests for instance field checks.
 - Clean build with instance field checks in place.
 - Merge branch 'master' into JDK-8202056
 - ... and 23 more: https://git.openjdk.java.net/jdk/compare/7925d0cc...bacff4e9

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/5709/files
  - new: https://git.openjdk.java.net/jdk/pull/5709/files/053de6bb..bacff4e9

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=5709&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=5709&range=01-02

  Stats: 2951 lines in 77 files changed: 2399 ins; 397 del; 155 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5709.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5709/head:pull/5709

PR: https://git.openjdk.java.net/jdk/pull/5709

Re: RFR: 8202056: Expand serial warning to check for bad overloads of serial-related methods and ineffectual fields [v4]

[Joe Darcy]

> This is an initial PR for expanded lint warnings done under two bugs:
> 
> 8202056: Expand serial warning to check for bad overloads of serial-related 
> methods and ineffectual fields
> 8160675: Issue lint warning for non-serializable non-transient instance 
> fields in serializable type
> 
> to get feedback on the general approach and test strategy before further 
> polishing the implementation.
> 
> The implementation initially started as an annotation processor I wrote 
> several years ago. The refined version being incorporated into Attr has been 
> refactored, had its checks expanded, and been partially ported to idiomatic 
> javac coding style rather than using the javax.lang.model API from annotation 
> processing.
> 
> Subsequent versions of this PR are expected to move the implementation closer 
> to idiomatic javac, in particular to use javac flags rather than 
> javax.lang.model.Modifier's. Additional resources keys will be defined for 
> the serialization-related fields and methods not having the expected 
> modifiers, types, etc. The resource keys for the existing checks related to 
> serialVersionUID and reused.
> 
> Please also review the corresponding CSRs:
> 
> https://bugs.openjdk.java.net/browse/JDK-8274335
> https://bugs.openjdk.java.net/browse/JDK-8274336
> 
> Informative serialization-related warning messages must take into account 
> whether a class, interface, annotation, record, and enum is being analyzed. 
> Enum classes and record classes have special handling in serialization. This 
> implementation under review has been augmented with checks for interface 
> types recommended by Chris Hegarty in an attachment on 8202056.
> 
> The JDK build has the Xlint:serial check enabled. The build did not pass with 
> the augmented checks. For most modules, this PR contains the library changes 
> necessary for the build to pass. I will start separate PRs in those library 
> areas to get the needed SuppressWarning("serial") or other changes in place. 
> For one module, I temporarily disabled the Xlint:serial check.
> 
> In terms of performance, I have not done benchmarks of the JDK build with and 
> without these changes, but informally the build seems to take about as long 
> as before.

Joe Darcy has updated the pull request with a new target base due to a merge or 
a rebase. The pull request now contains 35 commits:

 - Fix whitespace.
 - Merge branch 'master' into JDK-8202056
 - Merge branch 'master' into JDK-8202056
 - Merge branch 'master' into JDK-8202056
 - Restore serial checks on java.xml module.
 - Merge branch 'master' into JDK-8202056
 - Appease jcheck
 - Implement checks chegar recommended for interfaces.
 - Update comment.
 - Add tests for instance field checks.
 - ... and 25 more: https://git.openjdk.java.net/jdk/compare/d8a278f3...37ad8778

-

Changes: https://git.openjdk.java.net/jdk/pull/5709/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5709&range=03
  Stats: 1495 lines in 64 files changed: 1488 ins; 0 del; 7 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5709.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5709/head:pull/5709

PR: https://git.openjdk.java.net/jdk/pull/5709

Re: RFR: 8276400: openjdk image Jars, Zips and Jmods built from the same source are not reproducible

[Joe Darcy]

On Thu, 4 Nov 2021 20:56:45 GMT, Andrew Leonard  wrote:

> This PR enables reproducible Jars, Jmods and openjdk image zip files 
> (eg.src.zip).
> It provides support for SOURCE_DATE_EPOCH for Jar, Jmod and underlying 
> ZipOutputStream's.
> It fixes the following keys issues relating to reproducibility:
> - Jar and ZipOutputStream are not SOURCE_DATE_EPOCH aware
>   - Jar and ZipOutputStream now detect SOURCE_DATE_EPOCH environment setting
> - Jar and Jmod file content ordering was non-determinsitic
>   - Fixes to Jar and Jmod main's to ensure sorted classes content ordering
> - openjdk image zip file generation used "zip" which is non-determinsitic
>   - New openjdk build tool "GenerateZip" which produces the final 
> determinsitic zip files as part of the build and also detects 
> SOURCE_DATE_EPOCH
> 
> Signed-off-by: Andrew Leonard 

Please file a CSR for the behavioral change of recognizing SOURCE_DATE_EPOCH, 
etc. Thanks.

-

PR: https://git.openjdk.java.net/jdk/pull/6268

RFR: JDK-8273146: Start of release updates for JDK 19

[Joe Darcy]

The time to get JDK 19 underway draws nigh, please review this usual set of 
start-of-release updates, including CSRs for the javac and javax.lang.model 
updates:

JDK-8277512: Add SourceVersion.RELEASE_19
https://bugs.openjdk.java.net/browse/JDK-8277512

JDK-8277514: Add source 19 and target 19 to javac
https://bugs.openjdk.java.net/browse/JDK-8277514

Clean local tier 1 test runs for langtools, jdk, and hotspot.

-

Commit messages:
 - Add --release 18 information. Good tier1 test results.
 - JDK-8273146: Start of release updates for JDK 19

Changes: https://git.openjdk.java.net/jdk/pull/6493/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6493&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8273146
  Stats: 3242 lines in 67 files changed: 3202 ins; 0 del; 40 mod
  Patch: https://git.openjdk.java.net/jdk/pull/6493.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/6493/head:pull/6493

PR: https://git.openjdk.java.net/jdk/pull/6493

Re: RFR: JDK-8273146: Start of release updates for JDK 19 [v2]

[Joe Darcy]

> The time to get JDK 19 underway draws nigh, please review this usual set of 
> start-of-release updates, including CSRs for the javac and javax.lang.model 
> updates:
> 
> JDK-8277512: Add SourceVersion.RELEASE_19
> https://bugs.openjdk.java.net/browse/JDK-8277512
> 
> JDK-8277514: Add source 19 and target 19 to javac
> https://bugs.openjdk.java.net/browse/JDK-8277514
> 
> Clean local tier 1 test runs for langtools, jdk, and hotspot.

Joe Darcy has updated the pull request incrementally with one additional commit 
since the last revision:

  Respond to review feedback.

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/6493/files
  - new: https://git.openjdk.java.net/jdk/pull/6493/files/5052cd90..4da056ab

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=6493&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=6493&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/6493.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/6493/head:pull/6493

PR: https://git.openjdk.java.net/jdk/pull/6493

Re: RFR: JDK-8273146: Start of release updates for JDK 19 [v2]

[Joe Darcy]

On Mon, 22 Nov 2021 04:17:44 GMT, David Holmes  wrote:

> Hi Joe,
> 
> I looked at all the non-sym file changes. Only one potential issue spotted.
> 
> Thanks, David

*sigh* Yep; cut and paste error -- corrected in next push. Well spotted!

Thanks David

-

PR: https://git.openjdk.java.net/jdk/pull/6493

Re: RFR: 8275063: Implementation of Foreign Function & Memory API (Second incubator) [v26]

[Joe Darcy]

On Mon, 22 Nov 2021 12:09:30 GMT, Maurizio Cimadamore  
wrote:

>> This PR contains the API and implementation changes for JEP-419 [1]. A more 
>> detailed description of such changes, to avoid repetitions during the review 
>> process, is included as a separate comment.
>> 
>> [1] - https://openjdk.java.net/jeps/419
>
> Maurizio Cimadamore has updated the pull request with a new target base due 
> to a merge or a rebase. The pull request now contains 35 commits:
> 
>  - Merge branch 'master' into JEP-419
>  - Fix javadoc issues found in CSR review
>  - Adopt blessed modofier order
>  - Merge branch 'master' into JEP-419
>  - Revert removal of upcall MH customization
>(This change caused spurious VM crashes, so reverting to baseline)
>  - Further tweak upcall safety considerations
>  - Clarify safety considerations for upcalls
>  - Rename MemorySegment::ofAddressNative to MemorySegment::ofAddress
>(which is consistent with other restricted factories in VaList and 
> NativeSymbol)
>  - Streamline javadoc for package-info
>  - * Add two new CLinker static methods to compute upcall/downcall method 
> types
>* Clarify section on CLinker downcall type
>* Add section on CLinker safety guarantees
>  - ... and 25 more: 
> https://git.openjdk.java.net/jdk/compare/d427c79d...29cc6c60

Marked as reviewed by darcy (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/5907

Re: RFR: JDK-8273146: Start of release updates for JDK 19 [v3]

[Joe Darcy]

> The time to get JDK 19 underway draws nigh, please review this usual set of 
> start-of-release updates, including CSRs for the javac and javax.lang.model 
> updates:
> 
> JDK-8277512: Add SourceVersion.RELEASE_19
> https://bugs.openjdk.java.net/browse/JDK-8277512
> 
> JDK-8277514: Add source 19 and target 19 to javac
> https://bugs.openjdk.java.net/browse/JDK-8277514
> 
> Clean local tier 1 test runs for langtools, jdk, and hotspot.

Joe Darcy has updated the pull request with a new target base due to a merge or 
a rebase. The incremental webrev excludes the unrelated changes brought in by 
the merge/rebase. The pull request contains five additional commits since the 
last revision:

 - Remove SharedSpaces options from VMDeprecatedOptions.java.
 - Merge branch 'master' into JDK-8273146
 - Respond to review feedback.
 - Add --release 18 information. Good tier1 test results.
 - JDK-8273146: Start of release updates for JDK 19

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/6493/files
  - new: https://git.openjdk.java.net/jdk/pull/6493/files/4da056ab..5fe55cbf

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=6493&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=6493&range=01-02

  Stats: 1511 lines in 44 files changed: 1091 ins; 303 del; 117 mod
  Patch: https://git.openjdk.java.net/jdk/pull/6493.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/6493/head:pull/6493

PR: https://git.openjdk.java.net/jdk/pull/6493

Re: RFR: JDK-8273146: Start of release updates for JDK 19 [v4]

[Joe Darcy]

> The time to get JDK 19 underway draws nigh, please review this usual set of 
> start-of-release updates, including CSRs for the javac and javax.lang.model 
> updates:
> 
> JDK-8277512: Add SourceVersion.RELEASE_19
> https://bugs.openjdk.java.net/browse/JDK-8277512
> 
> JDK-8277514: Add source 19 and target 19 to javac
> https://bugs.openjdk.java.net/browse/JDK-8277514
> 
> Clean local tier 1 test runs for langtools, jdk, and hotspot.

Joe Darcy has updated the pull request with a new target base due to a merge or 
a rebase. The incremental webrev excludes the unrelated changes brought in by 
the merge/rebase. The pull request contains seven additional commits since the 
last revision:

 - Merge branch 'master' into JDK-8273146
 - Merge branch 'master' into JDK-8273146
 - Remove SharedSpaces options from VMDeprecatedOptions.java.
 - Merge branch 'master' into JDK-8273146
 - Respond to review feedback.
 - Add --release 18 information. Good tier1 test results.
 - JDK-8273146: Start of release updates for JDK 19

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/6493/files
  - new: https://git.openjdk.java.net/jdk/pull/6493/files/5fe55cbf..5c36a2ef

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=6493&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=6493&range=02-03

  Stats: 21630 lines in 395 files changed: 12529 ins; 5912 del; 3189 mod
  Patch: https://git.openjdk.java.net/jdk/pull/6493.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/6493/head:pull/6493

PR: https://git.openjdk.java.net/jdk/pull/6493

Re: RFR: JDK-8273146: Start of release updates for JDK 19 [v5]

[Joe Darcy]

> The time to get JDK 19 underway draws nigh, please review this usual set of 
> start-of-release updates, including CSRs for the javac and javax.lang.model 
> updates:
> 
> JDK-8277512: Add SourceVersion.RELEASE_19
> https://bugs.openjdk.java.net/browse/JDK-8277512
> 
> JDK-8277514: Add source 19 and target 19 to javac
> https://bugs.openjdk.java.net/browse/JDK-8277514
> 
> Clean local tier 1 test runs for langtools, jdk, and hotspot.

Joe Darcy has updated the pull request incrementally with one additional commit 
since the last revision:

  Update symbol information for JDK 18 b25.

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/6493/files
  - new: https://git.openjdk.java.net/jdk/pull/6493/files/5c36a2ef..53e46dec

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=6493&range=04
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=6493&range=03-04

  Stats: 85 lines in 5 files changed: 62 ins; 22 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/6493.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/6493/head:pull/6493

PR: https://git.openjdk.java.net/jdk/pull/6493

Re: RFR: 8275771: JDK source code contains redundant boolean operations in jdk.compiler and langtools

[Joe Darcy]

On Mon, 29 Nov 2021 19:05:59 GMT, Vicente Romero  wrote:

> Hi,
> 
> Please review this PR which is basically rewriting some redundant boolean 
> expressions in the compiler.
> 
> TIA

make/langtools/tools/compileproperties/CompileProperties.java line 187:

> 185: }
> 186: if ( ok && contents != null ) {
> 187: String tokens[] = (new 
> String(contents)).split("\\s+");

So the intended composite predicate here is thought to be
ok == true && contents != null
which is equivalent to
ok && contents != null.
The semantics of the current code are equivalent to just
contents != null
right?

src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Resolve.java line 1316:

> 1314: public void visitReference(JCMemberReference tree) {
> 1315: if (sRet.hasTag(VOID)) {
> 1316: result = true;

Isn't the equivalent statement to
result &= true
just
result
?

-

PR: https://git.openjdk.java.net/jdk/pull/6599

Re: RFR: JDK-8273146: Start of release updates for JDK 19 [v6]

[Joe Darcy]

> The time to get JDK 19 underway draws nigh, please review this usual set of 
> start-of-release updates, including CSRs for the javac and javax.lang.model 
> updates:
> 
> JDK-8277512: Add SourceVersion.RELEASE_19
> https://bugs.openjdk.java.net/browse/JDK-8277512
> 
> JDK-8277514: Add source 19 and target 19 to javac
> https://bugs.openjdk.java.net/browse/JDK-8277514
> 
> Clean local tier 1 test runs for langtools, jdk, and hotspot.

Joe Darcy has updated the pull request with a new target base due to a merge or 
a rebase. The pull request now contains ten commits:

 - Merge branch 'master' into JDK-8273146
 - Update symbol information for JDK 18 b25.
 - Merge branch 'master' into JDK-8273146
 - Merge branch 'master' into JDK-8273146
 - Remove SharedSpaces options from VMDeprecatedOptions.java.
 - Merge branch 'master' into JDK-8273146
 - Respond to review feedback.
 - Add --release 18 information. Good tier1 test results.
 - JDK-8273146: Start of release updates for JDK 19

-

Changes: https://git.openjdk.java.net/jdk/pull/6493/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6493&range=05
  Stats: 3286 lines in 68 files changed: 3242 ins; 4 del; 40 mod
  Patch: https://git.openjdk.java.net/jdk/pull/6493.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/6493/head:pull/6493

PR: https://git.openjdk.java.net/jdk/pull/6493

Re: RFR: JDK-8273146: Start of release updates for JDK 19 [v7]

[Joe Darcy]

> The time to get JDK 19 underway draws nigh, please review this usual set of 
> start-of-release updates, including CSRs for the javac and javax.lang.model 
> updates:
> 
> JDK-8277512: Add SourceVersion.RELEASE_19
> https://bugs.openjdk.java.net/browse/JDK-8277512
> 
> JDK-8277514: Add source 19 and target 19 to javac
> https://bugs.openjdk.java.net/browse/JDK-8277514
> 
> Clean local tier 1 test runs for langtools, jdk, and hotspot.

Joe Darcy has updated the pull request with a new target base due to a merge or 
a rebase. The pull request now contains 12 commits:

 - Merge branch 'master' into JDK-8273146
 - Merge branch 'master' into JDK-8273146
 - Merge branch 'master' into JDK-8273146
 - Merge branch 'master' into JDK-8273146
 - Update symbol information for JDK 18 b25.
 - Merge branch 'master' into JDK-8273146
 - Merge branch 'master' into JDK-8273146
 - Remove SharedSpaces options from VMDeprecatedOptions.java.
 - Merge branch 'master' into JDK-8273146
 - Respond to review feedback.
 - ... and 2 more: https://git.openjdk.java.net/jdk/compare/8b042d14...b1b4ae2b

-

Changes: https://git.openjdk.java.net/jdk/pull/6493/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6493&range=06
  Stats: 3280 lines in 67 files changed: 3237 ins; 4 del; 39 mod
  Patch: https://git.openjdk.java.net/jdk/pull/6493.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/6493/head:pull/6493

PR: https://git.openjdk.java.net/jdk/pull/6493

RFR: JDK-8278175: Enable all doclint warnings for build of java.desktop

[Joe Darcy]

In JDK 18, JDK-8189591 added the ability to suppress doclint warnings. 
Therefore, it is now possible to enable the full doclint checks for the 
java.desktop module if the instances of warnings are suppressed. This patch 
does this; it would be preferable to address the doc warnings directly, but 
that is beyond what I'm attempting to do here.

-

Commit messages:
 - JDK-8278175: Enable all doclint warnings for build of java.desktop

Changes: https://git.openjdk.java.net/jdk/pull/6687/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6687&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8278175
  Stats: 35 lines in 20 files changed: 16 ins; 0 del; 19 mod
  Patch: https://git.openjdk.java.net/jdk/pull/6687.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/6687/head:pull/6687

PR: https://git.openjdk.java.net/jdk/pull/6687

RFR: JDK-8278179: Enable all doclint warnings for build of java.naming

[Joe Darcy]

An exploratory build indicates that it is not necessary to disable the 
accessibility doclint check for the java.naming module.

-

Commit messages:
 - JDK-8278179: Enable all doclint warnings for build of java.naming

Changes: https://git.openjdk.java.net/jdk/pull/6688/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6688&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8278179
  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/6688.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/6688/head:pull/6688

PR: https://git.openjdk.java.net/jdk/pull/6688

Re: RFR: JDK-8273146: Start of release updates for JDK 19 [v8]

[Joe Darcy]

> The time to get JDK 19 underway draws nigh, please review this usual set of 
> start-of-release updates, including CSRs for the javac and javax.lang.model 
> updates:
> 
> JDK-8277512: Add SourceVersion.RELEASE_19
> https://bugs.openjdk.java.net/browse/JDK-8277512
> 
> JDK-8277514: Add source 19 and target 19 to javac
> https://bugs.openjdk.java.net/browse/JDK-8277514
> 
> Clean local tier 1 test runs for langtools, jdk, and hotspot.

Joe Darcy has updated the pull request incrementally with one additional commit 
since the last revision:

  Update symbol files to JDK 18 b26.

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/6493/files
  - new: https://git.openjdk.java.net/jdk/pull/6493/files/b1b4ae2b..88273596

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=6493&range=07
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=6493&range=06-07

  Stats: 610 lines in 3 files changed: 593 ins; 3 del; 14 mod
  Patch: https://git.openjdk.java.net/jdk/pull/6493.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/6493/head:pull/6493

PR: https://git.openjdk.java.net/jdk/pull/6493

Integrated: JDK-8278179: Enable all doclint warnings for build of java.naming

[Joe Darcy]

On Fri, 3 Dec 2021 03:28:46 GMT, Joe Darcy  wrote:

> An exploratory build indicates that it is not necessary to disable the 
> accessibility doclint check for the java.naming module.

This pull request has now been integrated.

Changeset: 780b8b10
Author:    Joe Darcy 
URL:   
https://git.openjdk.java.net/jdk/commit/780b8b1072811208968e4f32f5368eab622fcdcc
Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod

8278179: Enable all doclint warnings for build of java.naming

Reviewed-by: iris, erikj

-

PR: https://git.openjdk.java.net/jdk/pull/6688

Integrated: JDK-8278175: Enable all doclint warnings for build of java.desktop

[Joe Darcy]

On Fri, 3 Dec 2021 01:18:20 GMT, Joe Darcy  wrote:

> In JDK 18, JDK-8189591 added the ability to suppress doclint warnings. 
> Therefore, it is now possible to enable the full doclint checks for the 
> java.desktop module if the instances of warnings are suppressed. This patch 
> does this; it would be preferable to address the doc warnings directly, but 
> that is beyond what I'm attempting to do here.

This pull request has now been integrated.

Changeset: 02ee337a
Author:Joe Darcy 
URL:   
https://git.openjdk.java.net/jdk/commit/02ee337ae0d163ae44b1691eb9de12c5608ba178
Stats: 34 lines in 20 files changed: 16 ins; 0 del; 18 mod

8278175: Enable all doclint warnings for build of java.desktop

Reviewed-by: erikj, prr

-

PR: https://git.openjdk.java.net/jdk/pull/6687

Re: RFR: JDK-8278175: Enable all doclint warnings for build of java.desktop

[Joe Darcy]

On Fri, 3 Dec 2021 01:18:20 GMT, Joe Darcy  wrote:

> In JDK 18, JDK-8189591 added the ability to suppress doclint warnings. 
> Therefore, it is now possible to enable the full doclint checks for the 
> java.desktop module if the instances of warnings are suppressed. This patch 
> does this; it would be preferable to address the doc warnings directly, but 
> that is beyond what I'm attempting to do here.

> 

Sure; filed JDK-8278254 Cleanup doclint warnings in java.desktop module

-

PR: https://git.openjdk.java.net/jdk/pull/6687

RFR: JDK-8278273: Remove unnecessary exclusion of doclint accessibility checks

[Joe Darcy]

Exploratory builds indicate it is not currently necessary to exclude the 
doclint accessibility checks; this patch enables them.

(Enabling the reference checks is left for future work.)

-

Commit messages:
 - JDK-8278273: Remove unnecessary exclusion of doclint accessibility checks

Changes: https://git.openjdk.java.net/jdk/pull/6713/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6713&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8278273
  Stats: 14 lines in 7 files changed: 0 ins; 0 del; 14 mod
  Patch: https://git.openjdk.java.net/jdk/pull/6713.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/6713/head:pull/6713

PR: https://git.openjdk.java.net/jdk/pull/6713

Integrated: JDK-8278273: Remove unnecessary exclusion of doclint accessibility checks

[Joe Darcy]

On Sun, 5 Dec 2021 23:45:32 GMT, Joe Darcy  wrote:

> Exploratory builds indicate it is not currently necessary to exclude the 
> doclint accessibility checks; this patch enables them.
> 
> (Enabling the reference checks is left for future work.)

This pull request has now been integrated.

Changeset: 5045eb53
Author:    Joe Darcy 
URL:   
https://git.openjdk.java.net/jdk/commit/5045eb538b3afc6cf646642f1109473597b3004a
Stats: 14 lines in 7 files changed: 0 ins; 0 del; 14 mod

8278273: Remove unnecessary exclusion of doclint accessibility checks

Reviewed-by: iris, alanb, ihse

-

PR: https://git.openjdk.java.net/jdk/pull/6713

Re: RFR: 8278251: Enable "missing-explicit-ctor" check in the jdk.unsupported.desktop module

[Joe Darcy]

On Fri, 3 Dec 2021 20:55:23 GMT, Sergey Bylokhov  wrote:

> The "missing-explicit-ctor" check was disabled by the 
> [JDK-8071961](https://bugs.openjdk.java.net/browse/JDK-8071961) and later was 
> fixed by the [JDK-8250853](https://bugs.openjdk.java.net/browse/JDK-8250853). 
> So we can re-enable this check again.
> 
> The fix will remove the "Java.gmk" file and as a result the 
> "jdk.unsupported.desktop" folder.
> 
> All "Pre-submit tests" builds are green.

Not a reviewer for this particular change, but I support its goals.

-

PR: https://git.openjdk.java.net/jdk/pull/6708

Re: RFR: JDK-8273146: Start of release updates for JDK 19 [v9]

[Joe Darcy]

> The time to get JDK 19 underway draws nigh, please review this usual set of 
> start-of-release updates, including CSRs for the javac and javax.lang.model 
> updates:
> 
> JDK-8277512: Add SourceVersion.RELEASE_19
> https://bugs.openjdk.java.net/browse/JDK-8277512
> 
> JDK-8277514: Add source 19 and target 19 to javac
> https://bugs.openjdk.java.net/browse/JDK-8277514
> 
> Clean local tier 1 test runs for langtools, jdk, and hotspot.

Joe Darcy has updated the pull request with a new target base due to a merge or 
a rebase. The pull request now contains 17 commits:

 - Merge branch 'master' into JDK-8273146
 - Merge branch 'master' into JDK-8273146
 - Merge branch 'master' into JDK-8273146
 - Merge branch 'master' into JDK-8273146
 - Update symbol files to JDK 18 b26.
 - Merge branch 'master' into JDK-8273146
 - Merge branch 'master' into JDK-8273146
 - Merge branch 'master' into JDK-8273146
 - Merge branch 'master' into JDK-8273146
 - Update symbol information for JDK 18 b25.
 - ... and 7 more: https://git.openjdk.java.net/jdk/compare/ea8d3c92...9f68398a

-

Changes: https://git.openjdk.java.net/jdk/pull/6493/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6493&range=08
  Stats: 3870 lines in 67 files changed: 3827 ins; 4 del; 39 mod
  Patch: https://git.openjdk.java.net/jdk/pull/6493.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/6493/head:pull/6493

PR: https://git.openjdk.java.net/jdk/pull/6493

Integrated: JDK-8273146: Start of release updates for JDK 19

[Joe Darcy]

On Mon, 22 Nov 2021 03:15:51 GMT, Joe Darcy  wrote:

> The time to get JDK 19 underway draws nigh, please review this usual set of 
> start-of-release updates, including CSRs for the javac and javax.lang.model 
> updates:
> 
> JDK-8277512: Add SourceVersion.RELEASE_19
> https://bugs.openjdk.java.net/browse/JDK-8277512
> 
> JDK-8277514: Add source 19 and target 19 to javac
> https://bugs.openjdk.java.net/browse/JDK-8277514
> 
> Clean local tier 1 test runs for langtools, jdk, and hotspot.

This pull request has now been integrated.

Changeset: 09831e7a
Author:Joe Darcy 
Committer: Jesper Wilhelmsson 
URL:   
https://git.openjdk.java.net/jdk/commit/09831e7aa47ebe41eab2f3014ebbacf338097ef6
Stats: 4252 lines in 67 files changed: 4206 ins; 7 del; 39 mod

8273146: Start of release updates for JDK 19
8277511: Add SourceVersion.RELEASE_19
8277513: Add source 19 and target 19 to javac

Reviewed-by: dholmes, alanb, erikj, iris, mikael, ihse

-

PR: https://git.openjdk.java.net/jdk/pull/6493

RFR: JDK-8277515: Update --release 18 symbol information for JDK 18 build 29

[Joe Darcy]

Usual update to the JDK 19 symbol files for changes in JDK 18; this time 
JDK-8276660 in JDK 18 build 28.

-

Commit messages:
 - JDK-8277515: Update --release 18 symbol information for JDK 18 build 29

Changes: https://git.openjdk.java.net/jdk/pull/6948/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6948&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8277515
  Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/6948.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/6948/head:pull/6948

PR: https://git.openjdk.java.net/jdk/pull/6948

Integrated: JDK-8277515: Update --release 18 symbol information for JDK 18 build 29

[Joe Darcy]

On Mon, 3 Jan 2022 18:26:24 GMT, Joe Darcy  wrote:

> Usual update to the JDK 19 symbol files for changes in JDK 18; this time 
> JDK-8276660 in JDK 18 build 28.

This pull request has now been integrated.

Changeset: 9a0e8900
Author:    Joe Darcy 
URL:   
https://git.openjdk.java.net/jdk/commit/9a0e890056fb8ae4e28e656118e73fae33ba5e2a
Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod

8277515: Update --release 18 symbol information for JDK 18 build 29

Reviewed-by: iris

-

PR: https://git.openjdk.java.net/jdk/pull/6948

RFR: JDK-8279397: Update --release 18 symbol information for JDK 18 build 32

[Joe Darcy]

Update of JDK 18 symbol information for build 32.

@lahodaj , can you take a look at the diff? Given the code changes for 
JDK-8270416: "Enhance construction of Identity maps" 
(https://github.com/openjdk/jdk/commit/5832a3440489d0967dc3b0542c1ace51eed292d6),
 I didn't see why the symbol update was triggered.

-

Commit messages:
 - JDK-8279397: Update --release 18 symbol information for JDK 18 build 32

Changes: https://git.openjdk.java.net/jdk/pull/7165/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7165&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8279397
  Stats: 10 lines in 1 file changed: 10 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/7165.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/7165/head:pull/7165

PR: https://git.openjdk.java.net/jdk/pull/7165

Integrated: JDK-8279397: Update --release 18 symbol information for JDK 18 build 32

[Joe Darcy]

On Thu, 20 Jan 2022 19:03:36 GMT, Joe Darcy  wrote:

> Update of JDK 18 symbol information for build 32.
> 
> @lahodaj , can you take a look at the diff? Given the code changes for 
> JDK-8270416: "Enhance construction of Identity maps" 
> (https://github.com/openjdk/jdk/commit/5832a3440489d0967dc3b0542c1ace51eed292d6),
>  I didn't see why the symbol update was triggered.

This pull request has now been integrated.

Changeset: c1e4f3dd
Author:Joe Darcy 
URL:   
https://git.openjdk.java.net/jdk/commit/c1e4f3dd1b42474c9abc22c7b981a98f9c36e0d5
Stats: 10 lines in 1 file changed: 10 ins; 0 del; 0 mod

8279397: Update --release 18 symbol information for JDK 18 build 32

Reviewed-by: iris, jlahoda

-

PR: https://git.openjdk.java.net/jdk/pull/7165

Re: RFR: JDK-8279397: Update --release 18 symbol information for JDK 18 build 32

[Joe Darcy]

On Fri, 21 Jan 2022 18:39:02 GMT, Jan Lahoda  wrote:

> I believe this is an artifact of limited optimization of the InnerClasses 
> attribute: if the InnerClasses attribute refers to a class that is not part 
> of `ct.sym`, then it is stripped, but if the class is part of ct.sym, the 
> code does not check if it is used from the headers. So some InnerClass 
> entries may sadly be produced for classes that were only used inside method 
> bodies. Possibly an improvement for the future to do more aggressive 
> cleaning. (In general, recording more/unnecessary classes in the InnerClasses 
> shouldn't be harmful besides wasting space, I believe.)

Good to know; thanks Jan.

-

PR: https://git.openjdk.java.net/jdk/pull/7165

Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines

[Joe Darcy]

On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan  wrote:

> Hi
> 
> I have reviewed the code for removing double semicolons at the end of lines
> 
> all the best
> matteo

Marked as reviewed by darcy (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/7268