Integrated: 8325800: Drop unused cups declaration from Oracle build configuration
On Tue, 13 Feb 2024 20:47:01 GMT, Mikael Vidstedt wrote: > The cups dependency was used for Solaris builds, and has been unused since > [JDK-8244224](https://bugs.openjdk.org/browse/JDK-8244224). > > Testing: tier1 This pull request has now been integrated. Changeset: 8765b176 Author:Mikael Vidstedt URL: https://git.openjdk.org/jdk/commit/8765b176f97dbf334836f0aa6acd921d114304a9 Stats: 7 lines in 1 file changed: 0 ins; 6 del; 1 mod 8325800: Drop unused cups declaration from Oracle build configuration Reviewed-by: erikj - PR: https://git.openjdk.org/jdk/pull/17837
Re: RFR: 8325800: Drop unused cups declaration from Oracle build configuration
On Tue, 13 Feb 2024 20:47:01 GMT, Mikael Vidstedt wrote: > The cups dependency was used for Solaris builds, and has been unused since > [JDK-8244224](https://bugs.openjdk.org/browse/JDK-8244224). > > Testing: tier1 Thank you for the review! - PR Comment: https://git.openjdk.org/jdk/pull/17837#issuecomment-1942580652
Re: RFR: 8325800: Drop unused cups declaration from Oracle build configuration
On Tue, 13 Feb 2024 20:47:01 GMT, Mikael Vidstedt wrote: > The cups dependency was used for Solaris builds, and has been unused since > [JDK-8244224](https://bugs.openjdk.org/browse/JDK-8244224). > > Testing: tier1 Marked as reviewed by erikj (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/17837#pullrequestreview-1878936683
RFR: 8325800: Drop unused cups declaration from Oracle build configuration
The cups dependency was used for Solaris builds, and has been unused since [JDK-8244224](https://bugs.openjdk.org/browse/JDK-8244224). Testing: tier1 - Commit messages: - 8325800: Drop unused cups declaration from Oracle build configuration Changes: https://git.openjdk.org/jdk/pull/17837/files Webrev: https://webrevs.openjdk.org/?repo=jdk=17837=00 Issue: https://bugs.openjdk.org/browse/JDK-8325800 Stats: 7 lines in 1 file changed: 0 ins; 6 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/17837.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/17837/head:pull/17837 PR: https://git.openjdk.org/jdk/pull/17837
Re: RFR: JDK-8298405: Support Markdown in Documentation Comments [v31]
On Mon, 12 Feb 2024 23:52:35 GMT, Jonathan Gibbons wrote:
>> Please review a patch to add support for Markdown syntax in documentation
>> comments, as described in the associated JEP.
>>
>> Notable features:
>>
>> * support for `///` documentation comments in `JavaTokenizer`
>> * new module `jdk.internal.md` -- a private copy of the `commonmark-java`
>> library
>> * updates to `DocCommentParser` to treat `///` comments as Markdown
>> * updates to the standard doclet to render Markdown comments in HTML
>
> Jonathan Gibbons has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 40 commits:
>
> - Merge remote-tracking branch 'upstream/master' into
> 8298405.doclet-markdown-v3
> - improve support for DocCommentParser.LineKind
> - Merge remote-tracking branch 'upstream/master' into
> 8298405.doclet-markdown-v3 # Please enter a commit message to explain why
> this merge is necessary, # especially if it merges an updated upstream into a
> topic branch. # # Lines starting with '#' will be ignored, and an empty
> message aborts # the
>commit.
> - update copyright year on test
> - refactor recent new test case in TestMarkdown.java
> - address review feedback
> - address review feedback
> - added test case in TestMarkdown.java for handling of `@deprecated` tag
> - amend comment in test
> - improve comments on negative test case
> - ... and 30 more: https://git.openjdk.org/jdk/compare/2ed889b7...1c64a6e0
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java
line 563:
> 561:
> 562: /**
> 563: * {@returns the plain-text content of a named HTML element in a
> list of content}
Suggestion:
* {@return the plain-text content of a named HTML element in a list of
content}
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/Checker.java line
1021:
> 1019: .findFirst();
> 1020: if (first.isEmpty() || first.get() != tree) {
> 1021: dct.getFirstSentence().forEach(t ->
> System.err.println(t.getKind() + ": >>|" + t + "|<<"));
Is it leftover debug output?
src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/Start.java line 571:
> 569: // of a doclet to be specified instead of the name of the
> 570: // doclet class and optional doclet path.
> 571: // See https://bugs.openjdk.org/browse/JDK-8263219
It's hard to understand this:
> to permit an instance of an appropriately configured instance of a doclet
Also: how is that piece of code used? When I commented it out, no
test/langtools:langtools_javadoc tests failed.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/16388#discussion_r1487629102
PR Review Comment: https://git.openjdk.org/jdk/pull/16388#discussion_r1487659843
PR Review Comment: https://git.openjdk.org/jdk/pull/16388#discussion_r1487642764
Integrated: 8325731: Installation instructions for Debian/Ubuntu don't mention autoconf
On Tue, 13 Feb 2024 11:35:32 GMT, Johannes Bechberger wrote: > So I added autoconf besides build-essential. With both packages, `bash > configure` is runnable. This pull request has now been integrated. Changeset: c3c1cdd1 Author:Johannes Bechberger URL: https://git.openjdk.org/jdk/commit/c3c1cdd1b017654469f214c62457cde248474f2f Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod 8325731: Installation instructions for Debian/Ubuntu don't mention autoconf Reviewed-by: ihse - PR: https://git.openjdk.org/jdk/pull/17826
Re: RFR: 8325731: Installation instructions for Debian/Ubuntu don't mention autoconf
On Tue, 13 Feb 2024 11:35:32 GMT, Johannes Bechberger wrote: > So I added autoconf besides build-essential. With both packages, `bash > configure` is runnable. Thanks for fixing! - Marked as reviewed by ihse (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/17826#pullrequestreview-1877809447
RFR: 8325731: Installation instructions for Debian/Ubuntu don't mention autoconf
So I added autoconf besides build-essential. With both packages, `bash configure` is runnable. - Commit messages: - 8325731: Installation instructions for Debian/Ubuntu don't mention autoconf Changes: https://git.openjdk.org/jdk/pull/17826/files Webrev: https://webrevs.openjdk.org/?repo=jdk=17826=00 Issue: https://bugs.openjdk.org/browse/JDK-8325731 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/17826.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/17826/head:pull/17826 PR: https://git.openjdk.org/jdk/pull/17826
Integrated: 8325558: Add jcheck whitespace checking for properties files
On Fri, 9 Feb 2024 13:35:55 GMT, Magnus Ihse Bursie wrote: > This is an attempt to finally implement the idea brought forward in > JDK-8295729: Properties files is essentially source code. It should have the > same whitespace checks as all other source code, so we don't get spurious > trailing whitespace changes or leading tabs instead of spaces. > > With Skara jcheck, it is possible to increase the coverage of the whitespace > checks. > > However, this turned out to be problematic, since trailing whitespace is > significant in properties files. That issue has mostly been sorted out in a > series of PRs, and this patch will finish the job with the few remaining > files, and actually enable the check in jcheck. This pull request has now been integrated. Changeset: c266800a Author:Magnus Ihse Bursie URL: https://git.openjdk.org/jdk/commit/c266800a3a7dd44416b0b4df3bdd78410241d74b Stats: 761 lines in 95 files changed: 0 ins; 5 del; 756 mod 8325558: Add jcheck whitespace checking for properties files Reviewed-by: naoto, dfuchs, joehw - PR: https://git.openjdk.org/jdk/pull/17789
Integrated: 8325626: Allow selection of non-matching configurations using CONF=!string
On Mon, 12 Feb 2024 11:44:46 GMT, Magnus Ihse Bursie wrote: > A common scenario is for a developer to have two configurations, a product > and a debug version, e.g. `linux-x64`and `linux-x64-debug`. To select the > latter using `CONF` is just a matter of using `CONF=debug`, but to select the > former, the complete name needs to be supplied: `CONF=linux-x64`. > > Instead, this patch introduces the use of `!` as a negation character, so > `CONF=!debug` would select all configurations that do not match `debug`. > > I also took the time to clarify and correct the documentation on how to use > `CONF`. This pull request has now been integrated. Changeset: ec20b0aa Author:Magnus Ihse Bursie URL: https://git.openjdk.org/jdk/commit/ec20b0aa2ed711daeea5d0a09102093b3a2a49ec Stats: 51 lines in 4 files changed: 30 ins; 1 del; 20 mod 8325626: Allow selection of non-matching configurations using CONF=!string Reviewed-by: erikj, jwaters - PR: https://git.openjdk.org/jdk/pull/17804
