Re: RFR: 8333743: Change .jcheck/conf branches property to match valid branches
On Thu, 6 Jun 2024 18:24:50 GMT, Kevin Rushforth wrote: > Clean backport of `.jcheck/conf` change to jdk23. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19584#pullrequestreview-2102953724
Re: RFR: 8333743: Change .jcheck/conf branches property to match valid branches
On Thu, 6 Jun 2024 17:10:16 GMT, Kevin Rushforth wrote: > Update the `branches` property in `.jcheck/conf` to allow branches, now that > we are using them for JDK stabilization. This will allow integrators to use > Skara to create new stabilization branches (we had to do it manually this > time). Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19582#pullrequestreview-2102629350
Re: RFR: 8330182: Start of release updates for JDK 24 [v12]
On Wed, 5 Jun 2024 15:35:18 GMT, Joe Darcy wrote: >> Get JDK 24 underway. > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains 23 commits: > > - Update copyright. > - Updated problem list after bug fix. > - Merge branch 'master' into JDK-8330188 > - Merge branch 'master' into JDK-8330188 > - Temporarily problem list java.lang.instrument tests until jar generation > is fixed. > - Merge branch 'master' into JDK-8330188 > - Update symbol files for JDK 23 build 25. > - Correct release year. > - Merge branch 'master' into JDK-8330188 > - Add symbol files current with JDK 23 build 24. > - ... and 13 more: https://git.openjdk.org/jdk/compare/4369856c...f4a5026b Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/18787#pullrequestreview-2099585754
Re: RFR: 8330182: Start of release updates for JDK 24 [v10]
On Thu, 30 May 2024 17:11:31 GMT, Joe Darcy wrote: >> Get JDK 24 underway. > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains 18 commits: > > - Merge branch 'master' into JDK-8330188 > - Update symbol files for JDK 23 build 25. > - Correct release year. > - Merge branch 'master' into JDK-8330188 > - Add symbol files current with JDK 23 build 24. > - Merge branch 'master' into JDK-8330188 > - Merge branch 'master' into JDK-8330188 > - Fix-up test. > - Merge branch 'master' into JDK-8330188 > - Adjust test for deprecated options. > - ... and 8 more: https://git.openjdk.org/jdk/compare/32636dcc...39a028c3 Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/18787#pullrequestreview-2089018766
Re: RFR: 8332849: Update doc/testing.{md,html} (spelling and stale information) [v2]
On Fri, 24 May 2024 21:05:27 GMT, Mikael Vidstedt wrote: >> Update the testing doc to remove some stale information (AOT_MODULES, >> removed in [JDK-8264805](https://bugs.openjdk.org/browse/JDK-8264805)) and >> fix some spelling issues. >> >> Testing: tier1 > > Mikael Vidstedt has updated the pull request incrementally with one > additional commit since the last revision: > > Revert change to deliberately misspelled variables Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19375#pullrequestreview-2079262776
Re: RFR: 8332849: Update doc/testing.{md,html} (spelling and stale information)
On Thu, 23 May 2024 23:22:51 GMT, Mikael Vidstedt wrote: > Update the testing doc to remove some stale information (AOT_MODULES, removed > in [JDK-8264805](https://bugs.openjdk.org/browse/JDK-8264805)) and fix some > spelling issues. > > Testing: tier1 Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19375#pullrequestreview-2075624618
Re: RFR: 8330182: Start of release updates for JDK 24 [v5]
On Mon, 20 May 2024 22:42:20 GMT, Joe Darcy wrote: >> Get JDK 24 underway. > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains 11 commits: > > - Fix-up test. > - Merge branch 'master' into JDK-8330188 > - Adjust test for deprecated options. > - Merge branch 'master' into JDK-8330188 > - Update deprecated options test. > - Merge branch 'master' into JDK-8330188 > - Merge branch 'master' into JDK-8330188 > - Merge branch 'master' into JDK-8330188 > - Correct release date as observed in review feedback. > - Improve javadoc of class file update. > - ... and 1 more: https://git.openjdk.org/jdk/compare/d6b7f9b1...128f53a3 Still looks good. - Marked as reviewed by iris (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/18787#pullrequestreview-2067401131
Re: RFR: 8332085: Remove 10 year old transition check in GenerateCurrencyData tool
On Fri, 10 May 2024 21:30:21 GMT, Naoto Sato wrote: > The build tool that generates the currency data had a check that throws an > exception (causes a build failure) if the transition date is more than 10 > years away (past/future). This caused a build failure in 8u-RI repository. > Since the risk of build failure seems to exceed the potential benefit (make > the data clean), removing the check is appropriate. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19183#pullrequestreview-2051087379
Re: RFR: 8330182: Start of release updates for JDK 24 [v3]
On Mon, 29 Apr 2024 22:50:26 GMT, Joe Darcy wrote: >> Get JDK 24 underway. > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains seven additional commits since > the last revision: > > - Update deprecated options test. > - Merge branch 'master' into JDK-8330188 > - Merge branch 'master' into JDK-8330188 > - Merge branch 'master' into JDK-8330188 > - Correct release date as observed in review feedback. > - Improve javadoc of class file update. > - JDK-8330182: Start of release updates for JDK 24 >JDK-8330183: Add SourceVersion.RELEASE_24 >JDK-8330184: Add source 24 and target 24 to javac Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/18787#pullrequestreview-2030298396
Re: RFR: 8330182: Start of release updates for JDK 24 [v2]
On Wed, 17 Apr 2024 05:43:12 GMT, Joe Darcy wrote: >> Get JDK 24 underway. > > Joe Darcy has updated the pull request incrementally with two additional > commits since the last revision: > > - Correct release date as observed in review feedback. > - Improve javadoc of class file update. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/18787#pullrequestreview-2006604933
Re: RFR: 8330182: Start of release updates for JDK 24
On Mon, 15 Apr 2024 19:01:08 GMT, Joe Darcy wrote: > Get JDK 24 underway. The copyright year was not updated in all files *14.java. I assume that's intentional. I've also Reviewed the associated CSRs. make/conf/version-numbers.conf line 36: > 34: DEFAULT_VERSION_EXTRA2=0 > 35: DEFAULT_VERSION_EXTRA3=0 > 36: DEFAULT_VERSION_DATE=2024-03-17 "2024-03-17"? I thought that the expected date was "2025-03-18"? - Marked as reviewed by iris (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/18787#pullrequestreview-2002002355 PR Review Comment: https://git.openjdk.org/jdk/pull/18787#discussion_r1566336599
Re: RFR: 8320799: Bump minimum boot jdk to JDK 22
On Mon, 1 Apr 2024 16:16:50 GMT, Mikael Vidstedt wrote: > With the JDK 22 GA out it's time to bump the minimum boot JDK version for > mainline/JDK 23. > > Testing: tier1-5, GHA Thanks! - Marked as reviewed by iris (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/18563#pullrequestreview-1972143983
Re: RFR: 8325570: Update to Graphviz 9.0.0
On Fri, 9 Feb 2024 19:02:13 GMT, Mikael Vidstedt wrote:
> Graphviz (aka. dotty/dot) is used when building "full" docs, and in
> particular for creating various module graph images (.svg). This change
> upgrades the Graphviz version used to 9.0.0 (latest).
>
> In particular, the change:
>
> * Updates the createGraphvizBundle.sh script (currently broken) to build
> graphviz from source
> * Updates doc/building.{md,html} to reflect the role of Graphviz and Pandoc
> in the build
> * The version of of the graphviz dependency used when building at Oracle (in
> jib-profiles.js)
>
> Since, in addition to the changes in this PR itself, the exact version of
> Graphviz has an effect on the generated images, I have uploaded the docs
> generated by graphviz 9.0.0 here:
> https://cr.openjdk.org/~mikael/graphviz-9.0.0/cmp-v1/docs/api/. For baseline
> the latest jdk23 docs, which uses graphviz 2.38.0, should do the trick:
> https://download.java.net/java/early_access/jdk23/docs/api/.
>
> For example, picking a random .svg file:
>
> baseline (graphviz 2.38.0):
> https://download.java.net/java/early_access/jdk23/docs/api/java.base/java/lang/classfile/Signature/RefTypeSig-sealed-graph.svg
> new (graphviz 9.0.0):
> https://cr.openjdk.org/~mikael/graphviz-9.0.0/cmp-v1/docs/api/java.base/java/lang/classfile/Signature/RefTypeSig-sealed-graph.svg
>
>
> Testing: tier1, manual inspection of a few of the generated .svg files
>
> As far as I can tell there are only very minor differences between the old
> (2.38.0) and new (9.0.0) .svg files. In particular, it seems like the new
> graphs are ever so slightly (5-10% or so) larger, but otherwise appear to be
> identical.
This is the java.se module graph generated by the previous version of Graphviz
[https://cr.openjdk.org/~iris/se/22/latestSpec/images/java.se-graph.svg](https://cr.openjdk.org/~iris/se/22/latestSpec/images/java.se-graph.svg)
and the new version:
[https://cr.openjdk.org/~mikael/graphviz-9.0.0/cmp-v1/docs/api/java.se/module-graph.svg](https://cr.openjdk.org/~mikael/graphviz-9.0.0/cmp-v1/docs/api/java.se/module-graph.svg).
They appear to be topologically identical. The only differences I see is a
slight increase in size, as noted by @vidmik in his original PR comment and a
few crossed edges on the lower right side (e.g. java.net.http -> java.base,
java.prefs -> java.base).
I think it's a minor price to pay for moving to the more recent version.
Thanks for moving to the newer version!
-
Marked as reviewed by iris (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/17794#pullrequestreview-1875970167
Re: [jdk22] RFR: 8321480: ISO 4217 Amendment 176 Update
On Tue, 9 Jan 2024 19:27:12 GMT, Justin Lu wrote: > Please review this PR which is the backport of the ISO 4217 Amendment 176 > Update. Commit > [8b24851b](https://github.com/openjdk/jdk/commit/8b24851b9d3619c41c7a6cdb9193ed26a9b732dc) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. Confirmed changes identical to those in main-line. - Marked as reviewed by iris (Reviewer). PR Review: https://git.openjdk.org/jdk22/pull/45#pullrequestreview-1811892304
Re: RFR: JDK-8319413: Start of release updates for JDK 23 [v5]
On Tue, 5 Dec 2023 01:48:14 GMT, Joe Darcy wrote: >> Time to start making preparations for JDK 23. > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains 15 commits: > > - Merge branch 'master' into JDK-8319413 > - Add symbol files. > - Merge branch 'master' into JDK-8319413 > - Merge branch 'master' into JDK-8319413 > - Merge branch 'master' into JDK-8319413 > - Merge branch 'master' into JDK-8319413 > - Update symbol files to JDK 22 b26. > - Merge branch 'master' into JDK-8319413 > - Merge branch 'master' into JDK-8319413 > - Add symbol files for JDK 22 build 25. > - ... and 5 more: https://git.openjdk.org/jdk/compare/30b5d427...2ee6cb96 Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/16505#pullrequestreview-1764000855
Re: RFR: JDK-8319413: Start of release updates for JDK 23 [v4]
On Sat, 2 Dec 2023 20:40:57 GMT, Andrey Turbanov wrote: >> Joe Darcy has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update symbol files to JDK 22 b26. > > test/langtools/tools/javac/versions/Versions.java line 97: > >> 95: TWENTY_ONE(false,"65.0", "21"), >> 96: TWENTY_TWO(false,"66.0", "22"), >> 97: TWENTY_THREE(false,"67.0", "23"), > > As alignment is broken anyway, let's add space > Suggestion: > > TWENTY_THREE(false, "67.0", "23"), If you're going to add the space, I'd consider establishing new alignment at TWENTY to accommodate the eventual space needed for "THREE", "SEVEN", and "EIGHT". You wouldn't need to reset alignment for quite some time after that. - PR Review Comment: https://git.openjdk.org/jdk/pull/16505#discussion_r1414904341
Re: RFR: JDK-8319413: Start of release updates for JDK 23 [v3]
On Thu, 30 Nov 2023 20:48:21 GMT, Joe Darcy wrote: >> Time to start making preparations for JDK 23. > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains eight commits: > > - Merge branch 'master' into JDK-8319413 > - Merge branch 'master' into JDK-8319413 > - Add symbol files for JDK 22 build 25. > - Merge branch 'master' into JDK-8319413 > - Merge branch 'master' into JDK-8319413 > - Adjust expected release date. > - Fix omission in Classfile.java > - JDK-8319413: Start of release updates for JDK 23 Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/16505#pullrequestreview-1758548243
Re: RFR: 8320915: Update copyright year in build files
On Tue, 28 Nov 2023 17:00:57 GMT, Magnus Ihse Bursie wrote: > Over the year, even though we have tried to be diligent, there have been > commits that modify files without updating the copyright year. Here is a mass > update of the copyright years in the build system (`make/**`, `.github/**`). > > Feel free to verify that these files have indeed been modified in 2023 :-), > or trust my tools + manual verification. Also, as far as I (and my tools) can > tell, this is the only files modified in 2023 that have not had their header > updated. I randomly spot checked about a dozen of these files to confirm that they were changed this year. Everything looks good. Thanks for making this change! - Marked as reviewed by iris (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/16858#pullrequestreview-1753598130
Re: RFR: JDK-8319413: Start of release updates for JDK 23
On Fri, 3 Nov 2023 23:42:03 GMT, Joe Darcy wrote: > Time to start making preparations for JDK 23. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/16505#pullrequestreview-1751551968
Re: RFR: 8320763: Fix spacing arround assignment in spec.gmk.in [v2]
On Mon, 27 Nov 2023 15:05:20 GMT, Magnus Ihse Bursie wrote: >> For some reason, we have not been consistent with using spaces around the >> assignment operators (`:=` and `=`) in spec.gmk.in. This has annoyed me for >> a long time. >> >> When making this change, I noticed that there are a lot of late evaluation >> assignments (= instead of :=) that should not be there. To not confuse the >> code review, I will fix these separately. Thus this change will only change >> whitespace. > > Magnus Ihse Bursie has updated the pull request incrementally with one > additional commit since the last revision: > > Fix ?= Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/16825#pullrequestreview-1750990335
Re: RFR: 8320526: Use title case in building.md
On Tue, 21 Nov 2023 15:58:06 GMT, Magnus Ihse Bursie wrote: > We should use title case consistently in building.md. > > I thought I was done with fixing up the build README, but then I noticed this > and I couldn't unsee it... Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/16765#pullrequestreview-1742444708
Re: RFR: 8320334: Reflow markdown in testing.md
On Fri, 17 Nov 2023 16:39:54 GMT, Magnus Ihse Bursie wrote: > In preparation for textual updates, the markdown in testing.md is reflowed so > line lengths of 80 is respected, wherever possible. > > Note that is is correct that the testing.html file is unchanged (and indeed > a sign that only markdown line breaks have been modified). Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/16712#pullrequestreview-1737616656
Re: RFR: 8317357: Update links in building.md to use https rather than http
On Thu, 16 Nov 2023 17:09:25 GMT, Magnus Ihse Bursie wrote: > From the bug report: Building.md file contains a number of HTTP links that > would need to be converted to HTTPS in order for clicking on the links on the > OpenJDK web site at https://openjdk.org/groups/build/doc/building.html to > work. > > It is also best practice nowadays to always prefer https in links; most http > requests are upgraded to https anyway. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/16695#pullrequestreview-1735123412
Re: RFR: 8317979: Use TZ database style abbreviations in the CLDR locale provider [v3]
On Tue, 17 Oct 2023 16:52:12 GMT, Naoto Sato wrote: >> CLDR provides very few short names for time zones, such as PST/PDT. This >> will typically end up substituting names from the COMPAT provider. Once the >> COMPAT is removed, they will be displayed in the GMT format, i.e., >> GMT+XX:YY. Although some of the short names in the COMPAT provider are >> somewhat questionable (less common ones are simply made up from the long >> names by taking the initials), it would not be desirable for them to fall >> back to the GMT format. >> To mitigate the situation, CLDR can use the abbreviated names from the TZ >> database, which contains legacy (major) short names as FORMAT. The CLDR >> provider can use them instead of the GMT offset style. This enhancement is a >> precursor to the future removal of the COMPAT provider. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Delay populating GMT format at runtime. Reflecting review comments. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/16206#pullrequestreview-1683283733
Re: RFR: 8306630: Bump minimum boot jdk to JDK 21
On Tue, 26 Sep 2023 21:22:07 GMT, Mikael Vidstedt wrote: > With the JDK 21 GA out it's time to bump the minimum boot JDK version for > mainline/JDK 22. > > Testing: tier1-5, GHA (in progress) Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/15934#pullrequestreview-1645323993
Re: RFR: 8267174: Many test files have the wrong Copyright header
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote: > There are a number of files in the `test` directory that have an incorrect > copyright header, which includes the "classpath" exception text. This patch > removes that text from all test files that I could find it in. I did this > using a combination of `sed` and `grep`. Reviewing this patch is probably > easier using the raw patch file or a suitable webrev format. > > It's my assumption that these headers were introduced by mistake as it's > quite easy to copy the wrong template when creating new files. Thanks for fixing! - Marked as reviewed by iris (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/15573#pullrequestreview-1613704179
Re: RFR: 8314483: Optionally override copyright header in generated source [v2]
On Thu, 24 Aug 2023 17:36:46 GMT, Erik Joelsson wrote: >> In the JDK build we have various build tools that generate source code from >> data files. For most of these tools, the source files are based on template >> files, which already have copyright headers, but for some, the complete >> source file is generated by the tool, which is providing the copyright >> header programatically. For the latter, we would like to implement an >> override mechanism in each tool so that we can change the copyright header >> from a custom makefile. > > Erik Joelsson has updated the pull request incrementally with one additional > commit since the last revision: > > Suggestion from dholmes Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/15346#pullrequestreview-1594143141
Re: RFR: 8314762: Make {@Incubating} conventional
On Tue, 22 Aug 2023 12:19:42 GMT, Pavel Rappo wrote: > Please review this trivial PR. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/15387#pullrequestreview-1593932872
Re: RFR: 8314495: Update to use jtreg 7.3.1
On Thu, 17 Aug 2023 07:24:14 GMT, Christian Stein wrote: > Please review the change to update to using jtreg 7.3,1. > > The primary change is to the `jib-profiles.js` file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the `requiredVersion` has been updated in the various `TEST.ROOT` > files. > > This change set also un-problem-lists tests from > https://github.com/openjdk/jdk/commit/360f65d7b15b327e2f160c42f318945cc6548bda > > This change set also fixes: > - https://bugs.openjdk.org/browse/JDK-8313902 > - https://bugs.openjdk.org/browse/JDK-8313903 > > Testing: tier1-tier5 OK Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/15323#pullrequestreview-1585041001
Re: RFR: 8313167: Update to use jtreg 7.3
On Wed, 26 Jul 2023 09:06:19 GMT, Christian Stein wrote: > Please review the change to update to using jtreg 7.3. > > The primary change is to the `jib-profiles.js` file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the `requiredVersion` has been updated in the various `TEST.ROOT` > files. > > Testing: tier1-tier3 (tier4 and tier5 pending...) Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/15037#pullrequestreview-1565701286
Re: RFR: JDK-8306584: Start of release updates for JDK 22 [v6]
On Thu, 8 Jun 2023 00:37:07 GMT, Joe Darcy wrote: >> Time to get JDK 22 underway... > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains 39 commits: > > - Merge branch 'master' into JDK-8306584 > - Merge branch 'master' into JDK-8306584 > - Update wording to be consistent with JDK-8295071. > - Merge branch 'master' into JDK-8306584 > - Update wording of new constant to be consistent with JDK-8309554. > - Merge branch 'master' into JDK-8306584 > - Merge branch 'master' into JDK-8306584 > - Merge branch 'master' into JDK-8306584 > - Merge branch 'master' into JDK-8306584 > - Merge branch 'master' into JDK-8306584 > - ... and 29 more: https://git.openjdk.org/jdk/compare/4ffc8cc2...a03bcd40 Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/13567#pullrequestreview-1470093232
Re: RFR: JDK-8306584: Start of release updates for JDK 22 [v2]
On Tue, 30 May 2023 18:35:44 GMT, Joe Darcy wrote: >> Time to get JDK 22 underway... > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains 23 commits: > > - Merge branch 'master' into JDK-8306584 > - Merge branch 'master' into JDK-8306584 > - Sync in symbol changes for JDK 21 build 24. > - Merge branch 'master' into JDK-8306584 > - Merge branch 'master' into JDK-8306584 > - Merge branch 'master' into JDK-8306584 > - Minor test fixes. > - Merge branch 'master' into JDK-8306584 > - Update symbol files to JDK 21 b23. > - Merge branch 'JDK-8306584' of https://github.com/jddarcy/jdk into > JDK-8306584 > - ... and 13 more: https://git.openjdk.org/jdk/compare/1b8e6bf3...c7682791 Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/13567#pullrequestreview-1451837705
Re: RFR: JDK-8306584: Start of release updates for JDK 22
On Thu, 20 Apr 2023 20:28:18 GMT, Joe Darcy wrote: > Time to get JDK 22 underway... Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/13567#pullrequestreview-1440582657
Re: RFR: 8308072: [BACKOUT] update for deprecated sprintf for src/utils
On Mon, 15 May 2023 05:13:00 GMT, Tobias Hartmann wrote: > Clean backout of https://github.com/openjdk/jdk/pull/13915 / > [JDK-8307855](https://bugs.openjdk.org/browse/JDK-8307855) because > @kimbarrett noticed some issues after integration. Also the change is > non-trivial and therefore missing a second review. > > Thanks, > Tobias Verified this PR is a backout of the earlier change. - Marked as reviewed by iris (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/13975#pullrequestreview-1425795219
Re: RFR: 8296153: Bump minimum boot jdk to JDK 20
On Thu, 20 Apr 2023 19:15:00 GMT, Mikael Vidstedt wrote: > With the JDK 20 GA out it's time to bump the minimum boot JDK version for > mainline/JDK 21. > > Testing: tier1-5, GHA (the Windows build successfully downloads the JDK but > then fails for unrelated reasons, and one seemingly unrelated Vector API test > failure in tier 3) Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/13565#pullrequestreview-1396343205
Re: RFR: 8304896: Update to use jtreg 7.2
On Mon, 17 Apr 2023 14:56:16 GMT, Christian Stein wrote: > Please review the change to update to using jtreg 7.2. > > The primary change is to the `jib-profiles.js` file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the requiredVersion has been updated in the various `TEST.ROOT` > files. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/13496#pullrequestreview-1388989497
Re: RFR: JDK-8303798: REDO - Remove fdlibm C sources
On Sat, 1 Apr 2023 18:08:44 GMT, Joe Darcy wrote: > This PR is a redo of JDK-8302801: Remove fdlibm C sources. The problem with > JDK-8302801 was that it neglected (mea culpa) to include a Java > implementation of IEEEremainder before the FDLIBM C implementation was > deleted. Such an implementation has been successfully provided under > JDK-8304028: Port fdlibm IEEEremainder to Java. After JDK-8304028, there are > no native methods left in StrictMath. > > This PR is the same as JDK-8302801 other than StrictMath.c already being > removed under JDK-8304028. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/13279#pullrequestreview-1368368000
Re: RFR: 8303039: Utilize `coverageLevels.txt` [v2]
On Thu, 2 Mar 2023 01:03:20 GMT, Naoto Sato wrote: >> This is a pre-requisite for supporting CLDR v43, where they combine `seeds` >> locales with `common` locales >> (https://cldr.unicode.org/index/downloads/cldr-43#h.7s25aqdv767e). In order >> to have the same coverage level of locales, CLDRConverter tool needs to comb >> through the locale files based on the `coverageLevels.txt` file, (and the >> ones we already included as of v42). Confirmed the same set of locales is >> generated before and after this modification. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Explicitly filter coverage levels Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.org/jdk/pull/12812
Re: RFR: 8303020: Remove carriage return in pandoc version string
On Tue, 21 Feb 2023 17:59:07 GMT, Mikael Vidstedt wrote:
> On windows/cygwin, the PANDOC_VERSION variable includes the carriage return
> ('\r') which makes the version check fail:
>
> checking for pandoc version... 2.19.2
> , not the recommended version 2.19.2n 2.19.2
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/12696
Re: [jdk20] RFR: 8301886: Remove EA from JDK 20 version string starting with Initial RC promotion B35 on February 09, 2023
On Fri, 10 Feb 2023 18:12:19 GMT, Jesper Wilhelmsson wrote: > EA removed Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.org/jdk20/pull/123
Re: RFR: JDK-8296149: Start of release updates for JDK 21 [v4]
On Tue, 6 Dec 2022 17:05:16 GMT, Joe Darcy wrote: >> Usual start-of-release updates. Symbol updates in initial version reflect >> JDK 20 build 21. > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains 19 commits: > > - Merge branch 'master' into JDK-8296149 > - Merge branch 'master' into JDK-8296149 > - Merge branch 'master' into JDK-8296149 > - Merge branch 'master' into JDK-8296149 > - Merge branch 'master' into JDK-8296149 > - Update symbol information for JDK 20 build 26. > - Merge branch 'master' into JDK-8296149 > - Merge branch 'master' into JDK-8296149 > - Fix failed HotSpot regression tests. > - Merge branch 'master' into JDK-8296149 > - ... and 9 more: https://git.openjdk.org/jdk/compare/0d2a9ee5...e252e83a Still looks good. - PR: https://git.openjdk.org/jdk/pull/10924
Re: RFR: JDK-8296149: Start of release updates for JDK 21 [v2]
On Thu, 1 Dec 2022 18:53:38 GMT, Joe Darcy wrote: >> Usual start-of-release updates. Symbol updates in initial version reflect >> JDK 20 build 21. > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains 14 additional commits since > the last revision: > > - Update symbol information for JDK 20 build 26. > - Merge branch 'master' into JDK-8296149 > - Merge branch 'master' into JDK-8296149 > - Fix failed HotSpot regression tests. > - Merge branch 'master' into JDK-8296149 > - Update symbol information to JDK 20 build 24. > - Merge branch 'master' into JDK-8296149 > - Merge branch 'master' into JDK-8296149 > - Update symbols for JDK 20 b23. > - Merge branch 'master' into JDK-8296149 > - ... and 4 more: https://git.openjdk.org/jdk/compare/03d7ad1d...89731cb2 Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.org/jdk/pull/10924
Re: RFR: JDK-8296149: Start of release updates for JDK 21
On Tue, 1 Nov 2022 05:49:25 GMT, Joe Darcy wrote: > Usual start-of-release updates. Symbol updates in initial version reflect JDK > 20 build 21. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.org/jdk/pull/10924
Re: RFR: 8296479: Remove stray comment about POST_STRIP_CMD
On Mon, 7 Nov 2022 14:56:09 GMT, Magnus Ihse Bursie wrote: > The variable POST_STRIP_CMD has been removed, but not all comments about it Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.org/jdk/pull/11021
Re: RFR: JDK-8296137: diags-examples.xml is broken
On Fri, 4 Nov 2022 21:50:10 GMT, Jonathan Gibbons wrote: > Please review some minor updates to the `diags/examples` mechanism, repairing > some bitrot after one of the not-so-recent repo reorgs. > > For bonus, I've added a target for the German version of the output. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.org/jdk/pull/10998
Re: RFR: JDK-8295914: Add a header to generated HTML files in specs
On Thu, 27 Oct 2022 20:50:04 GMT, Jonathan Gibbons wrote: > Please review some updates to the parts of the build system related to > building the documentation. Your changes look good! Can't wait to see this in a promotion. - Marked as reviewed by iris (Reviewer). PR: https://git.openjdk.org/jdk/pull/10891
Re: RFR: 8284840: Update CLDR to Version 42.0
On Fri, 21 Oct 2022 16:55:28 GMT, Naoto Sato wrote:
> This is to update the CLDR data from version 41 to version 42. The vast
> majority of the changes are basically replacing the CLDR data, along with
> tools/testcase alignments to those upstream changes:
>
> https://unicode-org.atlassian.net/browse/CLDR-14032 (" at " is no longer used
> for standard date/time format)
> https://unicode-org.atlassian.net/browse/CLDR-14831 (NBSP prefixed to `a`,
> instead of a normal space )
> https://unicode-org.atlassian.net/browse/CLDR-11510 (Fix first day of week
> info for China (CN))
> https://unicode-org.atlassian.net/browse/CLDR-15966 (Japanese: Support
> numbers up to δΊ¬)
>
> Here is the link to CLDR v42's release notes:
> https://cldr.unicode.org/index/downloads/cldr-42
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/10820
Re: RFR: 8295163: Remove old hsdis Makefile
On Tue, 11 Oct 2022 16:00:38 GMT, Magnus Ihse Bursie wrote: > For some reason the old Makefile for hsdis was not removed when the build was > moved into the normal build system in > [JDK-8188073](https://bugs.openjdk.org/browse/JDK-8188073). This should be > fixed. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.org/jdk/pull/10660
Re: RFR: 8294456: Fix misleading-indentation warnings in JDK
On Thu, 29 Sep 2022 13:11:03 GMT, Raffaello Giulietti wrote: > This fixes misleading indentations, which allows enabling the (currently > disabled) `misleading-indentation` warning flag on two `.gmk` files. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.org/jdk/pull/10487
Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org [v4]
On Fri, 30 Sep 2022 01:11:45 GMT, Joe Darcy wrote: >> With the domain change from openjdk.java.net to openjdk.org, references to >> URLs in the sources should be updated. >> >> Updates were made using a shell script. I"ll run a copyright updater before >> any push. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > http -> https Marked as reviewed by iris (Reviewer). src/jdk.accessibility/windows/native/include/bridge/AccessBridgeCalls.h line 34: > 32: * the following link: > 33: * > 34: * > http://hg.openjdk.org/jdk9/jdk9/jdk/raw-file/tip/src/jdk.accessibility/windows/native/bridge/AccessBridgeCalls.c The domain for hg wasn't changed to openjdk.org. The original URL is correct. - PR: https://git.openjdk.org/jdk/pull/10501
Re: RFR: 8293224 Add link to openjdk.org/jtreg/ from doc/testing
On Thu, 1 Sep 2022 16:16:59 GMT, Ludvig Janiuk wrote: > doc/testing is a starting point for people interested in testing the JDK, but > it doesn't explain jtreg and its nuances and pitfalls very well. > https://openjdk.org/jtreg/, and expecially > https://openjdk.org/jtreg/faq.html, contain better material. Let's at least > add a pointer that will bring people there. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.org/jdk/pull/10122
Re: RFR: 8290488: IBM864 character encoding implementation bug
On Wed, 27 Jul 2022 17:47:36 GMT, Naoto Sato wrote: > Adding an extra c2b mapping for the `%` in `IBM864` charset. The discrepancy > came from the mapping difference between MS and IBM. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.org/jdk/pull/9661
