Re: RFR: 8298405: Implement JEP 467: Markdown Documentation Comments [v56]
On Wed, 1 May 2024 20:40:00 GMT, Jonathan Gibbons wrote: > > There should be some quick testing of the new default method on Elements > > using the VacuousElements implementation; see > > `test/langtools/tools/javac/processing/model/util/elements` for some > > examples. > > @jddarcy I've reorganized the tests in this area a bit, and moved the testing > for `DocCommentKind` to a new test, which includes testing the default > method, using `VacuousElements` (nice trick, that, by the way.). Although now > renamed, the older `TestGetDocComments` is now closer to the original form, > with the testing for `getDocCommentKind` being moved to a new test class. Creating one VacuousElements was preferable to creating one each time a new default method was added :-) - PR Comment: https://git.openjdk.org/jdk/pull/16388#issuecomment-2099322156
Re: RFR: 8298405: Implement JEP 467: Markdown Documentation Comments [v56]
On Fri, 12 Apr 2024 17:39:11 GMT, Joe Darcy wrote: > There should be some quick testing of the new default method on Elements > using the VacuousElements implementation; see > `test/langtools/tools/javac/processing/model/util/elements` for some examples. @jddarcy I've reorganized the tests in this area a bit, and moved the testing for `DocCommentKind` to a new test, which includes testing the default method, using `VacuousElements` (nice trick, that, by the way.). Although now renamed, the older `TestGetDocComments` is now closer to the original form, with the testing for `getDocCommentKind` being moved to a new test class. - PR Comment: https://git.openjdk.org/jdk/pull/16388#issuecomment-2089096959
Re: RFR: 8298405: Implement JEP 467: Markdown Documentation Comments [v56]
On Thu, 11 Apr 2024 17:52:14 GMT, Jonathan Gibbons wrote: >> Please review a patch to add support for Markdown syntax in documentation >> comments, as described in the associated JEP. >> >> Notable features: >> >> * support for `///` documentation comments in `JavaTokenizer` >> * new module `jdk.internal.md` -- a private copy of the `commonmark-java` >> library >> * updates to `DocCommentParser` to treat `///` comments as Markdown >> * updates to the standard doclet to render Markdown comments in HTML > > Jonathan Gibbons has updated the pull request incrementally with one > additional commit since the last revision: > > address review feedback for updates to Elements and friends There should be some quick testing of the new default method on Elements using the VacuousElements implementation; see `test/langtools/tools/javac/processing/model/util/elements` for some examples. - PR Comment: https://git.openjdk.org/jdk/pull/16388#issuecomment-2052196439
Re: RFR: 8298405: Implement JEP 467: Markdown Documentation Comments [v56]
> Please review a patch to add support for Markdown syntax in documentation > comments, as described in the associated JEP. > > Notable features: > > * support for `///` documentation comments in `JavaTokenizer` > * new module `jdk.internal.md` -- a private copy of the `commonmark-java` > library > * updates to `DocCommentParser` to treat `///` comments as Markdown > * updates to the standard doclet to render Markdown comments in HTML Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision: address review feedback for updates to Elements and friends - Changes: - all: https://git.openjdk.org/jdk/pull/16388/files - new: https://git.openjdk.org/jdk/pull/16388/files/21f5b004..d4c2c73b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=16388=55 - incr: https://webrevs.openjdk.org/?repo=jdk=16388=54-55 Stats: 9 lines in 2 files changed: 0 ins; 0 del; 9 mod Patch: https://git.openjdk.org/jdk/pull/16388.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/16388/head:pull/16388 PR: https://git.openjdk.org/jdk/pull/16388
