Re: RFR: 8328705: GHA: Cross-compilation jobs do not require build JDK [v2]
On Fri, 22 Mar 2024 14:18:39 GMT, Aleksey Shipilev wrote: >> Noticed this while fixing other GHA issues. >> >> We pass build JDK to cross-compilation jobs, which makes them dependent on >> Linux-x64 builds. But we only build hotspot in all those jobs, so AFAICS >> there is no need for build JDK, and therefore no need for the dependency. >> Untying cross-compilation jobs from Linux-x64 builds make GHA more parallel. >> >> Additional testing: >> - [x] GHA > > Aleksey Shipilev has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains two additional > commits since the last revision: > > - Merge branch 'master' into JDK-8328705-gha-cross-noneed-build > - Fix Thanks! - PR Comment: https://git.openjdk.org/jdk/pull/18437#issuecomment-2017819785
Re: RFR: 8328705: GHA: Cross-compilation jobs do not require build JDK [v2]
On Fri, 22 Mar 2024 14:18:39 GMT, Aleksey Shipilev wrote: >> Noticed this while fixing other GHA issues. >> >> We pass build JDK to cross-compilation jobs, which makes them dependent on >> Linux-x64 builds. But we only build hotspot in all those jobs, so AFAICS >> there is no need for build JDK, and therefore no need for the dependency. >> Untying cross-compilation jobs from Linux-x64 builds make GHA more parallel. >> >> Additional testing: >> - [x] GHA > > Aleksey Shipilev has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains two additional > commits since the last revision: > > - Merge branch 'master' into JDK-8328705-gha-cross-noneed-build > - Fix Nice catch and cleanup! Thanks! - Marked as reviewed by ihse (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/18437#pullrequestreview-1957509883
Re: RFR: 8328705: GHA: Cross-compilation jobs do not require build JDK [v2]
On Fri, 22 Mar 2024 14:18:39 GMT, Aleksey Shipilev wrote: >> Noticed this while fixing other GHA issues. >> >> We pass build JDK to cross-compilation jobs, which makes them dependent on >> Linux-x64 builds. But we only build hotspot in all those jobs, so AFAICS >> there is no need for build JDK, and therefore no need for the dependency. >> Untying cross-compilation jobs from Linux-x64 builds make GHA more parallel. >> >> Additional testing: >> - [x] GHA > > Aleksey Shipilev has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains two additional > commits since the last revision: > > - Merge branch 'master' into JDK-8328705-gha-cross-noneed-build > - Fix Thanks! I would like another sanity check, maybe @magicus can take a look? - PR Comment: https://git.openjdk.org/jdk/pull/18437#issuecomment-2017682557
Re: RFR: 8328705: GHA: Cross-compilation jobs do not require build JDK [v2]
> Noticed this while fixing other GHA issues. > > We pass build JDK to cross-compilation jobs, which makes them dependent on > Linux-x64 builds. But we only build hotspot in all those jobs, so AFAICS > there is no need for build JDK, and therefore no need for the dependency. > Untying cross-compilation jobs from Linux-x64 builds make GHA more parallel. > > Additional testing: > - [ ] GHA Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into JDK-8328705-gha-cross-noneed-build - Fix - Changes: - all: https://git.openjdk.org/jdk/pull/18437/files - new: https://git.openjdk.org/jdk/pull/18437/files/91073362..ab09c4ba Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=18437&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18437&range=00-01 Stats: 52703 lines in 2267 files changed: 7683 ins; 3769 del; 41251 mod Patch: https://git.openjdk.org/jdk/pull/18437.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18437/head:pull/18437 PR: https://git.openjdk.org/jdk/pull/18437
