Re: RFR: 8329816: Add SLEEF version 3.6.1 [v3]
On Thu, 27 Jun 2024 22:03:37 GMT, Mikael Vidstedt wrote: >> [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) is looking to >> optimize vector math operations by leveraging the SLEEF library. For legal >> reasons the actual contribution of the SLEEF files needs to be handled >> separately. This enhancement adds the relevant files, enabling the rest of >> [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) to move forward. > > Mikael Vidstedt has updated the pull request incrementally with one > additional commit since the last revision: > > Update README to include RISC-V An quick update, I just verified via QEMU that sleefinline_rvvm1.h works well too. - PR Comment: https://git.openjdk.org/jdk/pull/19185#issuecomment-2214322358
Re: RFR: 8329816: Add SLEEF version 3.6.1 [v3]
On Thu, 27 Jun 2024 22:03:37 GMT, Mikael Vidstedt wrote: >> [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) is looking to >> optimize vector math operations by leveraging the SLEEF library. For legal >> reasons the actual contribution of the SLEEF files needs to be handled >> separately. This enhancement adds the relevant files, enabling the rest of >> [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) to move forward. > > Mikael Vidstedt has updated the pull request incrementally with one > additional commit since the last revision: > > Update README to include RISC-V Just some minor comments in README, otherwise looks good. src/jdk.incubator.vector/linux/native/libvectormath/README line 18: > 16: NOTE: The following cmake options are necessary when building SLEEF: > 17: * -DSLEEF_BUILD_INLINE_HEADERS=ON > 18: * -DSLEEF_ENFORCE_SVE=ON `-DSLEEF_ENFORCE_SVE=ON` can be removed. src/jdk.incubator.vector/linux/native/libvectormath/README line 41: > 39: > 40: Currently, the only necessary change is: > 41: * make `Sleef_rempitabdp` and `Sleef_rempitabsp` in sleefinline_advsimd.h > and sleefinline_sve.h `static` to avoid multiple definitions. These lines can be removed now. - Marked as reviewed by mli (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/19185#pullrequestreview-2158620004 PR Review Comment: https://git.openjdk.org/jdk/pull/19185#discussion_r1665522936 PR Review Comment: https://git.openjdk.org/jdk/pull/19185#discussion_r1665523304
Re: RFR: 8329816: Add SLEEF version 3.6.1 [v3]
> [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) is looking to > optimize vector math operations by leveraging the SLEEF library. For legal > reasons the actual contribution of the SLEEF files needs to be handled > separately. This enhancement adds the relevant files, enabling the rest of > [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) to move forward. Mikael Vidstedt has updated the pull request incrementally with one additional commit since the last revision: Update README to include RISC-V - Changes: - all: https://git.openjdk.org/jdk/pull/19185/files - new: https://git.openjdk.org/jdk/pull/19185/files/b29de559..8a08ffa1 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=19185=02 - incr: https://webrevs.openjdk.org/?repo=jdk=19185=01-02 Stats: 10 lines in 1 file changed: 9 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/19185.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19185/head:pull/19185 PR: https://git.openjdk.org/jdk/pull/19185
