Re: RFR: 8332849: Update doc/testing.{md,html} (spelling and stale information) [v2]
On Fri, 24 May 2024 21:05:27 GMT, Mikael Vidstedt wrote: >> Update the testing doc to remove some stale information (AOT_MODULES, >> removed in [JDK-8264805](https://bugs.openjdk.org/browse/JDK-8264805)) and >> fix some spelling issues. >> >> Testing: tier1 > > Mikael Vidstedt has updated the pull request incrementally with one > additional commit since the last revision: > > Revert change to deliberately misspelled variables Thank you for all the reviews! - PR Comment: https://git.openjdk.org/jdk/pull/19375#issuecomment-2135734935
Re: RFR: 8332849: Update doc/testing.{md,html} (spelling and stale information) [v2]
On Fri, 24 May 2024 21:05:27 GMT, Mikael Vidstedt wrote: >> Update the testing doc to remove some stale information (AOT_MODULES, >> removed in [JDK-8264805](https://bugs.openjdk.org/browse/JDK-8264805)) and >> fix some spelling issues. >> >> Testing: tier1 > > Mikael Vidstedt has updated the pull request incrementally with one > additional commit since the last revision: > > Revert change to deliberately misspelled variables Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19375#pullrequestreview-2079262776
Re: RFR: 8332849: Update doc/testing.{md,html} (spelling and stale information) [v2]
On Fri, 24 May 2024 21:05:27 GMT, Mikael Vidstedt wrote: >> Update the testing doc to remove some stale information (AOT_MODULES, >> removed in [JDK-8264805](https://bugs.openjdk.org/browse/JDK-8264805)) and >> fix some spelling issues. >> >> Testing: tier1 > > Mikael Vidstedt has updated the pull request incrementally with one > additional commit since the last revision: > > Revert change to deliberately misspelled variables LGTM - Marked as reviewed by djelinski (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/19375#pullrequestreview-2078586910
Re: RFR: 8332849: Update doc/testing.{md,html} (spelling and stale information) [v2]
On Fri, 24 May 2024 21:05:27 GMT, Mikael Vidstedt wrote: >> Update the testing doc to remove some stale information (AOT_MODULES, >> removed in [JDK-8264805](https://bugs.openjdk.org/browse/JDK-8264805)) and >> fix some spelling issues. >> >> Testing: tier1 > > Mikael Vidstedt has updated the pull request incrementally with one > additional commit since the last revision: > > Revert change to deliberately misspelled variables Marked as reviewed by erikj (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19375#pullrequestreview-2078118971
Re: RFR: 8332849: Update doc/testing.{md,html} (spelling and stale information) [v2]
On Fri, 24 May 2024 12:50:59 GMT, Erik Joelsson wrote: >> doc/testing.html line 366: >> >>> 364: to setting JTREG_JOBS=1 JTREG_TIMEOUT_FACTOR=8, but using >>> 365: the keyword format means that the JTREG variable is parsed >>> 366: and verified for correctness, so JTREG="TIMEOUT_FACTOR=8" >> >> this was a deliberate typo > > Indeed, these two were intentional to demonstrate the error handling of the > JTREG make variable. Well that's embarrassing.. Thank you for the catch! Fixed (reverted). - PR Review Comment: https://git.openjdk.org/jdk/pull/19375#discussion_r1614063368
Re: RFR: 8332849: Update doc/testing.{md,html} (spelling and stale information) [v2]
> Update the testing doc to remove some stale information (AOT_MODULES, removed > in [JDK-8264805](https://bugs.openjdk.org/browse/JDK-8264805)) and fix some > spelling issues. > > Testing: tier1 Mikael Vidstedt has updated the pull request incrementally with one additional commit since the last revision: Revert change to deliberately misspelled variables - Changes: - all: https://git.openjdk.org/jdk/pull/19375/files - new: https://git.openjdk.org/jdk/pull/19375/files/859e52d1..88e930e1 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=19375=01 - incr: https://webrevs.openjdk.org/?repo=jdk=19375=00-01 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/19375.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19375/head:pull/19375 PR: https://git.openjdk.org/jdk/pull/19375
Re: RFR: 8332849: Update doc/testing.{md,html} (spelling and stale information)
On Thu, 23 May 2024 23:22:51 GMT, Mikael Vidstedt wrote: > Update the testing doc to remove some stale information (AOT_MODULES, removed > in [JDK-8264805](https://bugs.openjdk.org/browse/JDK-8264805)) and fix some > spelling issues. > > Testing: tier1 Changes requested by erikj (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19375#pullrequestreview-2076839326
Re: RFR: 8332849: Update doc/testing.{md,html} (spelling and stale information)
On Fri, 24 May 2024 09:15:51 GMT, Daniel Jeliński wrote: >> Update the testing doc to remove some stale information (AOT_MODULES, >> removed in [JDK-8264805](https://bugs.openjdk.org/browse/JDK-8264805)) and >> fix some spelling issues. >> >> Testing: tier1 > > doc/testing.html line 366: > >> 364: to setting JTREG_JOBS=1 JTREG_TIMEOUT_FACTOR=8, but using >> 365: the keyword format means that the JTREG variable is parsed >> 366: and verified for correctness, so JTREG="TIMEOUT_FACTOR=8" > > this was a deliberate typo Indeed, these two were intentional to demonstrate the error handling of the JTREG make variable. - PR Review Comment: https://git.openjdk.org/jdk/pull/19375#discussion_r1613429776
Re: RFR: 8332849: Update doc/testing.{md,html} (spelling and stale information)
On Thu, 23 May 2024 23:22:51 GMT, Mikael Vidstedt wrote: > Update the testing doc to remove some stale information (AOT_MODULES, removed > in [JDK-8264805](https://bugs.openjdk.org/browse/JDK-8264805)) and fix some > spelling issues. > > Testing: tier1 doc/testing.html line 366: > 364: to setting JTREG_JOBS=1 JTREG_TIMEOUT_FACTOR=8, but using > 365: the keyword format means that the JTREG variable is parsed > 366: and verified for correctness, so JTREG="TIMEOUT_FACTOR=8" this was a deliberate typo - PR Review Comment: https://git.openjdk.org/jdk/pull/19375#discussion_r1613155418
Re: RFR: 8332849: Update doc/testing.{md,html} (spelling and stale information)
On Thu, 23 May 2024 23:22:51 GMT, Mikael Vidstedt wrote: > Update the testing doc to remove some stale information (AOT_MODULES, removed > in [JDK-8264805](https://bugs.openjdk.org/browse/JDK-8264805)) and fix some > spelling issues. > > Testing: tier1 Thanks! ❤️ - Marked as reviewed by ihse (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/19375#pullrequestreview-2076318537
Re: RFR: 8332849: Update doc/testing.{md,html} (spelling and stale information)
On Thu, 23 May 2024 23:22:51 GMT, Mikael Vidstedt wrote: > Update the testing doc to remove some stale information (AOT_MODULES, removed > in [JDK-8264805](https://bugs.openjdk.org/browse/JDK-8264805)) and fix some > spelling issues. > > Testing: tier1 Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19375#pullrequestreview-2075624618
RFR: 8332849: Update doc/testing.{md,html} (spelling and stale information)
Update the testing doc to remove some stale information (AOT_MODULES, removed
in [JDK-8264805](https://bugs.openjdk.org/browse/JDK-8264805)) and fix some
spelling issues.
Testing: tier1
-
Commit messages:
- 8332849: Update doc/testing.{md,html} (spelling and stale information)
Changes: https://git.openjdk.org/jdk/pull/19375/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=19375=00
Issue: https://bugs.openjdk.org/browse/JDK-8332849
Stats: 46 lines in 2 files changed: 0 ins; 28 del; 18 mod
Patch: https://git.openjdk.org/jdk/pull/19375.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/19375/head:pull/19375
PR: https://git.openjdk.org/jdk/pull/19375
