Re: RFR: 8332885: Clarify failure_handler self-tests [v2]
> Adding commetns to clarify that the failure_handler selftests are intended to > be run manually. Ideally this would include a more thorough description of > the exepcted outputs, but this is what I have time to add right now. Ludvig Janiuk has updated the pull request incrementally with three additional commits since the last revision: - styling - typo - reflow - Changes: - all: https://git.openjdk.org/jdk/pull/19393/files - new: https://git.openjdk.org/jdk/pull/19393/files/26a7be5c..a9d2cab2 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=19393=01 - incr: https://webrevs.openjdk.org/?repo=jdk=19393=00-01 Stats: 7 lines in 1 file changed: 1 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk/pull/19393.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19393/head:pull/19393 PR: https://git.openjdk.org/jdk/pull/19393
Re: RFR: 8332885: Clarify failure_handler self-tests
On Fri, 24 May 2024 19:26:29 GMT, Erik Joelsson wrote: >> Adding commetns to clarify that the failure_handler selftests are intended >> to be run manually. Ideally this would include a more thorough description >> of the exepcted outputs, but this is what I have time to add right now. > > test/failure_handler/README line 115: > >> 113: generated artifacts and cannot be run as part of a CI. They are tests >> which timeout, crash, >> 114: fail in various ways and you can check the failure_handler output >> yourself. They might also >> 115: leave processes running on your machine so be extra careful about >> cleaning up. > > These lines are longer than the text blocks in the rest of this file. Could > you adjust formatting to match? Sure, thanks for noticing. - PR Review Comment: https://git.openjdk.org/jdk/pull/19393#discussion_r1615787886
Re: RFR: 8332885: Clarify failure_handler self-tests
On Fri, 24 May 2024 12:16:25 GMT, Ludvig Janiuk wrote: > Adding commetns to clarify that the failure_handler selftests are intended to > be run manually. Ideally this would include a more thorough description of > the exepcted outputs, but this is what I have time to add right now. test/failure_handler/README line 115: > 113: generated artifacts and cannot be run as part of a CI. They are tests > which timeout, crash, > 114: fail in various ways and you can check the failure_handler output > yourself. They might also > 115: leave processes running on your machine so be extra careful about > cleaning up. These lines are longer than the text blocks in the rest of this file. Could you adjust formatting to match? - PR Review Comment: https://git.openjdk.org/jdk/pull/19393#discussion_r1613935457
Re: RFR: 8332885: Clarify failure_handler self-tests
On Fri, 24 May 2024 12:16:25 GMT, Ludvig Janiuk wrote: > Adding commetns to clarify that the failure_handler selftests are intended to > be run manually. Ideally this would include a more thorough description of > the exepcted outputs, but this is what I have time to add right now. Marked as reviewed by lmesnik (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19393#pullrequestreview-2077481241
RFR: 8332885: Clarify failure_handler self-tests
Adding commetns to clarify that the failure_handler selftests are intended to be run manually. Ideally this would include a more thorough description of the exepcted outputs, but this is what I have time to add right now. - Commit messages: - 8332885 Clarify failure_handler self-tests Changes: https://git.openjdk.org/jdk/pull/19393/files Webrev: https://webrevs.openjdk.org/?repo=jdk=19393=00 Issue: https://bugs.openjdk.org/browse/JDK-8332885 Stats: 15 lines in 2 files changed: 15 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/19393.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19393/head:pull/19393 PR: https://git.openjdk.org/jdk/pull/19393
