Re: RFR: 8325878: Require minimum Clang version 13
On Thu, 15 Feb 2024 05:19:45 GMT, Kim Barrett wrote: > Please review this change that updates the minimum supported version of Clang > to be used for building OpenJDK from 3.5 to 13. > > This permits enabling C++17 (JDK-8314488), though Clang 5 might suffice for > that. A minimum of Clang 13 also obtains a critical bug fix for the > [[noreturn]] > attribute (see JDK-8303805). > > Testing: mach5 tier1, which includes building with a recent version of > Xcode/clang. Update to minimum XLC has been integrated, so going ahead with this. - PR Comment: https://git.openjdk.org/jdk/pull/17862#issuecomment-1981706282
Re: RFR: 8325878: Require minimum Clang version 13 [v2]
> Please review this change that updates the minimum supported version of Clang > to be used for building OpenJDK from 3.5 to 13. > > This permits enabling C++17 (JDK-8314488), though Clang 5 might suffice for > that. A minimum of Clang 13 also obtains a critical bug fix for the > [[noreturn]] > attribute (see JDK-8303805). > > Testing: mach5 tier1, which includes building with a recent version of > Xcode/clang. Kim Barrett has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: - Merge branch 'master' into update-clang - Merge branch 'master' into update-clang - Merge branch 'master' into update-clang - update minimum clang version - Changes: https://git.openjdk.org/jdk/pull/17862/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17862&range=01 Stats: 3 lines in 3 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/17862.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/17862/head:pull/17862 PR: https://git.openjdk.org/jdk/pull/17862
Re: RFR: 8325878: Require minimum Clang version 13
On Tue, 5 Mar 2024 08:24:20 GMT, Kim Barrett wrote: > I don't want to integrate this until the minimum aix-ppc toolchain has been > updated @kimbarrett Is anyone working on that problem? - PR Comment: https://git.openjdk.org/jdk/pull/17862#issuecomment-1981399543
Re: RFR: 8325878: Require minimum Clang version 13
On Tue, 5 Mar 2024 07:20:33 GMT, Kim Barrett wrote: > Thanks for reviews/responses. I'll go ahead with integration. We won't be > reliant on the new version immediately, so we can still reconsider if it > causes someone problems and they bring it up soon-ish. Well, no I'm not. I don't want to integrate this until the minimum aix-ppc toolchain has been updated. I don't know that there would be a problem, but I don't know there wouldn't be either. - PR Comment: https://git.openjdk.org/jdk/pull/17862#issuecomment-1978199756
Re: RFR: 8325878: Require minimum Clang version 13
On Thu, 15 Feb 2024 05:19:45 GMT, Kim Barrett wrote: > Please review this change that updates the minimum supported version of Clang > to be used for building OpenJDK from 3.5 to 13. > > This permits enabling C++17 (JDK-8314488), though Clang 5 might suffice for > that. A minimum of Clang 13 also obtains a critical bug fix for the > [[noreturn]] > attribute (see JDK-8303805). > > Testing: mach5 tier1, which includes building with a recent version of > Xcode/clang. Thanks for reviews/responses. I'll go ahead with integration. We won't be reliant on the new version immediately, so we can still reconsider if it causes someone problems and they bring it up soon-ish. - PR Comment: https://git.openjdk.org/jdk/pull/17862#issuecomment-1978107784
Re: RFR: 8325878: Require minimum Clang version 13
On Thu, 15 Feb 2024 05:19:45 GMT, Kim Barrett wrote: > Please review this change that updates the minimum supported version of Clang > to be used for building OpenJDK from 3.5 to 13. > > This permits enabling C++17 (JDK-8314488), though Clang 5 might suffice for > that. A minimum of Clang 13 also obtains a critical bug fix for the > [[noreturn]] > attribute (see JDK-8303805). > > Testing: mach5 tier1, which includes building with a recent version of > Xcode/clang. There was some discussion of clang versions over in the PR proposing to enable C++17 (https://github.com/openjdk/jdk/pull/14988). The minimum version proposed here (13) seemed acceptable from that discussion. Good to go here? - PR Comment: https://git.openjdk.org/jdk/pull/17862#issuecomment-1968065624
Re: RFR: 8325878: Require minimum Clang version 13
On Fri, 16 Feb 2024 04:46:24 GMT, Kim Barrett wrote: > > Unfortunately this will break my workflow on Linux - I use clang to build > > on Ubuntu 20.04, which is not that old, but it ships with clang 12. This is > > not a deal breaker, just annoying. > > That's unfortunate, but I think the [[noreturn]] issue is very important. > Until we have that fix, we can't rely on that attribute to silence certain > warnings. This requires us to continue to insert dead returns or apply other > workarounds. And forgetting to do so (because someone makes a change that > works fine with later versions or on other platforms) will lead to > build-breakage JBS issues/PRs just to continue to support older versions of > clang. We've already had several of those. Thank you for explaining the motivation. @forax also mentioned that our workaround produces false warnings in IDEs (just checked in CDT). I'm fine with it - I will find another solution for my Linux box. - PR Comment: https://git.openjdk.org/jdk/pull/17862#issuecomment-1947776707
Re: RFR: 8325878: Require minimum Clang version 13
On Thu, 15 Feb 2024 12:45:45 GMT, Thomas Stuefe wrote: > Unfortunately this will break my workflow on Linux - I use clang to build on > Ubuntu 20.04, which is not that old, but it ships with clang 12. This is not > a deal breaker, just annoying. That's unfortunate, but I think the [[noreturn]] issue is very important. Until we have that fix, we can't rely on that attribute to silence certain warnings. This requires us to continue to insert dead returns or apply other workarounds. And forgetting to do so (because someone makes a change that works fine with later versions or on other platforms) will lead to build-breakage JBS issues/PRs just to continue to support older versions of clang. We've already had several of those. - PR Comment: https://git.openjdk.org/jdk/pull/17862#issuecomment-1947750667
Re: RFR: 8325878: Require minimum Clang version 13
On Thu, 15 Feb 2024 05:19:45 GMT, Kim Barrett wrote: > Please review this change that updates the minimum supported version of Clang > to be used for building OpenJDK from 3.5 to 13. > > This permits enabling C++17 (JDK-8314488), though Clang 5 might suffice for > that. A minimum of Clang 13 also obtains a critical bug fix for the > [[noreturn]] > attribute (see JDK-8303805). > > Testing: mach5 tier1, which includes building with a recent version of > Xcode/clang. Unfortunately this will break my workflow on Linux - I use clang to build on Ubuntu 20.04, which is not that old, but it ships with clang 12. This is not a deal breaker, just annoying. - PR Comment: https://git.openjdk.org/jdk/pull/17862#issuecomment-1946030283
Re: RFR: 8325878: Require minimum Clang version 13
On Thu, 15 Feb 2024 05:19:45 GMT, Kim Barrett wrote: > Please review this change that updates the minimum supported version of Clang > to be used for building OpenJDK from 3.5 to 13. > > This permits enabling C++17 (JDK-8314488), though Clang 5 might suffice for > that. A minimum of Clang 13 also obtains a critical bug fix for the > [[noreturn]] > attribute (see JDK-8303805). > > Testing: mach5 tier1, which includes building with a recent version of > Xcode/clang. Change looks fine from a build perspective. - Marked as reviewed by ihse (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/17862#pullrequestreview-1882418401
Re: RFR: 8325878: Require minimum Clang version 13
On Thu, 15 Feb 2024 05:19:45 GMT, Kim Barrett wrote: > Please review this change that updates the minimum supported version of Clang > to be used for building OpenJDK from 3.5 to 13. > > This permits enabling C++17 (JDK-8314488), though Clang 5 might suffice for > that. A minimum of Clang 13 also obtains a critical bug fix for the > [[noreturn]] > attribute (see JDK-8303805). > > Testing: mach5 tier1, which includes building with a recent version of > Xcode/clang. Marked as reviewed by jwaters (Committer). - PR Review: https://git.openjdk.org/jdk/pull/17862#pullrequestreview-1882097398
