Re: RFR: 8326685: Linux builds not reproducible if two builds configured in different build folders [v3]

2024-02-27 Thread Erik Joelsson
On Tue, 27 Feb 2024 13:44:15 GMT, Andrew Leonard  wrote:

>> Adds Linux -fdebug-prefix-map'ing for SUPPORT_OUTPUTDIR and 
>> HOTSPOT_OUTPUTDIR when absolute paths are not allowed in the binaries, thus 
>> making the building of a JDK identically reproducible from different build 
>> directories.
>
> Andrew Leonard has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Re-trigger actions

Marked as reviewed by erikj (Reviewer).

-

PR Review: https://git.openjdk.org/jdk/pull/18009#pullrequestreview-1904920207


Re: RFR: 8326685: Linux builds not reproducible if two builds configured in different build folders [v3]

2024-02-27 Thread Andrew Leonard
On Tue, 27 Feb 2024 13:44:15 GMT, Andrew Leonard  wrote:

>> Adds Linux -fdebug-prefix-map'ing for SUPPORT_OUTPUTDIR and 
>> HOTSPOT_OUTPUTDIR when absolute paths are not allowed in the binaries, thus 
>> making the building of a JDK identically reproducible from different build 
>> directories.
>
> Andrew Leonard has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Re-trigger actions

@erikj79 ready for re-review please

-

PR Comment: https://git.openjdk.org/jdk/pull/18009#issuecomment-1966869370


Re: RFR: 8326685: Linux builds not reproducible if two builds configured in different build folders [v3]

2024-02-27 Thread Andrew Leonard
> Adds Linux -fdebug-prefix-map'ing for SUPPORT_OUTPUTDIR and HOTSPOT_OUTPUTDIR 
> when absolute paths are not allowed in the binaries, thus making the building 
> of a JDK identically reproducible from different build directories.

Andrew Leonard has updated the pull request incrementally with one additional 
commit since the last revision:

  Re-trigger actions

-

Changes:
  - all: https://git.openjdk.org/jdk/pull/18009/files
  - new: https://git.openjdk.org/jdk/pull/18009/files/4bd1d3dd..1af645c7

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18009&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18009&range=01-02

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18009.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18009/head:pull/18009

PR: https://git.openjdk.org/jdk/pull/18009