Re: RFR: 8326960: GHA: RISC-V sysroot cannot be debootstrapped due to ongoing Debian t64 transition

2024-03-22 Thread Aleksey Shipilev
On Thu, 21 Mar 2024 15:33:21 GMT, Aleksey Shipilev  wrote:

> Debian "unstable" is currently undergoing t64 (hello, Y2038) transition, 
> which breaks "sid" repo that we use for debootstrapping RISC-V very often. 
> This is seen across multiple repositories, and requires everyone to look 
> through GHA failures all the time. This PR tries to fix this: if debootstrap 
> for "sid" repos fails, the build for that arch would not continue. IMO, it is 
> a better compromise for current situation. We will flip back to expecting the 
> debootstrap to complete well after either t64 transition finishes, or we 
> switch to more stable Debian repo once it graduates.
> 
> Additional testing:
>  - [x] GHA

And away we go! Thanks Erik.

-

PR Comment: https://git.openjdk.org/jdk/pull/18435#issuecomment-2015193651


Re: RFR: 8326960: GHA: RISC-V sysroot cannot be debootstrapped due to ongoing Debian t64 transition

2024-03-22 Thread Erik Joelsson
On Thu, 21 Mar 2024 15:33:21 GMT, Aleksey Shipilev  wrote:

> Debian "unstable" is currently undergoing t64 (hello, Y2038) transition, 
> which breaks "sid" repo that we use for debootstrapping RISC-V very often. 
> This is seen across multiple repositories, and requires everyone to look 
> through GHA failures all the time. This PR tries to fix this: if debootstrap 
> for "sid" repos fails, the build for that arch would not continue. IMO, it is 
> a better compromise for current situation. We will flip back to expecting the 
> debootstrap to complete well after either t64 transition finishes, or we 
> switch to more stable Debian repo once it graduates.
> 
> Additional testing:
>  - [x] GHA

Marked as reviewed by erikj (Reviewer).

-

PR Review: https://git.openjdk.org/jdk/pull/18435#pullrequestreview-1954886889


Re: RFR: 8326960: GHA: RISC-V sysroot cannot be debootstrapped due to ongoing Debian t64 transition

2024-03-22 Thread Aleksey Shipilev
On Thu, 21 Mar 2024 15:33:21 GMT, Aleksey Shipilev  wrote:

> Debian "unstable" is currently undergoing t64 (hello, Y2038) transition, 
> which breaks "sid" repo that we use for debootstrapping RISC-V very often. 
> This is seen across multiple repositories, and requires everyone to look 
> through GHA failures all the time. This PR tries to fix this: if debootstrap 
> for "sid" repos fails, the build for that arch would not continue. IMO, it is 
> a better compromise for current situation. We will flip back to expecting the 
> debootstrap to complete well after either t64 transition finishes, or we 
> switch to more stable Debian repo once it graduates.
> 
> Additional testing:
>  - [x] GHA

OK, great. GHAs are passing with RISC-V build skipped over broken sysroot.

I will integrate after I get a second review from build/GHA maintainers.

-

PR Comment: https://git.openjdk.org/jdk/pull/18435#issuecomment-2014558684


Re: RFR: 8326960: GHA: RISC-V sysroot cannot be debootstrapped due to ongoing Debian t64 transition

2024-03-21 Thread Fei Yang
On Thu, 21 Mar 2024 15:33:21 GMT, Aleksey Shipilev  wrote:

> Debian "unstable" is currently undergoing t64 (hello, Y2038) transition, 
> which breaks "sid" repo that we use for debootstrapping RISC-V very often. 
> This is seen across multiple repositories, and requires everyone to look 
> through GHA failures all the time. This PR tries to fix this: if debootstrap 
> for "sid" repos fails, the build for that arch would not continue. IMO, it is 
> a better compromise for current situation. We will flip back to expecting the 
> debootstrap to complete well after either t64 transition finishes, or we 
> switch to more stable Debian repo once it graduates.
> 
> Additional testing:
>  - [x] GHA

LGTM. Since debian SID (aka Unstable) is not ensured to be debootstrappable, I 
think it's good to have such a compromise before we have the first debian 
release for riscv64. We will do daily build locally for the affected jdk repos 
during this t64 transition period.

-

Marked as reviewed by fyang (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18435#pullrequestreview-1953818946