Re: RFR: 8329494: Serial: Merge GenMarkSweep into MarkSweep
On Wed, 3 Apr 2024 09:56:42 GMT, Albert Mingkun Yang wrote: >> Hi all, >> >> This patch merges the class `GenMarkSweep` into `MarkSweep`. Just simply >> move. It may be better to merge the class `DeadSpacer` and `Compacter` into >> `MarkSweep` and then rename `MarkSweep`. The `MarkSweep` will be renamed at >> [JDK-8329521](https://bugs.openjdk.org/browse/JDK-8329521). And the >> `DeadSpacer` and `Compacter` may be refactored at >> [JDK-8305896](https://bugs.openjdk.org/browse/JDK-8305896) and >> [JDK-8305898](https://bugs.openjdk.org/browse/JDK-8305898), so I don't >> refactor them now. >> >> The tests `make test-tier1_gc` passed locally. Thanks for taking the time to >> review. >> >> Best Regards, >> -- Guoxiong > > Marked as reviewed by ayang (Reviewer). @albertnetymk @tschatzl Thanks for the review. - PR Comment: https://git.openjdk.org/jdk/pull/18589#issuecomment-2036116806
Re: RFR: 8329494: Serial: Merge GenMarkSweep into MarkSweep
On Wed, 3 Apr 2024 03:10:26 GMT, Guoxiong Li wrote: > Hi all, > > This patch merges the class `GenMarkSweep` into `MarkSweep`. Just simply > move. It may be better to merge the class `DeadSpacer` and `Compacter` into > `MarkSweep` and then rename `MarkSweep`. The `MarkSweep` will be renamed at > [JDK-8329521](https://bugs.openjdk.org/browse/JDK-8329521). And the > `DeadSpacer` and `Compacter` may be refactored at > [JDK-8305896](https://bugs.openjdk.org/browse/JDK-8305896) and > [JDK-8305898](https://bugs.openjdk.org/browse/JDK-8305898), so I don't > refactor them now. > > The tests `make test-tier1_gc` passed locally. Thanks for taking the time to > review. > > Best Regards, > -- Guoxiong seems good. - Marked as reviewed by tschatzl (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/18589#pullrequestreview-1976271613
Re: RFR: 8329494: Serial: Merge GenMarkSweep into MarkSweep
On Wed, 3 Apr 2024 03:10:26 GMT, Guoxiong Li wrote: > Hi all, > > This patch merges the class `GenMarkSweep` into `MarkSweep`. Just simply > move. It may be better to merge the class `DeadSpacer` and `Compacter` into > `MarkSweep` and then rename `MarkSweep`. The `MarkSweep` will be renamed at > [JDK-8329521](https://bugs.openjdk.org/browse/JDK-8329521). And the > `DeadSpacer` and `Compacter` may be refactored at > [JDK-8305896](https://bugs.openjdk.org/browse/JDK-8305896) and > [JDK-8305898](https://bugs.openjdk.org/browse/JDK-8305898), so I don't > refactor them now. > > The tests `make test-tier1_gc` passed locally. Thanks for taking the time to > review. > > Best Regards, > -- Guoxiong Marked as reviewed by ayang (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/18589#pullrequestreview-1976243060
Re: RFR: 8329494: Serial: Merge GenMarkSweep into MarkSweep
On Wed, 3 Apr 2024 03:10:26 GMT, Guoxiong Li wrote: > Hi all, > > This patch merges the class `GenMarkSweep` into `MarkSweep`. Just simply > move. It may be better to merge the class `DeadSpacer` and `Compacter` into > `MarkSweep` and then rename `MarkSweep`. The `MarkSweep` will be renamed at > [JDK-8329521](https://bugs.openjdk.org/browse/JDK-8329521). And the > `DeadSpacer` and `Compacter` may be refactored at > [JDK-8305896](https://bugs.openjdk.org/browse/JDK-8305896) and > [JDK-8305898](https://bugs.openjdk.org/browse/JDK-8305898), so I don't > refactor them now. > > The tests `make test-tier1_gc` passed locally. Thanks for taking the time to > review. > > Best Regards, > -- Guoxiong Build changes are trivially fine. - Marked as reviewed by ihse (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/18589#pullrequestreview-1976202642
