Greetings,
I am a FreeBSD ports committer and have taken over maintaining the
FreeBSD busybox port from Chris Rees.
I have updated the FreeBSD port to 1.18.5 and a couple of questions:
- Why do parts of the package use #include ?
- Is there a particular reason the sed scripts use GNU extensions or
syntax? What are the chances of these being replaced by POSIX default
constructs (If none, add: possibly if I submit a patch)?
I figured that there were a few warnings during the build, could these
be addressed for the next release:
--- These are hints that there are missing #include
directives: ---
coreutils/cp.c:168: warning: implicit declaration of function 'dirname'
archival/unzip.c:225: warning: implicit declaration of function 'dirname'
coreutils/dirname.c:20: warning: implicit declaration of function 'dirname'
coreutils/install.c:164: warning: implicit declaration of function 'dirname'
coreutils/rmdir.c:57: warning: implicit declaration of function 'dirname'
--- The next is a hint that declarations are later down in the code, not
at the beginning of a code block, or that I need to build the code as C99.
QUESTION: is busybox supposed to be C89 or C99 code?
libbb/getpty.c:23: warning: ISO C90 forbids mixed declarations and code
--- The next may need API cleanup, or a (void)fd; cast inside the
function if the API is supposed not to change:
libbb/udp_io.c:16: warning: unused parameter 'fd'
Thanks a lot.
Best regards
Matthias
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox