Re: busybox sed chokes on certain types of multi-expression regexps
On Monday 15 September 2014 19:00, Ari Sundholm wrote: > > Hello! > > Busybox sed seems to have some sort of a bug in its regexp parser. > Examples below: > > ~ # This doesn't work. > ~ busybox sed -e 's/a/b/1; s/a/b/g' > sed: bad option in substitution expression > > ~ # This works. > ~ busybox sed -e 's/a/b/1 ; s/a/b/g' > > ~ # Curiously, this also works. > ~ busybox sed -e 's/a/b/1;' Thanks for the report. Fixed in git. ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox
Re: killall behaviour
On Friday 05 September 2014 18:22, Harald Becker wrote: > Hi Denys ! > > > Unfortunately, there is no commonly agreed definition of > > "program named FOO". > > ... but standard usage cases should be acted on correct: > > Think of: > > ln -s /bin/Busybox ntpd > ln -s /bin/Busybox syslogd > ln -s /bin/Busybox klogd > > ntpd ... > syslogd ... > klogd ... > > Busybox killall ntpd > > ... will not only kill ntpd, but also syslogd and klogd ... do you think > anyone expect this? No, it won't. Try it. ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox
Re: ftpd authentication
On Monday 15 September 2014 16:34, Morten Kvistgaard wrote: > Hello Denys, > > I've studied the last patch you applied to ftpd. > > The patch can be fixed if you reorder the "change_identity" to beneath the > jail. Fix in what way? What is the bug? > Also the "change_identity" ought to conflict with the NOMMU jail break. > However a carefully placed call to "getpwuid" seems to somehow solve this. > (wtf?) I've tested it on Ubuntu + uClinux. What is the bug? > An unrelated small issue: The ftpd is not listing hidden files like other ftp > servers do. This' got to an error? (Solution is simple.) I applied this part of your change. Thank you. ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox
busybox sed chokes on certain types of multi-expression regexps
Hello! Busybox sed seems to have some sort of a bug in its regexp parser. Examples below: ~ # This doesn't work. ~ busybox sed -e 's/a/b/1; s/a/b/g' sed: bad option in substitution expression ~ # This works. ~ busybox sed -e 's/a/b/1 ; s/a/b/g' ~ # Curiously, this also works. ~ busybox sed -e 's/a/b/1;' Best regards, Ari Sundholm a...@tuxera.com ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox
RE: ftpd authentication
Hello Denys, I've studied the last patch you applied to ftpd. The patch can be fixed if you reorder the "change_identity" to beneath the jail. Also the "change_identity" ought to conflict with the NOMMU jail break. However a carefully placed call to "getpwuid" seems to somehow solve this. (wtf?) I've tested it on Ubuntu + uClinux. An unrelated small issue: The ftpd is not listing hidden files like other ftp servers do. This' got to an error? (Solution is simple.) I've attached a patch with the above. Regards, Morten Kvistgaard > -Original Message- > From: Denys Vlasenko [mailto:vda.li...@googlemail.com] > Sent: 5. august 2014 22:00 > To: Morten Kvistgaard > Cc: busybox@busybox.net > Subject: Re: ftpd authentication > > On Mon, Aug 4, 2014 at 12:38 PM, Morten Kvistgaard engineering.dk> wrote: > > I've attached a patch for adding basic authentication to the ftpd. > > > > This used to work with version 1.21.1. And walter harms tested it with > 1.22.1. And it worked with trunk 3 months ago. > > > > It doesn't seem to work with the current trunk though? > > > > The difference lies with "getpwnam" I think. (It's returning NULL on > > my Ubuntu.) > > getpwnam will not be very happy in chroot. > > I fixed that, and also added actual change of user identity, and refactored > password check to not duplicate code. > > Applied to git, please try it now. > For example, I'm curious whether people who want _anon_ ftp are unhappy > now -- This message has been scanned for viruses and dangerous content by CronLab (www.cronlab.com), and is believed to be clean. 0001-fix-ftp-authentication-change_identity-ls-A.patch Description: 0001-fix-ftp-authentication-change_identity-ls-A.patch ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox
