Re: 1.23.0 FreeBSD build fails: 1 showstopper mempcpy(), 1 sendfile() incompat.
Am 2. Februar 2015 02:32:31 MEZ, schrieb Denys Vlasenko : >On Sun, Feb 1, 2015 at 11:23 AM, Matthias Andree > wrote: >> Am 31. Januar 2015 17:58:40 MEZ, schrieb Denys Vlasenko >> : >>> >>> On Wed, Jan 28, 2015 at 10:50 PM, Matthias Andree > >>> wrote: > > Matthias, please get current git, uncomment this line, > and confirm that it builds for you. Let me know the version > of FreeBSD which needs it (newer ones may grow their own > mempcpy(), we need to be ready for that). That works. >>> >>> >>> Let me know the version of FreeBSD which needs it. >>> Let me know the version of FreeBSD which needs it. >>> Let me know the version of FreeBSD which needs it. >>> Let me know the version of FreeBSD which needs it. >>> Let me know the version of FreeBSD which needs it. >> >> >> All for now, I cannot look i! nto the future about when someone might >add >> such extensions. In doubt, do not use nonstandard extensions... > >Ok, let me restate the question. >On which version(s) of FreeBSD do you see lack of mempcpy? All released versions are affected, and probably more systems than just FreeBSD. This mempcpy() is not something that FreeBSD would "lack"; instead, it is a nonstandard non-portable extension that is specific to and not available outside of pure GNU environments. ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox
Re: 1.23.0 FreeBSD build fails: 1 showstopper mempcpy(), 1 sendfile() incompat.
On Mon, Feb 02, 2015 at 02:32:31AM +0100, Denys Vlasenko wrote: > On Sun, Feb 1, 2015 at 11:23 AM, Matthias Andree > wrote: > > Am 31. Januar 2015 17:58:40 MEZ, schrieb Denys Vlasenko > > : > >> > >> On Wed, Jan 28, 2015 at 10:50 PM, Matthias Andree > >> wrote: > > Matthias, please get current git, uncomment this line, > and confirm that it builds for you. Let me know the version > of FreeBSD which needs it (newer ones may grow their own > mempcpy(), we need to be ready for that). > >>> > >>> > >>> That works. > >> > >> > >> Let me know the version of FreeBSD which needs it. > >> Let me know the version of FreeBSD which needs it. > >> Let me know the version of FreeBSD which needs it. > >> Let me know the version of FreeBSD which needs it. > >> Let me know the version of FreeBSD which needs it. > > > > > > All for now, I cannot look i! nto the future about when someone might add > > such extensions. In doubt, do not use nonstandard extensions... > > Ok, let me restate the question. > On which version(s) of FreeBSD do you see lack of mempcpy? I see no indication that mempcpy has ever been available on FreeBSD; the man page says only "This function is a GNU extension." under CONFORMING TO. gnulib documentation indicates that it is essentially glibc only. HTH, Isaac Dunham ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox
Re: 1.23.0 FreeBSD build fails: 1 showstopper mempcpy(), 1 sendfile() incompat.
On Sun, Feb 1, 2015 at 11:23 AM, Matthias Andree wrote: > Am 31. Januar 2015 17:58:40 MEZ, schrieb Denys Vlasenko > : >> >> On Wed, Jan 28, 2015 at 10:50 PM, Matthias Andree >> wrote: Matthias, please get current git, uncomment this line, and confirm that it builds for you. Let me know the version of FreeBSD which needs it (newer ones may grow their own mempcpy(), we need to be ready for that). >>> >>> >>> That works. >> >> >> Let me know the version of FreeBSD which needs it. >> Let me know the version of FreeBSD which needs it. >> Let me know the version of FreeBSD which needs it. >> Let me know the version of FreeBSD which needs it. >> Let me know the version of FreeBSD which needs it. > > > All for now, I cannot look i! nto the future about when someone might add > such extensions. In doubt, do not use nonstandard extensions... Ok, let me restate the question. On which version(s) of FreeBSD do you see lack of mempcpy? ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox
[PATCH] fix gzip applet not to store timestamps
Storing the original file's modification time in the output file is
harmful (precludes deterministic results) and unlike official gzip,
the busybox version provides no way to suppress this behavior; the -n
option is silently ignored. Rather than trying to make -n work, this
patch just removes the timestamp-storing functionality. It should be
considered deprecated anyway; it's not Y2038-safe and gunzip ignores
it by default.
Per RFC 1952, 0 is the correct value to store to indicate that there
is no timestamp.
Rich
diff --git a/archival/gzip.c b/archival/gzip.c
index 1e779c9..903577b 100644
--- a/archival/gzip.c
+++ b/archival/gzip.c
@@ -2007,7 +2007,7 @@ static void ct_init(void)
* IN assertions: the input and output buffers are cleared.
*/
-static void zip(ulg time_stamp)
+static void zip()
{
ush deflate_flags = 0; /* pkzip -es, -en or -ex equivalent */
@@ -2018,7 +2018,7 @@ static void zip(ulg time_stamp)
/* compression method: 8 (DEFLATED) */
/* general flags: 0 */
put_32bit(0x00088b1f);
- put_32bit(time_stamp);
+ put_32bit(0);
/* Write deflated file to zip file */
G1.crc = ~0;
@@ -2044,8 +2044,6 @@ static void zip(ulg time_stamp)
static
IF_DESKTOP(long long) int FAST_FUNC pack_gzip(transformer_aux_data_t *aux
UNUSED_PARAM)
{
- struct stat s;
-
/* Clear input and output buffers */
G1.outcnt = 0;
#ifdef DEBUG
@@ -2077,9 +2075,7 @@ IF_DESKTOP(long long) int FAST_FUNC
pack_gzip(transformer_aux_data_t *aux UNUSED
G2.bl_desc.max_length = MAX_BL_BITS;
//G2.bl_desc.max_code= 0;
- s.st_ctime = 0;
- fstat(STDIN_FILENO, &s);
- zip(s.st_ctime);
+ zip();
return 0;
}
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
