[EDT][PATCH 11/11] Typo fix : implemenation --> implementation
EP-E9D7571734A347E2ADA07C4134AB97EA Hi, Subject: [PATCH 11/11] typo fix implemenation --> implementation Signed-off-by: Maninder Singh Reviewed-by: Akhilesh Kumar --- e2fsprogs/old_e2fsprogs/blkid/dev.c |2 +- e2fsprogs/old_e2fsprogs/blkid/tag.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/e2fsprogs/old_e2fsprogs/blkid/dev.c b/e2fsprogs/old_e2fsprogs/blkid/dev.c index 260e49c..84b7b0a 100644 --- a/e2fsprogs/old_e2fsprogs/blkid/dev.c +++ b/e2fsprogs/old_e2fsprogs/blkid/dev.c @@ -90,7 +90,7 @@ void blkid_debug_dump_dev(blkid_dev dev) * * These routines do not expose the list.h implementation, which are a * contamination of the namespace, and which force us to reveal far, far - * too much of our internal implemenation. I'm not convinced I want + * too much of our internal implementation. I'm not convinced I want * to keep list.h in the long term, anyway. It's fine for kernel * programming, but performance is not the #1 priority for this * library, and I really don't like the tradeoff of type-safety for diff --git a/e2fsprogs/old_e2fsprogs/blkid/tag.c b/e2fsprogs/old_e2fsprogs/blkid/tag.c index 7424ede..f10a701 100644 --- a/e2fsprogs/old_e2fsprogs/blkid/tag.c +++ b/e2fsprogs/old_e2fsprogs/blkid/tag.c @@ -230,7 +230,7 @@ errout: * * These routines do not expose the list.h implementation, which are a * contamination of the namespace, and which force us to reveal far, far - * too much of our internal implemenation. I'm not convinced I want + * too much of our internal implementation. I'm not convinced I want * to keep list.h in the long term, anyway. It's fine for kernel * programming, but performance is not the #1 priority for this * library, and I really don't like the tradeoff of type-safety for -- 1.7.1 Thanks Maninder Singh ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox
[EDT][PATCH 10/11]Typo fix : calender --> calendar
EP-E9D7571734A347E2ADA07C4134AB97EA Hi, Subject: [PATCH 10/11] typo fix calender --> calendar Signed-off-by: Maninder Singh Reviewed-by: Akhilesh Kumar --- coreutils/Config.src |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/coreutils/Config.src b/coreutils/Config.src index 1bbb91e..1ec3a0a 100644 --- a/coreutils/Config.src +++ b/coreutils/Config.src @@ -11,7 +11,7 @@ config CAL bool "cal" default y help - cal is used to display a monthly calender. + cal is used to display a monthly calendar. config CATV bool "catv" -- 1.7.1 Thanks Maninder Singh ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox
[EDT][PATCH 9/11]Typo fix:arguement --> argument
EP-E9D7571734A347E2ADA07C4134AB97EA Hi, Subject: [PATCH 09/11] typo fix arguement --> argument Signed-off-by: Maninder Singh Reviewed-by: Akhilesh Kumar --- Makefile |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index e088857..65b2642 100644 --- a/Makefile +++ b/Makefile @@ -552,7 +552,7 @@ export INSTALL_PATH ?= /boot # # INSTALL_MOD_PATH specifies a prefix to MODLIB for module directory # relocations required by build roots. This is not defined in the -# makefile but the arguement can be passed to make if needed. +# makefile but the argument can be passed to make if needed. # MODLIB = $(INSTALL_MOD_PATH)/lib/modules/$(KERNELRELEASE) -- 1.7.1 Thanks Maninder Singh ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox
[EDT][PATCH 8/11]Typo fix : protcol-->protocol
EP-E9D7571734A347E2ADA07C4134AB97EA Hi, Subject: [PATCH 08/11] typo fix protcol-->protocol Signed-off-by: Maninder Singh Reviewed-by: Akhilesh Kumar --- docs/cgi/env.html |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/docs/cgi/env.html b/docs/cgi/env.html index b83c750..66a548b 100644 --- a/docs/cgi/env.html +++ b/docs/cgi/env.html @@ -38,7 +38,7 @@ fulfilled by the gateway program: SERVER_PROTOCOL -The name and revision of the information protcol this request came +The name and revision of the information protocol this request came in with. Format: protocol/revision SERVER_PORT -- 1.7.1 Thanks Maninder Singh ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox
[EDT][PATCH 7/11]Typo fix :preceeded--> preceded
EP-E9D7571734A347E2ADA07C4134AB97EA Hi, Subject: [PATCH 07/11] typo fix preceeded--> preceded Signed-off-by: Maninder Singh Reviewed-by: Akhilesh Kumar --- miscutils/less.c|2 +- scripts/basic/docproc.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/miscutils/less.c b/miscutils/less.c index 554e546..d5a68d1 100644 --- a/miscutils/less.c +++ b/miscutils/less.c @@ -1848,7 +1848,7 @@ key and/or command line switch compatibility is a good idea: Most options may be changed either on the command line, or from within less by using the - or -- command. Options may be given in one of two forms: either a single -character preceded by a -, or a name preceeded by --. +character preceded by a -, or a name preceded by --. -? --help Display help (from command line). -a --search-skip-screen diff --git a/scripts/basic/docproc.c b/scripts/basic/docproc.c index 7f21443..720098a 100644 --- a/scripts/basic/docproc.c +++ b/scripts/basic/docproc.c @@ -264,7 +264,7 @@ void singfunc(char * filename, char * line) vec[idx++] = KERNELDOC; vec[idx++] = DOCBOOK; - /* Split line up in individual parameters preceeded by FUNCTION */ + /* Split line up in individual parameters preceded by FUNCTION */ for (i=0; line[i]; i++) { if (isspace(line[i])) { line[i] = '\0'; -- 1.7.1 Thanks Maninder Singh ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox
[EDT][PATCH 6/11]Typo fix : vitual --> virtual
EP-E9D7571734A347E2ADA07C4134AB97EA Hi, Subject: [PATCH 06/11] typo fix vitual --> virtual Signed-off-by: Maninder Singh Reviewed-by: Akhilesh Kumar --- editors/vi.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/editors/vi.c b/editors/vi.c index c8c7b32..6ce513c 100644 --- a/editors/vi.c +++ b/editors/vi.c @@ -3357,7 +3357,7 @@ static void refresh(int full_screen) tp = t + 1; } - // see if there are any changes between vitual screen and out_buf + // see if there are any changes between virtual screen and out_buf changed = FALSE;// assume no change cs = 0; ce = columns - 1; @@ -3394,7 +3394,7 @@ static void refresh(int full_screen) if (cs < 0) cs = 0; if (ce > columns - 1) ce = columns - 1; if (cs > ce) { cs = 0; ce = columns - 1; } - // is there a change between vitual screen and out_buf + // is there a change between virtual screen and out_buf if (changed) { // copy changed part of buffer to virtual screen memcpy(sp+cs, out_buf+cs, ce-cs+1); -- 1.7.1 Thanks Maninder Singh ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox
[EDT][PATCH 5/11]Typo fix: speficied--> specified
EP-E9D7571734A347E2ADA07C4134AB97EA Hi, Subject: [PATCH 05/11] typo fix speficied--> specified Signed-off-by: Maninder Singh Reviewed-by: Akhilesh Kumar --- selinux/Config.src |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/selinux/Config.src b/selinux/Config.src index 47d15b6..d4701f6 100644 --- a/selinux/Config.src +++ b/selinux/Config.src @@ -64,7 +64,7 @@ config RUNCON default n depends on SELINUX help - Enable support to run command in speficied security context. + Enable support to run command in specified security context. config FEATURE_RUNCON_LONG_OPTIONS bool "Enable long options" -- 1.7.1 Thanks Maninder Singh ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox
[EDT][PATCH 4/11]Typo Fix: fuction --> function
EP-E9D7571734A347E2ADA07C4134AB97EA Hi, Subject: [PATCH 04/11] typo fix fuction --> function Signed-off-by: Maninder Singh Reviewed-by: Akhilesh Kumar --- e2fsprogs/old_e2fsprogs/e2fsck.c |4 ++-- util-linux/mkfs_reiser.c |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/e2fsprogs/old_e2fsprogs/e2fsck.c b/e2fsprogs/old_e2fsprogs/e2fsck.c index 0799b64..b816c62 100644 --- a/e2fsprogs/old_e2fsprogs/e2fsck.c +++ b/e2fsprogs/old_e2fsprogs/e2fsck.c @@ -6381,7 +6381,7 @@ static int deallocate_inode_block(ext2_filsys fs, blk_t *block_nr, } /* - * This fuction deallocates an inode + * This function deallocates an inode */ static void deallocate_inode(e2fsck_t ctx, ext2_ino_t ino, char* block_buf) { @@ -6447,7 +6447,7 @@ static void deallocate_inode(e2fsck_t ctx, ext2_ino_t ino, char* block_buf) } /* - * This fuction clears the htree flag on an inode + * This function clears the htree flag on an inode */ static void clear_htree(e2fsck_t ctx, ext2_ino_t ino) { diff --git a/util-linux/mkfs_reiser.c b/util-linux/mkfs_reiser.c index 13abaa8..56c8f0a 100644 --- a/util-linux/mkfs_reiser.c +++ b/util-linux/mkfs_reiser.c @@ -66,7 +66,7 @@ struct reiserfs_super_block { char s_magic[10]; /* 52 "ReIsErFs" or "ReIsEr2Fs" or "ReIsEr3Fs" */ uint16_t sb_fs_state; /* 62 it is set to used by fsck to mark which phase of rebuilding is done (used for fsck debugging) */ - uint32_t sb_hash_function_code; /* 64 code of fuction which was/is/will be used to sort names in a directory. See codes in above */ + uint32_t sb_hash_function_code; /* 64 code of function which was/is/will be used to sort names in a directory. See codes in above */ uint16_t sb_tree_height;/* 68 height of filesytem tree. Tree consisting of only one root block has 2 here */ uint16_t sb_bmap_nr;/* 70 amount of bitmap blocks needed to address each block of file system */ uint16_t sb_version;/* 72 this field is only reliable on filesystem with non-standard journal */ -- 1.7.1 Thanks Maninder Singh ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox
[EDT] [PATCH 3/11] Typo fix : accomodate --> accommodate
EP-E9D7571734A347E2ADA07C4134AB97EA Hi, Subject: [PATCH 03/11] typo fix accomodate --> accommodate Signed-off-by: Maninder Singh Reviewed-by: Akhilesh Kumar --- coreutils/stat.c |2 +- coreutils/uudecode.c |2 +- findutils/xargs.c|2 +- networking/netstat.c |2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/coreutils/stat.c b/coreutils/stat.c index 769fac0..f7fd227 100644 --- a/coreutils/stat.c +++ b/coreutils/stat.c @@ -374,7 +374,7 @@ static void print_it(const char *masterformat, { /* Create a working copy of the format string */ char *format = xstrdup(masterformat); - /* Add 2 to accomodate our conversion of the stat '%s' format string + /* Add 2 to accommodate our conversion of the stat '%s' format string * to the printf '%llu' one. */ char *dest = xmalloc(strlen(format) + 2 + 1); char *b; diff --git a/coreutils/uudecode.c b/coreutils/uudecode.c index 3f12273..7aa5c67 100644 --- a/coreutils/uudecode.c +++ b/coreutils/uudecode.c @@ -46,7 +46,7 @@ static void FAST_FUNC read_stduu(FILE *src_stream, FILE *dst_stream, int flags U encoded_len = line[0] * 4 / 3; /* Check that line is not too short. (we tolerate -* overly _long_ line to accomodate possible extra '`'). +* overly _long_ line to accommodate possible extra '`'). * Empty line case is also caught here. */ if (str_len <= encoded_len) { break; /* go to bb_error_msg_and_die("short file"); */ diff --git a/findutils/xargs.c b/findutils/xargs.c index 76c4747..25e47ec 100644 --- a/findutils/xargs.c +++ b/findutils/xargs.c @@ -151,7 +151,7 @@ static void store_param(char *s) * is seen, store the address of a new parameter to args[]. * If reading discovers that last chars do not form the complete * parameter, the pointer to the first such "tail character" is returned. - * (buf has extra byte at the end to accomodate terminating NUL + * (buf has extra byte at the end to accommodate terminating NUL * of "tail characters" string). * Otherwise, the returned pointer points to NUL byte. * On entry, buf[] may contain some "seed chars" which are to become diff --git a/networking/netstat.c b/networking/netstat.c index 1303d3f..2196d42 100644 --- a/networking/netstat.c +++ b/networking/netstat.c @@ -119,7 +119,7 @@ typedef enum { #define ADDR_NORMAL_WIDTH23 /* When there are IPv6 connections the IPv6 addresses will be * truncated to none-recognition. The '-W' option makes the - * address columns wide enough to accomodate for longest possible + * address columns wide enough to accommodate for longest possible * IPv6 addresses, i.e. addresses of the form * ::::::ddd.ddd.ddd.ddd */ -- 1.7.1 Thanks Maninder Singh ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox
[EDT] [PATCH 2/11] Typo fix:assigment --> assignment
EP-E9D7571734A347E2ADA07C4134AB97EA Hi, Subject: [PATCH 02/11] typo fix assigment --> assignment Signed-off-by: Maninder Singh Reviewed-by: Akhilesh Kumar --- shell/hush.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/shell/hush.c b/shell/hush.c index f2c0a70..5852712 100644 --- a/shell/hush.c +++ b/shell/hush.c @@ -442,7 +442,7 @@ enum { MAYBE_ASSIGNMENT = 0, DEFINITELY_ASSIGNMENT = 1, NOT_ASSIGNMENT= 2, - /* Not an assigment, but next word may be: "if v=xyz cmd;" */ + /* Not an assignment, but next word may be: "if v=xyz cmd;" */ WORD_IS_KEYWORD = 3, }; /* Used for initialization: o_string foo = NULL_O_STRING; */ -- 1.7.1 Thanks Maninder Singh ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox
[EDT][PATCH 1/11] Typo fix : begining -> beginning
EP-E9D7571734A347E2ADA07C4134AB97EA Hi, Subject: [PATCH 01/11] typo fix begining -> beginning Signed-off-by: Maninder Singh Reviewed-by: Akhilesh Kumar --- editors/diff.c |2 +- editors/vi.c | 10 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/editors/diff.c b/editors/diff.c index c3ad31b..cf14b1d 100644 --- a/editors/diff.c +++ b/editors/diff.c @@ -363,7 +363,7 @@ static void stone(const int *a, int n, const int *b, int *J, int pref) } struct line { - /* 'serial' is not used in the begining, so we reuse it + /* 'serial' is not used in the beginning, so we reuse it * to store line offsets, thus reducing memory pressure */ union { diff --git a/editors/vi.c b/editors/vi.c index 2e4f7fc..c8c7b32 100644 --- a/editors/vi.c +++ b/editors/vi.c @@ -501,7 +501,7 @@ static char *prev_line(char *); // return pointer to prev line B-o-l static char *next_line(char *);// return pointer to next line B-o-l static char *end_screen(void); // get pointer to last char on screen static int count_lines(char *, char *);// count line from start to stop -static char *find_line(int); // find begining of line #li +static char *find_line(int); // find beginning of line #li static char *move_to_col(char *, int); // move "p" to column l static void dot_left(void);// move dot left- dont leave line static void dot_right(void); // move dot right- dont leave line @@ -1684,10 +1684,10 @@ static char *dollar_line(char *p) // return pointer to just before NL line static char *prev_line(char *p) // return pointer first char prev line { - p = begin_line(p); // goto begining of cur line + p = begin_line(p); // goto beginning of cur line if (p > text && p[-1] == '\n') p--;// step to prev line - p = begin_line(p); // goto begining of prev line + p = begin_line(p); // goto beginning of prev line return p; } @@ -1735,7 +1735,7 @@ static int count_lines(char *start, char *stop) return cnt; } -static char *find_line(int li) // find begining of line #li +static char *find_line(int li) // find beginning of line #li { char *q; @@ -3844,7 +3844,7 @@ static void do_cmd(int c) } break; #endif /* FEATURE_VI_SEARCH */ - case '0': // 0- goto begining of line + case '0': // 0- goto beginning of line case '1': // 1- case '2': // 2- case '3': // 3- -- 1.7.1 Thanks Maninder Singh ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox
[EDT][PATCH 0/11] typo fixes in busybox
EP-E9D7571734A347E2ADA07C4134AB97EA Hi, During codewalk through find little typo mistakes, So i made a script to find out common typo errors done by developer and sending fixes for the same to make busybox more perfect :) No Functinality changes. Patch list (One patch for one word correction ni buxybox so that it is easy fro reviewer and commiter to review the patches). 1 Typo fix (begining -> beginning) 2 Typo fix (assigment --> assignment) 3 Typo fix (accomodate --> accommodate) 4 Typo fix (fuction --> function) 5 Typo fix (speficied--> specified) 6 Typo fix (vitual --> virtual) 7 Typo fix (preceeded--> preceded) 8 Typo fix (protcol-->protocol) 9 Typo fix (arguement --> argument) 10 Typo fix (calender --> calendar) 11 Typo fix ( implemenation --> implementation) Thanks Maninder Singh ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox
Busybox "udhcpc" and classless static routes (rfc3442)
Hello, I'm trying to use "udhcpc" from busybox (The client, not the server) to obtain classless static routes through a DHCP packet. My DHCP server side (isc-dhcpd-4.1.1-P1) is configured with: option rfc3442-classless-static-routes code 121 = array of integer 8; option ms-classless-static-routes code 249 = array of integer 8; and option rfc3442-classless-static-routes 24, 192, 168, 123, 10, 10, 10, 1, 0, 192, 168, 1, 2; option ms-classless-static-routes 24, 192, 168, 123, 10, 10, 10, 1, 0, 192, 168, 1, 2; However on the client side I don't appear to source that data as part of the DHCP query. Here's the udhcpc client query strings I've tried: /sbin/udhcpc -C $(dmidecode -s system-serial-number) -n -q -s /etc/udhcpc/udhcpc.script -i eth0 -O 121 /sbin/udhcpc -C $(dmidecode -s system-serial-number) -n -q -s /etc/udhcpc/udhcpc.script -i eth0 -O staticroutes In /etc/udhcpc/udhcpc.script I'm printing the following to STDOUT to see if the routes are pupulated: echo "DHCP Boot Function = ${1} $2 $3 $4 $5 $6 $7" echo "Broadcast = ${broadcast}" echo "Netmask = ${subnet}" echo "Domain = ${domain}" echo "Leased IP = ${ip}" echo "Router = ${router}" echo "CIDR Route = $cidrroute" It looks like "$cidroute" should be populated by option 121/staticroutes but that doesn't work. Any suggestions would be greatly appreciated. Thank you, -Alex ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox
[PATCH] ip addr: support change and replace commands
Signed-off-by: Michael Tokarev --- networking/ip.c | 2 +- networking/libiproute/ipaddress.c | 20 2 files changed, 13 insertions(+), 9 deletions(-) diff --git a/networking/ip.c b/networking/ip.c index 98fe621..d35345c 100644 --- a/networking/ip.c +++ b/networking/ip.c @@ -33,7 +33,7 @@ //usage: "{ {add|del} IFADDR dev STRING | {show|flush}\n" //usage: " [dev STRING] [to PREFIX] }" //usage:#define ipaddr_full_usage "\n\n" -//usage: "ipaddr {add|delete} IFADDR dev STRING\n" +//usage: "ipaddr {add|change|replace|delete} IFADDR dev STRING\n" //usage: "ipaddr {show|flush} [dev STRING] [scope SCOPE-ID]\n" //usage: " [to PREFIX] [label PATTERN]\n" //usage: " IFADDR := PREFIX | ADDR peer PREFIX\n" diff --git a/networking/libiproute/ipaddress.c b/networking/libiproute/ipaddress.c index 4072d06..85f3356 100644 --- a/networking/libiproute/ipaddress.c +++ b/networking/libiproute/ipaddress.c @@ -598,7 +598,7 @@ static int default_scope(inet_prefix *lcl) } /* Return value becomes exitcode. It's okay to not return at all */ -static int ipaddr_modify(int cmd, char **argv) +static int ipaddr_modify(int cmd, int flags, char **argv) { static const char option[] ALIGN1 = "peer\0""remote\0""broadcast\0""brd\0" @@ -622,7 +622,7 @@ static int ipaddr_modify(int cmd, char **argv) memset(&req, 0, sizeof(req)); req.n.nlmsg_len = NLMSG_LENGTH(sizeof(struct ifaddrmsg)); - req.n.nlmsg_flags = NLM_F_REQUEST; + req.n.nlmsg_flags = NLM_F_REQUEST | flags; req.n.nlmsg_type = cmd; req.ifa.ifa_family = preferred_family; @@ -749,16 +749,20 @@ static int ipaddr_modify(int cmd, char **argv) int FAST_FUNC do_ipaddr(char **argv) { static const char commands[] ALIGN1 = - "add\0""delete\0""list\0""show\0""lst\0""flush\0"; + /* 01 2 3 4 5 6 7 8 */ + "add\0""change\0""chg\0""replace\0""delete\0""list\0""show\0""lst\0""flush\0"; int cmd = 2; if (*argv) { cmd = index_in_substrings(commands, *argv); if (cmd < 0) invarg(*argv, applet_name); argv++; - if (cmd <= 1) - return ipaddr_modify((cmd == 0) ? RTM_NEWADDR : RTM_DELADDR, argv); - } - /* 2 == list, 3 == show, 4 == lst */ - return ipaddr_list_or_flush(argv, cmd == 5); + if (cmd <= 4) + return ipaddr_modify(cmd == 4 ? RTM_DELADDR : RTM_NEWADDR, + cmd == 0 ? NLM_F_CREATE|NLM_F_EXCL : + cmd == 1 || cmd == 2 ? NLM_F_REPLACE : + cmd == 3 ? NLM_F_CREATE|NLM_F_REPLACE : + 0, argv); + } + return ipaddr_list_or_flush(argv, cmd == 8); } -- 2.1.4 ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox