Re: six patches from tinycore linux
Il giorno gio 12 ago 2021 alle ore 17:15 Lauri Kasanen ha scritto: > On Thu, 12 Aug 2021 16:59:35 +0200 > Emmanuel Deloget wrote: > > > * busybox-1.33.0_tc_depmod.patch : it *seems* that this one solves a > > bug but I cannot wrap my head around it. More particularly, I'm > > wondering if this is a tinycore thing (having modules hidden behind > > symlinks) or if this is a real issue. > > Without it modules behind a symlinked dir aren't found; but again, very > likely just affects TC, so didn't send it. > Following the links is the correct way of doing, in any case. I think it deserves a second thought on this patch and does not bloat at all. -R ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox
Re: six patches from tinycore linux
Il giorno gio 12 ago 2021 alle ore 17:15 Lauri Kasanen ha scritto: > On Thu, 12 Aug 2021 16:59:35 +0200 > Emmanuel Deloget wrote: > > > * busybox-1.33.0_skip-loop-control.patch makes get_free_loop() behave > > as if there was no free loop devices (unconditionnaly). It would help > > to have some background info here, as it does not seem to fix a bug. > > It fixes a specific case of non-devtmpfs + the loop device returned by > loop-control does not exist in /dev yet. The code after in that case is > racy and buggy, but such a combo is rare, probably just us, so we didn't > submit it. > I made a new patch that checks if the devtmpfs is supported otherwise skip the loop control. I have tested the code in simple main() for both cases and in a running busybox without devtmpfs. Cheers, -- Roberto A. Foglietta +39.349.33.30.697 busybox-1.33.0_if-not-devtmpfs-skip-loop-control.patch Description: Binary data ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox
Re: six patches from tinycore linux
On Thu, 12 Aug 2021 16:59:35 +0200 Emmanuel Deloget wrote: > * busybox-1.33.0_skip-loop-control.patch makes get_free_loop() behave > as if there was no free loop devices (unconditionnaly). It would help > to have some background info here, as it does not seem to fix a bug. It fixes a specific case of non-devtmpfs + the loop device returned by loop-control does not exist in /dev yet. The code after in that case is racy and buggy, but such a combo is rare, probably just us, so we didn't submit it. > * busybox-1.27.1-wget-make-default-timeout-configurable.patch does > exactly what it says it does - it makes the default wget timeout a > configurable value. I sent this a long time ago and it was rejected. > * busybox-1.33.0_modprobe.patch checks whether the module is an ELF > bianry before sending it to the kernel. Since the checks that the > kernel performs are more comprehensive, I don't see much value in > adding a simple check of the ELF header here -- not to mention that > the code is duplicated. This silences very loud kernel complaints when using compressed modules IIRC. Was discussed on both here and lkml. > * busybox-1.33.0_tc_depmod.patch : it *seems* that this one solves a > bug but I cannot wrap my head around it. More particularly, I'm > wondering if this is a tinycore thing (having modules hidden behind > symlinks) or if this is a real issue. Without it modules behind a symlinked dir aren't found; but again, very likely just affects TC, so didn't send it. - Lauri ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox
Re: six patches from tinycore linux
Roberto A. Foglietta wrote: >Who is in charge of evaluating patch application? The 'About BusyBox' page on the website says: BusyBox is maintained by Denys Vlasenko [vda.li...@googlemail.com] Cheers, Ron ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox
Re: six patches from tinycore linux
Hello, On Thu, Aug 12, 2021 at 4:01 PM Ron Yorston wrote: > > Roberto A. Foglietta wrote: > >Hi Ron, > > > > what's about the other five? > * busybox-1.33.0_skip-loop-control.patch makes get_free_loop() behave as if there was no free loop devices (unconditionnaly). It would help to have some background info here, as it does not seem to fix a bug. * busybox-1.29.3_root_path.patch adds /usr/local/bin to the list of default PATH ; the whole value can be configured by setting BB_ADDITIONAL_PATH so I'm not sure there is much value here. * busybox-1.27.1-wget-make-default-timeout-configurable.patch does exactly what it says it does - it makes the default wget timeout a configurable value. I agree that the default value of 900 seconds might be a bit surprising. A value in [30, 120] might have been better. I'm not sure whether the good thing to do is to make the value configurable or provide a saner default value (15 minutes? that's a bit long...). Is there a rationale for this very, very long timeout? * busybox-1.33.0_modprobe.patch checks whether the module is an ELF bianry before sending it to the kernel. Since the checks that the kernel performs are more comprehensive, I don't see much value in adding a simple check of the ELF header here -- not to mention that the code is duplicated. * busybox-1.33.0_tc_depmod.patch : it *seems* that this one solves a bug but I cannot wrap my head around it. More particularly, I'm wondering if this is a tinycore thing (having modules hidden behind symlinks) or if this is a real issue. ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox
Re: six patches from tinycore linux
Il giorno gio 12 ago 2021 alle ore 16:01 Ron Yorston ha scritto: > Roberto A. Foglietta wrote: > >Hi Ron, > > > > what's about the other five? > > Well, I can see that they haven't been applied. But other than that > I have no particular insight. Who is in charge of evaluating patch application? I reviewed those patches but I cannot give an ultimate opinion. About this one busybox-1.33.0_skip-loop-control.patch: is useful when devtmpfs is not configured into the kernel For sure it needs some more work in order to check if devtmpfs is supported. The easiest way I know is to check with this 'grep devtmpfs /proc/filesystems'. Do you have a better idea? Cheers, -- Roberto A. Foglietta +39.349.33.30.697 ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox
Re: six patches from tinycore linux
Roberto A. Foglietta wrote: >Hi Ron, > > what's about the other five? Well, I can see that they haven't been applied. But other than that I have no particular insight. Ron ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox
