Re: [PATCH] Add svg to built in MIME types list
Hi Denys, The correct type for JS is 'application/javascript' (without 'x-' prefixed). Cheers, Xabier Oneca_,,_ ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox
Re: [PATCH] Add svg to built in MIME types list
applied, thanks On Thu, Jun 6, 2019 at 5:42 PM Vicente Jiménez wrote: > > Signed-off-by: Vicente Jimenez Aguilar > --- > networking/httpd.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/networking/httpd.c b/networking/httpd.c > index 3f1e02ec8..b09ac0a2f 100644 > --- a/networking/httpd.c > +++ b/networking/httpd.c > @@ -1726,6 +1726,7 @@ static NOINLINE void send_file_and_exit(const > char *url, int what) > ".jpg.jpeg\0" "image/jpeg\0" > ".gif\0" "image/gif\0" > ".png\0" "image/png\0" > + ".svg\0" "image/svg+xml\0" > /* .css line must be after .c line */ > ".css\0" "text/css\0" > ".wav\0" "audio/wav\0" > -- > 2.20.1 > Could not send it directly. So It is attached also. > > -- > saludos > vicente > ___ > busybox mailing list > busybox@busybox.net > http://lists.busybox.net/mailman/listinfo/busybox ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox
Re: [PATCH] Add svg to built in MIME types list
On Fri, 7 Jun 2019 08:36:42 +0200 Xabier Oneca -- xOneca wrote: > (But there's missing js!) I second this. That's the only change I had to make recently to httpd.conf, because FF does not execute JS with the wrong mime type (other browsers do). - Lauri ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox
Re: [PATCH] Add svg to built in MIME types list
Hi Vicente, > ".jpg.jpeg\0" "image/jpeg\0" > ".gif\0" "image/gif\0" > ".png\0" "image/png\0" > + ".svg\0" "image/svg+xml\0" > /* .css line must be after .c line */ > ".css\0" "text/css\0" > ".wav\0" "audio/wav\0" There's a httpd.conf syntax for adding custom extensions. That said, I think SVG *can* be more popular than, e.g. WAV, QT, MOV and MIDI, so I think as it is, it is a good incorporation. (But there's missing js!) I think the embedded list should consist of just common extensions (txt, htm(l), jp(e)g, gif, png, css, js) and everything else is use-case dependant. Maybe an example httpd.conf should be added to 'examples' folder? Just my opinion. Current full list, for context: > ".txt.h.c.cc.cpp\0" "text/plain\0" > ".htm.html\0" "text/html\0" > ".jpg.jpeg\0" "image/jpeg\0" > ".gif\0" "image/gif\0" > ".png\0" "image/png\0" > ".css\0" "text/css\0" > ".wav\0" "audio/wav\0" > ".avi\0" "video/x-msvideo\0" > ".qt.mov\0" "video/quicktime\0" > ".mpe.mpeg\0" "video/mpeg\0" > ".mid.midi\0" "audio/midi\0" > ".mp3\0" "audio/mpeg\0" > #if 0 /* unpopular */ > ".au\0" "audio/basic\0" > ".pac\0" "application/x-ns-proxy-autoconfig\0" > ".vrml.wrl\0" "model/vrml\0" > #endif Cheers, Xabier Oneca_,,_ ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox
[PATCH] Add svg to built in MIME types list
Signed-off-by: Vicente Jimenez Aguilar --- networking/httpd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/networking/httpd.c b/networking/httpd.c index 3f1e02ec8..b09ac0a2f 100644 --- a/networking/httpd.c +++ b/networking/httpd.c @@ -1726,6 +1726,7 @@ static NOINLINE void send_file_and_exit(const char *url, int what) ".jpg.jpeg\0" "image/jpeg\0" ".gif\0" "image/gif\0" ".png\0" "image/png\0" + ".svg\0" "image/svg+xml\0" /* .css line must be after .c line */ ".css\0" "text/css\0" ".wav\0" "audio/wav\0" -- 2.20.1 Could not send it directly. So It is attached also. -- saludos vicente From ea7845e943408f5ee9cd543312449b6411df8103 Mon Sep 17 00:00:00 2001 From: Vicente Jimenez Aguilar Date: Thu, 6 Jun 2019 17:12:55 +0200 Subject: [PATCH] Add svg to built in MIME types list Signed-off-by: Vicente Jimenez Aguilar --- networking/httpd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/networking/httpd.c b/networking/httpd.c index 3f1e02ec8..b09ac0a2f 100644 --- a/networking/httpd.c +++ b/networking/httpd.c @@ -1726,6 +1726,7 @@ static NOINLINE void send_file_and_exit(const char *url, int what) ".jpg.jpeg\0" "image/jpeg\0" ".gif\0" "image/gif\0" ".png\0" "image/png\0" + ".svg\0" "image/svg+xml\0" /* .css line must be after .c line */ ".css\0" "text/css\0" ".wav\0" "audio/wav\0" -- 2.20.1 ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox
