Re: [V2 PATCH] crond: log5 fix typo, replace log level '4' with '5'

[Bernhard Reutner-Fischer]

On Thu, 1 Feb 2024 03:17:09 +
Jones Syue 薛懷宗  wrote:

> Found previous patch accidentally adds 'x' permission to file 'crond.c',
> attached v2 patch would not change permissions of file 'crond.c', 
> thank you :)

Applied, thanks!
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox

Re: [V2 PATCH] crond: log5 fix typo, replace log level '4' with '5'

[Jones Syue 薛懷宗]

Found previous patch accidentally adds 'x' permission to file 'crond.c',
attached v2 patch would not change permissions of file 'crond.c', 
thank you :)

--

Regards,
Jones Syue | 薛懷宗
QNAP Systems, Inc.
From c47cc51d53d1781d615eb27bb57e242ef9842474 Mon Sep 17 00:00:00 2001
From: Jones Syue 
Date: Thu, 1 Feb 2024 11:06:49 +0800
Subject: [PATCH] crond: log5 fix typo, replace log level '4' with '5'

log5() with crondlog(5, msg, va) seems making logging more consistent.

~/git/busybox/scripts/bloat-o-meter ~/busybox_{orig,fix}
function old new   delta
--
(add/remove: 0/0 grow/shrink: 0/0 up/down: 0/0) Total: 0 bytes

Signed-off-by: Jones Syue 
---
 miscutils/crond.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/miscutils/crond.c b/miscutils/crond.c
index 3bbb5ac..b3762d3 100644
--- a/miscutils/crond.c
+++ b/miscutils/crond.c
@@ -190,7 +190,7 @@ static void log5(const char *msg, ...)
 {
va_list va;
va_start(va, msg);
-   crondlog(4, msg, va);
+   crondlog(5, msg, va);
va_end(va);
 }
 
-- 
2.1.4

___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox

[PATCH] crond: log5 fix typo, replace log level '4' with '5'

[Jones Syue 薛懷宗]

Hello list,

Attached is a patch to fix a typo in crond.c log5(),
please take a look and review, thank you :)

--

Regards,
Jones Syue | 薛懷宗
QNAP Systems, Inc.From 86c8516a255657497a9caa5673c08191c90c0397 Mon Sep 17 00:00:00 2001
From: Jones Syue 
Date: Mon, 29 Jan 2024 10:58:41 +0800
Subject: [PATCH] crond: log5 fix typo, replace log level '4' with '5'

log5() with crondlog(5, msg, va) seems making logging more consistent.

function old new   delta
--
(add/remove: 0/0 grow/shrink: 0/0 up/down: 0/0) Total: 0 bytes

Signed-off-by: Jones Syue 
---
 miscutils/crond.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
 mode change 100644 => 100755 miscutils/crond.c

diff --git a/miscutils/crond.c b/miscutils/crond.c
old mode 100644
new mode 100755
index 3bbb5ac..b3762d3
--- a/miscutils/crond.c
+++ b/miscutils/crond.c
@@ -190,7 +190,7 @@ static void log5(const char *msg, ...)
 {
va_list va;
va_start(va, msg);
-   crondlog(4, msg, va);
+   crondlog(5, msg, va);
va_end(va);
 }
 
-- 
2.1.4

___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox