Re: Ash glob symlink regression when using libc glob

2017-10-31 Thread Kang-Che Sung 
On Tue, Oct 31, 2017 at 8:48 PM, Lauri Kasanen  wrote:
>
> So it was fixed after 2.26 and no released glibc contains the fix. How
> about either editing the description to say glibc >= 2.27 only, or even
> checking that compile-time?

I would like to have both. And probably give a preprocessor warning about
this, something like "warning: glibc <2.27 has buggy glob(); enabling
ash internal one"
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox

Re: Ash glob symlink regression when using libc glob

2017-10-31 Thread Lauri Kasanen 
On Tue, 31 Oct 2017 13:34:48 +0100
Denys Vlasenko  wrote:

> > It fails with glibc 2.24 and 2.7, x86 and x86_64, so probably everything
> > between. Are you on a more recent glibc?
> 
> $ /lib64/libc.so.6
> GNU C Library (GNU libc) development release version 2.26.9000.

This looks relevant:
http://sourceware.org/git/?p=glibc.git;a=commit;h=5554304f0dddf75dc27cc6250fc53355161fd16a

So it was fixed after 2.26 and no released glibc contains the fix. How
about either editing the description to say glibc >= 2.27 only, or even
checking that compile-time?

- Lauri
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox

Re: Ash glob symlink regression when using libc glob

2017-10-31 Thread Denys Vlasenko 
On Tue, Oct 31, 2017 at 8:31 AM, Lauri Kasanen  wrote:
> On Mon, 30 Oct 2017 20:24:08 +0100
> Denys Vlasenko  wrote:
>
>> On Sun, Oct 29, 2017 at 7:43 PM, Lauri Kasanen  wrote:
>> > Hi,
>> >
>> > It was reported the following case fails with bb 1.27.2:
>> >
>> > ln -s nonexistent mylink
>> > mv myli* someother
>> >
>> > It also fails with master. I bisected it to
>> > b3f29b452a660a7293162897424bed205f7f9147, "ash: use glob() from libc".
>> > Works with bash.
>>
>> Can't reproduce. myli* does expend for me.
>
> It fails with glibc 2.24 and 2.7, x86 and x86_64, so probably everything
> between. Are you on a more recent glibc?

$ /lib64/libc.so.6
GNU C Library (GNU libc) development release version 2.26.9000.
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox

Re: Ash glob symlink regression when using libc glob

2017-10-31 Thread Lauri Kasanen 
On Mon, 30 Oct 2017 20:24:08 +0100
Denys Vlasenko  wrote:

> On Sun, Oct 29, 2017 at 7:43 PM, Lauri Kasanen  wrote:
> > Hi,
> >
> > It was reported the following case fails with bb 1.27.2:
> >
> > ln -s nonexistent mylink
> > mv myli* someother
> >
> > It also fails with master. I bisected it to
> > b3f29b452a660a7293162897424bed205f7f9147, "ash: use glob() from libc".
> > Works with bash.
> 
> Can't reproduce. myli* does expend for me.

It fails with glibc 2.24 and 2.7, x86 and x86_64, so probably everything
between. Are you on a more recent glibc?

My attached config was from the bisect commit, so applying it directly
to master may cause the wrong value for CONFIG_ASH_INTERNAL_GLOB.

- Lauri
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox

Re: Ash glob symlink regression when using libc glob

2017-10-30 Thread Denys Vlasenko 
On Sun, Oct 29, 2017 at 7:43 PM, Lauri Kasanen  wrote:
> Hi,
>
> It was reported the following case fails with bb 1.27.2:
>
> ln -s nonexistent mylink
> mv myli* someother
>
> It also fails with master. I bisected it to
> b3f29b452a660a7293162897424bed205f7f9147, "ash: use glob() from libc".
> Works with bash.

Can't reproduce. myli* does expend for me.
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox

Ash glob symlink regression when using libc glob

2017-10-29 Thread Lauri Kasanen 
Hi,

It was reported the following case fails with bb 1.27.2:

ln -s nonexistent mylink
mv myli* someother

It also fails with master. I bisected it to
b3f29b452a660a7293162897424bed205f7f9147, "ash: use glob() from libc".
Works with bash.

- Lauri


bb-config.gz
Description: Binary data
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox