Re: [PATCH 0/2] Add -R to less applet (bug #5546)

[Denys Vlasenko]

fixed, thanks

On Wed, Jan 24, 2018 at 7:39 AM, Kang-Che Sung  wrote:
> Hi Denys Vlasenko,
>
> I think I found a typo in the recent commit
> 8528d3d4f8240ab4715f671aa819fe034f0fc285
>
>> @@ -106,7 +122,7 @@
>>
>>  //usage:#define less_trivial_usage
>>  //usage: "[-E" IF_FEATURE_LESS_REGEXP("I")IF_FEATURE_LESS_FLAGS("Mm")
>> -//usage: "N" IF_FEATURE_LESS_TRUNCATE("S") "h~] [FILE]..."
>> +//usage: "N" IF_FEATURE_LESS_TRUNCATE("S") IF_FEATURE_LESS_TRUNCATE("R") 
>> "h~] [FILE]..."
>>  //usage:#define less_full_usage "\n\n"
>>  //usage: "View FILE (or stdin) one screenful at a time\n"
>>  //usage: "\n -E Quit once the end of a file is reached"
>
>
> It shouldn't be IF_FEATURE_LESS_TRUNCATE("R") .
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox

Re: [PATCH 0/2] Add -R to less applet (bug #5546)

[Kang-Che Sung]

Hi Denys Vlasenko,

I think I found a typo in the recent commit
8528d3d4f8240ab4715f671aa819fe034f0fc285

> @@ -106,7 +122,7 @@
>
>  //usage:#define less_trivial_usage
>  //usage: "[-E" IF_FEATURE_LESS_REGEXP("I")IF_FEATURE_LESS_FLAGS("Mm")
> -//usage: "N" IF_FEATURE_LESS_TRUNCATE("S") "h~] [FILE]..."
> +//usage: "N" IF_FEATURE_LESS_TRUNCATE("S") IF_FEATURE_LESS_TRUNCATE("R") 
> "h~] [FILE]..."
>  //usage:#define less_full_usage "\n\n"
>  //usage: "View FILE (or stdin) one screenful at a time\n"
>  //usage: "\n -E Quit once the end of a file is reached"


It shouldn't be IF_FEATURE_LESS_TRUNCATE("R") .
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox

Re: [PATCH 0/2] Add -R to less applet (bug #5546)

[Denys Vlasenko]

On Fri, Jan 19, 2018 at 8:40 PM, Lubomir Rintel  wrote:
> chained are two patches that add make the less applet behave well with
> tools that use coloring and paging at the same time. My first busybox
> patches, so I beg for some understanding if I didn't get things right.
>
> Issues have been reported for nmcli, systemd and git upstreams (perhaps
> more) all of the falling victim to a rather reasonable assumption that
> a thing called "less" behaves like "less" (in support of "-R" option
> in particular). I guess the implausibility of teaching all of the
> affected tools to do some sort of capability assessment of pager's
> capabilities justifies the slight growth in the applet size.

In testing, your patch does not work well when end of line with color
escapes is past the end of screen.

For now I adapted your patches so that less -R just removes color escapes.
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox