[GitHub] [xerces-c] rleigh-codelibre commented on pull request #34: XERCESC-2225: Link to installed CMake targets of CURL
rleigh-codelibre commented on pull request #34: URL: https://github.com/apache/xerces-c/pull/34#issuecomment-923305154 XERCESC-2226 added as a followup action. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[xerces-c] branch master updated: link to installed CMake targets of CURL
This is an automated email from the ASF dual-hosted git repository.
rleigh pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/xerces-c.git
The following commit(s) were added to refs/heads/master by this push:
new af1935b link to installed CMake targets of CURL
new 6b82b24 Merge pull request #34 from prince-chrismc/patch-1
af1935b is described below
commit af1935b567c18c8b2de71d6ea97239be60876335
Author: Chris Mc
AuthorDate: Fri Sep 3 20:21:37 2021 -0400
link to installed CMake targets of CURL
Just like how it was done for ICU
---
src/CMakeLists.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index 344851f..f396fc5 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -1085,7 +1085,7 @@ endif()
if(XERCES_USE_NETACCESSOR_CURL)
list(APPEND libxerces_c_SOURCES ${curl_sources})
list(APPEND libxerces_c_HEADERS ${curl_headers})
- list(APPEND libxerces_c_DEPS ${CURL_LIBRARIES})
+ list(APPEND libxerces_c_DEPS CURL::libcurl)
endif()
if(XERCES_USE_NETACCESSOR_SOCKET)
-
To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org
For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2225) Link to installed CMake targets of CURL
[ https://issues.apache.org/jira/browse/XERCESC-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17417810#comment-17417810 ] Roger Leigh commented on XERCESC-2225: -- XERCESC-2226 added as a followup. > Link to installed CMake targets of CURL > --- > > Key: XERCESC-2225 > URL: https://issues.apache.org/jira/browse/XERCESC-2225 > Project: Xerces-C++ > Issue Type: Bug > Components: Build >Affects Versions: 3.2.3 >Reporter: Roger Leigh >Assignee: Roger Leigh >Priority: Major > > Match ICU behaviour. > https://github.com/apache/xerces-c/pull/34 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Created] (XERCESC-2226) Increment minimum CMake version to 3.12
Roger Leigh created XERCESC-2226: Summary: Increment minimum CMake version to 3.12 Key: XERCESC-2226 URL: https://issues.apache.org/jira/browse/XERCESC-2226 Project: Xerces-C++ Issue Type: Bug Components: Build Affects Versions: 3.2.3 Reporter: Roger Leigh Assignee: Roger Leigh Followup for XERCESC-2225 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Created] (XERCESC-2225) Link to installed CMake targets of CURL
Roger Leigh created XERCESC-2225: Summary: Link to installed CMake targets of CURL Key: XERCESC-2225 URL: https://issues.apache.org/jira/browse/XERCESC-2225 Project: Xerces-C++ Issue Type: Bug Components: Build Affects Versions: 3.2.3 Reporter: Roger Leigh Assignee: Roger Leigh Match ICU behaviour. https://github.com/apache/xerces-c/pull/34 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[GitHub] [xerces-c] rleigh-codelibre merged pull request #37: [XERCESC-2224] DFAContentModel::checkUniqueParticleAttribution (): speed enhancement
rleigh-codelibre merged pull request #37: URL: https://github.com/apache/xerces-c/pull/37 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[GitHub] [xerces-c] rleigh-codelibre commented on pull request #37: [XERCESC-2224] DFAContentModel::checkUniqueParticleAttribution (): speed enhancement
rleigh-codelibre commented on pull request #37: URL: https://github.com/apache/xerces-c/pull/37#issuecomment-923298020 The logic looks perfectly fine to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[xerces-c] branch master updated: DFAContentModel::checkUniqueParticleAttribution (): speed enhancement
This is an automated email from the ASF dual-hosted git repository.
rleigh pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/xerces-c.git
The following commit(s) were added to refs/heads/master by this push:
new 02cec95 DFAContentModel::checkUniqueParticleAttribution (): speed
enhancement
new c0b90c2 Merge pull request #37 from
rouault/faster_checkUniqueParticleAttribution
02cec95 is described below
commit 02cec9524882815db078fa5fb7486762928a4d3d
Author: Even Rouault
AuthorDate: Mon Sep 20 11:59:45 2021 +0200
DFAContentModel::checkUniqueParticleAttribution (): speed enhancement
The complexity of this method is roughly O(n^3). Fuzzers can generate
schemas with n = several thousands. The test fTransTable[i][j] ==
XMLContentModel::gInvalidTrans
is independant of the k loop, and can thus being moved at a upper level
to improve runtime.
---
src/xercesc/validators/common/DFAContentModel.cpp | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/xercesc/validators/common/DFAContentModel.cpp
b/src/xercesc/validators/common/DFAContentModel.cpp
index 2f590fe..5030565 100644
--- a/src/xercesc/validators/common/DFAContentModel.cpp
+++ b/src/xercesc/validators/common/DFAContentModel.cpp
@@ -1642,9 +1642,10 @@ void DFAContentModel::checkUniqueParticleAttribution
(SchemaGrammar*const pG
// for each state, check whether it has overlap transitions
for (i = 0; i < fTransTableSize; i++) {
for (j = 0; j < fElemMapSize; j++) {
+if (fTransTable[i][j] == XMLContentModel::gInvalidTrans)
+continue;
for (k = j+1; k < fElemMapSize; k++) {
-if (fTransTable[i][j] != XMLContentModel::gInvalidTrans &&
-fTransTable[i][k] != XMLContentModel::gInvalidTrans &&
+if (fTransTable[i][k] != XMLContentModel::gInvalidTrans &&
conflictTable[j][k] == 0) {
// If this is text in a Schema mixed content model, skip
it.
-
To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org
For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Created] (XERCESC-2224) DFAContentModel::checkUniqueParticleAttribution (): speed enhancement
Even Rouault created XERCESC-2224: - Summary: DFAContentModel::checkUniqueParticleAttribution (): speed enhancement Key: XERCESC-2224 URL: https://issues.apache.org/jira/browse/XERCESC-2224 Project: Xerces-C++ Issue Type: Improvement Reporter: Even Rouault The complexity of this method is roughly O(n^3). Fuzzers can generate schemas with n = several thousands. The test fTransTable[i][j] == XMLContentModel::gInvalidTrans is independant of the k loop, and can thus being moved at a upper level to improve runtime. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[GitHub] [xerces-c] rouault opened a new pull request #37: DFAContentModel::checkUniqueParticleAttribution (): speed enhancement
rouault opened a new pull request #37: URL: https://github.com/apache/xerces-c/pull/37 The complexity of this method is roughly O(n^3). Fuzzers can generate schemas with n = several thousands. The test fTransTable[i][j] == XMLContentModel::gInvalidTrans is independant of the k loop, and can thus being moved at a upper level to improve runtime. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
