[GitHub] [xerces-c] rleigh-codelibre commented on pull request #46: DTD hot fix

2022-01-23 Thread GitBox 


rleigh-codelibre commented on pull request #46:
URL: https://github.com/apache/xerces-c/pull/46#issuecomment-1019437334


   @rouault Did this problem surface with any of your recent work identifying 
memory bugs?  Do you have any thoughts on the change being proposed and the 
test failure?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org
For additional commands, e-mail: c-dev-h...@xerces.apache.org

[GitHub] [xerces-c] rleigh-codelibre commented on pull request #46: DTD hot fix

2022-01-23 Thread GitBox 


rleigh-codelibre commented on pull request #46:
URL: https://github.com/apache/xerces-c/pull/46#issuecomment-1019436958


   There is also a unit test failure, which needs investigation.  If there 
isn't a logic error in the PR, the corresponding unit tests might need updating 
to match.
   
   ```
   33: Test command: /usr/local/cmake-3.12.4/bin/cmake "-DNAME=MemHandlerTest1" 
"-DPROGRAM=/home/travis/build/apache/xerces-c/cmake-build/tests/MemHandlerTest" 
"-DARGS=-v=always;-n;-r=2;personal.xml" 
"-DLIBXERCES_C=/home/travis/build/apache/xerces-c/cmake-build/src/libxerces-c-4.0.so"
 "-DWORKDIR=/home/travis/build/apache/xerces-c/samples/data" "-DSTDIN=" 
"-DEXPECT_FAIL=FALSE" 
"-DOBSERVED_DIR=/home/travis/build/apache/xerces-c/cmake-build/tests/observed" 
"-DEXPECTED_DIR=/home/travis/build/apache/xerces-c/tests/expected" 
"-DDIFF=/usr/bin/diff" 
"-DNLS_HOME=/home/travis/build/apache/xerces-c/cmake-build/src" "-P" 
"/home/travis/build/apache/xerces-c/cmake/RunTest.cmake"
   33: Test timeout computed to be: 1000
   33: -- Running 
/home/travis/build/apache/xerces-c/cmake-build/tests/MemHandlerTest -v=always 
-n -r=2 personal.xml
   33: --- 
/home/travis/build/apache/xerces-c/cmake-build/tests/observed/MemHandlerTest1-exp.log
2022-01-21 15:42:13.453749473 +
   33: +++ 
/home/travis/build/apache/xerces-c/cmake-build/tests/observed/MemHandlerTest1.log
2022-01-21 15:42:13.449749191 +
   33: @@ -1,4 +1,4 @@
   33: -At destruction, domBuilderMemMonitor has 0 bytes.
   33: -At destruction, sax2MemMonitor has 0 bytes.
   33: -At destruction, sax1MemMonitor has 0 bytes.
   33: +At destruction, domBuilderMemMonitor has 276 bytes.
   33: +At destruction, sax2MemMonitor has 276 bytes.
   33: +At destruction, sax1MemMonitor has 276 bytes.
   33:  At destruction, staticMemMonitor has 0 bytes.
   33: CMake Error at /home/travis/build/apache/xerces-c/cmake/RunTest.cmake:71 
(message):
   33:   Observed output does not match expected output
   33: Call Stack (most recent call first):
   33:   /home/travis/build/apache/xerces-c/cmake/RunTest.cmake:88 
(test_command)
   33: 
   33: 
   33/79 Test #33: MemHandlerTest1 ..***Failed0.02 sec
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org
For additional commands, e-mail: c-dev-h...@xerces.apache.org

[GitHub] [xerces-c] rleigh-codelibre commented on pull request #46: DTD hot fix

2022-01-20 Thread GitBox 


rleigh-codelibre commented on pull request #46:
URL: https://github.com/apache/xerces-c/pull/46#issuecomment-1017961677


   @johnjamesmccann Thanks for opening this PR.  The changes appear as an 
addition of two new files at the toplevel, rather than as a change to the 
original files.  Please could you update this to add the changes in the correct 
directory so that the original files are updated?  Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org
For additional commands, e-mail: c-dev-h...@xerces.apache.org