[jira] [Commented] (XERCESC-2190) deprecated GetVersionEx
[
https://issues.apache.org/jira/browse/XERCESC-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17073112#comment-17073112
]
Scott Cantor commented on XERCESC-2190:
---
Officially, there's no question here, we're not supporting any EOL Windows
versions. I'm not trying to waffle on that at all. I would suggest if there's a
3.3 you just pull the offending code at that point if it makes life easier.
Re: RHEL, my RPMs have to build clean and install clean on the stock platform.
I do think all the C++ is now in my hands, so the install might be clean, but
my build at present doesn't have any ability to incorporate a non-stock
compiler at build time. That may change but not likely any sooner than November
when it goes EOL.
> deprecated GetVersionEx
> ---
>
> Key: XERCESC-2190
> URL: https://issues.apache.org/jira/browse/XERCESC-2190
> Project: Xerces-C++
> Issue Type: Bug
>Affects Versions: 3.2.2
>Reporter: Aleksey Dobrunov
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Hello.
> *"GetVersionEx* may be altered or unavailable for releases after Windows 8.1.
> Instead, use the [Version Helper
> functions"|https://docs.microsoft.com/windows/desktop/SysInfo/version-helper-apis]
>
> [https://docs.microsoft.com/en-us/windows/win32/api/sysinfoapi/nf-sysinfoapi-getversionexa]
> .
> {code:java}
> C:\Work\code\xerces-c\src\xercesc\util\Transcoders\Win32\Win32TransService.cpp(323):
> warning C4996: 'GetVersionExA': was declared deprecated
> C:\Program Files (x86)\Windows
> Kits\10\include\10.0.18362.0\um\sysinfoapi.h(387): note: see declaration of
> 'GetVersionExA'
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org
For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2190) deprecated GetVersionEx
[
https://issues.apache.org/jira/browse/XERCESC-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17073107#comment-17073107
]
Roger Leigh commented on XERCESC-2190:
--
Yes, I was surprised when I went to check on Server 2008 R2 in more detail.
It's not that long since I had to support it either.
For RHEL6, I used to use devtoolset-8 for development on this platform. It's
definitely a viable option for users who need to target it.
I'm certainly not suggesting deliberately ripping support for older platform
out just for the sake of it. But I do feel that given the development
constraints we are working under, it would be good to be realistic about what
is effectively supportable, and what is absolutely unsupportable, and there are
quite a few platforms which I do feel are not reasonable to support in any
capacity. I'd say Windows Vista and below fall in that category. Windows 7 is
hanging on by a thread but realistically I can't test on it any longer; I've
been forced onto Windows 10 and VS2017/VS2019, and Server 2016. AppVeyor can
be used to test on other compilers up to a point, but debugging and more
extensive testing aren't possible.
> deprecated GetVersionEx
> ---
>
> Key: XERCESC-2190
> URL: https://issues.apache.org/jira/browse/XERCESC-2190
> Project: Xerces-C++
> Issue Type: Bug
>Affects Versions: 3.2.2
>Reporter: Aleksey Dobrunov
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Hello.
> *"GetVersionEx* may be altered or unavailable for releases after Windows 8.1.
> Instead, use the [Version Helper
> functions"|https://docs.microsoft.com/windows/desktop/SysInfo/version-helper-apis]
>
> [https://docs.microsoft.com/en-us/windows/win32/api/sysinfoapi/nf-sysinfoapi-getversionexa]
> .
> {code:java}
> C:\Work\code\xerces-c\src\xercesc\util\Transcoders\Win32\Win32TransService.cpp(323):
> warning C4996: 'GetVersionExA': was declared deprecated
> C:\Program Files (x86)\Windows
> Kits\10\include\10.0.18362.0\um\sysinfoapi.h(387): note: see declaration of
> 'GetVersionExA'
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org
For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2190) deprecated GetVersionEx
[
https://issues.apache.org/jira/browse/XERCESC-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17073036#comment-17073036
]
Scott Cantor commented on XERCESC-2190:
---
Yes, I'm very clear about what's supported and it's a really small list, and
the Windows policy is exactly that.
For the record, Server 2008 is not EOL. It's fully supported in Azure, which
means there's nothing about it that's not supported other than the blackmail by
MS to move people to their cloud. As a platform, nothing's really changed for
my projects, it remains supported.
I personally only support the compiler I use, which is 2017 at the moment. As a
project I don't have an opinion other than to say I can't spend any time on
issues on any other compiler, so either somebody else has to or it needs to be
clear that that's all that's supported.
My point re: this change is just that I don't see a huge win or any sort of
"cleanup" gained from ripping the code out and breaking the unsupported
versions. I'm not saying we should support older versions, but that's not the
same as breaking them. But if you feel strongly I'm fine with it.
Re: C++11, RHEL6 is something I have to support and it doesn't have a GCC new
enough. I build on some older but don't officially support them so breaking
them isn't fatal but I do have to support 6. It does sunset this year though so
that may not be a dealbreaker.
> deprecated GetVersionEx
> ---
>
> Key: XERCESC-2190
> URL: https://issues.apache.org/jira/browse/XERCESC-2190
> Project: Xerces-C++
> Issue Type: Bug
>Affects Versions: 3.2.2
>Reporter: Aleksey Dobrunov
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Hello.
> *"GetVersionEx* may be altered or unavailable for releases after Windows 8.1.
> Instead, use the [Version Helper
> functions"|https://docs.microsoft.com/windows/desktop/SysInfo/version-helper-apis]
>
> [https://docs.microsoft.com/en-us/windows/win32/api/sysinfoapi/nf-sysinfoapi-getversionexa]
> .
> {code:java}
> C:\Work\code\xerces-c\src\xercesc\util\Transcoders\Win32\Win32TransService.cpp(323):
> warning C4996: 'GetVersionExA': was declared deprecated
> C:\Program Files (x86)\Windows
> Kits\10\include\10.0.18362.0\um\sysinfoapi.h(387): note: see declaration of
> 'GetVersionExA'
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org
For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2190) deprecated GetVersionEx
[
https://issues.apache.org/jira/browse/XERCESC-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17073023#comment-17073023
]
Scott Cantor commented on XERCESC-2190:
---
Yes, I'm very clear about what's supported and it's a really small list, and
the Windows policy is exactly that.
For the record, Server 2008 is not EOL. It's fully supported in Azure, which
means there's nothing about it that's not supported other than the blackmail by
MS to move people to their cloud. As a platform, nothing's really changed for
my projects, it remains supported.
I personally only support the compiler I use, which is 2017 at the moment. As a
project I don't have an opinion other than to say I can't spend any time on
issues on any other compiler, so either somebody else has to or it needs to be
clear that that's all that's supported.
My point re: this change is just that I don't see a huge win or any sort of
"cleanup" gained from ripping the code out and breaking the unsupported
versions. I'm not saying we should support older versions, but that's not the
same as breaking them. But if you feel strongly I'm fine with it.
Re: C++11, I don't know offhand. I have not moved any of my code to any
C++11-only areas but that doesn't mean I couldn't, I would have to review the
compiler history and platforms. I'm very boost-heavy in my code if I need
something newish because I can get that everywhere I need it.
> deprecated GetVersionEx
> ---
>
> Key: XERCESC-2190
> URL: https://issues.apache.org/jira/browse/XERCESC-2190
> Project: Xerces-C++
> Issue Type: Bug
>Affects Versions: 3.2.2
>Reporter: Aleksey Dobrunov
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Hello.
> *"GetVersionEx* may be altered or unavailable for releases after Windows 8.1.
> Instead, use the [Version Helper
> functions"|https://docs.microsoft.com/windows/desktop/SysInfo/version-helper-apis]
>
> [https://docs.microsoft.com/en-us/windows/win32/api/sysinfoapi/nf-sysinfoapi-getversionexa]
> .
> {code:java}
> C:\Work\code\xerces-c\src\xercesc\util\Transcoders\Win32\Win32TransService.cpp(323):
> warning C4996: 'GetVersionExA': was declared deprecated
> C:\Program Files (x86)\Windows
> Kits\10\include\10.0.18362.0\um\sysinfoapi.h(387): note: see declaration of
> 'GetVersionExA'
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org
For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2190) deprecated GetVersionEx
[
https://issues.apache.org/jira/browse/XERCESC-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17073003#comment-17073003
]
Roger Leigh commented on XERCESC-2190:
--
I think that as a project we should have a clearly supported list of platforms
and compilers which we target, and be very clear about what isn't supported.
When it comes to Windows, I'd personally cut it off when Microsoft stop
supporting it completely. I've generally used their support page for this.
For example:
https://support.microsoft.com/en-us/help/13853/windows-lifecycle-fact-sheet By
this page, the final Windows 7 release went out of support in January, and also
so did the server version Windows 2008R2. This leaves us with Windows 8.1 and
10 to support.
On top of this, there are the corresponding Visual Studio versions which
support these releases. For these two major versions, that includes VS2013,
VS2015, VS2017 and VS2019. In other projects, I target a maximum of three
Visual Studio releases simply due to the logistics of testing and supporting
several versions. For Xerces-C, I'd suggest that as the maximum due to the
manpower available. That would give use a VS2015 baseline.
For 3.3, if that sounds reasonable, I'd like to make that official. Similarly,
making C++11 the minimum on all platforms would be something to consider, given
that at this point it's available almost universally.
> deprecated GetVersionEx
> ---
>
> Key: XERCESC-2190
> URL: https://issues.apache.org/jira/browse/XERCESC-2190
> Project: Xerces-C++
> Issue Type: Bug
>Affects Versions: 3.2.2
>Reporter: Aleksey Dobrunov
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Hello.
> *"GetVersionEx* may be altered or unavailable for releases after Windows 8.1.
> Instead, use the [Version Helper
> functions"|https://docs.microsoft.com/windows/desktop/SysInfo/version-helper-apis]
>
> [https://docs.microsoft.com/en-us/windows/win32/api/sysinfoapi/nf-sysinfoapi-getversionexa]
> .
> {code:java}
> C:\Work\code\xerces-c\src\xercesc\util\Transcoders\Win32\Win32TransService.cpp(323):
> warning C4996: 'GetVersionExA': was declared deprecated
> C:\Program Files (x86)\Windows
> Kits\10\include\10.0.18362.0\um\sysinfoapi.h(387): note: see declaration of
> 'GetVersionExA'
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org
For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2190) deprecated GetVersionEx
[
https://issues.apache.org/jira/browse/XERCESC-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17072989#comment-17072989
]
Scott Cantor commented on XERCESC-2190:
---
I definitely agree *for my purposes* but my point was that I tend not to
introduce changes that don't actually fix an issue *and* end up changing where
the code will run if I don't have a reason to do it.
In this case, I would say to leave it and if/when GetVersionEx does disappear
and start causing real problems on supported platforms, we can have a record
that it's safe to just yank.
So I think we have what we need but no reason to do anything at this time.
But as I say, that's just my perspective on how to deal with these kinds of
issues.
> deprecated GetVersionEx
> ---
>
> Key: XERCESC-2190
> URL: https://issues.apache.org/jira/browse/XERCESC-2190
> Project: Xerces-C++
> Issue Type: Bug
>Affects Versions: 3.2.2
>Reporter: Aleksey Dobrunov
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Hello.
> *"GetVersionEx* may be altered or unavailable for releases after Windows 8.1.
> Instead, use the [Version Helper
> functions"|https://docs.microsoft.com/windows/desktop/SysInfo/version-helper-apis]
>
> [https://docs.microsoft.com/en-us/windows/win32/api/sysinfoapi/nf-sysinfoapi-getversionexa]
> .
> {code:java}
> C:\Work\code\xerces-c\src\xercesc\util\Transcoders\Win32\Win32TransService.cpp(323):
> warning C4996: 'GetVersionExA': was declared deprecated
> C:\Program Files (x86)\Windows
> Kits\10\include\10.0.18362.0\um\sysinfoapi.h(387): note: see declaration of
> 'GetVersionExA'
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org
For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2190) deprecated GetVersionEx
[
https://issues.apache.org/jira/browse/XERCESC-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17072987#comment-17072987
]
Roger Leigh commented on XERCESC-2190:
--
I checked both call sites.
WindowsFileMgr.cpp: Used to check if on NT or not. Can be dropped entirely (I
doubt anyone cares about Windows 9x at this point)
Win32TransService: Used to check if on XP or later. Can be dropped entirely
(even XP is obsolete and unsupported at this point)
So both should be completely safe to drop. They are only needed for Win9x and
Win2000 respectively.
> deprecated GetVersionEx
> ---
>
> Key: XERCESC-2190
> URL: https://issues.apache.org/jira/browse/XERCESC-2190
> Project: Xerces-C++
> Issue Type: Bug
>Affects Versions: 3.2.2
>Reporter: Aleksey Dobrunov
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Hello.
> *"GetVersionEx* may be altered or unavailable for releases after Windows 8.1.
> Instead, use the [Version Helper
> functions"|https://docs.microsoft.com/windows/desktop/SysInfo/version-helper-apis]
>
> [https://docs.microsoft.com/en-us/windows/win32/api/sysinfoapi/nf-sysinfoapi-getversionexa]
> .
> {code:java}
> C:\Work\code\xerces-c\src\xercesc\util\Transcoders\Win32\Win32TransService.cpp(323):
> warning C4996: 'GetVersionExA': was declared deprecated
> C:\Program Files (x86)\Windows
> Kits\10\include\10.0.18362.0\um\sysinfoapi.h(387): note: see declaration of
> 'GetVersionExA'
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org
For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2190) deprecated GetVersionEx
[
https://issues.apache.org/jira/browse/XERCESC-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17072934#comment-17072934
]
Scott Cantor commented on XERCESC-2190:
---
I wouldn't be prepared to make a unilateral decision for the project that
support for anything older be dropped. I don't personally need it but I can't
speak for others.
> deprecated GetVersionEx
> ---
>
> Key: XERCESC-2190
> URL: https://issues.apache.org/jira/browse/XERCESC-2190
> Project: Xerces-C++
> Issue Type: Bug
>Affects Versions: 3.2.2
>Reporter: Aleksey Dobrunov
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Hello.
> *"GetVersionEx* may be altered or unavailable for releases after Windows 8.1.
> Instead, use the [Version Helper
> functions"|https://docs.microsoft.com/windows/desktop/SysInfo/version-helper-apis]
>
> [https://docs.microsoft.com/en-us/windows/win32/api/sysinfoapi/nf-sysinfoapi-getversionexa]
> .
> {code:java}
> C:\Work\code\xerces-c\src\xercesc\util\Transcoders\Win32\Win32TransService.cpp(323):
> warning C4996: 'GetVersionExA': was declared deprecated
> C:\Program Files (x86)\Windows
> Kits\10\include\10.0.18362.0\um\sysinfoapi.h(387): note: see declaration of
> 'GetVersionExA'
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org
For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2190) deprecated GetVersionEx
[
https://issues.apache.org/jira/browse/XERCESC-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026898#comment-17026898
]
Aleksey Dobrunov commented on XERCESC-2190:
---
pull request https://github.com/apache/xerces-c/pull/4
> deprecated GetVersionEx
> ---
>
> Key: XERCESC-2190
> URL: https://issues.apache.org/jira/browse/XERCESC-2190
> Project: Xerces-C++
> Issue Type: Bug
>Affects Versions: 3.2.2
>Reporter: Aleksey Dobrunov
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Hello.
> *"GetVersionEx* may be altered or unavailable for releases after Windows 8.1.
> Instead, use the [Version Helper
> functions"|https://docs.microsoft.com/windows/desktop/SysInfo/version-helper-apis]
>
> [https://docs.microsoft.com/en-us/windows/win32/api/sysinfoapi/nf-sysinfoapi-getversionexa]
> .
> {code:java}
> C:\Work\code\xerces-c\src\xercesc\util\Transcoders\Win32\Win32TransService.cpp(323):
> warning C4996: 'GetVersionExA': was declared deprecated
> C:\Program Files (x86)\Windows
> Kits\10\include\10.0.18362.0\um\sysinfoapi.h(387): note: see declaration of
> 'GetVersionExA'
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org
For additional commands, e-mail: c-dev-h...@xerces.apache.org
