[jira] [Commented] (XERCESC-2194) Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t
[ https://issues.apache.org/jira/browse/XERCESC-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17072926#comment-17072926 ] Scott Cantor commented on XERCESC-2194: --- Master: aacdef3fa74bea84ff1ff4cd699782bcc080873f 3.2 branch: 526624138f1f755688510908b996d9601a2ed69d I can't do anything with the pull request but it should be removed. > Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t > -- > > Key: XERCESC-2194 > URL: https://issues.apache.org/jira/browse/XERCESC-2194 > Project: Xerces-C++ > Issue Type: Bug > Components: Build >Affects Versions: 3.2.2 >Reporter: Rasmus Thomsen >Assignee: Scott Cantor >Priority: Major > Fix For: 3.2.3 > > > When including Xerces_autoconf_config.hpp on Windows the following error > messages: > > {code:cpp} > error C4430: Fehlender Typspezifizierer - int wird angenommen. Hinweis: > "default-int" wird von C++ nicht unterstützt. > error C2146: Syntaxfehler: Fehlendes ";" vor Bezeichner "XMLSSize_t" > {code} > (Sorry that these are in German - they translate to "Missing type specifier - > assuming int" and "syntax error: missing ";" before identifier "XMLSSize_t") > Apparently ssize_t is a POSIX extension and as such isn't available in MSVC > (by default?) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2194) Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t
[ https://issues.apache.org/jira/browse/XERCESC-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17053133#comment-17053133 ] Rasmus Thomsen commented on XERCESC-2194: - https://github.com/apache/xerces-c/pull/8 > Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t > -- > > Key: XERCESC-2194 > URL: https://issues.apache.org/jira/browse/XERCESC-2194 > Project: Xerces-C++ > Issue Type: Bug > Components: Build >Affects Versions: 3.2.2 >Reporter: Rasmus Thomsen >Assignee: Scott Cantor >Priority: Major > Fix For: 3.2.3 > > > When including Xerces_autoconf_config.hpp on Windows the following error > messages: > > {code:cpp} > error C4430: Fehlender Typspezifizierer - int wird angenommen. Hinweis: > "default-int" wird von C++ nicht unterstützt. > error C2146: Syntaxfehler: Fehlendes ";" vor Bezeichner "XMLSSize_t" > {code} > (Sorry that these are in German - they translate to "Missing type specifier - > assuming int" and "syntax error: missing ";" before identifier "XMLSSize_t") > Apparently ssize_t is a POSIX extension and as such isn't available in MSVC > (by default?) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2194) Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t
[ https://issues.apache.org/jira/browse/XERCESC-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17053130#comment-17053130 ] Rasmus Thomsen commented on XERCESC-2194: - So I just tested this on our Windows machine and it appears that SIZE_OF_SSIZE_T is an empty string, but somehow CMake still evaluates that as true (?). We're using CMake 3.12.1. I'll open a PR for it :) > Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t > -- > > Key: XERCESC-2194 > URL: https://issues.apache.org/jira/browse/XERCESC-2194 > Project: Xerces-C++ > Issue Type: Bug > Components: Build >Affects Versions: 3.2.2 >Reporter: Rasmus Thomsen >Assignee: Scott Cantor >Priority: Major > Fix For: 3.2.3 > > > When including Xerces_autoconf_config.hpp on Windows the following error > messages: > > {code:cpp} > error C4430: Fehlender Typspezifizierer - int wird angenommen. Hinweis: > "default-int" wird von C++ nicht unterstützt. > error C2146: Syntaxfehler: Fehlendes ";" vor Bezeichner "XMLSSize_t" > {code} > (Sorry that these are in German - they translate to "Missing type specifier - > assuming int" and "syntax error: missing ";" before identifier "XMLSSize_t") > Apparently ssize_t is a POSIX extension and as such isn't available in MSVC > (by default?) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2194) Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t
[ https://issues.apache.org/jira/browse/XERCESC-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052442#comment-17052442 ] Roger Leigh commented on XERCESC-2194: -- Looking at https://cmake.org/cmake/help/v3.16/module/CheckTypeSize.html I agree that HAVE_ should be fine. However, I'm curious as to why the existing logic is not working for you. What is the value of SIZEOF_SSIZE_T if you print it out? Both "" and 0 should evaluate to false. That's my understanding of https://cmake.org/cmake/help/v3.0/command/if.html HAVE_ was present back to CMake 3.0, so there are no compatibility concerns to switching over. If you want to open a PR, I'll be happy to test. > Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t > -- > > Key: XERCESC-2194 > URL: https://issues.apache.org/jira/browse/XERCESC-2194 > Project: Xerces-C++ > Issue Type: Bug > Components: Build >Affects Versions: 3.2.2 >Reporter: Rasmus Thomsen >Assignee: Scott Cantor >Priority: Major > Fix For: 3.2.3 > > > When including Xerces_autoconf_config.hpp on Windows the following error > messages: > > {code:cpp} > error C4430: Fehlender Typspezifizierer - int wird angenommen. Hinweis: > "default-int" wird von C++ nicht unterstützt. > error C2146: Syntaxfehler: Fehlendes ";" vor Bezeichner "XMLSSize_t" > {code} > (Sorry that these are in German - they translate to "Missing type specifier - > assuming int" and "syntax error: missing ";" before identifier "XMLSSize_t") > Apparently ssize_t is a POSIX extension and as such isn't available in MSVC > (by default?) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2194) Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t
[ https://issues.apache.org/jira/browse/XERCESC-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052225#comment-17052225 ] Rasmus Thomsen commented on XERCESC-2194: - Ah, sorry if it seemed otherwise but my proposed fix isn't tested yet - that was mostly what I read out of the CMake docs. I'll go ahead and test it tomorrow and submit a change if it works. Thanks for the help already! :) > Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t > -- > > Key: XERCESC-2194 > URL: https://issues.apache.org/jira/browse/XERCESC-2194 > Project: Xerces-C++ > Issue Type: Bug > Components: Build >Affects Versions: 3.2.2 >Reporter: Rasmus Thomsen >Assignee: Scott Cantor >Priority: Major > Fix For: 3.2.3 > > > When including Xerces_autoconf_config.hpp on Windows the following error > messages: > > {code:cpp} > error C4430: Fehlender Typspezifizierer - int wird angenommen. Hinweis: > "default-int" wird von C++ nicht unterstützt. > error C2146: Syntaxfehler: Fehlendes ";" vor Bezeichner "XMLSSize_t" > {code} > (Sorry that these are in German - they translate to "Missing type specifier - > assuming int" and "syntax error: missing ";" before identifier "XMLSSize_t") > Apparently ssize_t is a POSIX extension and as such isn't available in MSVC > (by default?) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2194) Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t
[ https://issues.apache.org/jira/browse/XERCESC-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1705#comment-1705 ] Scott Cantor commented on XERCESC-2194: --- I don't generally touch CMake, and will never do so do for any non-Windows builds but if the change fixes your issue and does not break my build I probably would consider applying it. > Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t > -- > > Key: XERCESC-2194 > URL: https://issues.apache.org/jira/browse/XERCESC-2194 > Project: Xerces-C++ > Issue Type: Bug > Components: Build >Affects Versions: 3.2.2 >Reporter: Rasmus Thomsen >Priority: Major > > When including Xerces_autoconf_config.hpp on Windows the following error > messages: > > {code:cpp} > error C4430: Fehlender Typspezifizierer - int wird angenommen. Hinweis: > "default-int" wird von C++ nicht unterstützt. > error C2146: Syntaxfehler: Fehlendes ";" vor Bezeichner "XMLSSize_t" > {code} > (Sorry that these are in German - they translate to "Missing type specifier - > assuming int" and "syntax error: missing ";" before identifier "XMLSSize_t") > Apparently ssize_t is a POSIX extension and as such isn't available in MSVC > (by default?) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2194) Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t
[ https://issues.apache.org/jira/browse/XERCESC-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052212#comment-17052212 ] Rasmus Thomsen commented on XERCESC-2194: - According to [the CMake docs|https://cmake.org/cmake/help/v3.17/module/CheckTypeSize.html?highlight=i] it might be a better idea to use {code}HAVE_${TYPE}{code} in XercesIntTypes.cmake instead of SIZEOF_SSIZE_T to determine if it's available: {code:diff} -if(SIZEOF_SIZE_T) +if(HAVE_SIZEOF_OFF_T) set(XERCES_SIZE_T size_t) set(XERCES_SIZE_MAX SIZE_MAX) else() set(XERCES_SIZE_T "unsigned long") set(XERCES_SIZE_MAX ULONG_MAX) endif() -if(SIZEOF_SSIZE_T) +if(HAVE_ssize_t) set(XERCES_SSIZE_T SIZEOF_SSIZE_T) set(XERCES_SSIZE_MAX SSIZE_MAX) else() set(XERCES_SSIZE_T long) set(XERCES_SSIZE_MAX LONG_MAX) endif() {code} Or something along those lines? > Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t > -- > > Key: XERCESC-2194 > URL: https://issues.apache.org/jira/browse/XERCESC-2194 > Project: Xerces-C++ > Issue Type: Bug > Components: Build >Affects Versions: 3.2.2 >Reporter: Rasmus Thomsen >Priority: Major > > When including Xerces_autoconf_config.hpp on Windows the following error > messages: > > {code:cpp} > error C4430: Fehlender Typspezifizierer - int wird angenommen. Hinweis: > "default-int" wird von C++ nicht unterstützt. > error C2146: Syntaxfehler: Fehlendes ";" vor Bezeichner "XMLSSize_t" > {code} > (Sorry that these are in German - they translate to "Missing type specifier - > assuming int" and "syntax error: missing ";" before identifier "XMLSSize_t") > Apparently ssize_t is a POSIX extension and as such isn't available in MSVC > (by default?) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2194) Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t
[ https://issues.apache.org/jira/browse/XERCESC-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052206#comment-17052206 ] Rasmus Thomsen commented on XERCESC-2194: - Hm, CMake does check for ssize_t and recognizes that it's not available: {code}-- Check size of ssize_t - failed{code} but we still end up with ssize_t in our builds. We're building from the 3.2.2 Git tag. We use MSVC version 19.14.26428.1 > Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t > -- > > Key: XERCESC-2194 > URL: https://issues.apache.org/jira/browse/XERCESC-2194 > Project: Xerces-C++ > Issue Type: Bug > Components: Build >Affects Versions: 3.2.2 >Reporter: Rasmus Thomsen >Priority: Major > > When including Xerces_autoconf_config.hpp on Windows the following error > messages: > > {code:cpp} > error C4430: Fehlender Typspezifizierer - int wird angenommen. Hinweis: > "default-int" wird von C++ nicht unterstützt. > error C2146: Syntaxfehler: Fehlendes ";" vor Bezeichner "XMLSSize_t" > {code} > (Sorry that these are in German - they translate to "Missing type specifier - > assuming int" and "syntax error: missing ";" before identifier "XMLSSize_t") > Apparently ssize_t is a POSIX extension and as such isn't available in MSVC > (by default?) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2194) Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t
[ https://issues.apache.org/jira/browse/XERCESC-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052151#comment-17052151 ] Scott Cantor commented on XERCESC-2194: --- Ack, and same goes for VS2017. > Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t > -- > > Key: XERCESC-2194 > URL: https://issues.apache.org/jira/browse/XERCESC-2194 > Project: Xerces-C++ > Issue Type: Bug > Components: Build >Affects Versions: 3.2.2 >Reporter: Rasmus Thomsen >Priority: Major > > When including Xerces_autoconf_config.hpp on Windows the following error > messages: > > {code:cpp} > error C4430: Fehlender Typspezifizierer - int wird angenommen. Hinweis: > "default-int" wird von C++ nicht unterstützt. > error C2146: Syntaxfehler: Fehlendes ";" vor Bezeichner "XMLSSize_t" > {code} > (Sorry that these are in German - they translate to "Missing type specifier - > assuming int" and "syntax error: missing ";" before identifier "XMLSSize_t") > Apparently ssize_t is a POSIX extension and as such isn't available in MSVC > (by default?) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2194) Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t
[ https://issues.apache.org/jira/browse/XERCESC-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052139#comment-17052139 ] Scott Morgan commented on XERCESC-2194: --- It's generated by CMake, and should define XMLSSize_t to long, via a XERCES_SSIZE_T define in all in that file Or at least that's what it does on my system. > Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t > -- > > Key: XERCESC-2194 > URL: https://issues.apache.org/jira/browse/XERCESC-2194 > Project: Xerces-C++ > Issue Type: Bug > Components: Build >Affects Versions: 3.2.2 >Reporter: Rasmus Thomsen >Priority: Major > > When including Xerces_autoconf_config.hpp on Windows the following error > messages: > > {code:cpp} > error C4430: Fehlender Typspezifizierer - int wird angenommen. Hinweis: > "default-int" wird von C++ nicht unterstützt. > error C2146: Syntaxfehler: Fehlendes ";" vor Bezeichner "XMLSSize_t" > {code} > (Sorry that these are in German - they translate to "Missing type specifier - > assuming int" and "syntax error: missing ";" before identifier "XMLSSize_t") > Apparently ssize_t is a POSIX extension and as such isn't available in MSVC > (by default?) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org
[jira] [Commented] (XERCESC-2194) Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t
[ https://issues.apache.org/jira/browse/XERCESC-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052120#comment-17052120 ] Scott Cantor commented on XERCESC-2194: --- Isn't that the autotools-specific header? You would never include any of them directly, but if it's being included by mistake perhaps there's an issue somewhere around the guarding macros. > Including Xerces_autoconf_config.hpp on Windows fails due to undefined ssize_t > -- > > Key: XERCESC-2194 > URL: https://issues.apache.org/jira/browse/XERCESC-2194 > Project: Xerces-C++ > Issue Type: Bug > Components: Build >Affects Versions: 3.2.2 >Reporter: Rasmus Thomsen >Priority: Major > > When including Xerces_autoconf_config.hpp on Windows the following error > messages: > > {code:cpp} > error C4430: Fehlender Typspezifizierer - int wird angenommen. Hinweis: > "default-int" wird von C++ nicht unterstützt. > error C2146: Syntaxfehler: Fehlendes ";" vor Bezeichner "XMLSSize_t" > {code} > (Sorry that these are in German - they translate to "Missing type specifier - > assuming int" and "syntax error: missing ";" before identifier "XMLSSize_t") > Apparently ssize_t is a POSIX extension and as such isn't available in MSVC > (by default?) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org