Re: [Cake] act_conndscp

2019-04-01 Thread Ryan Mounce
On Tue, 2 Apr 2019 at 00:37, Kevin Darbyshire-Bryant
 wrote:
>
>
>
> > On 23 Mar 2019, at 18:35, Kevin Darbyshire-Bryant 
> >  wrote:
> >
> >
> >
> >> On 22 Mar 2019, at 21:24, Kevin Darbyshire-Bryant 
> >>  wrote:
> >>
> >> It looks like act_conndscp has been shot down by the kernel people, at 
> >> least in its current form.  Setting a conntrack mark from tc is regarded 
> >> as “not sure if it is a good idea”.  The other way (conntrack to skb) is 
> >> fine.  That’s sort of good news in that ingress is the hard bit as it’s 
> >> problematic with iptables.
> >>
> >> egress is within iptables coverage - ‘just’ need a way to store a DSCP & 
> >> flag to conntrack mark.
> >
> > Never give in, never surrender.
> >
>
> Given in.  Surrendered.

:(

FWIW I've applied an updated patch with your iptables 'abomination'
and it's been working without issue.
___
Cake mailing list
Cake@lists.bufferbloat.net
https://lists.bufferbloat.net/listinfo/cake


Re: [Cake] [Ecn-sane] The two SCE tests I have in mind

2019-04-01 Thread Dave Taht
On Mon, Apr 1, 2019 at 6:03 PM Stephen Hemminger
 wrote:
>
> On Sun, 24 Mar 2019 13:32:03 +0100
> Michael Richardson  wrote:
>
> > Jonathan Morton  wrote:
> > >> On 24 Mar, 2019, at 12:05 pm, Pete Heist  wrote:
> > >>
> > >> tcpdump -r file.pcap udp port 2112 and greater 80 and "ip[1] != 0x1”
> > >>
> > >> “greater 80” ignores the handshake packets and 0x1 is whatever TOS
> > >> value we want to make sure the packets contain. We can use different
> > >> filters for other traffic.
> >
> > > Bear in mind that the TOS byte contains ECN as well as DSCP fields, 
> > and
> > > the latter is left-justified.
> >
> > libpcap should probably learn about DSCN bits to avoid people having to
> > think so much :-)

Well, I still have nothing better than tcptrace + xplot.

> >
> > Send patches to me/github.


> >
>
> Libpcap is ancient history by now. It is like ifconfig, everyone still can't 
> reprogram
> their brain; but the tool is on life support.
>
> All development is happening on wireshark/tshark.
> ___
> Cake mailing list
> Cake@lists.bufferbloat.net
> https://lists.bufferbloat.net/listinfo/cake



-- 

Dave Täht
CTO, TekLibre, LLC
http://www.teklibre.com
Tel: 1-831-205-9740
___
Cake mailing list
Cake@lists.bufferbloat.net
https://lists.bufferbloat.net/listinfo/cake


Re: [Cake] [Ecn-sane] The two SCE tests I have in mind

2019-04-01 Thread Stephen Hemminger
On Sun, 24 Mar 2019 13:32:03 +0100
Michael Richardson  wrote:

> Jonathan Morton  wrote:
> >> On 24 Mar, 2019, at 12:05 pm, Pete Heist  wrote:
> >> 
> >> tcpdump -r file.pcap udp port 2112 and greater 80 and "ip[1] != 0x1”
> >> 
> >> “greater 80” ignores the handshake packets and 0x1 is whatever TOS
> >> value we want to make sure the packets contain. We can use different
> >> filters for other traffic.  
> 
> > Bear in mind that the TOS byte contains ECN as well as DSCP fields, and
> > the latter is left-justified.  
> 
> libpcap should probably learn about DSCN bits to avoid people having to
> think so much :-)
> 
> Send patches to me/github.
> 

Libpcap is ancient history by now. It is like ifconfig, everyone still can't 
reprogram
their brain; but the tool is on life support.

All development is happening on wireshark/tshark.
___
Cake mailing list
Cake@lists.bufferbloat.net
https://lists.bufferbloat.net/listinfo/cake


Re: [Cake] act_conndscp

2019-04-01 Thread Kevin Darbyshire-Bryant


> On 23 Mar 2019, at 18:35, Kevin Darbyshire-Bryant 
>  wrote:
> 
> 
> 
>> On 22 Mar 2019, at 21:24, Kevin Darbyshire-Bryant 
>>  wrote:
>> 
>> It looks like act_conndscp has been shot down by the kernel people, at least 
>> in its current form.  Setting a conntrack mark from tc is regarded as “not 
>> sure if it is a good idea”.  The other way (conntrack to skb) is fine.  
>> That’s sort of good news in that ingress is the hard bit as it’s problematic 
>> with iptables.
>> 
>> egress is within iptables coverage - ‘just’ need a way to store a DSCP & 
>> flag to conntrack mark.
> 
> Never give in, never surrender.
> 

Given in.  Surrendered.

___
Cake mailing list
Cake@lists.bufferbloat.net
https://lists.bufferbloat.net/listinfo/cake