Re: Autocorrect functionality
Le mercredi 19 octobre 2022, 01:05:19 CEST Albert Astals Cid a écrit : > Sorry for the cross-posting. > Please CC me, i'm on none of the two lists > > > Both pimcommon and calligra have Autocorrect functionality, but PIM one > broke at some point and I guess no one realized? Indeed I saw that it didn’t load default file long time ago but didn’t have time to investigate it. > > PIM is looking for files in > GenericDataDir/autocorrect > > https://invent.kde.org/pim/pimcommon/-/blob/master/src/pimcommon/autocorrec > tion/autocorrection.cpp#L1063 > > PIM does not install nor contain any autocorrect.xml file > > > > Calligra is looking for files both in > GenericDataDir/autocorrect and GenericDataDir/calligra/autocorrect > > https://invent.kde.org/office/calligra/-/blob/master/plugins/textediting/au > tocorrection/Autocorrect.cpp#L727 > > Calligra does contains an autocorrect.xml file that gets installed into > GenericDataDir/calligra/autocorrect/autocorrect.xml > > > So unless there's something wrong in my assessment, PIM autocorrect is > broken, and if it was not broken it would depend on calligra for the files > to exist since it does not ship its own autocorrect files (that's good, > since duplication is bad) > > > Solutions: > A) Make PIM look for files also in GenericDataDir/calligra and live with > the dependency to calligra for the feature Not a good solution as even me I don’t install it. > B) Accept that the feature in > PIM was broken for a long time and just remove it Not acceptable for sure. > C) Make a library that both PIM and Calligra use If you have time ok :) D) duplicate files, it’s the easy solution. > > Ideally we would go with C but we all know it's not like we have lots of > people with time available to jump and work on this... > > Comments? Opinions? > > Sorry for the cross-posting. > Please CC me, i'm on none of the two lists > > Cheers, > Albert -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB Group company Tel: France +33 (0)4 90 84 08 53, http://www.kdab.fr KDAB - The Qt, C++ and OpenGL Experts
Re: Autocorrect functionality
On Mittwoch, 19. Oktober 2022 01:05:19 CEST Albert Astals Cid wrote: > Sorry for the cross-posting. > Please CC me, i'm on none of the two lists > > > Both pimcommon and calligra have Autocorrect functionality, but PIM one > broke at some point and I guess no one realized? [...] > Solutions: > A) Make PIM look for files also in GenericDataDir/calligra and live with > the dependency to calligra for the feature B) Accept that the feature in > PIM was broken for a long time and just remove it C) Make a library that > both PIM and Calligra use > > Ideally we would go with C but we all know it's not like we have lots of > people with time available to jump and work on this... Right, that's ultimately what I'd like to see as well, all the auto- correction, grammar checking and translation features moving into Frameworks, alongside spell-checking. Those are all features you would like to have everywhere you write more than a few words of text IMHO. But lacking time for this, it's not more than a wishlist item unfortunately... Regards, Volker signature.asc Description: This is a digitally signed message part.
Re: Autocorrect functionality
El dimecres, 19 d’octubre de 2022, a les 7:31:26 (CEST), Laurent Montel va escriure: > Le mercredi 19 octobre 2022, 01:05:19 CEST Albert Astals Cid a écrit : > > Sorry for the cross-posting. > > Please CC me, i'm on none of the two lists > > > > > > Both pimcommon and calligra have Autocorrect functionality, but PIM one > > broke at some point and I guess no one realized? > > Indeed I saw that it didn’t load default file long time ago but didn’t have > time to investigate it. > > > PIM is looking for files in > > > > GenericDataDir/autocorrect > > > > https://invent.kde.org/pim/pimcommon/-/blob/master/src/pimcommon/autocorre > > c > > tion/autocorrection.cpp#L1063 > > > > PIM does not install nor contain any autocorrect.xml file > > > > > > > > Calligra is looking for files both in > > > > GenericDataDir/autocorrect and GenericDataDir/calligra/autocorrect > > > > https://invent.kde.org/office/calligra/-/blob/master/plugins/textediting/a > > u > > tocorrection/Autocorrect.cpp#L727 > > > > Calligra does contains an autocorrect.xml file that gets installed into > > GenericDataDir/calligra/autocorrect/autocorrect.xml > > > > > > So unless there's something wrong in my assessment, PIM autocorrect is > > broken, and if it was not broken it would depend on calligra for the files > > to exist since it does not ship its own autocorrect files (that's good, > > since duplication is bad) > > > > Solutions: > > A) Make PIM look for files also in GenericDataDir/calligra and live with > > > > the dependency to calligra for the feature > > Not a good solution as even me I don’t install it. > > > B) Accept that the feature in > > PIM was broken for a long time and just remove it > > Not acceptable for sure. > > > C) Make a library that both PIM and Calligra use > > If you have time ok :) > > D) duplicate files, it’s the easy solution. I don't think that's a good idea, counting language files it's 15 files, copying them means they will definitely diverge at some point Cheers, Albert > > > Ideally we would go with C but we all know it's not like we have lots of > > people with time available to jump and work on this... > > > > Comments? Opinions? > > > > Sorry for the cross-posting. > > Please CC me, i'm on none of the two lists > > > > Cheers, > > > > Albert
Re: Autocorrect functionality
Le mercredi 19 octobre 2022, 18:02:58 CEST Albert Astals Cid a écrit : > > > > D) duplicate files, it’s the easy solution. > > I don't think that's a good idea, counting language files it's 15 files, > copying them means they will definitely diverge at some point > Or we need to move them in a repo which is a dependancy for pim* and calligra => in a framework module. Otherwise kmail autocorrect will be always broken. After that is calligra word is still in development ? Is still release ? Regards.
Re: Autocorrect functionality
On Wednesday October 19 2022 21:57:14 Laurent Montel wrote: > >Or we need to move them in a repo which is a dependancy for pim* and calligra >=> in a framework module. >Otherwise kmail autocorrect will be always broken. judging from the results of autocorrect I see posted I'd remove the 1st two words from that last sentence... and I'd be more in favour of a framework that teaches people to ego-correct :-/ R.
Re: Autocorrect functionality
On onsdag den 19. oktober 2022 17.42.29 CEST, Volker Krause wrote: On Mittwoch, 19. Oktober 2022 01:05:19 CEST Albert Astals Cid wrote: Sorry for the cross-posting. Please CC me, i'm on none of the two lists Both pimcommon and calligra have Autocorrect functionality, but PIM one broke at some point and I guess no one realized? [...] Solutions: A) Make PIM look for files also in GenericDataDir/calligra and live with the dependency to calligra for the feature B) Accept that the feature in PIM was broken for a long time and just remove it C) Make a library that both PIM and Calligra use Ideally we would go with C but we all know it's not like we have lots of people with time available to jump and work on this... Right, that's ultimately what I'd like to see as well, all the auto- correction, grammar checking and translation features moving into Frameworks, alongside spell-checking. Those are all features you would like to have everywhere you write more than a few words of text IMHO. But lacking time for this, it's not more than a wishlist item unfortunately... I think there are two separate issues here: 1) The data, where to host/maintain/install, and 2) code duplication. To reduce the amount of work we could postpone this until needs get pressing or sombody finds the time. The data we have in calligra atm is not very comprehensive. This makes it pretty useless if it is not updated. The data in libreoffice is pretty good though, so using that data would be nice. But how to do that? Could we: . Merge current LO data with calligra data, A job to do now, and data must be maintained two places. . Copy current data from LO into our repo keeping data format, When data is updated in LO, somebody needs to make a new copy. Install both calligra data and LO data. . Copy data automatically from LO at release time keeping data format, Install both calligra data and LO data. I don't particulary like any of these, but trying to be practical... -- Mvh Dag
