Re: [Carbon-dev] [Carbon-commits] [Carbon-Core] svn commit r75825 - in trunk/carbon/core/distribution: . src/assembly

2010-10-26 Thread Isuru Suriarachchi 
Hi Pradeep,

There are many errors while generating docs in Carbon core. Those are due to
small issues in user guides inside Carbon core. Can you please fix those as
well?

Thanks,
~Isuru

On Tue, Oct 26, 2010 at 10:07 AM, Isuru Suriarachchi  wrote:

> Thanks Pradeep and Sameera for fixing it. Will test it on the builder..
>
> Thanks,
> ~Isuru
>
>
> On Tue, Oct 26, 2010 at 8:36 AM, Sameera Jayasoma wrote:
>
>> Hi Pradeep,
>>
>> Applied the patch.
>>
>> Thanks
>> Sameera
>>
>>
>> On Tue, Oct 26, 2010 at 5:19 AM, Pradeep Fernando wrote:
>>
>>> Hi,
>>>
>>> I created a patch to address above issue & attached to the same JIRA
>>> thread. (https://wso2.org/jira/browse/CARBON-3412)
>>> please review & commit.
>>>
>>> about the patch:
>>> removed the carbon dependency from the distribution pom , there wasn't
>>> a need for that dependency since we are creating a temp distribution
>>> to overcome this exact restriction.It was my mistake to add this.
>>>
>>> -Pradeep
>>>
>>> On Tue, Oct 26, 2010 at 1:44 AM, Isuru Suriarachchi 
>>> wrote:
>>> > Hi Sameera/Pradeep,
>>> >
>>> > This commit causes a build break on a clean repository. That is
>>> because, in
>>> > the "2-unpack-wso2carbon" execution, it requires a wso2carbon.zip pack
>>> in
>>> > the maven repository. But in the first build on a clean repo, this
>>> won't be
>>> > there. This should be done by extracting the target/wso2carbon.zip
>>> using
>>> > ant. Please fix properly..
>>> >
>>> > Thanks,
>>> > ~Isuru
>>> >
>>> > On Tue, Oct 19, 2010 at 12:28 AM,  wrote:
>>> >>
>>> >> Author: sameera
>>> >> Date: Mon Oct 18 11:58:41 2010
>>> >> New Revision: 75825
>>> >> URL: http://wso2.org/svn/browse/wso2?view=rev&revision=75825
>>> >>
>>> >> Log:
>>> >> applying the patch provided by Pradeep for
>>> >> https://wso2.org/jira/browse/CARBON-3412
>>> >>
>>> >> Added:
>>> >>   trunk/carbon/core/distribution/src/assembly/docs.xml
>>> >> Modified:
>>> >>   trunk/carbon/core/distribution/pom.xml
>>> >>   trunk/carbon/core/distribution/src/assembly/dist.xml
>>> >>
>>> >> Modified: trunk/carbon/core/distribution/pom.xml
>>> >> URL:
>>> >>
>>> http://wso2.org/svn/browse/wso2/trunk/carbon/core/distribution/pom.xml?rev=75825&r1=75824&r2=75825&view=diff
>>> >>
>>> >>
>>> ==
>>> >> --- trunk/carbon/core/distribution/pom.xml  (original)
>>> >> +++ trunk/carbon/core/distribution/pom.xml  Mon Oct 18 11:58:41
>>> 2010
>>> >> @@ -96,12 +96,113 @@
>>> >> 
>>> >> 
>>> >> 
>>> >> +
>>> >> +
>>> >> +org.apache.maven.plugins
>>> >> +maven-dependency-plugin
>>> >> +2.0-alpha-4
>>> >> +false
>>> >> +
>>> >> +
>>> >> +2-unpack-wso2carbon
>>> >> +package
>>> >> +
>>> >> +unpack
>>> >> +
>>> >> +
>>> >> +
>>> >> +
>>> >> +
>>>  org.wso2.carbon
>>> >> +
>>>  wso2carbon
>>> >> +${pom.version}
>>> >> +zip
>>> >> +true
>>> >> +
>>> >>  target
>>> >> +
>>> >> +
>>> >> +
>>> >> +
>>> >> +
>>> >> +
>>> >> +
>>> >> 
>>> >> org.apache.maven.plugins
>>> >> maven-antrun-plugin
>>> >> 1.1
>>> >> 
>>> >> 
>>> >> +3-extract-docs-from-components
>>> >> +package
>>> >> +
>>> >> +run
>>> >> +
>>> >> +
>>> >> +
>>> >> +>> >> value="target/docs-temp"/>
>>> >> +
>>> >> +
>>> >> +
>>> >> +>> >> name="wso2carbon-${pom.version}.zip"/>
>>> >> +
>>> >> +
>>> >> +>> >> todir="target/wso2carbon-${pom.version}/repository/components"
>>> >> overwrite="true">
>>> >> +>> >> dir="${tempdir}/wso2carbon-${pom.version}/repository/components">
>>> >> +
>>> >> +
>>> >> +>> >> file="target/carbon-${pom.version}.zip"/>
>>> >> +
>>> >> +
>>> >> +
>>> >> +>> >

Re: [Carbon-dev] Advanced search with multiple tags in G-reg does not work

2010-10-26 Thread Samisa Abeysinghe 
As our open source model works, this can only be fixed on trunk. You have to
migrate to the latest version.

On Wed, Oct 27, 2010 at 10:11 AM, Sarasi Munasinghe  wrote:

> Hi Sumedha,
>
> I created a JIRA [1]. I need this for a released version.
>
>
> [1] https://wso2.org/jira/browse/REGISTRY-566
>
> Thanks
> Sarasi
>
>
> On Wed, Oct 27, 2010 at 7:49 AM, Sumedha Rubasinghe wrote:
>
>>
>>
>> On Tue, Oct 26, 2010 at 11:43 PM, Sarasi Munasinghe wrote:
>>
>>> Hi,
>>>
>>> I have encountered an issue in the G-Reg Advanced search as it does not
>>> allow to insert multiple tags. I need to use this functionality in the
>>> support-KB system.
>>> Currently it allows only to insert single tags.
>>>
>>> Is that a known issue?
>>> Kindly appreciate your feedback.
>>>
>>
>> Hi Sarasi,
>> This is a known limitation. But can be fixed. Do you need this for a
>> released version or for the trunk?
>> Please create a JIRA.
>>
>> /sumedha
>>
>>
>>
>>>
>>> Thanks,
>>> Sarasi
>>> ___
>>> Carbon-dev mailing list
>>> Carbon-dev@wso2.org
>>> https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>>>
>>>
>>
>> ___
>> Carbon-dev mailing list
>> Carbon-dev@wso2.org
>> https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>>
>>
>
> ___
> Carbon-dev mailing list
> Carbon-dev@wso2.org
> https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>
> Thanks,
Samisa...

Samisa Abeysinghe
VP Engineering
WSO2 Inc.
http://wso2.com
http://wso2.org
___
Carbon-dev mailing list
Carbon-dev@wso2.org
https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev

Re: [Carbon-dev] Deployment of 'Custom mediators' fails in the latest WSO2 ESB nightly builds

2010-10-26 Thread Supun Kamburugamuva 
Shall we remove the final from the method.

public final OMElement serializeMediator(OMElement parent, Mediator m) ?

Thanks,
Supun..

On Mon, Oct 25, 2010 at 2:32 PM, Udayanga Wickramasinghe  wrote:

>
>
> On Mon, Oct 25, 2010 at 1:58 PM, Supun Kamburugamuva wrote:
>
>> This is due to an API change. Now if your Serializer is extending
>> from AbstractMediatorSerializer, you have to override the
>>
>> protected abstract OMElement serializeSpecificMediator(Mediator m);
>>
>
>> Previously user had to override the
>>
>> public OMElement serializeMediator(OMElement parent, Mediator m).
>>
>> But this method is final now.
>>
>
> FYI ,
> Similarly Mediator Factory API  has also been changed to ,
> protected Mediator createSpecificMediator(OMElement elem,
> Properties props)
>
> was previously  :  public Mediator createMediator(OMElement elem)  [which
> is final now..]
>
>
> Regards,
> Udayanga
>
>
> --
> *Udayanga Wickramasinghe*
> Software Engineer; WSO2 Inc.; http://wso2.com,
> *email: **udayan...@wso2.com* * cell: +94 (77)
> 983-4365
> blog: **http://udayangawiki.blogspot.com*
> *
> twitter: **http://twitter.com/udayanga_wick*
> *
> **
> * 
>
> ___
> Carbon-dev mailing list
> Carbon-dev@wso2.org
> https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>
>


-- 
Supun Kamburugamuva
Technical Lead
WSO2 Inc.;  http://wso2.org
E-mail: su...@wso2.com;  Mobile: +94 77 431 3585
Blog: http://supunk.blogspot.com
___
Carbon-dev mailing list
Carbon-dev@wso2.org
https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev

Re: [Carbon-dev] ++(WSO2 Committers)

2010-10-26 Thread Pradeep Fernando 
Hi,
thank you for adding me as a comitter. Hoping to contribute to  carbon
in the future too.

-Pradeep

On Wed, Oct 27, 2010 at 10:56 AM, Sameera Jayasoma  wrote:
> Hi Pradeep,
>
> It is with great pleasure that we welcome you as a WSO2 committer. Thank you
> for your contributions.
>
> Welcome aboard!
>
> Thanks
> Sameera
>
> --
> Sameera Jayasoma
> Technical Lead and Product Manager, WSO2 Carbon
>
> WSO2, Inc. (http://wso2.com)
> email: same...@wso2.com
> blog: http://tech.jayasoma.org
>
> Lean . Enterprise . Middleware
>
> ___
> Carbon-dev mailing list
> Carbon-dev@wso2.org
> https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>
>



-- 
Pradeep Fernando
Software Engineer
WSO2 Inc; http://wso2.com/

blog: http://pradeepfernando.blogspot.com/
m: +94776603662

___
Carbon-dev mailing list
Carbon-dev@wso2.org
https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev

Re: [Carbon-dev] Dead page appears when accessing service listing page

2010-10-26 Thread Heshan Suriyaarachchi 
Hi Isuru,

We are fixing these in the trunk. We'll be moving the fixes to the branch,
once the branching completes.

On Tue, Oct 26, 2010 at 10:16 PM, Isuru Suriarachchi  wrote:

> Hi Heshan,
>
> In the Carbon 3.1.0 branch, I get the following NPE when accessing the
> service listing page in AppServer. Is this related to your recent carbon
> core changes?
>
> java.lang.NullPointerException
> at
> org.wso2.carbon.ui.JspServlet$ServletContextAdaptor.getResourcePaths(JspServlet.java:196)
> at
> org.apache.jsp.service_002dmgt.service_005finfo_jsp._jspService(service_005finfo_jsp.java:883)
> at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:97)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
> at
> org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:332)
> at
> org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:314)
> at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:264)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
> at org.wso2.carbon.ui.JspServlet.service(JspServlet.java:119)
> at org.wso2.carbon.ui.TilesJspServlet.service(TilesJspServlet.java:80)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
> at
> org.eclipse.equinox.http.helper.ContextPathServletAdaptor.service(ContextPathServletAdaptor.java:36)
> at
> org.eclipse.equinox.http.servlet.internal.ServletRegistration.handleRequest(ServletRegistration.java:90)
> at
> org.eclipse.equinox.http.servlet.internal.ProxyServlet.processAlias(ProxyServlet.java:111)
> at
> org.eclipse.equinox.http.servlet.internal.ProxyServlet.service(ProxyServlet.java:67)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
> at org.wso2.carbon.bridge.BridgeServlet.service(BridgeServlet.java:152)
>
> Thanks,
> ~Isuru
>
> --
> Isuru Suriarachchi
> Technical Lead & Product Manager, WSO2 Application Server
> WSO2 Inc. http://wso2.com
> email : is...@wso2.com
> blog : http://isurues.wordpress.com/
>
> lean . enterprise . middleware
>
>
> ___
> Carbon-dev mailing list
> Carbon-dev@wso2.org
> https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>
>


-- 
Regards,
Heshan Suriyaarachchi
Software Engineer
WSO2 Inc.; http://wso2.com/

Blog: http://heshans.blogspot.com/
___
Carbon-dev mailing list
Carbon-dev@wso2.org
https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev

Re: [Carbon-dev] ++(WSO2 Committers)

2010-10-26 Thread Harshana Martin 
Congratz Pradeep!!

On Wed, Oct 27, 2010 at 10:56 AM, Sameera Jayasoma  wrote:

> Hi Pradeep,
>
> It is with great pleasure that we welcome you as a WSO2 committer. Thank
> you for your contributions.
>
> Welcome aboard!
>
> Thanks
> Sameera
>
> --
> Sameera Jayasoma
> Technical Lead and Product Manager, WSO2 Carbon
>
> WSO2, Inc. (http://wso2.com)
> email: same...@wso2.com
> blog: http://tech.jayasoma.org
>
> Lean . Enterprise . Middleware
>
> ___
> Carbon-dev mailing list
> Carbon-dev@wso2.org
> https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>
>


-- 
Harshana Martin
Software Engineer
WSO2 Inc.
Web:http://wso2.com

Mobile: +94 716062650
Blog: http://harshana05.blogspot.com
Profile: https://www.google.com/profiles/harshana05
___
Carbon-dev mailing list
Carbon-dev@wso2.org
https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev

[Carbon-dev] ++(WSO2 Committers)

2010-10-26 Thread Sameera Jayasoma 
Hi Pradeep,

It is with great pleasure that we welcome you as a WSO2 committer. Thank you
for your contributions.

Welcome aboard!

Thanks
Sameera

-- 
Sameera Jayasoma
Technical Lead and Product Manager, WSO2 Carbon

WSO2, Inc. (http://wso2.com)
email: same...@wso2.com
blog: http://tech.jayasoma.org

Lean . Enterprise . Middleware
___
Carbon-dev mailing list
Carbon-dev@wso2.org
https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev

Re: [Carbon-dev] [Carbon-commits] [Carbon-Core] svn commit r76361 - trunk/carbon/core/org.wso2.carbon.ui/src/main/java/org/wso2/carbon/ui

2010-10-26 Thread Amila Maha Arachchi 
Hi,

Sorry, it was my mistake.

Regards,
AmilaM.

On Tue, Oct 26, 2010 at 10:41 PM, Isuru Suriarachchi  wrote:

> Hi Miyuru/AmilaM,
>
> On Mon, Oct 25, 2010 at 9:58 PM,  wrote:
>
>> Author: miyuru
>> Date: Mon Oct 25 09:28:58 2010
>> New Revision: 76361
>> URL: http://wso2.org/svn/browse/wso2?view=rev&revision=76361
>>
>> Log:
>> fixed CARBON-7958, patch contributed by Amila Maharachchi
>>
>>
>> Modified:
>>
>> trunk/carbon/core/org.wso2.carbon.ui/src/main/java/org/wso2/carbon/ui/JspServlet.java
>>
>> Modified:
>> trunk/carbon/core/org.wso2.carbon.ui/src/main/java/org/wso2/carbon/ui/JspServlet.java
>> URL:
>> http://wso2.org/svn/browse/wso2/trunk/carbon/core/org.wso2.carbon.ui/src/main/java/org/wso2/carbon/ui/JspServlet.java?rev=76361&r1=76360&r2=76361&view=diff
>>
>> ==
>> ---
>> trunk/carbon/core/org.wso2.carbon.ui/src/main/java/org/wso2/carbon/ui/JspServlet.java
>>   (original)
>> +++
>> trunk/carbon/core/org.wso2.carbon.ui/src/main/java/org/wso2/carbon/ui/JspServlet.java
>>   Mon Oct 25 09:28:58 2010
>> @@ -192,10 +192,17 @@
>> Set resultFromProviders =
>> uiResourceRegistry.getUIResourcePaths(name);
>>
>> //Merging two sets.
>> -for(String resourcePath:resultFromProviders){
>> -result.add(resourcePath);
>> +if (resultFromProviders != null && result != null) {
>> +for (String resourcePath : resultFromProviders) {
>> +result.add(resourcePath);
>> +}
>> +return result;
>> +} else if (resultFromProviders != null) {
>> +return result;
>> +} else {
>> +return resultFromProviders;
>> }
>>
>
> Shouldn't this be..
>
> } else if (resultFromProviders != null) {
>
>return resultFromProviders;
>   } else {
> return result;
>   }
>
> Thanks,
> ~Isuru
>

>
>> -return result;
>>
>> +
>> }
>>
>> public RequestDispatcher getRequestDispatcher(String arg0) {
>>
>> ___
>> Carbon-commits mailing list
>> carbon-comm...@wso2.org
>> https://wso2.org/cgi-bin/mailman/listinfo/carbon-commits
>>
>
>
>
> --
> Isuru Suriarachchi
> Technical Lead & Product Manager, WSO2 Application Server
> WSO2 Inc. http://wso2.com
> email : is...@wso2.com
> blog : http://isurues.wordpress.com/
>
> lean . enterprise . middleware
>
>
> ___
> Carbon-commits mailing list
> carbon-comm...@wso2.org
> https://wso2.org/cgi-bin/mailman/listinfo/carbon-commits
>
>
___
Carbon-dev mailing list
Carbon-dev@wso2.org
https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev

Re: [Carbon-dev] Advanced search with multiple tags in G-reg does not work

2010-10-26 Thread Sarasi Munasinghe 
Hi Sumedha,

I created a JIRA [1]. I need this for a released version.


[1] https://wso2.org/jira/browse/REGISTRY-566

Thanks
Sarasi

On Wed, Oct 27, 2010 at 7:49 AM, Sumedha Rubasinghe wrote:

>
>
> On Tue, Oct 26, 2010 at 11:43 PM, Sarasi Munasinghe wrote:
>
>> Hi,
>>
>> I have encountered an issue in the G-Reg Advanced search as it does not
>> allow to insert multiple tags. I need to use this functionality in the
>> support-KB system.
>> Currently it allows only to insert single tags.
>>
>> Is that a known issue?
>> Kindly appreciate your feedback.
>>
>
> Hi Sarasi,
> This is a known limitation. But can be fixed. Do you need this for a
> released version or for the trunk?
> Please create a JIRA.
>
> /sumedha
>
>
>
>>
>> Thanks,
>> Sarasi
>> ___
>> Carbon-dev mailing list
>> Carbon-dev@wso2.org
>> https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>>
>>
>
> ___
> Carbon-dev mailing list
> Carbon-dev@wso2.org
> https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>
>
___
Carbon-dev mailing list
Carbon-dev@wso2.org
https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev

Re: [Carbon-dev] Advanced search with multiple tags in G-reg does not work

2010-10-26 Thread Sumedha Rubasinghe 
On Tue, Oct 26, 2010 at 11:43 PM, Sarasi Munasinghe  wrote:

> Hi,
>
> I have encountered an issue in the G-Reg Advanced search as it does not
> allow to insert multiple tags. I need to use this functionality in the
> support-KB system.
> Currently it allows only to insert single tags.
>
> Is that a known issue?
> Kindly appreciate your feedback.
>

Hi Sarasi,
This is a known limitation. But can be fixed. Do you need this for a
released version or for the trunk?
Please create a JIRA.

/sumedha



>
> Thanks,
> Sarasi
> ___
> Carbon-dev mailing list
> Carbon-dev@wso2.org
> https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>
>
___
Carbon-dev mailing list
Carbon-dev@wso2.org
https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev

[Carbon-dev] Invitation: [Group E] Code Review @ Thu Oct 28 1:30pm - 2:30pm (carbon-dev@wso2.org)

2010-10-26 Thread Senaka Fernando 
BEGIN:VCALENDAR
PRODID:-//Google Inc//Google Calendar 70.9054//EN
VERSION:2.0
CALSCALE:GREGORIAN
METHOD:REQUEST
BEGIN:VEVENT
DTSTART:20101028T08Z
DTEND:20101028T09Z
DTSTAMP:20101026T211400Z
ORGANIZER;CN=Senaka Fernando:mailto:sen...@wso2.com
UID:6lsjhbve12g4cvvkj6bhev4...@google.com
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=Asela Pathberiya;X-NUM-GUESTS=0:mailto:as...@wso2.com
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;CN=Hiranya Jayathilaka;X-NUM-GUESTS=0:mailto:hira...@wso2.com
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=ACCEPTED;RSVP=TRUE
 ;CN=Senaka Fernando;X-NUM-GUESTS=0:mailto:sen...@wso2.com
ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP=
 TRUE;cn=carbon-...@wso2.org;X-NUM-GUESTS=0:mailto:carbon-dev@wso2.org
CREATED:20101026T211358Z
DESCRIPTION:This week's code review session for group E will be held in #59
 . We will be reviewing the UM Permission Tree and Asela will own this code 
 review session.\nView your event at http://www.google.com/calendar/event?ac
 tion=VIEW&eid=NmxzamhidmUxMmc0Y3Z2a2o2YmhldjRzZTAgY2FyYm9uLWRldkB3c28yLm9yZ
 w&tok=MTUjc2VuYWthQHdzbzIuY29tYjI0Y2Q4NWYyYjQ1MGViNjViZjYxOTI4NDY1NWI3ZDhhY
 mRmYzE3Mw&ctz=Asia%2FColombo&hl=en.
LAST-MODIFIED:20101026T211358Z
LOCATION:#59 meeting room - 3rd floor
SEQUENCE:0
STATUS:CONFIRMED
SUMMARY:[Group E] Code Review
TRANSP:OPAQUE
END:VEVENT
END:VCALENDAR


invite.ics
Description: application/ics
___
Carbon-dev mailing list
Carbon-dev@wso2.org
https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev

Re: [Carbon-dev] [Code Reviews - Group C]

2010-10-26 Thread Denis Weerasiri 
On Tue, Oct 26, 2010 at 4:13 PM, Amila Jayasekara  wrote:

> Hi All,
>
>
>
> Group C code reviews will be lead by Sameera for next few weeks. Please
> communicate with Sameera and arrange review sessions.
>
>
> Last week we reviewed some of the User core code. Mainly the
> DatabaseUserStoreManager.
>
>
> Some of the lessons we learn t are as follows,
>
>
> Use of database connections
>
> If a database connection is opened by a particular method, it should close
> the connection in a finally block.
>
> When closing a connection there is possibility that an exception might
> rise. In that case we should not through the exception. In other words we
> should not throw exceptions in finally block.
>
>
> try{
>
> }catch(SQLException) {
>
> //log
>
> //throw or handle
>
> }
>
> finally {
>
> Try {
>
> Statement.close();
>
> Resultset.close();
>
> Connection.close()
>
> }catch(SQLException e){
>
> //log
>
> //do not throw exceptions here
>
> }
>
> }
>
>
> Class/method who created the connection must close the connection. If a
> reference is passed to another method, class, that class/method should not
> close the connection.
>
>
> When closing connections, it is better to close all database related
> objects, resultSet, statements and connections.
>
>
> OSGI,
>
> BundleActivator start method should not throw any exception. This leads
> OSGI to restart bundle over and over.  Therefore bundle activator start
> method should catch exceptions & errors and log them to a file.
>
> E.g: -try {
>
> }
>
> Catch (Throwable e) {
>
> //log
>
> //do not throw exceptions
>
> }
>
>
>
> Naming,
>
> Should  not have names like Statement sqlStmt1 etc …
> Should have a meaningful name.
>
> E.g :- Statement updateUserTableSQL
>
>
> Next reviews
>
> Rajike – ESB Endpoints
>
> Chathuri – Tooling related component
>
> Sameera – Carbon related component
>
>
>
> Thanks
>
> AmilaJ
>
Let's create a crucible project for the next reviews.

>
> ___
> Carbon-dev mailing list
> Carbon-dev@wso2.org
> https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>
>


-- 
Thanks,
Denis
--
*Denis Weerasiri*
Software Engineer; WSO2 Inc.; http://wso2.com,
*email: denisw *...@wso2.com*
*cell: +94 (71) 684-4450
blog: **http://ddweerasiri.blogspot.com* *
twitter: **http://twitter.com/ddweerasiri* *
linked-in: 
**http://lk.linkedin.com/in/ddweerasiri*
___
Carbon-dev mailing list
Carbon-dev@wso2.org
https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev

[Carbon-dev] Advanced search with multiple tags in G-reg does not work

2010-10-26 Thread Sarasi Munasinghe 
Hi,

I have encountered an issue in the G-Reg Advanced search as it does not
allow to insert multiple tags. I need to use this functionality in the
support-KB system.
Currently it allows only to insert single tags.

Is that a known issue?
Kindly appreciate your feedback.

Thanks,
Sarasi
___
Carbon-dev mailing list
Carbon-dev@wso2.org
https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev

Re: [Carbon-dev] Dead page appears when accessing service listing page

2010-10-26 Thread Isuru Suriarachchi 
Found the issue and applied the patch from AmilaM.

Thanks,
~Isuru

On Tue, Oct 26, 2010 at 10:16 PM, Isuru Suriarachchi  wrote:

> Hi Heshan,
>
> In the Carbon 3.1.0 branch, I get the following NPE when accessing the
> service listing page in AppServer. Is this related to your recent carbon
> core changes?
>
> java.lang.NullPointerException
> at
> org.wso2.carbon.ui.JspServlet$ServletContextAdaptor.getResourcePaths(JspServlet.java:196)
> at
> org.apache.jsp.service_002dmgt.service_005finfo_jsp._jspService(service_005finfo_jsp.java:883)
> at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:97)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
> at
> org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:332)
> at
> org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:314)
> at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:264)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
> at org.wso2.carbon.ui.JspServlet.service(JspServlet.java:119)
> at org.wso2.carbon.ui.TilesJspServlet.service(TilesJspServlet.java:80)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
> at
> org.eclipse.equinox.http.helper.ContextPathServletAdaptor.service(ContextPathServletAdaptor.java:36)
> at
> org.eclipse.equinox.http.servlet.internal.ServletRegistration.handleRequest(ServletRegistration.java:90)
> at
> org.eclipse.equinox.http.servlet.internal.ProxyServlet.processAlias(ProxyServlet.java:111)
> at
> org.eclipse.equinox.http.servlet.internal.ProxyServlet.service(ProxyServlet.java:67)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
> at org.wso2.carbon.bridge.BridgeServlet.service(BridgeServlet.java:152)
>
> Thanks,
> ~Isuru
>
> --
> Isuru Suriarachchi
> Technical Lead & Product Manager, WSO2 Application Server
> WSO2 Inc. http://wso2.com
> email : is...@wso2.com
> blog : http://isurues.wordpress.com/
>
> lean . enterprise . middleware
>
>


-- 
Isuru Suriarachchi
Technical Lead & Product Manager, WSO2 Application Server
WSO2 Inc. http://wso2.com
email : is...@wso2.com
blog : http://isurues.wordpress.com/

lean . enterprise . middleware
___
Carbon-dev mailing list
Carbon-dev@wso2.org
https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev

Re: [Carbon-dev] [Carbon-commits] [Carbon-Core] svn commit r76361 - trunk/carbon/core/org.wso2.carbon.ui/src/main/java/org/wso2/carbon/ui

2010-10-26 Thread Isuru Suriarachchi 
Hi Miyuru/AmilaM,

On Mon, Oct 25, 2010 at 9:58 PM,  wrote:

> Author: miyuru
> Date: Mon Oct 25 09:28:58 2010
> New Revision: 76361
> URL: http://wso2.org/svn/browse/wso2?view=rev&revision=76361
>
> Log:
> fixed CARBON-7958, patch contributed by Amila Maharachchi
>
>
> Modified:
>
> trunk/carbon/core/org.wso2.carbon.ui/src/main/java/org/wso2/carbon/ui/JspServlet.java
>
> Modified:
> trunk/carbon/core/org.wso2.carbon.ui/src/main/java/org/wso2/carbon/ui/JspServlet.java
> URL:
> http://wso2.org/svn/browse/wso2/trunk/carbon/core/org.wso2.carbon.ui/src/main/java/org/wso2/carbon/ui/JspServlet.java?rev=76361&r1=76360&r2=76361&view=diff
>
> ==
> ---
> trunk/carbon/core/org.wso2.carbon.ui/src/main/java/org/wso2/carbon/ui/JspServlet.java
>   (original)
> +++
> trunk/carbon/core/org.wso2.carbon.ui/src/main/java/org/wso2/carbon/ui/JspServlet.java
>   Mon Oct 25 09:28:58 2010
> @@ -192,10 +192,17 @@
> Set resultFromProviders =
> uiResourceRegistry.getUIResourcePaths(name);
>
> //Merging two sets.
> -for(String resourcePath:resultFromProviders){
> -result.add(resourcePath);
> +if (resultFromProviders != null && result != null) {
> +for (String resourcePath : resultFromProviders) {
> +result.add(resourcePath);
> +}
> +return result;
> +} else if (resultFromProviders != null) {
> +return result;
> +} else {
> +return resultFromProviders;
> }
>

Shouldn't this be..

} else if (resultFromProviders != null) {
   return resultFromProviders;
  } else {
return result;
  }

Thanks,
~Isuru



> -return result;
> +
> }
>
> public RequestDispatcher getRequestDispatcher(String arg0) {
>
> ___
> Carbon-commits mailing list
> carbon-comm...@wso2.org
> https://wso2.org/cgi-bin/mailman/listinfo/carbon-commits
>



-- 
Isuru Suriarachchi
Technical Lead & Product Manager, WSO2 Application Server
WSO2 Inc. http://wso2.com
email : is...@wso2.com
blog : http://isurues.wordpress.com/

lean . enterprise . middleware
___
Carbon-dev mailing list
Carbon-dev@wso2.org
https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev

[Carbon-dev] Carbom component branch restructuring for 3.1.0

2010-10-26 Thread Milinda Pathirage 
We are starting carbon component directory restructuring script within 10
mins(for 3.1.0 branch). Do not update your source(Stratos 1.0.0 branch and
carbon 3.1.0 branch) within this time. Once we are done with svn directory
restructuring, we'll send a notification to carbon-dev.

Thanks
Milinda

-- 
Milinda Pathirage
Technical Lead and Product Manager, Business Process Server - WSO2 Inc;
http://wso2.com
Blog: http://blog.mpathirage.com

Lean Enterprise Middleware
___
Carbon-dev mailing list
Carbon-dev@wso2.org
https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev

[Carbon-dev] Dead page appears when accessing service listing page

2010-10-26 Thread Isuru Suriarachchi 
Hi Heshan,

In the Carbon 3.1.0 branch, I get the following NPE when accessing the
service listing page in AppServer. Is this related to your recent carbon
core changes?

java.lang.NullPointerException
at
org.wso2.carbon.ui.JspServlet$ServletContextAdaptor.getResourcePaths(JspServlet.java:196)
at
org.apache.jsp.service_002dmgt.service_005finfo_jsp._jspService(service_005finfo_jsp.java:883)
at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:97)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
at
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:332)
at
org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:314)
at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:264)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
at org.wso2.carbon.ui.JspServlet.service(JspServlet.java:119)
at org.wso2.carbon.ui.TilesJspServlet.service(TilesJspServlet.java:80)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
at
org.eclipse.equinox.http.helper.ContextPathServletAdaptor.service(ContextPathServletAdaptor.java:36)
at
org.eclipse.equinox.http.servlet.internal.ServletRegistration.handleRequest(ServletRegistration.java:90)
at
org.eclipse.equinox.http.servlet.internal.ProxyServlet.processAlias(ProxyServlet.java:111)
at
org.eclipse.equinox.http.servlet.internal.ProxyServlet.service(ProxyServlet.java:67)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
at org.wso2.carbon.bridge.BridgeServlet.service(BridgeServlet.java:152)

Thanks,
~Isuru

-- 
Isuru Suriarachchi
Technical Lead & Product Manager, WSO2 Application Server
WSO2 Inc. http://wso2.com
email : is...@wso2.com
blog : http://isurues.wordpress.com/

lean . enterprise . middleware
___
Carbon-dev mailing list
Carbon-dev@wso2.org
https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev

[Carbon-dev] BAM-1.1.1-RC6

2010-10-26 Thread Ajith Vitharana 
Hi all,

Find the latest BAM pack here [1].

[1] http://builder.wso2.org/~carbon/bam-1.1.1-RC6/

Thanks
ajithn
___
Carbon-dev mailing list
Carbon-dev@wso2.org
https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev

Re: [Carbon-dev] [Stratos-dev] Can we branch carbon, stratos today for next release

2010-10-26 Thread Isuru Suriarachchi 
I'm done with versioning the branch now. But we couldn't run the script to
apply the branching stratergy due to network issues. Milinda will be working
on it tonight. Until that is done, still the branch is frozen.

Carbon 3.1.0 branch can be found at [1] and Stratos 1.0.0 branch can be
found at [2].

When it comes to products, I've only changed appserver versions. Each
product team will have to version your respective Carbon products and
Stratos services.

Thanks,
~Isuru

[1] https://svn.wso2.org/repos/wso2/branches/carbon/3.1.0/
[2] https://svn.wso2.org/repos/wso2/branches/stratos/1.0.0/

On Mon, Oct 25, 2010 at 12:20 PM, Isuru Suriarachchi  wrote:

> Hi All,
>
> I'll start creating the branch Today at 1.30 IST. So If you are doing any
> commits to Carbon trunk after that, please make sure you create diffs for
> those such that you can apply those into the branch after it will be done.
>
> Thanks,
> ~Isuru
>
>
> On Mon, Oct 25, 2010 at 12:06 PM, Isuru Suriarachchi wrote:
>
>> Hi Shankar,
>>
>> I'll start branching in about one hour.
>>
>> Thanks,
>> ~Isuru
>>
>> On Mon, Oct 25, 2010 at 10:30 AM, Selvaratnam Uthaiyashankar <
>> shan...@wso2.com> wrote:
>>
>>> $subject? If anybody in middle, please shout.
>>>
>>> Regards,
>>> Shankar
>>>
>>> --
>>> S.Uthaiyashankar
>>> Senior Architect & Senior Manager
>>> WSO2 Inc.
>>> http://wso2.com/ - "lean . enterprise . middleware"
>>>
>>> ___
>>> Stratos-dev mailing list
>>> stratos-...@wso2.org
>>> https://wso2.org/cgi-bin/mailman/listinfo/stratos-dev
>>>
>>>
>>
>>
>> --
>> Isuru Suriarachchi
>> Technical Lead & Product Manager, WSO2 Application Server
>>
>> WSO2 Inc. http://wso2.com
>> email : is...@wso2.com
>> blog : http://isurues.wordpress.com/
>>
>> lean . enterprise . middleware
>>
>>
>
>
> --
> Isuru Suriarachchi
> Technical Lead & Product Manager, WSO2 Application Server
> WSO2 Inc. http://wso2.com
> email : is...@wso2.com
> blog : http://isurues.wordpress.com/
>
> lean . enterprise . middleware
>
>


-- 
Isuru Suriarachchi
Technical Lead & Product Manager, WSO2 Application Server
WSO2 Inc. http://wso2.com
email : is...@wso2.com
blog : http://isurues.wordpress.com/

lean . enterprise . middleware
___
Carbon-dev mailing list
Carbon-dev@wso2.org
https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev

[Carbon-dev] (no subject)

2010-10-26 Thread Javier López del Castillo Caymares 

Hello everybody:

I have installed Data Service Hosting Feature 3.0.1 to
wso2esb-3.0.1. It
works fine but one problem; I apply security to a data service
(Scenarios 1, Username Token) and get this error when I try the
service:


Fault: DS Fault Message: Error in setting user roles.Nested
Exception:-java.lang.NullPointerException [detail]


   DS Fault Message: Error in
setting
   user roles.Nested
Exception:-java.lang.NullPointerException



If I apply the same scenarios to a proxy service everything work
fine,
the problem is only with the data services.

is there anyone who can help???

best regards
jlcc


___
Carbon-dev mailing list
Carbon-dev@wso2.org
https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev

[Carbon-dev] [Code Reviews - Group C]

2010-10-26 Thread Amila Jayasekara 
Hi All,



Group C code reviews will be lead by Sameera for next few weeks. Please
communicate with Sameera and arrange review sessions.


Last week we reviewed some of the User core code. Mainly the
DatabaseUserStoreManager.


Some of the lessons we learn t are as follows,


Use of database connections

If a database connection is opened by a particular method, it should close
the connection in a finally block.

When closing a connection there is possibility that an exception might rise.
In that case we should not through the exception. In other words we should
not throw exceptions in finally block.


try{

}catch(SQLException) {

//log

//throw or handle

}

finally {

Try {

Statement.close();

Resultset.close();

Connection.close()

}catch(SQLException e){

//log

//do not throw exceptions here

}

}


Class/method who created the connection must close the connection. If a
reference is passed to another method, class, that class/method should not
close the connection.


When closing connections, it is better to close all database related
objects, resultSet, statements and connections.


OSGI,

BundleActivator start method should not throw any exception. This leads OSGI
to restart bundle over and over.  Therefore bundle activator start method
should catch exceptions & errors and log them to a file.

E.g: -try {

}

Catch (Throwable e) {

//log

//do not throw exceptions

}



Naming,

Should  not have names like Statement sqlStmt1 etc … Should
have a meaningful name.

E.g :- Statement updateUserTableSQL


Next reviews

Rajike – ESB Endpoints

Chathuri – Tooling related component

Sameera – Carbon related component



Thanks

AmilaJ
___
Carbon-dev mailing list
Carbon-dev@wso2.org
https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev

Re: [Carbon-dev] Version problems in carbon core parent pom in trunk

2010-10-26 Thread Supun Kamburugamuva 
Please take an svn up.

Thanks,
Supun..

On Tue, Oct 26, 2010 at 3:17 PM, Sadeep Jayasumana  wrote:

> Hi devs,
>
> Following changes are required in carbon core parent pom in trunk for it to
> be in sync with versions in branch dependencies
>
>
> -2.1.0-SNAPSHOT
> +2.1.0-wso2v1
>
> -1.3-SNAPSHOT
> +1.3
>
>
> Thanks and Regards,
> --
> Sadeep Jayasumana
>
> Software Engineer
> WSO2 Inc.
> Email - sad...@wso2.com
> Mobile - +94 77 22 66 507
>
>
>
> --
> Sadeep Jayasumana
>
> Software Engineer
> WSO2 Inc.
> Email - sad...@wso2.com
> Mobile - +94 77 22 66 507
>
> ___
> Carbon-dev mailing list
> Carbon-dev@wso2.org
> https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev
>
>


-- 
Supun Kamburugamuva
Technical Lead
WSO2 Inc.;  http://wso2.org
E-mail: su...@wso2.com;  Mobile: +94 77 431 3585
Blog: http://supunk.blogspot.com
___
Carbon-dev mailing list
Carbon-dev@wso2.org
https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev

[Carbon-dev] Version problems in carbon core parent pom in trunk

2010-10-26 Thread Sadeep Jayasumana 
Hi devs,

Following changes are required in carbon core parent pom in trunk for it to
be in sync with versions in branch dependencies


-2.1.0-SNAPSHOT
+2.1.0-wso2v1

-1.3-SNAPSHOT
+1.3


Thanks and Regards,
-- 
Sadeep Jayasumana

Software Engineer
WSO2 Inc.
Email - sad...@wso2.com
Mobile - +94 77 22 66 507



-- 
Sadeep Jayasumana

Software Engineer
WSO2 Inc.
Email - sad...@wso2.com
Mobile - +94 77 22 66 507
___
Carbon-dev mailing list
Carbon-dev@wso2.org
https://wso2.org/cgi-bin/mailman/listinfo/carbon-dev