Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN
On 5 Dec 2008, at 23:00, Guillermo Roditi wrote: I think the trunk version fixes all your problems, but nobody has been able to accurately describe their problems or produce a simple failing test case. I've found some plugins which call mk_accessors more than once for the same attribute / package, which fails. This is because, on the second application, the attribute is added with no options, which results in the accessor methods for it being removed. Please find test attached. Cheers t0m double_apply.t Description: Binary data ___ List: Catalyst@lists.scsys.co.uk Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/ Dev site: http://dev.catalyst.perl.org/
Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN
On 5 Dec 2008, at 23:00, Guillermo Roditi wrote: All of you who have experienced errors rooted in MooseX::Emulate/ Adopt::Class::Accessor::Fast please please please send me error messages and show me the code that breaks. Catalyst::Plugin::HashedCookies calls Catalyst::Request- >make_accessor, which in some ways is quite broken (as you're re- opening the package from outside), but it isn't actually very hard to fix/support.. Tests and patch attached. Cheers t0m reopen_packages.diff Description: Binary data ___ List: Catalyst@lists.scsys.co.uk Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/ Dev site: http://dev.catalyst.perl.org/
Re: [Catalyst] [Announce] Catalyst-Runtime 5.8000_04 shipped to CPAN
On 5 Dec 2008, at 23:00, Guillermo Roditi wrote: I think the trunk version fixes all your problems, but nobody has been able to accurately describe their problems or produce a simple failing test case. HTML::Widget uses Class::Accessor::Chained::Fast, which overrides make_accessor. As mk_accessors no longer uses make_accessor to generate the coderef, this breaks horribly... Test case attached. Cheers t0m class_accessor_chained_fast.t Description: Binary data ___ List: Catalyst@lists.scsys.co.uk Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst Searchable archive: http://www.mail-archive.com/catalyst@lists.scsys.co.uk/ Dev site: http://dev.catalyst.perl.org/
