Re: [ccache] [PATCH 2/2] Fix Segmentation fault error when gcc -o /dev/null

2019-01-23 Thread Robert Yang via ccache



On 1/23/19 11:23 PM, Joel Rosdahl wrote:

On Tue, 22 Jan 2019 at 10:36, Robert Yang via ccache
 wrote:

Fixed:
$ export CCACHE_DEBUG=1
$ ccache gcc -c hello.c -o /dev/null

Segmentation fault (core dumped)

This is because failed to open /dev/null.foo (Permission denied), check file
stream before write to it can fix the problem.


Thanks, applied on master.

On a side note, I had to edit the author information before applying your
patches via "git am" since the mails were sent from "Robert Yang via ccache
". I don't know why that happened in your case.


Thank you very much, I don't know what happened, I will use github next time.

// Robert


Regardless, I prefer patches via GitHub pull requests nowadays if possible. I
have updated
https://github.com/ccache/ccache/blob/master/CONTRIBUTING.md#contributing-code
accordingly.

-- Joel



___
ccache mailing list
ccache@lists.samba.org
https://lists.samba.org/mailman/listinfo/ccache


Re: [ccache] [PATCH 2/2] Fix Segmentation fault error when gcc -o /dev/null

2019-01-23 Thread Joel Rosdahl via ccache
On Tue, 22 Jan 2019 at 10:36, Robert Yang via ccache
 wrote:
> Fixed:
> $ export CCACHE_DEBUG=1
> $ ccache gcc -c hello.c -o /dev/null
>
> Segmentation fault (core dumped)
>
> This is because failed to open /dev/null.foo (Permission denied), check file
> stream before write to it can fix the problem.

Thanks, applied on master.

On a side note, I had to edit the author information before applying your
patches via "git am" since the mails were sent from "Robert Yang via ccache
". I don't know why that happened in your case.
Regardless, I prefer patches via GitHub pull requests nowadays if possible. I
have updated
https://github.com/ccache/ccache/blob/master/CONTRIBUTING.md#contributing-code
accordingly.

-- Joel

___
ccache mailing list
ccache@lists.samba.org
https://lists.samba.org/mailman/listinfo/ccache


Re: [ccache] [PATCH 1/2] dev.mk.in: fix file name too long error

2019-01-23 Thread Joel Rosdahl via ccache
On Tue, 22 Jan 2019 at 10:36, Robert Yang via ccache
 wrote:
> The all_cppflags changes path to filename which causes file name too long
> error when the path is longer than NAME_MAX (usually 255). Strip srcdir
> to fix the problem.

Thanks, applied on master.

-- Joel

___
ccache mailing list
ccache@lists.samba.org
https://lists.samba.org/mailman/listinfo/ccache