Re: mkisofs "-graft-points" not working?

2008-04-23 Thread Bill Davidsen

Joerg Schilling wrote:

Bill Davidsen <[EMAIL PROTECTED]> wrote:

  

What you do here did never work as you believe.. You are using incorrect
syntax.
  
  
What I have been doing has been working for years, and worked with the 
mkisofs from wodim, and with "mkisofs 2.01a12 (i686-pc-linux-gnu)" which 
I had lying around.



It may be that it worked in your specific case. Before it has been fixed, it
was non-deterministic and it did not work as documented in the man page.

As I had to deal with a broken implementation and a documentation with no
self-contradictions, I decided to implement what's documented in the man 
page 


Hoewver, looking at the code. it seems that you found a bug introduced
with a code cleanup. The code to auto-append a '/' in case the target is a dir
was disabled.

The next release will be fixed.


Thank you.

--
Bill Davidsen <[EMAIL PROTECTED]>
 "Woe unto the statesman who makes war without a reason that will still
 be valid when the war is over..." Otto von Bismark 




--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]



Re: mkisofs "-graft-points" not working?

2008-04-23 Thread Joerg Schilling
Bill Davidsen <[EMAIL PROTECTED]> wrote:

> > What you do here did never work as you believe.. You are using incorrect
> > syntax.
> >   
>
> What I have been doing has been working for years, and worked with the 
> mkisofs from wodim, and with "mkisofs 2.01a12 (i686-pc-linux-gnu)" which 
> I had lying around.

It may be that it worked in your specific case. Before it has been fixed, it
was non-deterministic and it did not work as documented in the man page.

As I had to deal with a broken implementation and a documentation with no
self-contradictions, I decided to implement what's documented in the man 
page 

Hoewver, looking at the code. it seems that you found a bug introduced
with a code cleanup. The code to auto-append a '/' in case the target is a dir
was disabled.

The next release will be fixed.

Jörg

-- 
 EMail:[EMAIL PROTECTED] (home) Jörg Schilling D-13353 Berlin
   [EMAIL PROTECTED](uni)  
   [EMAIL PROTECTED] (work) Blog: http://schily.blogspot.com/
 URL:  http://cdrecord.berlios.de/old/private/ ftp://ftp.berlios.de/pub/schily


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]



Re: mkisofs "-graft-points" not working?

2008-04-18 Thread Bill Davidsen

Joerg Schilling wrote:

Bill Davidsen <[EMAIL PROTECTED]> wrote:

  
After installing the recent cdrtools (a35), I started a backup script 
which writes all the backup information in a file and then creates an 
ISO image thus:

  mkisofs -o $DATE.iso -RU -graft-points -path-list $DATE.filelist

The run aborted saying that files had the same Rockridge name. After 
some investigation, it appears that the conflict was caused by ignoring 
the graft points and putting every file in the root of the image instead 
of using the subdirectory information. The man page for mkisofs 
indicates that graft-points still is intended to function as I have been 
using it for years.


The symptom is that a graft point like "USRLCL=/usr/local" no longer 
creates a subdirectory called USRLCL, but rather puts the tree starting 
with /usr/local directly in the root of the ISO image. Needless to say, 
this change doesn't qualify as an enhancement with me.



What you do here did never work as you believe.. You are using incorrect
syntax.
  


What I have been doing has been working for years, and worked with the 
mkisofs from wodim, and with "mkisofs 2.01a12 (i686-pc-linux-gnu)" which 
I had lying around.
If you like to create a grafted _directory_ in the ISO image, you need to 
add a slash to the path name to the left of the equal sign.
  


The script for monthly backup has a graft point HOME=/home which has 
been working for five years on one of the machines I tested, which reports:

gaimboi:davidsen> mkisofs -version
mkisofs 2.0 (i686-pc-linux-gnu)
gaimboi:davidsen> l /usr/local/bin/mkisofs
-rwxr-xr-x1 root  1413386 Jun 14  2003 /usr/local/bin/mkisofs

This was built from *your* source and installed. If it doesn't work that 
way, then you changed it. And the man page still seems to say what I 
expect, if I say DIR=foo/bar/zot then no matter what the path right of 
equal is, that gets renamed as whatever is left of equal.


Try this with your own old code to realize it has always worked this way:
 mkdir AA BB
 touch AA/test
 touch BB/test
 mkisofs -o test1.iso AAA=AA BBB=BB
 mkisofs -o test2.iso AAA=AA BBB=AA/test

In the first case BBB is a directory, in the 2nd it is a file. And 
current code presents no error message, the graft point is silently 
totally ignored. You changed it, you broke existing scripts, it fails 
without warning, and it doesn't conform to the documentation.


For once could you fix it and admit there's a problem, instead of trying 
to claim it always worked that way?


--
Bill Davidsen <[EMAIL PROTECTED]>
 "Woe unto the statesman who makes war without a reason that will still
 be valid when the war is over..." Otto von Bismark 




--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]



Re: mkisofs "-graft-points" not working?

2008-04-18 Thread Joerg Schilling
Bill Davidsen <[EMAIL PROTECTED]> wrote:

> After installing the recent cdrtools (a35), I started a backup script 
> which writes all the backup information in a file and then creates an 
> ISO image thus:
>   mkisofs -o $DATE.iso -RU -graft-points -path-list $DATE.filelist
>
> The run aborted saying that files had the same Rockridge name. After 
> some investigation, it appears that the conflict was caused by ignoring 
> the graft points and putting every file in the root of the image instead 
> of using the subdirectory information. The man page for mkisofs 
> indicates that graft-points still is intended to function as I have been 
> using it for years.
>
> The symptom is that a graft point like "USRLCL=/usr/local" no longer 
> creates a subdirectory called USRLCL, but rather puts the tree starting 
> with /usr/local directly in the root of the ISO image. Needless to say, 
> this change doesn't qualify as an enhancement with me.

What you do here did never work as you believe.. You are using incorrect
syntax.

If you like to create a grafted _directory_ in the ISO image, you need to 
add a slash to the path name to the left of the equal sign.


Jörg

-- 
 EMail:[EMAIL PROTECTED] (home) Jörg Schilling D-13353 Berlin
   [EMAIL PROTECTED](uni)  
   [EMAIL PROTECTED] (work) Blog: http://schily.blogspot.com/
 URL:  http://cdrecord.berlios.de/old/private/ ftp://ftp.berlios.de/pub/schily


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]



mkisofs "-graft-points" not working?

2008-04-17 Thread Bill Davidsen
After installing the recent cdrtools (a35), I started a backup script 
which writes all the backup information in a file and then creates an 
ISO image thus:

 mkisofs -o $DATE.iso -RU -graft-points -path-list $DATE.filelist

The run aborted saying that files had the same Rockridge name. After 
some investigation, it appears that the conflict was caused by ignoring 
the graft points and putting every file in the root of the image instead 
of using the subdirectory information. The man page for mkisofs 
indicates that graft-points still is intended to function as I have been 
using it for years.


The symptom is that a graft point like "USRLCL=/usr/local" no longer 
creates a subdirectory called USRLCL, but rather puts the tree starting 
with /usr/local directly in the root of the ISO image. Needless to say, 
this change doesn't qualify as an enhancement with me.


Just a warning, started quite a while ago, perhaps as long ago as a26. 
I'm sure that there's some obscure option to make graft-points work as 
they used to, and I'll be told to read the manual (as usual), and it's 
all a kernel problem (as usual), or it's my hardware (as I was told last 
week), but at the moment mkisofs doesn't have working graft-points.




Simple test:

posidon:davidsen> cd /tmp
posidon:davidsen> mkdir AA BB
posidon:davidsen> touch AA/temp
posidon:davidsen> touch BB/temp
posidon:davidsen> mkisofs -o x.iso -RU -graft-points DirAA=AA DirBB=BB
Warning: creating filesystem that does not conform to ISO-9660.
Setting input-charset to 'UTF-8' from locale.
Unknown file type (unallocated) AA/.. - ignoring and continuing.
Using temp000 for  /temp (temp)
mkisofs: Error: 'BB/temp' and 'AA/temp' have the same Rock Ridge name 
'temp'.

mkisofs: Unable to sort directory
posidon:davidsen>



Trying without graft-points it seems to work:

posidon:davidsen> tree -d
.
|-- AA
`-- BB

2 directories
posidon:davidsen> mkisofs -o y.iso -RU .
Warning: creating filesystem that does not conform to ISO-9660.
Setting input-charset to 'UTF-8' from locale.
Unknown file type (unallocated) ./.. - ignoring and continuing.
Total translation table size: 0
Total rockridge attributes bytes: 817
Total directory bytes: 4586
Path table size(bytes): 30
Max brk space used 0
177 extents written (0 MB)
posidon:davidsen> isoinfo -l -i y.iso

Directory listing of /
d-   000   2048 Apr 17 2008 [ 23 02] .
d-   000   2048 Apr 17 2008 [ 23 02] ..
d-   000   2048 Apr 17 2008 [ 24 02] AA
d-   000   2048 Apr 17 2008 [ 25 02] BB

Directory listing of /AA/
d-   000   2048 Apr 17 2008 [ 24 02] .
d-   000   2048 Apr 17 2008 [ 23 02] ..
--   000  0 Apr 17 2008 [-16 00] temp

Directory listing of /BB/
d-   000   2048 Apr 17 2008 [ 25 02] .
d-   000   2048 Apr 17 2008 [ 23 02] ..
--   000  0 Apr 17 2008 [-17 00] temp
posidon:davidsen>


--
Bill Davidsen <[EMAIL PROTECTED]>
 "Woe unto the statesman who makes war without a reason that will still
 be valid when the war is over..." Otto von Bismark 




--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]