[PATCH] rbd: fix ida/idr memory leak

2014-06-04 Thread Ilya Dryomov 
ida_destroy() needs to be called on module exit to release ida caches.

Signed-off-by: Ilya Dryomov ilya.dryo...@inktank.com
---
 drivers/block/rbd.c |1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
index 94747afc2e78..ecdd4aee173c 100644
--- a/drivers/block/rbd.c
+++ b/drivers/block/rbd.c
@@ -5464,6 +5464,7 @@ err_out_slab:
 
 static void __exit rbd_exit(void)
 {
+   ida_destroy(rbd_dev_id_ida);
rbd_sysfs_cleanup();
if (single_major)
unregister_blkdev(rbd_major, RBD_DRV_NAME);
-- 
1.7.10.4

--
To unsubscribe from this list: send the line unsubscribe ceph-devel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] rbd: fix ida/idr memory leak

2014-06-04 Thread Alex Elder 
On 06/04/2014 11:38 AM, Ilya Dryomov wrote:
 ida_destroy() needs to be called on module exit to release ida caches.

Looks good to me.

Reviewed-by: Alex Elder el...@linaro.org

 Signed-off-by: Ilya Dryomov ilya.dryo...@inktank.com
 ---
  drivers/block/rbd.c |1 +
  1 file changed, 1 insertion(+)
 
 diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
 index 94747afc2e78..ecdd4aee173c 100644
 --- a/drivers/block/rbd.c
 +++ b/drivers/block/rbd.c
 @@ -5464,6 +5464,7 @@ err_out_slab:
  
  static void __exit rbd_exit(void)
  {
 + ida_destroy(rbd_dev_id_ida);
   rbd_sysfs_cleanup();
   if (single_major)
   unregister_blkdev(rbd_major, RBD_DRV_NAME);
 

--
To unsubscribe from this list: send the line unsubscribe ceph-devel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html