[PATCH] D24954: [ToolChains] Disable OpenSUSE rules for SLES10

[İsmail Dönmez via cfe-commits]

ismail added a comment.

That looks good to me but I am not a reviewer. Someone else must approve.


https://reviews.llvm.org/D24954



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24954: [ToolChains] Do not assume OpenSUSE for other SUSE variants

[İsmail Dönmez via cfe-commits]

ismail added a comment.

This will break SLES11 and later so it's not OK. Also note that SLES10 is not 
supported anymore.


https://reviews.llvm.org/D24954



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20672: Don't pass -fms-compatibility-version flag during build

[İsmail Dönmez via cfe-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL270860: Since some time clang itself figures out the default 
for ms-compatibility… (authored by ismail).

Changed prior to commit:
  http://reviews.llvm.org/D20672?vs=58586=58623#toc

Repository:
  rL LLVM

http://reviews.llvm.org/D20672

Files:
  llvm/trunk/cmake/modules/HandleLLVMOptions.cmake

Index: llvm/trunk/cmake/modules/HandleLLVMOptions.cmake
===
--- llvm/trunk/cmake/modules/HandleLLVMOptions.cmake
+++ llvm/trunk/cmake/modules/HandleLLVMOptions.cmake
@@ -353,19 +353,6 @@
   append("/Zc:rvalueCast" CMAKE_CXX_FLAGS)
 
   if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
-# Find and run MSVC (not clang-cl) and get its version. This will tell
-# clang-cl what version of MSVC to pretend to be so that the STL works.
-execute_process(COMMAND "$ENV{VSINSTALLDIR}/VC/bin/cl.exe"
-  OUTPUT_QUIET
-  ERROR_VARIABLE MSVC_COMPAT_VERSION
-  )
-string(REGEX REPLACE "^.*Compiler Version ([0-9.]+) for .*$" "\\1"
-  MSVC_COMPAT_VERSION "${MSVC_COMPAT_VERSION}")
-append("-fms-compatibility-version=${MSVC_COMPAT_VERSION}"
-  CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
-  endif()
-
-  if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
 # clang-cl and cl by default produce non-deterministic binaries because
 # link.exe /incremental requires a timestamp in the .obj file.  clang-cl
 # has the flag /Brepro to force deterministic binaries. We want to pass 
that


Index: llvm/trunk/cmake/modules/HandleLLVMOptions.cmake
===
--- llvm/trunk/cmake/modules/HandleLLVMOptions.cmake
+++ llvm/trunk/cmake/modules/HandleLLVMOptions.cmake
@@ -353,19 +353,6 @@
   append("/Zc:rvalueCast" CMAKE_CXX_FLAGS)
 
   if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
-# Find and run MSVC (not clang-cl) and get its version. This will tell
-# clang-cl what version of MSVC to pretend to be so that the STL works.
-execute_process(COMMAND "$ENV{VSINSTALLDIR}/VC/bin/cl.exe"
-  OUTPUT_QUIET
-  ERROR_VARIABLE MSVC_COMPAT_VERSION
-  )
-string(REGEX REPLACE "^.*Compiler Version ([0-9.]+) for .*$" "\\1"
-  MSVC_COMPAT_VERSION "${MSVC_COMPAT_VERSION}")
-append("-fms-compatibility-version=${MSVC_COMPAT_VERSION}"
-  CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
-  endif()
-
-  if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
 # clang-cl and cl by default produce non-deterministic binaries because
 # link.exe /incremental requires a timestamp in the .obj file.  clang-cl
 # has the flag /Brepro to force deterministic binaries. We want to pass that
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D20672: Don't pass -fms-compatibility-version flag during build

[İsmail Dönmez via cfe-commits]

ismail created this revision.
ismail added reviewers: hans, rnk.
ismail added a subscriber: cfe-commits.
ismail set the repository for this revision to rL LLVM.

Since some time clang itself figures out the default for 
ms-compatibility-version and uses it. Trying to figure it out during build is 
redundant and also will not work when the environment variable VSINSTALLDIR is 
not defined (which is not defined if you don't install whole Visual Studio but 
use Visual C++ Build Tools package).

Tested by bootstrapping clang with clang-cl.


Repository:
  rL LLVM

http://reviews.llvm.org/D20672

Files:
  cmake/modules/HandleLLVMOptions.cmake

Index: cmake/modules/HandleLLVMOptions.cmake
===
--- cmake/modules/HandleLLVMOptions.cmake
+++ cmake/modules/HandleLLVMOptions.cmake
@@ -353,19 +353,6 @@
   append("/Zc:rvalueCast" CMAKE_CXX_FLAGS)
 
   if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
-# Find and run MSVC (not clang-cl) and get its version. This will tell
-# clang-cl what version of MSVC to pretend to be so that the STL works.
-execute_process(COMMAND "$ENV{VSINSTALLDIR}/VC/bin/cl.exe"
-  OUTPUT_QUIET
-  ERROR_VARIABLE MSVC_COMPAT_VERSION
-  )
-string(REGEX REPLACE "^.*Compiler Version ([0-9.]+) for .*$" "\\1"
-  MSVC_COMPAT_VERSION "${MSVC_COMPAT_VERSION}")
-append("-fms-compatibility-version=${MSVC_COMPAT_VERSION}"
-  CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
-  endif()
-
-  if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
 # clang-cl and cl by default produce non-deterministic binaries because
 # link.exe /incremental requires a timestamp in the .obj file.  clang-cl
 # has the flag /Brepro to force deterministic binaries. We want to pass 
that


Index: cmake/modules/HandleLLVMOptions.cmake
===
--- cmake/modules/HandleLLVMOptions.cmake
+++ cmake/modules/HandleLLVMOptions.cmake
@@ -353,19 +353,6 @@
   append("/Zc:rvalueCast" CMAKE_CXX_FLAGS)
 
   if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
-# Find and run MSVC (not clang-cl) and get its version. This will tell
-# clang-cl what version of MSVC to pretend to be so that the STL works.
-execute_process(COMMAND "$ENV{VSINSTALLDIR}/VC/bin/cl.exe"
-  OUTPUT_QUIET
-  ERROR_VARIABLE MSVC_COMPAT_VERSION
-  )
-string(REGEX REPLACE "^.*Compiler Version ([0-9.]+) for .*$" "\\1"
-  MSVC_COMPAT_VERSION "${MSVC_COMPAT_VERSION}")
-append("-fms-compatibility-version=${MSVC_COMPAT_VERSION}"
-  CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
-  endif()
-
-  if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
 # clang-cl and cl by default produce non-deterministic binaries because
 # link.exe /incremental requires a timestamp in the .obj file.  clang-cl
 # has the flag /Brepro to force deterministic binaries. We want to pass that
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18035: [GCC] PR23529 Mangler part of attrbute abi_tag support

[İsmail Dönmez via cfe-commits]

ismail added a subscriber: ismail.
ismail added a comment.

Richard,

Does this mean this feature will never be accepted? It would help to make a 
clear statement on this issue. I am not happy how this feature is introduced 
but it's too late now that every big Linux distro out there switched to the new 
ABI.


http://reviews.llvm.org/D18035



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15006: Driver: Better detection of mingw-gcc

[İsmail Dönmez via cfe-commits]

ismail added a comment.

Reverted in r257468.


http://reviews.llvm.org/D15006



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15006: Driver: Better detection of mingw-gcc

[İsmail Dönmez via cfe-commits]

ismail added a comment.

Martell, any update on this?


http://reviews.llvm.org/D15006



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15006: Driver: Better detection of mingw-gcc

[İsmail Dönmez via cfe-commits]

ismail added a comment.

Tested on openSUSE and it works. Thanks!


http://reviews.llvm.org/D15006



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12695: [Driver] Use UniversalCRT on Windows if available

[İsmail Dönmez via cfe-commits]

This doesn't seem to work here, VS 2015 on Win 10 x64:

C:\Users\ismail\Desktop>clang-cl.exe -fms-compatibility-version=19 foo.cpp
LINK : fatal error LNK1104: cannot open file 'kernel32.lib'
clang-cl.exe: error: linker command failed with exit code 1104 (use -v
to see invocation)

Works fine after setting LIB.

On Fri, Sep 11, 2015 at 3:11 AM, Reid Kleckner via cfe-commits
 wrote:
> This revision was automatically updated to reflect the committed changes.
> Closed by commit rL247362: [Driver] Use UniversalCRT on Windows if available 
> (authored by rnk).
>
> Changed prior to commit:
>   http://reviews.llvm.org/D12695?vs=34475=34515#toc
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D12695
>
> Files:
>   cfe/trunk/lib/Driver/MSVCToolChain.cpp
>   cfe/trunk/lib/Driver/ToolChains.h
>   cfe/trunk/lib/Driver/Tools.cpp
>
>
> ___
> cfe-commits mailing list
> cfe-commits@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12695: [Driver] Use UniversalCRT on Windows if available

[İsmail Dönmez via cfe-commits]

Hi,

C:\Users\ismail\Desktop>set include
INCLUDE=C:\Program Files (x86)\Microsoft Visual Studio
14.0\VC\INCLUDE;C:\Program Files (x86)\Microsoft Visual Studio
14.0\VC\ATLMFC\INCLUDE;C:\Program Files (x86)\Windows
Kits\10\include\10.0.10240.0\ucrt;C:\Program Files (x86)\Windows
Kits\NETFXSDK\4.6\include\um;C:\Program Files (x86)\Windows
Kits\10\include\10.0.10240.0\shared;C:\Program Files (x86)\Windows
Kits\10\include\10.0.10240.0\um;C:\Program Files (x86)\Windows
Kits\10\include\10.0.10240.0\winrt;

C:\Users\ismail\Desktop>set lib
LIB=C:\Program Files (x86)\Microsoft Visual Studio
14.0\VC\LIB\amd64;C:\Program Files (x86)\Microsoft Visual Studio
14.0\VC\ATLMFC\LIB\amd64;C:\Program Files (x86)\Windows
Kits\10\lib\10.0.10240.0\ucrt\x64;C:\Program Files (x86)\Windows
Kits\NETFXSDK\4.6\lib\um\x64;C:\Program Files (x86)\Windows
Kits\10\lib\10.0.10240.0\um\x64;
LIBPATH=C:\WINDOWS\Microsoft.NET\Framework64\v4.0.30319;C:\Program
Files (x86)\Microsoft Visual Studio 14.0\VC\LIB\amd64;C:\Program Files
(x86)\Microsoft Visual Studio 14.0\VC\ATLMFC\LIB\amd64;C:\Program
Files (x86)\Windows Kits\10\UnionMetadata;C:\Program Files
(x86)\Windows Kits\10\References;C:\Program Files (x86)\Windows
Kits\10\References\Windows.Foundation.UniversalApiContract\1.0.0.0;C:\Program
Files (x86)\Windows
Kits\10\References\Windows.Foundation.FoundationContract\1.0.0.0;C:\Program
Files (x86)\Windows
Kits\10\References\indows.Networking.Connectivity.WwanContract\1.0.0.0;C:\Program
Files (x86)\Microsoft SDKs\Windows
Kits\10\ExtensionSDKs\Microsoft.VCLibs\14.0\References\CommonConfiguration\neutral;

C:\Users\ismail\Desktop>clang-cl.exe -###
-fms-compatibility-version=19 mandelbrot-mp.cpp
clang version 3.8.0 (http://llvm.org/git/clang
d2dc884a74b40711955713829e7a09b8ff5ca1bc) (http://llvm.org/git/llvm
595af7ed8595ccf005efb087b5bb7d9a19e50e3b)
Target: x86_64-pc-windows-msvc
Thread model: posix
InstalledDir: C:\Program Files\LLVM\bin
 "C:\\Program Files\\LLVM\\bin\\clang-cl.exe" "-cc1" "-triple"
"x86_64-pc-windows-msvc19.0.0" "-emit-obj" "-mrelax-all"
"-disable-free" "-main-file-name" "mandelbrot-mp.cpp"
"-mrelocation-model" "pic" "-pic-level" "2" "-mthread-model" "posix"
"-relaxed-aliasing" "-fmath-errno" "-masm-verbose"
"-mconstructor-aliases" "-munwind-tables" "-target-cpu" "x86-64"
"-D_MT" "--dependent-lib=libcmt" "--dependent-lib=oldnames"
"-fms-volatile" "-fdiagnostics-format" "msvc"
"-momit-leaf-frame-pointer" "-dwarf-column-info" "-resource-dir"
"C:\\Program Files\\LLVM\\bin\\..\\lib\\clang\\3.8.0"
"-internal-isystem" "C:\\Program
Files\\LLVM\\bin\\..\\lib\\clang\\3.8.0\\include" "-internal-isystem"
"C:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\VC\\INCLUDE"
"-internal-isystem" "C:\\Program Files (x86)\\Microsoft Visual Studio
14.0\\VC\\ATLMFC\\INCLUDE" "-internal-isystem" "C:\\Program Files
(x86)\\Windows Kits\\10\\include\\10.0.10240.0\\ucrt"
"-internal-isystem" "C:\\Program Files (x86)\\Windows
Kits\\NETFXSDK\\4.6\\include\\um" "-internal-isystem" "C:\\Program
Files (x86)\\Windows Kits\\10\\include\\10.0.10240.0\\shared"
"-internal-isystem" "C:\\Program Files (x86)\\Windows
Kits\\10\\include\\10.0.10240.0\\um" "-internal-isystem" "C:\\Program
Files (x86)\\Windows Kits\\10\\include\\10.0.10240.0\\winrt" "-Wall"
"-fdeprecated-macro" "-fdebug-compilation-dir"
"C:\\Users\\ismail\\Desktop" "-ferror-limit" "19" "-fmessage-length"
"100" "-mstackrealign" "-fms-extensions" "-fms-compatibility"
"-fms-compatibility-version=19" "-std=c++14"
"-fdelayed-template-parsing" "-fobjc-runtime=gcc"
"-fdiagnostics-show-option" "-fcolor-diagnostics" "-o"
"C:\\Users\\ismail\\AppData\\Local\\Temp\\mandelbrot-mp-d6f68c.obj"
"-x" "c++" "mandelbrot-mp.cpp"
 "C:\\Program Files (x86)\\Microsoft Visual Studio
14.0\\VC\\bin\\amd64\\link.exe" "-out:mandelbrot-mp.exe" "-nologo"
"C:\\Users\\ismail\\AppData\\Local\\Temp\\mandelbrot-mp-d6f68c.obj"


On Fri, Sep 11, 2015 at 4:42 PM, Igor Kudrin  wrote:
> Please, can you show the output of the following commands:
>
> 1) set include
> 2) set lib
> 3) clang-cl.exe -### -fms-compatibility-version=19 foo.cpp
>
>
> On 11.09.2015 17:44, İsmail Dönmez wrote:
>>
>> This doesn't seem to work here, VS 2015 on Win 10 x64:
>>
>> C:\Users\ismail\Desktop>clang-cl.exe -fms-compatibility-version=19 foo.cpp
>> LINK : fatal error LNK1104: cannot open file 'kernel32.lib'
>> clang-cl.exe: error: linker command failed with exit code 1104 (use -v
>> to see invocation)
>>
>> Works fine after setting LIB.
>>
>> On Fri, Sep 11, 2015 at 3:11 AM, Reid Kleckner via cfe-commits
>>  wrote:
>>>
>>> This revision was automatically updated to reflect the committed changes.
>>> Closed by commit rL247362: [Driver] Use UniversalCRT on Windows if
>>> available (authored by rnk).
>>>
>>> Changed prior to commit:
>>>http://reviews.llvm.org/D12695?vs=34475=34515#toc
>>>
>>> Repository:
>>>rL LLVM
>>>
>>> http://reviews.llvm.org/D12695
>>>
>>> Files:
>>>cfe/trunk/lib/Driver/MSVCToolChain.cpp

Re: r246497 - [modules] Rework serialized DeclContext lookup table management. Instead of

[İsmail Dönmez via cfe-commits]

Hi,

On Tue, Sep 1, 2015 at 1:17 AM, Richard Smith via cfe-commits
 wrote:
> Author: rsmith
> Date: Mon Aug 31 17:17:11 2015
> New Revision: 246497
>
> URL: http://llvm.org/viewvc/llvm-project?rev=246497=rev
> Log:
> [modules] Rework serialized DeclContext lookup table management. Instead of
> walking the loaded ModuleFiles looking for lookup tables for the context, 
> store
> them all in one place, and merge them together if we find we have too many
> (currently, more than 4). If we do merge, include the merged form in our
> serialized lookup table, so that downstream readers never need to look at our
> imports' tables.
>
> This gives a huge performance improvement to builds with very large numbers of
> modules (in some cases, more than a 2x speedup was observed).
>
> Added:
> cfe/trunk/lib/Serialization/MultiOnDiskHashTable.h

This doesn't seem to compile with VS2015:

FAILED: C:\PROGRA~2\MICROS~1.0\VC\bin\amd64\cl.exe   /nologo /TP
/DWIN32 /D_WINDOWS   -wd4146 -wd4180 -wd4244 -wd4258 -wd4267 -wd4291
-wd4345 -wd4351 -wd4355 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503
-wd4624 -wd4722 -wd4800 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610
-wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389
-wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4324 -w14062 -we4238 /W4
/Zc:inline /Zc:sizedDealloc- /MT /O2 /Ob2
-Itools\clang\lib\Serialization -I..\tools\clang\lib\Serialization
-I..\tools\clang\include -Itools\clang\include -Iinclude -I..\include
  -UNDEBUG  /EHs-c- /GR- /showIncludes -DCLANG_ENABLE_ARCMT
-DCLANG_ENABLE_OBJC_REWRITER -DCLANG_ENABLE_STATIC_ANALYZER
-DGTEST_HAS_RTTI=0 -D_CRT_NONSTDC_NO_DEPRECATE
-D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE
-D_CRT_SECURE_NO_WARNINGS -D_GNU_SOURCE -D_HAS_EXCEPTIONS=0
-D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS
/Fotools\clang\lib\Serialization\CMakeFiles\clangSerialization.dir\ASTReader.cpp.obj
/Fdtools\clang\lib\Serialization\CMakeFiles\clangSerialization.dir\
/FS -c ..\tools\clang\lib\Serialization\ASTReader.cpp
c:\cygwin64\home\ismail\src\llvm\tools\clang\lib\serialization\MultiOnDiskHashTable.h(117):
error C2065: 'Files': undeclared identifier
c:\cygwin64\home\ismail\src\llvm\tools\clang\lib\serialization\MultiOnDiskHashTable.h(111):
note: while compiling class template member function 'void
clang::serialization::MultiOnDiskHashTable::removeOverriddenTables(void)'
c:\cygwin64\home\ismail\src\llvm\tools\clang\lib\serialization\MultiOnDiskHashTable.h(243):
note: see reference to function template instantiation 'void
clang::serialization::MultiOnDiskHashTable::removeOverriddenTables(void)'
being compiled
c:\cygwin64\home\ismail\src\llvm\tools\clang\lib\serialization\ASTReaderInternals.h(114):
note: see reference to class template instantiation
'clang::serialization::MultiOnDiskHashTable'
being compiled
c:\cygwin64\home\ismail\src\llvm\tools\clang\lib\serialization\MultiOnDiskHashTable.h(117):
error C2228: left of '.count' must have class/struct/union
c:\cygwin64\home\ismail\src\llvm\tools\clang\lib\serialization\MultiOnDiskHashTable.h(117):
note: type is 'unknown-type'
ninja: build stopped: subcommand failed.
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11932: [OPENMP] Link libomp.lib on Windows

[İsmail Dönmez via cfe-commits]

ismail accepted this revision.
ismail added a reviewer: ismail.
ismail added a comment.
This revision is now accepted and ready to land.

Great work. Tested fine on Windows. Next step would be mapping /openmp flag to 
-fopenmp but I guess thats for another bug.


http://reviews.llvm.org/D11932



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11932: [OPENMP] Link libomp.lib on Windows

[İsmail Dönmez via cfe-commits]

ismail added a comment.

In http://reviews.llvm.org/D11932#225158, @hfinkel wrote:

 What library path should be passed (where did you build the OpenMP runtime 
 library)?


This is a default installation so the lib path is $PATH_TO_CLANG_EXE/../lib 
which in my case is C:\Program Files\LLVM\lib


http://reviews.llvm.org/D11932



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [clang-tools-extra] r245052 - [clang-tidy] Move IncludeSorter.* and IncludeInserter.* to clang-tidy/utils/

[İsmail Dönmez via cfe-commits]

Looks fixed now, thanks!

On Sat, Aug 15, 2015 at 8:41 AM, Alexander Kornienko ale...@google.com wrote:
 ... or this may have been fixed by r245144. In any case, please check again
 and report if anything is still broken.


 On Sat, Aug 15, 2015 at 7:39 AM, Alexander Kornienko ale...@google.com
 wrote:

 Sorry for not posting an update earlier.

 I can't reproduce the build failure, and I see no build bots failing in a
 similar way. Must be something with your local configuration.


 On Fri, Aug 14, 2015 at 7:47 PM, Alexander Kornienko ale...@google.com
 wrote:

 Strange. No build bots complained about this so far. I'll take a look at
 this in an hour or so.

 On 14 Aug 2015 19:42, İsmail Dönmez ism...@i10z.com wrote:

 Hi,

 On Fri, Aug 14, 2015 at 5:31 PM, Alexander Kornienko via cfe-commits
 cfe-commits@lists.llvm.org wrote:
  Author: alexfh
  Date: Fri Aug 14 09:31:31 2015
  New Revision: 245052
 
  URL: http://llvm.org/viewvc/llvm-project?rev=245052view=rev
  Log:
  [clang-tidy] Move IncludeSorter.* and IncludeInserter.* to
  clang-tidy/utils/
 
  This is better structurally and it also fixes a linker error in the
  configure
  build.

 This seems to break cmake build on Linux:

 FAILED: :  /home/abuild/rpmbuild/BUILD/llvm/stage1/bin/clang++
 -fPIC -fuse-ld=gold -stdlib=libc++ -fPIC -fvisibility-inlines-hidden
 -Wall -W -Wno-unused-parameter -Wwrite-strings -Wcast-qual
 -Wmissing-field-initializers -pedantic -Wno-long-long
 -Wcovered-switch-default -Wnon-virtual-dtor -Werror=date-time
 -std=c++11 -fcolor-diagnostics -ffunction-sections -fdata-sections
 -fno-common -Woverloaded-virtual -fno-strict-aliasing
 -Wno-nested-anon-types -O2 -g  -stdlib=libc++ -Wl,-z,defs   -Wl,-O3
 -Wl,--gc-sections -shared
 -Wl,-soname,libclangTidyModernizeModule.so.3.8 -o
 lib64/libclangTidyModernizeModule.so.3.8.0svn

 tools/clang/tools/extra/clang-tidy/modernize/CMakeFiles/clangTidyModernizeModule.dir/ModernizeTidyModule.cpp.o

 tools/clang/tools/extra/clang-tidy/modernize/CMakeFiles/clangTidyModernizeModule.dir/PassByValueCheck.cpp.o
  lib64/libclangAST.so.3.8.0svn lib64/libclangASTMatchers.so.3.8.0svn
 lib64/libclangBasic.so.3.8.0svn lib64/libclangLex.so.3.8.0svn
 lib64/libclangTidy.so.3.8.0svn
 lib64/libclangTidyReadabilityModule.so.3.8.0svn
 lib64/libLLVMSupport.so.3.8.0svn -Wl,-rpath,\$ORIGIN/../lib64  :

 ../tools/clang/tools/extra/clang-tidy/modernize/PassByValueCheck.cpp:169:
 error: undefined reference to
 'clang::tidy::IncludeInserter::IncludeInserter(clang::SourceManager
 const, clang::LangOptions const,
 clang::tidy::IncludeSorter::IncludeStyle)'

 /home/abuild/rpmbuild/BUILD/llvm/stage1/bin/../include/c++/v1/memory:2516:
 error: undefined reference to
 'clang::tidy::IncludeInserter::~IncludeInserter()'

 ../tools/clang/tools/extra/clang-tidy/modernize/PassByValueCheck.cpp:171:
 error: undefined reference to
 'clang::tidy::IncludeInserter::CreatePPCallbacks()'

 ../tools/clang/tools/extra/clang-tidy/modernize/PassByValueCheck.cpp:215:
 error: undefined reference to
 'clang::tidy::IncludeInserter::CreateIncludeInsertion(clang::FileID,
 llvm::StringRef, bool)'

 /home/abuild/rpmbuild/BUILD/llvm/stage1/bin/../include/c++/v1/memory:2516:
 error: undefined reference to
 'clang::tidy::IncludeInserter::~IncludeInserter()'

 /home/abuild/rpmbuild/BUILD/llvm/stage1/bin/../include/c++/v1/memory:2516:
 error: undefined reference to
 'clang::tidy::IncludeInserter::~IncludeInserter()'
 clang-3.8: error: linker command failed with exit code 1 (use -v to
 see invocation)



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11932: [OPENMP] Link libomp.lib on Windows

[İsmail Dönmez via cfe-commits]

ismail added a comment.

Tests pass but, now when I tried to compile a file with -fopenmp I get:

LINK: fatal error LNK1104: cannot open file 'libomp.lib'

libomp.lib does exist in C:\Program Files\LLVM\lib but I guess we need to 
pass the library path down to linker.


http://reviews.llvm.org/D11932



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits