Re: [PATCH] [clang] Emit ObjC method and block annotation attributes to IR
John McCall may know particular reasons why these annotations are not propagated to IR level. > On 19 May 2016, at 19:37, Max Bazaliy via cfe-commits >wrote: > > Hey, > > For some reason clang does not emit ObjC method and block annotations to IR. > Here is a fix for that. > > -- > Max Bazaliy > ___ > cfe-commits mailing list > cfe-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits signature.asc Description: Message signed with OpenPGP using GPGMail ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: r269559 - ModuleMap.h: Fix a \param. [-Wdocumentation]
> On 14 May 2016, at 14:37, NAKAMURA Takumi via cfe-commits >wrote: > > - /// \param Filename The umbreall header to collect. > + /// \param Header The umbreall header to collect. s/Umbreall/Umbrella/ signature.asc Description: Message signed with OpenPGP using GPGMail ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang-tools-extra] r266518 - Replace hardcoded comment at 'lit.site.cfg.in'
Author: alexdenisov Date: Sat Apr 16 02:01:42 2016 New Revision: 266518 URL: http://llvm.org/viewvc/llvm-project?rev=266518=rev Log: Replace hardcoded comment at 'lit.site.cfg.in' At the moment almost every lit.site.cfg.in contains two lines comment: ## Autogenerated by LLVM/Clang configuration. # Do not edit! The patch adds variable LIT_SITE_CFG_IN_HEADER, that is replaced from configure_lit_site_cfg with the note and some useful information. Modified: clang-tools-extra/trunk/test/Unit/lit.site.cfg.in clang-tools-extra/trunk/test/lit.site.cfg.in Modified: clang-tools-extra/trunk/test/Unit/lit.site.cfg.in URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/Unit/lit.site.cfg.in?rev=266518=266517=266518=diff == --- clang-tools-extra/trunk/test/Unit/lit.site.cfg.in (original) +++ clang-tools-extra/trunk/test/Unit/lit.site.cfg.in Sat Apr 16 02:01:42 2016 @@ -1,5 +1,5 @@ -## Autogenerated by LLVM/Clang configuration. -# Do not edit! +@LIT_SITE_CFG_IN_HEADER@ + config.extra_tools_obj_dir = "@CLANG_TOOLS_BINARY_DIR@/unittests" config.extra_tools_src_dir = "@CLANG_TOOLS_SOURCE_DIR@/unittests" config.llvm_libs_dir = "@LLVM_LIBS_DIR@" Modified: clang-tools-extra/trunk/test/lit.site.cfg.in URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/lit.site.cfg.in?rev=266518=266517=266518=diff == --- clang-tools-extra/trunk/test/lit.site.cfg.in (original) +++ clang-tools-extra/trunk/test/lit.site.cfg.in Sat Apr 16 02:01:42 2016 @@ -1,7 +1,7 @@ +@LIT_SITE_CFG_IN_HEADER@ + import sys -## Autogenerated by LLVM/Clang configuration. -# Do not edit! config.llvm_tools_dir = "@LLVM_TOOLS_DIR@" config.llvm_libs_dir = "@LLVM_LIBS_DIR@" config.lit_tools_dir = "@LLVM_LIT_TOOLS_DIR@" ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
r266516 - Replace hardcoded comment at 'lit.site.cfg.in'
Author: alexdenisov Date: Sat Apr 16 01:54:46 2016 New Revision: 266516 URL: http://llvm.org/viewvc/llvm-project?rev=266516=rev Log: Replace hardcoded comment at 'lit.site.cfg.in' At the moment almost every lit.site.cfg.in contains two lines comment: ## Autogenerated by LLVM/Clang configuration. # Do not edit! The patch adds variable LIT_SITE_CFG_IN_HEADER, that is replaced from configure_lit_site_cfg with the note and some useful information. Modified: cfe/trunk/test/Unit/lit.site.cfg.in cfe/trunk/test/lit.site.cfg.in cfe/trunk/utils/perf-training/lit.site.cfg.in cfe/trunk/utils/perf-training/order-files.lit.site.cfg.in Modified: cfe/trunk/test/Unit/lit.site.cfg.in URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Unit/lit.site.cfg.in?rev=266516=266515=266516=diff == --- cfe/trunk/test/Unit/lit.site.cfg.in (original) +++ cfe/trunk/test/Unit/lit.site.cfg.in Sat Apr 16 01:54:46 2016 @@ -1,7 +1,7 @@ +@LIT_SITE_CFG_IN_HEADER@ + import sys -## Autogenerated by LLVM/Clang configuration. -# Do not edit! config.llvm_src_root = "@LLVM_SOURCE_DIR@" config.llvm_obj_root = "@LLVM_BINARY_DIR@" config.llvm_tools_dir = "@LLVM_TOOLS_DIR@" Modified: cfe/trunk/test/lit.site.cfg.in URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/lit.site.cfg.in?rev=266516=266515=266516=diff == --- cfe/trunk/test/lit.site.cfg.in (original) +++ cfe/trunk/test/lit.site.cfg.in Sat Apr 16 01:54:46 2016 @@ -1,7 +1,7 @@ +@LIT_SITE_CFG_IN_HEADER@ + import sys -## Autogenerated by LLVM/Clang configuration. -# Do not edit! config.llvm_src_root = "@LLVM_SOURCE_DIR@" config.llvm_obj_root = "@LLVM_BINARY_DIR@" config.llvm_tools_dir = "@LLVM_TOOLS_DIR@" Modified: cfe/trunk/utils/perf-training/lit.site.cfg.in URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/utils/perf-training/lit.site.cfg.in?rev=266516=266515=266516=diff == --- cfe/trunk/utils/perf-training/lit.site.cfg.in (original) +++ cfe/trunk/utils/perf-training/lit.site.cfg.in Sat Apr 16 01:54:46 2016 @@ -1,7 +1,7 @@ +@LIT_SITE_CFG_IN_HEADER@ + import sys -## Autogenerated by LLVM/Clang configuration. -# Do not edit! config.clang_tools_dir = "@CLANG_TOOLS_DIR@" config.test_exec_root = "@CMAKE_CURRENT_BINARY_DIR@" config.test_source_root = "@CMAKE_CURRENT_SOURCE_DIR@" Modified: cfe/trunk/utils/perf-training/order-files.lit.site.cfg.in URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/utils/perf-training/order-files.lit.site.cfg.in?rev=266516=266515=266516=diff == --- cfe/trunk/utils/perf-training/order-files.lit.site.cfg.in (original) +++ cfe/trunk/utils/perf-training/order-files.lit.site.cfg.in Sat Apr 16 01:54:46 2016 @@ -1,7 +1,7 @@ +@LIT_SITE_CFG_IN_HEADER@ + import sys -## Autogenerated by LLVM/Clang configuration. -# Do not edit! config.clang_tools_dir = "@CLANG_TOOLS_DIR@" config.test_exec_root = "@CMAKE_CURRENT_BINARY_DIR@" config.test_source_root = "@CMAKE_CURRENT_SOURCE_DIR@" ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] Add ObjCBoxable handling to ObjCMigrator
Rebased against trunk: objc_migrator_objc_boxable.patch Description: Binary data -- AlexDenisov Software Engineer, http://lowlevelbits.org > On 05 Dec 2015, at 22:19, John McCallwrote: > >> On Dec 5, 2015, at 7:58 AM, AlexDenisov <1101.deb...@gmail.com> wrote: >> Extend ObjCMigrator to cover automatic migration from message sending to >> boxable literals, e.g.: >> >> ```before >> typedef struct __attribute__((objc_boxable)) CGRect CGRect; >> /// ... >> CGRect rect; >> [NSValue valueWithBytes: objCType:@encode(CGRect)]; >> [NSValue valueWithCGPoint:functionReturningCGPoint()]; >> ``` >> >> ```after >> typedef struct __attribute__((objc_boxable)) CGRect CGRect; >> /// ... >> CGRect rect; >> @(rect); >> @(functionReturningCGPoint()); >> ``` >> >> I will appreciate any ideas how to improve it since the implementation is >> far from beautiful. >> >> > > CC’ing Argyrios, who knows the migration code much better than I do. > > John. signature.asc Description: Message signed with OpenPGP using GPGMail ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] Add ObjCBoxable handling to ObjCMigrator
Any updates? :) -- AlexDenisov Software Engineer, http://lowlevelbits.org > On 05 Dec 2015, at 22:19, John McCallwrote: > >> On Dec 5, 2015, at 7:58 AM, AlexDenisov <1101.deb...@gmail.com> wrote: >> Extend ObjCMigrator to cover automatic migration from message sending to >> boxable literals, e.g.: >> >> ```before >> typedef struct __attribute__((objc_boxable)) CGRect CGRect; >> /// ... >> CGRect rect; >> [NSValue valueWithBytes: objCType:@encode(CGRect)]; >> [NSValue valueWithCGPoint:functionReturningCGPoint()]; >> ``` >> >> ```after >> typedef struct __attribute__((objc_boxable)) CGRect CGRect; >> /// ... >> CGRect rect; >> @(rect); >> @(functionReturningCGPoint()); >> ``` >> >> I will appreciate any ideas how to improve it since the implementation is >> far from beautiful. >> >> > > CC’ing Argyrios, who knows the migration code much better than I do. > > John. signature.asc Description: Message signed with OpenPGP using GPGMail ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits