[PATCH] D82822: [OpenMP][FIX] Consistently use OpenMPIRBuilder if requested

2020-06-30 Thread Anchu Rajendran S via Phabricator via cfe-commits 
anchu-rajendran accepted this revision.
anchu-rajendran added a comment.
This revision is now accepted and ready to land.

LGTM :). Thanks!




Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:1543
+OMPBuilder->getOrCreateIdent(SrcLocStr));
+  }
 

Nit: I think its better to add comments on the implicit assumptions in clang 
code / on why initializations here is not required if OMPIRBuilder is not used. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82822/new/

https://reviews.llvm.org/D82822



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D82470: [OpenMP][IRBuilder] Support nested parallel regions

2020-06-26 Thread Anchu Rajendran S via Phabricator via cfe-commits 
anchu-rajendran added a comment.
Herald added a subscriber: rogfer01.

The change looks good to me. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82470/new/

https://reviews.llvm.org/D82470



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits