Re: [PATCH] D21695: [clang] Version support for UBSan handlers

2016-12-13 Thread Andrew Ford via cfe-commits
It does have c++11, but some functions are missing.  I don't know the
details of which ones are missing or why, have only seen std::to_string be
a problem so far.

On Mon, Dec 12, 2016 at 11:05 AM Filipe Cabecinhas <
filcab+llvm.phabrica...@gmail.com> wrote:

> Thanks Vedant!
> Andrew: does Android not support C++11? I don't understand why it wouldn't
> have these funcions.
>
> Thank you,
>
>  Filipe
>
> On Mon, 12 Dec 2016 at 18:58, Vedant Kumar  wrote:
>
>
>
> > On Dec 12, 2016, at 10:17 AM, Andrew Ford via Phabricator <
> revi...@reviews.llvm.org> wrote:
>
> >
>
> > andrewford added a comment.
>
> >
>
> > This broke the build on android due to use of std::to_string. Would
> someone mind changing it to llvm::to_string, I don't have commit access to
> change it myself. Thanks!
>
>
>
> Should be done with r289452.
>
>
>
> vedant
>
>
>
> >
>
> >
>
> > Repository:
>
> >  rL LLVM
>
> >
>
> > https://reviews.llvm.org/D21695
>
> >
>
> >
>
> >
>
>
>
>
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


Re: [PATCH] D24826: [LTO] Add -flto-jobs=N to control backend parallelism

2016-09-23 Thread Andrew Ford via cfe-commits
andrewford added a subscriber: andrewford.
andrewford added a comment.

This is breaking our android lldb build, because it uses std::to_string.  Looks 
like there is llvm::to_string, which should be preferred. Would someone mind 
changing it?  I don't have commit access or I would myself. :)

Thanks in advance


Repository:
  rL LLVM

https://reviews.llvm.org/D24826



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits