[PATCH] D66296: [BUNDLER]Improve the test, NFC.

2019-08-15 Thread Azharuddin Mohammed via Phabricator via cfe-commits 
azharudd added a comment.

Looks like this is failing on Darwin:

  
http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/1193/consoleFull#-2382751928254eaf0-7326-4999-85b0-388101f2d404
  
  
/Users/buildslave/jenkins/workspace/clang-stage1-cmake-RA-incremental/llvm-project/clang/test/Driver/clang-offload-bundler.c:120:15:
 error: CK-TEXTLL: expected string not found in input
  // CK-TEXTLL: @A = dso_local global i32 0
^
  
/Users/buildslave/jenkins/workspace/clang-stage1-cmake-RA-incremental/clang-build/tools/clang/test/Driver/Output/clang-offload-bundler.c.tmp.bundle3.ll:3:1:
 note: scanning from here
  ; ModuleID = 
'/Users/buildslave/jenkins/workspace/clang-stage1-cmake-RA-incremental/llvm-project/clang/test/Driver/clang-offload-bundler.c'
  ^
  
/Users/buildslave/jenkins/workspace/clang-stage1-cmake-RA-incremental/clang-build/tools/clang/test/Driver/Output/clang-offload-bundler.c.tmp.bundle3.ll:8:1:
 note: possible intended match here
  @A = global i32 0, align 4


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66296/new/

https://reviews.llvm.org/D66296



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D85773: [Driver][XRay][test] Update the macOS support check

2020-08-11 Thread Azharuddin Mohammed via Phabricator via cfe-commits 
azharudd created this revision.
azharudd added a reviewer: arphaman.
Herald added subscribers: cfe-commits, dexonsmith, dberris.
Herald added a project: clang.
azharudd requested review of this revision.

For macOS, the code says, the XRay flag is only supported on x86_64.
Updating the test and making that check explicit.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D85773

Files:
  clang/test/Driver/XRay/xray-instrument-os.c


Index: clang/test/Driver/XRay/xray-instrument-os.c
===
--- clang/test/Driver/XRay/xray-instrument-os.c
+++ clang/test/Driver/XRay/xray-instrument-os.c
@@ -1,4 +1,4 @@
 // RUN: not %clang -o /dev/null -v -fxray-instrument -c %s
-// XFAIL: -linux-, -freebsd, -darwin, -macos
+// XFAIL: -linux-, -freebsd, x86_64-apple-darwin, x86_64-apple-macos
 // REQUIRES: amd64 || x86_64 || x86_64h || arm || aarch64 || arm64
 typedef int a;


Index: clang/test/Driver/XRay/xray-instrument-os.c
===
--- clang/test/Driver/XRay/xray-instrument-os.c
+++ clang/test/Driver/XRay/xray-instrument-os.c
@@ -1,4 +1,4 @@
 // RUN: not %clang -o /dev/null -v -fxray-instrument -c %s
-// XFAIL: -linux-, -freebsd, -darwin, -macos
+// XFAIL: -linux-, -freebsd, x86_64-apple-darwin, x86_64-apple-macos
 // REQUIRES: amd64 || x86_64 || x86_64h || arm || aarch64 || arm64
 typedef int a;
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D85773: [Driver][XRay][test] Update the macOS support check

2020-08-27 Thread Azharuddin Mohammed via Phabricator via cfe-commits 
azharudd added a comment.

In D85773#2211929 , @dberris wrote:

> LGTM from me if XRay actually does work on non-x86_64 macOS.

The code says that it is supported only on x86_64 macOS. The way this test is 
written, it should fail on platforms where it is supported.

(Sorry about the delay here.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85773/new/

https://reviews.llvm.org/D85773

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D85773: [Driver][XRay][test] Update the macOS support check

2020-08-27 Thread Azharuddin Mohammed via Phabricator via cfe-commits 
This revision was automatically updated to reflect the committed changes.
Closed by commit rGd22985c41087: [Driver][XRay][test] Update the macOS support 
check (authored by azharudd).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85773/new/

https://reviews.llvm.org/D85773

Files:
  clang/test/Driver/XRay/xray-instrument-os.c


Index: clang/test/Driver/XRay/xray-instrument-os.c
===
--- clang/test/Driver/XRay/xray-instrument-os.c
+++ clang/test/Driver/XRay/xray-instrument-os.c
@@ -1,4 +1,4 @@
 // RUN: not %clang -o /dev/null -v -fxray-instrument -c %s
-// XFAIL: -linux-, -freebsd, -darwin, -macos
+// XFAIL: -linux-, -freebsd, x86_64-apple-darwin, x86_64-apple-macos
 // REQUIRES: amd64 || x86_64 || x86_64h || arm || aarch64 || arm64
 typedef int a;


Index: clang/test/Driver/XRay/xray-instrument-os.c
===
--- clang/test/Driver/XRay/xray-instrument-os.c
+++ clang/test/Driver/XRay/xray-instrument-os.c
@@ -1,4 +1,4 @@
 // RUN: not %clang -o /dev/null -v -fxray-instrument -c %s
-// XFAIL: -linux-, -freebsd, -darwin, -macos
+// XFAIL: -linux-, -freebsd, x86_64-apple-darwin, x86_64-apple-macos
 // REQUIRES: amd64 || x86_64 || x86_64h || arm || aarch64 || arm64
 typedef int a;
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D124474: Honor COMPILER_RT_INCLUDE_TESTS when using LLVM_BUILD_EXTERNAL_COMPILER_RT=ON

2022-04-26 Thread Azharuddin Mohammed via Phabricator via cfe-commits 
azharudd created this revision.
azharudd added reviewers: yln, delcypher, beanz, phosek.
Herald added a subscriber: mgorny.
Herald added a project: All.
azharudd requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

When building with LLVM_BUILD_EXTERNAL_COMPILER_RT=ON (where we build
compiler-rt with the just built clang), the compiler-rt tests are being
enabled based on LLVM_INCLUDE_TESTS and not COMPILER_RT_INCLUDE_TESTS,
thereby providing no way to disable just the compiler-rt tests.

This change makes the compiler-rt tests depend on COMPILER_RT_INCLUDE_TESTS
instead. The default value of COMPILER_RT_INCLUDE_TESTS is set to the
value of LLVM_INCLUDE_TESTS (this retains the existing behavior too).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D124474

Files:
  clang/runtime/CMakeLists.txt


Index: clang/runtime/CMakeLists.txt
===
--- clang/runtime/CMakeLists.txt
+++ clang/runtime/CMakeLists.txt
@@ -22,6 +22,8 @@
   endif()
 endfunction()
 
+option(COMPILER_RT_INCLUDE_TESTS "Generate build targets for compiler-rt 
tests." ${LLVM_INCLUDE_TESTS})
+
 set(COMPILER_RT_SRC_ROOT ${LLVM_MAIN_SRC_DIR}/projects/compiler-rt)
 # Fallback to the external path, if the other one isn't available.
 # This is the same behavior (try "internal", then check the LLVM_EXTERNAL_...
@@ -62,7 +64,7 @@
   if(TARGET cxx-headers)
 list(APPEND compiler_rt_configure_deps "cxx-headers")
   endif()
-  if(LLVM_INCLUDE_TESTS)
+  if(COMPILER_RT_INCLUDE_TESTS)
 list(APPEND compiler_rt_configure_deps LLVMTestingSupport)
   endif()
 
@@ -85,7 +87,6 @@

-DCOMPILER_RT_OUTPUT_DIR=${LLVM_LIBRARY_OUTPUT_INTDIR}/clang/${CLANG_VERSION}
-DCOMPILER_RT_EXEC_OUTPUT_DIR=${LLVM_RUNTIME_OUTPUT_INTDIR}

-DCOMPILER_RT_INSTALL_PATH:PATH=lib${LLVM_LIBDIR_SUFFIX}/clang/${CLANG_VERSION}
-   -DCOMPILER_RT_INCLUDE_TESTS=${LLVM_INCLUDE_TESTS}
-DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX}
-DLLVM_LIBDIR_SUFFIX=${LLVM_LIBDIR_SUFFIX}
-DLLVM_RUNTIME_OUTPUT_INTDIR=${LLVM_RUNTIME_OUTPUT_INTDIR}
@@ -129,7 +130,7 @@
   VERBATIM USES_TERMINAL)
   endforeach()
 
-  if(LLVM_INCLUDE_TESTS)
+  if(COMPILER_RT_INCLUDE_TESTS)
 # Add binaries that compiler-rt tests depend on.
 set(COMPILER_RT_TEST_DEPENDENCIES
   FileCheck count not llvm-nm llvm-objdump llvm-symbolizer llvm-jitlink)


Index: clang/runtime/CMakeLists.txt
===
--- clang/runtime/CMakeLists.txt
+++ clang/runtime/CMakeLists.txt
@@ -22,6 +22,8 @@
   endif()
 endfunction()
 
+option(COMPILER_RT_INCLUDE_TESTS "Generate build targets for compiler-rt tests." ${LLVM_INCLUDE_TESTS})
+
 set(COMPILER_RT_SRC_ROOT ${LLVM_MAIN_SRC_DIR}/projects/compiler-rt)
 # Fallback to the external path, if the other one isn't available.
 # This is the same behavior (try "internal", then check the LLVM_EXTERNAL_...
@@ -62,7 +64,7 @@
   if(TARGET cxx-headers)
 list(APPEND compiler_rt_configure_deps "cxx-headers")
   endif()
-  if(LLVM_INCLUDE_TESTS)
+  if(COMPILER_RT_INCLUDE_TESTS)
 list(APPEND compiler_rt_configure_deps LLVMTestingSupport)
   endif()
 
@@ -85,7 +87,6 @@
-DCOMPILER_RT_OUTPUT_DIR=${LLVM_LIBRARY_OUTPUT_INTDIR}/clang/${CLANG_VERSION}
-DCOMPILER_RT_EXEC_OUTPUT_DIR=${LLVM_RUNTIME_OUTPUT_INTDIR}
-DCOMPILER_RT_INSTALL_PATH:PATH=lib${LLVM_LIBDIR_SUFFIX}/clang/${CLANG_VERSION}
-   -DCOMPILER_RT_INCLUDE_TESTS=${LLVM_INCLUDE_TESTS}
-DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX}
-DLLVM_LIBDIR_SUFFIX=${LLVM_LIBDIR_SUFFIX}
-DLLVM_RUNTIME_OUTPUT_INTDIR=${LLVM_RUNTIME_OUTPUT_INTDIR}
@@ -129,7 +130,7 @@
   VERBATIM USES_TERMINAL)
   endforeach()
 
-  if(LLVM_INCLUDE_TESTS)
+  if(COMPILER_RT_INCLUDE_TESTS)
 # Add binaries that compiler-rt tests depend on.
 set(COMPILER_RT_TEST_DEPENDENCIES
   FileCheck count not llvm-nm llvm-objdump llvm-symbolizer llvm-jitlink)
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D124474: Honor COMPILER_RT_INCLUDE_TESTS when using LLVM_BUILD_EXTERNAL_COMPILER_RT=ON

2022-04-26 Thread Azharuddin Mohammed via Phabricator via cfe-commits 
azharudd added a comment.

In D124474#3475432 , @beanz wrote:

> I question whether we should be extending this or killing it off... Is there 
> a reason you're using `LLVM_BUILD_EXTERNAL_COMPILER_RT` instead of 
> `LLVM_ENABLE_RUNTIMES=compiler-rt`?

In this case I'm just trying to make it work with existing build configurations 
where it is being used (for example Swift). We should definitely be moving away 
from `LLVM_BUILD_EXTERNAL_COMPILER_RT` in favor of `LLVM_ENABLE_RUNTIMES` 
eventually though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124474/new/

https://reviews.llvm.org/D124474

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D124474: Honor COMPILER_RT_INCLUDE_TESTS when using LLVM_BUILD_EXTERNAL_COMPILER_RT=ON

2022-04-26 Thread Azharuddin Mohammed via Phabricator via cfe-commits 
azharudd added a comment.

In D124474#3475550 , @beanz wrote:

> In D124474#3475539 , @azharudd 
> wrote:
>
>> In this case I'm just trying to make it work with existing build 
>> configurations where it is being used (for example Swift). We should 
>> definitely be moving away from `LLVM_BUILD_EXTERNAL_COMPILER_RT` in favor of 
>> `LLVM_ENABLE_RUNTIMES` eventually though.
>
> My point here is that maybe you should move away from the legacy way of 
> building now rather than improving it... Not sure how @phosek feels about 
> this. I would personally very much prefer if we only had one way to build 
> compiler-rt instead of the half dozen we have today.

I understand, and I agree there should be only one way to do it. I did think 
about it but it is more involved and I unfortunately don't have the time to 
commit to it right now. I'm hoping we can take care of it at some point (I'm 
tracking it), but until then this satisfies the immediate need.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124474/new/

https://reviews.llvm.org/D124474

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53912: [Headers] [MS] Add intrin0.h

2018-10-30 Thread Azharuddin Mohammed via Phabricator via cfe-commits 
azharudd created this revision.
azharudd added reviewers: rnk, mgrang.
Herald added subscribers: jfb, mgorny.

xatomic.h header in VS 2017 includes  instead of  like
before. Adding an intrin0.h header which internally includes  when
compiling for the Windows platform.


Repository:
  rC Clang

https://reviews.llvm.org/D53912

Files:
  lib/Headers/CMakeLists.txt
  lib/Headers/intrin0.h


Index: lib/Headers/intrin0.h
===
--- /dev/null
+++ lib/Headers/intrin0.h
@@ -0,0 +1,30 @@
+/* === intrin0.h --===
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to 
deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING 
FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+ * THE SOFTWARE.
+ *
+ *===---===
+ */
+
+/* xatomic.h in VS 2017 includes  instead of .
+ * If compiling for the Windows platform, we'll internally just include
+ * . */
+
+#ifdef _MSC_VER
+#include 
+#endif /* _MSC_VER */
Index: lib/Headers/CMakeLists.txt
===
--- lib/Headers/CMakeLists.txt
+++ lib/Headers/CMakeLists.txt
@@ -57,6 +57,7 @@
   ia32intrin.h
   immintrin.h
   intrin.h
+  intrin0.h
   inttypes.h
   invpcidintrin.h
   iso646.h


Index: lib/Headers/intrin0.h
===
--- /dev/null
+++ lib/Headers/intrin0.h
@@ -0,0 +1,30 @@
+/* === intrin0.h --===
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+ * THE SOFTWARE.
+ *
+ *===---===
+ */
+
+/* xatomic.h in VS 2017 includes  instead of .
+ * If compiling for the Windows platform, we'll internally just include
+ * . */
+
+#ifdef _MSC_VER
+#include 
+#endif /* _MSC_VER */
Index: lib/Headers/CMakeLists.txt
===
--- lib/Headers/CMakeLists.txt
+++ lib/Headers/CMakeLists.txt
@@ -57,6 +57,7 @@
   ia32intrin.h
   immintrin.h
   intrin.h
+  intrin0.h
   inttypes.h
   invpcidintrin.h
   iso646.h
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53912: [Headers] [MS] Add intrin0.h

2018-11-01 Thread Azharuddin Mohammed via Phabricator via cfe-commits 
azharudd added a comment.

In https://reviews.llvm.org/D53912#1281584, @rnk wrote:

> This sounds like it would defeat what I'm assuming is the intended purpose of 
> intrin0.h, which is to reduce compile time. intrin.h is kind of enormous, and 
> the compile time problems are well-documented. We should investigate what's 
> up with intrin0.h and implement as many builtins as we need to support it.


I agree. This currently resolves issues with building for ARM64 target using 
Visual Studio 2017. The missing intrinsics it complains about are already 
present in intrin.h. We could add those to intrin0.h too but that would 
duplicate. Please let me know what you think.


Repository:
  rC Clang

https://reviews.llvm.org/D53912



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits