[PATCH] D124708: Fix "the the" typo in documentation and user facing strings

[Brian Tracy via Phabricator via cfe-commits]

briantracy marked an inline comment as done.
briantracy added a comment.

Thank you Mark and Gabor. At your discretion, could you commit this on my 
behalf? My email is "brian.trac...@gmail.com" and full name is "Brian Tracy". 
Thanks again.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124708/new/

https://reviews.llvm.org/D124708

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D124708: Fix "the the" typo in documentation and user facing strings

[Brian Tracy via Phabricator via cfe-commits]

briantracy updated this revision to Diff 426259.
briantracy added a comment.

Updated sanitizer tests to include newly fixed error message strings.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124708/new/

https://reviews.llvm.org/D124708

Files:
  clang/docs/LanguageExtensions.rst
  clang/docs/MatrixTypes.rst
  clang/docs/UndefinedBehaviorSanitizer.rst
  clang/docs/analyzer/checkers.rst
  clang/lib/StaticAnalyzer/Checkers/cert/InvalidPtrChecker.cpp
  clang/test/Analysis/cert/env34-c.c
  libcxx/include/__iterator/advance.h
  libcxx/src/filesystem/operations.cpp
  llvm/docs/AMDGPUUsage.rst
  llvm/docs/BugLifeCycle.rst
  llvm/docs/CodingStandards.rst
  llvm/docs/CommandGuide/llvm-profdata.rst
  llvm/include/llvm/Analysis/Loads.h
  llvm/include/llvm/ExecutionEngine/Orc/Core.h
  llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h
  llvm/tools/llvm-profdata/llvm-profdata.cpp

Index: llvm/tools/llvm-profdata/llvm-profdata.cpp
===
--- llvm/tools/llvm-profdata/llvm-profdata.cpp
+++ llvm/tools/llvm-profdata/llvm-profdata.cpp
@@ -994,7 +994,7 @@
   "zero-counter-threshold", cl::init(0.7), cl::Hidden,
   cl::desc("For the function which is cold in instr profile but hot in "
"sample profile, if the ratio of the number of zero counters "
-   "divided by the the total number of counters is above the "
+   "divided by the total number of counters is above the "
"threshold, the profile of the function will be regarded as "
"being harmful for performance and will be dropped."));
   cl::opt SupplMinSizeThreshold(
Index: llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h
===
--- llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h
+++ llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h
@@ -196,7 +196,7 @@
 };
 
 /// Meta qualifiers for a value. Pair of whatever expression is used to qualify
-/// the the value, and Boolean of whether or not it's indirect.
+/// the value, and Boolean of whether or not it's indirect.
 class DbgValueProperties {
 public:
   DbgValueProperties(const DIExpression *DIExpr, bool Indirect)
Index: llvm/include/llvm/ExecutionEngine/Orc/Core.h
===
--- llvm/include/llvm/ExecutionEngine/Orc/Core.h
+++ llvm/include/llvm/ExecutionEngine/Orc/Core.h
@@ -1331,7 +1331,7 @@
   lookupInitSymbols(ExecutionSession &ES,
 const DenseMap &InitSyms);
 
-  /// Performs an async lookup for the the given symbols in each of the given
+  /// Performs an async lookup for the given symbols in each of the given
   /// JITDylibs, calling the given handler once all lookups have completed.
   static void
   lookupInitSymbolsAsync(unique_function OnComplete,
Index: llvm/include/llvm/Analysis/Loads.h
===
--- llvm/include/llvm/Analysis/Loads.h
+++ llvm/include/llvm/Analysis/Loads.h
@@ -75,9 +75,9 @@
 /// within the specified loop) would access only dereferenceable memory, and
 /// be properly aligned on every iteration of the specified loop regardless of
 /// its placement within the loop. (i.e. does not require predication beyond
-/// that required by the the header itself and could be hoisted into the header
+/// that required by the header itself and could be hoisted into the header
 /// if desired.)  This is more powerful than the variants above when the
-/// address loaded from is analyzeable by SCEV.  
+/// address loaded from is analyzeable by SCEV.
 bool isDereferenceableAndAlignedInLoop(LoadInst *LI, Loop *L,
ScalarEvolution &SE,
DominatorTree &DT);
Index: llvm/docs/CommandGuide/llvm-profdata.rst
===
--- llvm/docs/CommandGuide/llvm-profdata.rst
+++ llvm/docs/CommandGuide/llvm-profdata.rst
@@ -170,7 +170,7 @@
 .. option:: --zero-counter-threshold=
 
  For the function which is cold in instr profile but hot in sample profile, if
- the ratio of the number of zero counters divided by the the total number of
+ the ratio of the number of zero counters divided by the total number of
  counters is above the threshold, the profile of the function will be regarded
  as being harmful for performance and will be dropped.
 
Index: llvm/docs/CodingStandards.rst
===
--- llvm/docs/CodingStandards.rst
+++ llvm/docs/CodingStandards.rst
@@ -1312,7 +1312,7 @@
 ... use I ...
 
 Usage of ``std::for_each()``/``llvm::for_each()`` functions is discouraged,
-unless the the callable object already exists.
+unless the callable object already exists.
 
 Don't evaluate ``end()`` every time through a loop
 ^^

[PATCH] D124708: Fix "the the" typo in documentation and user facing strings

[Brian Tracy via Phabricator via cfe-commits]

briantracy created this revision.
briantracy added a reviewer: echristo.
Herald added subscribers: martong, kerbowa, hiraditya, jvesely.
Herald added a project: All.
briantracy requested review of this revision.
Herald added projects: clang, libc++, LLVM.
Herald added subscribers: llvm-commits, libcxx-commits, cfe-commits.
Herald added a reviewer: libc++.

There are many more instances of this pattern, but I chose to limit this change 
to .rst files (docs), anything in libcxx/include, and string literals. These 
have the highest chance of being seen by end users.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D124708

Files:
  clang/docs/LanguageExtensions.rst
  clang/docs/MatrixTypes.rst
  clang/docs/UndefinedBehaviorSanitizer.rst
  clang/docs/analyzer/checkers.rst
  clang/lib/StaticAnalyzer/Checkers/cert/InvalidPtrChecker.cpp
  libcxx/include/__iterator/advance.h
  libcxx/src/filesystem/operations.cpp
  llvm/docs/AMDGPUUsage.rst
  llvm/docs/BugLifeCycle.rst
  llvm/docs/CodingStandards.rst
  llvm/docs/CommandGuide/llvm-profdata.rst
  llvm/include/llvm/Analysis/Loads.h
  llvm/include/llvm/ExecutionEngine/Orc/Core.h
  llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h
  llvm/tools/llvm-profdata/llvm-profdata.cpp

Index: llvm/tools/llvm-profdata/llvm-profdata.cpp
===
--- llvm/tools/llvm-profdata/llvm-profdata.cpp
+++ llvm/tools/llvm-profdata/llvm-profdata.cpp
@@ -982,7 +982,7 @@
   "zero-counter-threshold", cl::init(0.7), cl::Hidden,
   cl::desc("For the function which is cold in instr profile but hot in "
"sample profile, if the ratio of the number of zero counters "
-   "divided by the the total number of counters is above the "
+   "divided by the total number of counters is above the "
"threshold, the profile of the function will be regarded as "
"being harmful for performance and will be dropped."));
   cl::opt SupplMinSizeThreshold(
Index: llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h
===
--- llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h
+++ llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h
@@ -196,7 +196,7 @@
 };
 
 /// Meta qualifiers for a value. Pair of whatever expression is used to qualify
-/// the the value, and Boolean of whether or not it's indirect.
+/// the value, and Boolean of whether or not it's indirect.
 class DbgValueProperties {
 public:
   DbgValueProperties(const DIExpression *DIExpr, bool Indirect)
Index: llvm/include/llvm/ExecutionEngine/Orc/Core.h
===
--- llvm/include/llvm/ExecutionEngine/Orc/Core.h
+++ llvm/include/llvm/ExecutionEngine/Orc/Core.h
@@ -1331,7 +1331,7 @@
   lookupInitSymbols(ExecutionSession &ES,
 const DenseMap &InitSyms);
 
-  /// Performs an async lookup for the the given symbols in each of the given
+  /// Performs an async lookup for the given symbols in each of the given
   /// JITDylibs, calling the given handler once all lookups have completed.
   static void
   lookupInitSymbolsAsync(unique_function OnComplete,
Index: llvm/include/llvm/Analysis/Loads.h
===
--- llvm/include/llvm/Analysis/Loads.h
+++ llvm/include/llvm/Analysis/Loads.h
@@ -75,9 +75,9 @@
 /// within the specified loop) would access only dereferenceable memory, and
 /// be properly aligned on every iteration of the specified loop regardless of
 /// its placement within the loop. (i.e. does not require predication beyond
-/// that required by the the header itself and could be hoisted into the header
+/// that required by the header itself and could be hoisted into the header
 /// if desired.)  This is more powerful than the variants above when the
-/// address loaded from is analyzeable by SCEV.  
+/// address loaded from is analyzeable by SCEV.
 bool isDereferenceableAndAlignedInLoop(LoadInst *LI, Loop *L,
ScalarEvolution &SE,
DominatorTree &DT);
Index: llvm/docs/CommandGuide/llvm-profdata.rst
===
--- llvm/docs/CommandGuide/llvm-profdata.rst
+++ llvm/docs/CommandGuide/llvm-profdata.rst
@@ -170,7 +170,7 @@
 .. option:: --zero-counter-threshold=
 
  For the function which is cold in instr profile but hot in sample profile, if
- the ratio of the number of zero counters divided by the the total number of
+ the ratio of the number of zero counters divided by the total number of
  counters is above the threshold, the profile of the function will be regarded
  as being harmful for performance and will be dropped.
 
Index: llvm/docs/CodingStandards.rst
===
--- llvm/docs/CodingStandards.rst
+++ llvm/docs/CodingS